Make DOOM work

I think I lost this work originally

.github/workflows/test-content.yml

@@ -38,4 +38,4 @@ jobs:
     - name: Content.Tests
       run: dotnet test --no-build Content.Tests/Content.Tests.csproj -v n
     - name: Content.IntegrationTests
-      run: COMPlus_gcServer=1 dotnet test --no-build Content.IntegrationTests/Content.IntegrationTests.csproj -v n
+      run: dotnet test --no-build Content.IntegrationTests/Content.IntegrationTests.csproj -v n

.gitmodules

@@ -13,9 +13,3 @@
 [submodule "ManagedHttpListener"]
 	path = ManagedHttpListener
 	url = https://github.com/space-wizards/ManagedHttpListener.git
-[submodule "Linguini"]
-	path = Linguini
-	url = https://github.com/space-wizards/Linguini
-[submodule "cefglue"]
-	path = cefglue
-	url = https://gitlab.com/xiliumhq/chromiumembedded/cefglue/

OpenToolkit.GraphicsLibraryFramework/Enums/WindowHintBool.cs

@@ -129,7 +129,5 @@ namespace OpenToolkit.GraphicsLibraryFramework
         /// for controlling sRGB rendering and a created OpenGL ES context will always have sRGB rendering enabled.
         /// </summary>
         SrgbCapable = 0x0002100E,
-
-        ScaleToMonitor = 0x0002200C,
     }
 }

OpenToolkit.GraphicsLibraryFramework/GLFW.cs

@@ -5551,15 +5551,5 @@ namespace OpenToolkit.GraphicsLibraryFramework
         {
             return glfwGetX11Window(window);
         }
-
-        public static unsafe IntPtr GetX11Display(Window* window)
-        {
-            return glfwGetX11Display(window);
-        }
-
-        public static unsafe IntPtr GetWin32Window(Window* window)
-        {
-            return glfwGetWin32Window(window);
-        }
     }
 }

OpenToolkit.GraphicsLibraryFramework/GLFWNative.cs

@@ -23,12 +23,12 @@ namespace OpenToolkit.GraphicsLibraryFramework
                     return IntPtr.Zero;
                 }
 
-                if (OperatingSystem.IsLinux())
+                if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
                 {
                     return NativeLibrary.Load("libglfw.so.3", assembly, path);
                 }
 
-                if (OperatingSystem.IsMacOS())
+                if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
                 {
                     return NativeLibrary.Load("libglfw.3.dylib", assembly, path);
                 }
@@ -406,11 +406,5 @@ namespace OpenToolkit.GraphicsLibraryFramework
 
         [DllImport(LibraryName)]
         public static extern uint glfwGetX11Window(Window* window);
-
-        [DllImport(LibraryName)]
-        public static extern IntPtr glfwGetX11Display(Window* window);
-
-        [DllImport(LibraryName)]
-        public static extern IntPtr glfwGetWin32Window(Window* window);
     }
 }

Resources/EngineCredits/Libraries.yml

@@ -23,48 +23,6 @@
     OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
     WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
-- name: Box2D
-  license: |
-    MIT License
-
-    Copyright (c) 2019 Erin Catto
-
-    Permission is hereby granted, free of charge, to any person obtaining a copy
-    of this software and associated documentation files (the "Software"), to deal
-    in the Software without restriction, including without limitation the rights
-    to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-    copies of the Software, and to permit persons to whom the Software is
-    furnished to do so, subject to the following conditions:
-
-    The above copyright notice and this permission notice shall be included in all
-    copies or substantial portions of the Software.
-
-    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-    IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-    FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-    AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-    LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-    OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-    SOFTWARE.
-
-- name: Bullet Physics SDK
-  license: |
-    The files in this repository are licensed under the zlib license, except for the files under 'Extras' and examples/ThirdPartyLibs.
-
-    Bullet Continuous Collision Detection and Physics Library
-    http://bulletphysics.org
-
-    This software is provided 'as-is', without any express or implied warranty.
-    In no event will the authors be held liable for any damages arising from the use of this software.
-    Permission is granted to anyone to use this software for any purpose,
-    including commercial applications, and to alter it and redistribute it freely,
-    subject to the following restrictions:
-
-    1. The origin of this software must not be misrepresented; you must not claim that you wrote the original software.
-    If you use this software in a product, an acknowledgment in the product documentation would be appreciated but is not required.
-    2. Altered source versions must be plainly marked as such, and must not be misrepresented as being the original software.
-    3. This notice may not be removed or altered from any source distribution.
-
 - name: Castle Core
   license: |
     Copyright 2004-2016 Castle Project - http://www.castleproject.org/
@@ -359,43 +317,6 @@
     See the License for the specific language governing permissions and
     limitations under the License.
 
-- name: Farseer Physics Engine
-  license: |
-    Microsoft Permissive License (Ms-PL)
-
-    This license governs use of the accompanying software.
-    If you use the software, you accept this license.
-    If you do not accept the license, do not use the software.
-
-    1. Definitions
-    The terms "reproduce," "reproduction," "derivative works," and "distribution" have the same meaning here as under U.S. copyright law.
-    A "contribution" is the original software, or any additions or changes to the software.
-    A "contributor" is any person that distributes its contribution under this license.
-    "Licensed patents" are a contributor's patent claims that read directly on its contribution.
-
-    2. Grant of Rights
-    (A) Copyright Grant- Subject to the terms of this license, including the license conditions and limitations in section 3,
-    each contributor grants you a non-exclusive, worldwide, royalty-free copyright license to reproduce its contribution,
-    prepare derivative works of its contribution, and distribute its contribution or any derivative works that you create.
-    (B) Patent Grant- Subject to the terms of this license, including the license conditions and limitations in section 3,
-    each contributor grants you a non-exclusive, worldwide, royalty-free license under its licensed patents to
-    make, have made, use, sell, offer for sale, import, and/or otherwise dispose of its contribution in the software or
-    derivative works of the contribution in the software.
-
-    3. Conditions and Limitations
-    (A) No Trademark License- This license does not grant you rights to use any contributors' name, logo, or trademarks.
-    (B) If you bring a patent claim against any contributor over patents that you claim are infringed by the software,
-    your patent license from such contributor to the software ends automatically.
-    (C) If you distribute any portion of the software, you must retain all copyright, patent, trademark,
-    and attribution notices that are present in the software.
-    (D) If you distribute any portion of the software in source code form, you may do so only under this license by
-    including a complete copy of this license with your distribution. If you distribute any portion of the software in
-    compiled or object code form, you may only do so under a license that complies with this license.
-    (E) The software is licensed "as-is." You bear the risk of using it. The contributors give no express warranties,
-    guarantees or conditions. You may have additional consumer rights under your local laws which this license cannot change.
-    To the extent permitted under your local laws, the contributors exclude the implied warranties of
-    merchantability, fitness for a particular purpose and non-infringement.
-
 - name: Mono.Cecil
   license: |
     Copyright (c) 2008 - 2015 Jb Evain

Resources/Locale/en-US/console.ftl

@@ -0,0 +1 @@
+console-line-edit-placeholder = Command Here

Resources/Locale/en-US/custom-controls.ftl

@@ -1,11 +0,0 @@
-## EntitySpawnWindow
-
-entity-spawn-window-title = Entity Spawn Panel
-entity-spawn-window-search-bar-placeholder = search
-entity-spawn-window-clear-button = Clear
-entity-spawn-window-erase-button-text = Erase Mode
-entity-spawn-window-override-menu-tooltip = Override placement
-
-## Console
-
-console-line-edit-placeholder = Command Here

Resources/Locale/en-US/tab-container.ftl

@@ -1 +0,0 @@
-tab-container-not-tab-title-provided = No title

Resources/Locale/en-US/view-variables.ftl

@@ -1,11 +0,0 @@
-## ViewVariablesInstanceEntity
-
-view-variable-instance-entity-server-components-add-component-button-placeholder = Add Component
-view-variable-instance-entity-client-variables-tab-title = Client Variables
-view-variable-instance-entity-client-components-tab-title = Client Components
-view-variable-instance-entity-server-variables-tab-title = Server Variables
-view-variable-instance-entity-server-components-tab-title = Server Components
-view-variable-instance-entity-client-components-search-bar-placeholder = Search
-view-variable-instance-entity-server-components-search-bar-placeholder = Search
-view-variable-instance-entity-add-window-server-components = Add Component [S]
-view-variable-instance-entity-add-window-client-components = Add Component [C]

Resources/Shaders/Internal/light-blur.swsl

@@ -1,41 +0,0 @@
-preset raw;
-
-uniform highp vec2 direction;
-uniform highp vec2 size;
-uniform highp float radius;
-
-varying highp vec2 pos;
-varying highp vec4 blurPos1;
-varying highp vec4 blurPos2;
-
-
-void vertex()
-{
-    highp float aspect = size.y / size.x;
-    highp float horRadius = aspect * radius;
-
-    highp vec2 offset = vec2(horRadius, radius) * direction;
-
-    VERTEX = apply_mvp(VERTEX);
-
-    pos = (VERTEX + vec2(1.0)) / 2.0;
-
-    blurPos1.xy = pos + offset;
-    blurPos1.zw = pos - offset;
-    blurPos2.xy = pos + offset * 2.0;
-    blurPos2.zw = pos - offset * 2.0;
-}
-
-
-void fragment()
-{
-    // Very simple gaussian blur.
-    highp vec4 sum = zTexture(pos) * 0.375;
-
-    sum += zTexture(blurPos1.xy) * 0.25;
-    sum += zTexture(blurPos1.zw) * 0.25;
-    sum += zTexture(blurPos2.xy) * 0.0625;
-    sum += zTexture(blurPos2.zw) * 0.0625;
-
-    COLOR = sum;
-}

Robust.Analyzers/FriendAnalyzer.cs

@@ -1,107 +0,0 @@
-using System.Collections.Immutable;
-using System.Diagnostics.CodeAnalysis;
-using System.Linq;
-using Microsoft.CodeAnalysis;
-using Microsoft.CodeAnalysis.CSharp;
-using Microsoft.CodeAnalysis.CSharp.Syntax;
-using Microsoft.CodeAnalysis.Diagnostics;
-
-namespace Robust.Analyzers
-{
-    [DiagnosticAnalyzer(LanguageNames.CSharp)]
-    public class FriendAnalyzer : DiagnosticAnalyzer
-    {
-        const string FriendAttribute = "Robust.Shared.Analyzers.FriendAttribute";
-
-        public const string DiagnosticId = "RA0002";
-
-        private const string Title = "Tried to access friend-only member";
-        private const string MessageFormat = "Tried to access member \"{0}\" in class \"{1}\" which can only be accessed by friend classes";
-        private const string Description = "Make sure to specify the accessing class in the friends attribute.";
-        private const string Category = "Usage";
-
-        [SuppressMessage("ReSharper", "RS2008")]
-        private static readonly DiagnosticDescriptor Rule = new (DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Error, true, Description);
-
-        public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(Rule);
-
-        public override void Initialize(AnalysisContext context)
-        {
-            context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics);
-            context.EnableConcurrentExecution();
-            context.RegisterSyntaxNodeAction(CheckFriendship, SyntaxKind.SimpleMemberAccessExpression);
-        }
-
-        private void CheckFriendship(SyntaxNodeAnalysisContext context)
-        {
-            if (context.Node is not MemberAccessExpressionSyntax memberAccess)
-                return;
-
-            // We only do something if our parent is one of a few types.
-            switch (context.Node.Parent)
-            {
-                // If we're being assigned...
-                case AssignmentExpressionSyntax assignParent:
-                {
-                    if (assignParent.Left != memberAccess)
-                        return;
-                    break;
-                }
-
-                // If we're being invoked...
-                case InvocationExpressionSyntax:
-                    break;
-
-                // Otherwise, do nothing.
-                default:
-                    return;
-            }
-
-            // Get the friend attribute
-            var friendAttr = context.Compilation.GetTypeByMetadataName(FriendAttribute);
-
-            // Get the type that is containing this expression, or, the class where this is happening.
-            if (context.ContainingSymbol?.ContainingType is not { } containingType)
-                return;
-
-            // We check all of our children and get only the identifiers.
-            foreach (var identifier in memberAccess.ChildNodes().Select(node => node as IdentifierNameSyntax))
-            {
-                if (identifier == null) continue;
-
-                // Get the type info of the identifier, so we can check the attributes...
-                if (context.SemanticModel.GetTypeInfo(identifier).ConvertedType is not { } type)
-                    continue;
-
-                // Same-type access is always fine.
-                if (SymbolEqualityComparer.Default.Equals(type, containingType))
-                    continue;
-
-                // Finally, get all attributes of the type, to check if we have any friend classes.
-                foreach (var attribute in type.GetAttributes())
-                {
-                    // If the attribute isn't the friend attribute, continue.
-                    if (!SymbolEqualityComparer.Default.Equals(attribute.AttributeClass, friendAttr))
-                        continue;
-
-                    // Check all types allowed in the friend attribute. (We assume there's only one constructor arg.)
-                    foreach (var constant in attribute.ConstructorArguments[0].Values)
-                    {
-                        // Check if the value is a type...
-                        if (constant.Value is not INamedTypeSymbol t)
-                            continue;
-
-                        // If we find that the containing class is specified in the attribute, return! All is good.
-                        if (SymbolEqualityComparer.Default.Equals(containingType, t))
-                            return;
-                    }
-
-                    // Not in a friend class! Report an error.
-                    context.ReportDiagnostic(
-                        Diagnostic.Create(Rule, context.Node.GetLocation(),
-                            $"{context.Node.ToString().Split('.').LastOrDefault()}", $"{type.Name}"));
-                }
-            }
-        }
-    }
-}

Robust.Analyzers/Robust.Analyzers.csproj

@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <TargetFramework>netstandard2.0</TargetFramework>
-    <LangVersion>9</LangVersion>
   </PropertyGroup>
 
   <ItemGroup>

Robust.Benchmarks/NumericsHelpers/AddBenchmark.cs

@@ -1,28 +0,0 @@
-using BenchmarkDotNet.Attributes;
-
-namespace Robust.Benchmarks.NumericsHelpers
-{
-    public class AddBenchmark
-    {
-        [Params(32, 128)]
-        public int N { get; set; }
-
-        private float[] _inputA = default!;
-        private float[] _inputB = default!;
-        private float[] _output = default!;
-
-        [GlobalSetup]
-        public void Setup()
-        {
-            _inputA = new float[N];
-            _inputB = new float[N];
-            _output = new float[N];
-        }
-
-        [Benchmark]
-        public void Bench()
-        {
-            Shared.Maths.NumericsHelpers.Add(_inputA, _inputB, _output);
-        }
-    }
-}

Robust.Benchmarks/Program.cs

@@ -4,11 +4,9 @@ namespace Robust.Benchmarks
 {
     internal class Program
     {
-        // --allCategories=ctg1,ctg2
-        // --anyCategories=ctg1,ctg2
         public static void Main(string[] args)
         {
-            BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args);
+            BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run();
         }
     }
 }

Robust.Benchmarks/Serialization/BenchmarkIntSerializer.cs

@@ -1,40 +0,0 @@
-using System.Globalization;
-using Robust.Shared.IoC;
-using Robust.Shared.Serialization.Manager;
-using Robust.Shared.Serialization.Manager.Result;
-using Robust.Shared.Serialization.Markdown;
-using Robust.Shared.Serialization.Markdown.Validation;
-using Robust.Shared.Serialization.Markdown.Value;
-using Robust.Shared.Serialization.TypeSerializers.Interfaces;
-
-namespace Robust.Benchmarks.Serialization
-{
-    public class BenchmarkIntSerializer : ITypeSerializer<int, ValueDataNode>
-    {
-        public ValidationNode Validate(ISerializationManager serializationManager, ValueDataNode node,
-            IDependencyCollection dependencies, ISerializationContext? context = null)
-        {
-            return int.TryParse(node.Value, out _)
-                ? new ValidatedValueNode(node)
-                : new ErrorNode(node, $"Failed parsing int value: {node.Value}");
-        }
-
-        public DeserializationResult Read(ISerializationManager serializationManager, ValueDataNode node,
-            IDependencyCollection dependencies, bool skipHook, ISerializationContext? context = null)
-        {
-            return new DeserializedValue<int>(int.Parse(node.Value, CultureInfo.InvariantCulture));
-        }
-
-        public DataNode Write(ISerializationManager serializationManager, int value, bool alwaysWrite = false,
-            ISerializationContext? context = null)
-        {
-            return new ValueDataNode(value.ToString(CultureInfo.InvariantCulture));
-        }
-
-        public int Copy(ISerializationManager serializationManager, int source, int target, bool skipHook,
-            ISerializationContext? context = null)
-        {
-            return source;
-        }
-    }
-}

Robust.Benchmarks/Serialization/Copy/SerializationCopyBenchmark.cs

@@ -6,13 +6,11 @@ using Robust.Shared.Serialization.Manager;
 using Robust.Shared.Serialization.Markdown;
 using Robust.Shared.Serialization.Markdown.Mapping;
 using Robust.Shared.Serialization.Markdown.Sequence;
-using Robust.Shared.Serialization.TypeSerializers.Implementations.Custom;
 using Robust.Shared.Utility;
 using YamlDotNet.RepresentationModel;
 
 namespace Robust.Benchmarks.Serialization.Copy
 {
-    [MemoryDiagnoser]
     public class SerializationCopyBenchmark : SerializationBenchmark
     {
         public SerializationCopyBenchmark()
@@ -37,10 +35,6 @@ namespace Robust.Benchmarks.Serialization.Copy
 
         private SeedDataDefinition Seed { get; }
 
-        private BenchmarkFlagsEnum FlagZero = BenchmarkFlagsEnum.Zero;
-
-        private BenchmarkFlagsEnum FlagThirtyOne = BenchmarkFlagsEnum.ThirtyOne;
-
         [Benchmark]
         public string? CreateCopyString()
         {
@@ -117,35 +111,5 @@ namespace Robust.Benchmarks.Serialization.Copy
 
             return copy;
         }
-
-        [Benchmark]
-        [BenchmarkCategory("flag")]
-        public object? CopyFlagZero()
-        {
-            return SerializationManager.CopyWithTypeSerializer(
-                typeof(FlagSerializer<BenchmarkFlags>),
-                (int) FlagZero,
-                (int) FlagZero);
-        }
-
-        [Benchmark]
-        [BenchmarkCategory("flag")]
-        public object? CopyFlagThirtyOne()
-        {
-            return SerializationManager.CopyWithTypeSerializer(
-                typeof(FlagSerializer<BenchmarkFlags>),
-                (int) FlagThirtyOne,
-                (int) FlagThirtyOne);
-        }
-
-        [Benchmark]
-        [BenchmarkCategory("customTypeSerializer")]
-        public object? CopyIntegerCustomSerializer()
-        {
-            return SerializationManager.CopyWithTypeSerializer(
-                typeof(BenchmarkIntSerializer),
-                Integer,
-                Integer);
-        }
     }
 }

Robust.Benchmarks/Serialization/Definitions/BenchmarkFlags.cs

@@ -1,19 +0,0 @@
-using System;
-using Robust.Shared.Serialization;
-
-namespace Robust.Benchmarks.Serialization.Definitions
-{
-    public class BenchmarkFlags
-    {
-        public const int Zero = 1 << 0;
-        public const int ThirtyOne = 1 << 31;
-    }
-
-    [Flags]
-    [FlagsFor(typeof(BenchmarkFlags))]
-    public enum BenchmarkFlagsEnum
-    {
-        Zero = BenchmarkFlags.Zero,
-        ThirtyOne = BenchmarkFlags.ThirtyOne
-    }
-}

Robust.Benchmarks/Serialization/Definitions/DataDefinitionWithString.cs

@@ -5,7 +5,7 @@ namespace Robust.Benchmarks.Serialization.Definitions
     [DataDefinition]
     public class DataDefinitionWithString
     {
-        [DataField("string")]
+        [field: DataField("string")]
         public string StringField { get; init; } = default!;
     }
 }

Robust.Benchmarks/Serialization/Definitions/SealedDataDefinitionWithString.cs

@@ -1,11 +0,0 @@
-using Robust.Shared.Serialization.Manager.Attributes;
-
-namespace Robust.Benchmarks.Serialization.Definitions
-{
-    [DataDefinition]
-    public sealed class SealedDataDefinitionWithString
-    {
-        [DataField("string")]
-        public string StringField { get; init; } = default!;
-    }
-}

Robust.Benchmarks/Serialization/Initialize/SerializationInitializeBenchmark.cs

@@ -3,7 +3,6 @@ using Robust.Shared.Serialization.Manager;
 
 namespace Robust.Benchmarks.Serialization.Initialize
 {
-    [MemoryDiagnoser]
     public class SerializationInitializeBenchmark : SerializationBenchmark
     {
         [IterationCleanup]

Robust.Benchmarks/Serialization/Read/SerializationReadBenchmark.cs

@@ -1,17 +1,14 @@
 using System.IO;
 using BenchmarkDotNet.Attributes;
 using Robust.Benchmarks.Serialization.Definitions;
-using Robust.Shared.Serialization.Manager.Result;
 using Robust.Shared.Serialization.Markdown;
 using Robust.Shared.Serialization.Markdown.Mapping;
 using Robust.Shared.Serialization.Markdown.Sequence;
 using Robust.Shared.Serialization.Markdown.Value;
-using Robust.Shared.Serialization.TypeSerializers.Implementations.Custom;
 using YamlDotNet.RepresentationModel;
 
 namespace Robust.Benchmarks.Serialization.Read
 {
-    [MemoryDiagnoser]
     public class SerializationReadBenchmark : SerializationBenchmark
     {
         public SerializationReadBenchmark()
@@ -35,10 +32,6 @@ namespace Robust.Benchmarks.Serialization.Read
 
         private MappingDataNode SeedNode { get; }
 
-        private ValueDataNode FlagZero { get; } = new("Zero");
-
-        private ValueDataNode FlagThirtyOne { get; } = new("ThirtyOne");
-
         [Benchmark]
         public string? ReadString()
         {
@@ -62,35 +55,5 @@ namespace Robust.Benchmarks.Serialization.Read
         {
             return SerializationManager.ReadValue<SeedDataDefinition>(SeedNode);
         }
-
-        [Benchmark]
-        [BenchmarkCategory("flag")]
-        public DeserializationResult ReadFlagZero()
-        {
-            return SerializationManager.ReadWithTypeSerializer(
-                typeof(int),
-                typeof(FlagSerializer<BenchmarkFlags>),
-                FlagZero);
-        }
-
-        [Benchmark]
-        [BenchmarkCategory("flag")]
-        public DeserializationResult ReadThirtyOne()
-        {
-            return SerializationManager.ReadWithTypeSerializer(
-                typeof(int),
-                typeof(FlagSerializer<BenchmarkFlags>),
-                FlagThirtyOne);
-        }
-
-        [Benchmark]
-        [BenchmarkCategory("customTypeSerializer")]
-        public DeserializationResult ReadIntegerCustomSerializer()
-        {
-            return SerializationManager.ReadWithTypeSerializer(
-                typeof(int),
-                typeof(BenchmarkIntSerializer),
-                IntNode);
-        }
     }
 }

Robust.Benchmarks/Serialization/SerializationArrayBenchmark.cs

@@ -1,127 +0,0 @@
-using BenchmarkDotNet.Attributes;
-using Robust.Benchmarks.Serialization.Definitions;
-using Robust.Shared.Serialization.Markdown.Mapping;
-using Robust.Shared.Serialization.Markdown.Sequence;
-using Robust.Shared.Serialization.Markdown.Value;
-
-namespace Robust.Benchmarks.Serialization
-{
-    [MemoryDiagnoser]
-    public class SerializationArrayBenchmark : SerializationBenchmark
-    {
-        public SerializationArrayBenchmark()
-        {
-            InitializeSerialization();
-
-            OneStringDefNode = new SequenceDataNode();
-            OneStringDefNode.Add(new MappingDataNode
-            {
-                ["string"] = new ValueDataNode("ABC")
-            });
-
-            TenStringDefsNode = new SequenceDataNode();
-
-            for (var i = 0; i < 10; i++)
-            {
-                TenStringDefsNode.Add(new MappingDataNode
-                {
-                    ["string"] = new ValueDataNode("ABC")
-                });
-            }
-        }
-
-        private SequenceDataNode EmptyNode { get; } = new();
-
-        private SequenceDataNode OneIntNode { get; } = new("1");
-
-        private SequenceDataNode TenIntsNode { get; } = new("1", "2", "3", "4", "5", "6", "7", "8", "9", "10");
-
-        private SequenceDataNode OneStringDefNode { get; }
-
-        private SequenceDataNode TenStringDefsNode { get; }
-
-        [Benchmark]
-        [BenchmarkCategory("read")]
-        public string[]? ReadEmptyString()
-        {
-            return SerializationManager.ReadValue<string[]>(EmptyNode);
-        }
-
-        [Benchmark]
-        [BenchmarkCategory("read")]
-        public string[]? ReadOneString()
-        {
-            return SerializationManager.ReadValue<string[]>(OneIntNode);
-        }
-
-        [Benchmark]
-        [BenchmarkCategory("read")]
-        public string[]? ReadTenStrings()
-        {
-            return SerializationManager.ReadValue<string[]>(TenIntsNode);
-        }
-
-        [Benchmark]
-        [BenchmarkCategory("read")]
-        public int[]? ReadEmptyInt()
-        {
-            return SerializationManager.ReadValue<int[]>(EmptyNode);
-        }
-
-        [Benchmark]
-        [BenchmarkCategory("read")]
-        public int[]? ReadOneInt()
-        {
-            return SerializationManager.ReadValue<int[]>(OneIntNode);
-        }
-
-        [Benchmark]
-        [BenchmarkCategory("read")]
-        public int[]? ReadTenInts()
-        {
-            return SerializationManager.ReadValue<int[]>(TenIntsNode);
-        }
-
-        [Benchmark]
-        [BenchmarkCategory("read")]
-        public DataDefinitionWithString[]? ReadEmptyStringDataDef()
-        {
-            return SerializationManager.ReadValue<DataDefinitionWithString[]>(EmptyNode);
-        }
-
-        [Benchmark]
-        [BenchmarkCategory("read")]
-        public DataDefinitionWithString[]? ReadOneStringDataDef()
-        {
-            return SerializationManager.ReadValue<DataDefinitionWithString[]>(OneStringDefNode);
-        }
-
-        [Benchmark]
-        [BenchmarkCategory("read")]
-        public DataDefinitionWithString[]? ReadTenStringDataDefs()
-        {
-            return SerializationManager.ReadValue<DataDefinitionWithString[]>(TenStringDefsNode);
-        }
-
-        [Benchmark]
-        [BenchmarkCategory("read")]
-        public SealedDataDefinitionWithString[]? ReadEmptySealedStringDataDef()
-        {
-            return SerializationManager.ReadValue<SealedDataDefinitionWithString[]>(EmptyNode);
-        }
-
-        [Benchmark]
-        [BenchmarkCategory("read")]
-        public SealedDataDefinitionWithString[]? ReadOneSealedStringDataDef()
-        {
-            return SerializationManager.ReadValue<SealedDataDefinitionWithString[]>(OneStringDefNode);
-        }
-
-        [Benchmark]
-        [BenchmarkCategory("read")]
-        public SealedDataDefinitionWithString[]? ReadTenSealedStringDataDefs()
-        {
-            return SerializationManager.ReadValue<SealedDataDefinitionWithString[]>(TenStringDefsNode);
-        }
-    }
-}

Robust.Benchmarks/Serialization/Write/SerializationWriteBenchmark.cs

@@ -7,12 +7,10 @@ using Robust.Shared.Serialization.Markdown;
 using Robust.Shared.Serialization.Markdown.Mapping;
 using Robust.Shared.Serialization.Markdown.Sequence;
 using Robust.Shared.Serialization.Markdown.Value;
-using Robust.Shared.Serialization.TypeSerializers.Implementations.Custom;
 using YamlDotNet.RepresentationModel;
 
 namespace Robust.Benchmarks.Serialization.Write
 {
-    [MemoryDiagnoser]
     public class SerializationWriteBenchmark : SerializationBenchmark
     {
         public SerializationWriteBenchmark()
@@ -37,10 +35,6 @@ namespace Robust.Benchmarks.Serialization.Write
 
         private SeedDataDefinition Seed { get; }
 
-        private BenchmarkFlagsEnum FlagZero = BenchmarkFlagsEnum.Zero;
-
-        private BenchmarkFlagsEnum FlagThirtyOne = BenchmarkFlagsEnum.ThirtyOne;
-
         [Benchmark]
         public DataNode WriteString()
         {
@@ -100,35 +94,5 @@ namespace Robust.Benchmarks.Serialization.Write
 
             return mapping;
         }
-
-        [Benchmark]
-        [BenchmarkCategory("flag")]
-        public DataNode WriteFlagZero()
-        {
-            return SerializationManager.WriteWithTypeSerializer(
-                typeof(int),
-                typeof(FlagSerializer<BenchmarkFlags>),
-                FlagZero);
-        }
-
-        [Benchmark]
-        [BenchmarkCategory("flag")]
-        public DataNode WriteThirtyOne()
-        {
-            return SerializationManager.WriteWithTypeSerializer(
-                typeof(int),
-                typeof(FlagSerializer<BenchmarkFlags>),
-                FlagThirtyOne);
-        }
-
-        [Benchmark]
-        [BenchmarkCategory("customTypeSerializer")]
-        public DataNode WriteIntegerCustomSerializer()
-        {
-            return SerializationManager.WriteWithTypeSerializer(
-                typeof(int),
-                typeof(BenchmarkIntSerializer),
-                Integer);
-        }
     }
 }

Robust.Client.CEF/BeforeBrowseContext.cs

@@ -1,32 +0,0 @@
-using Xilium.CefGlue;
-
-namespace Robust.Client.CEF
-{
-    public sealed class BeforeBrowseContext
-    {
-        internal readonly CefRequest CefRequest;
-
-        public string Url => CefRequest.Url;
-        public string Method => CefRequest.Method;
-
-        public bool IsRedirect { get; }
-        public bool UserGesture { get; }
-
-        public bool IsCancelled { get; private set; }
-
-        internal BeforeBrowseContext(
-            bool isRedirect,
-            bool userGesture,
-            CefRequest cefRequest)
-        {
-            CefRequest = cefRequest;
-            IsRedirect = isRedirect;
-            UserGesture = userGesture;
-        }
-
-        public void DoCancel()
-        {
-            IsCancelled = true;
-        }
-    }
-}

Robust.Client.CEF/BrowserControl.cs

@@ -1,593 +0,0 @@
-using System;
-using System.Collections.Generic;
-using Robust.Client.Graphics;
-using Robust.Client.Input;
-using Robust.Client.UserInterface;
-using Robust.Shared.IoC;
-using Robust.Shared.Log;
-using Robust.Shared.Maths;
-using Robust.Shared.Utility;
-using Robust.Shared.ViewVariables;
-using SixLabors.ImageSharp.PixelFormats;
-using Xilium.CefGlue;
-using static Robust.Client.CEF.CefKeyCodes;
-using static Robust.Client.CEF.CefKeyCodes.ChromiumKeyboardCode;
-using static Robust.Client.Input.Keyboard;
-
-namespace Robust.Client.CEF
-{
-    // Funny browser control to integrate in UI.
-    public class BrowserControl : Control, IBrowserControl, IRawInputControl
-    {
-        private const int ScrollSpeed = 50;
-
-        [Dependency] private readonly IClyde _clyde = default!;
-        [Dependency] private readonly IInputManager _inputMgr = default!;
-        [Dependency] private readonly CefManager _cef = default!;
-
-        private RobustRequestHandler _requestHandler = new RobustRequestHandler(Logger.GetSawmill("root"));
-        private LiveData? _data;
-        private string _startUrl = "about:blank";
-
-        [ViewVariables(VVAccess.ReadWrite)]
-        public string Url
-        {
-            get => _data == null ? _startUrl : _data.Browser.GetMainFrame().Url;
-            set
-            {
-                if (_data == null)
-                    _startUrl = value;
-                else
-                    _data.Browser.GetMainFrame().LoadUrl(value);
-            }
-        }
-
-        [ViewVariables] public bool IsLoading => _data?.Browser.IsLoading ?? false;
-
-        private readonly Dictionary<Key, ChromiumKeyboardCode> _keyMap = new()
-        {
-            [Key.A] = VKEY_A,
-            [Key.B] = VKEY_B,
-            [Key.C] = VKEY_C,
-            [Key.D] = VKEY_D,
-            [Key.E] = VKEY_E,
-            [Key.F] = VKEY_F,
-            [Key.G] = VKEY_G,
-            [Key.H] = VKEY_H,
-            [Key.I] = VKEY_I,
-            [Key.J] = VKEY_J,
-            [Key.K] = VKEY_K,
-            [Key.L] = VKEY_L,
-            [Key.M] = VKEY_M,
-            [Key.N] = VKEY_N,
-            [Key.O] = VKEY_O,
-            [Key.P] = VKEY_P,
-            [Key.Q] = VKEY_Q,
-            [Key.R] = VKEY_R,
-            [Key.S] = VKEY_S,
-            [Key.T] = VKEY_T,
-            [Key.U] = VKEY_U,
-            [Key.V] = VKEY_V,
-            [Key.W] = VKEY_W,
-            [Key.X] = VKEY_X,
-            [Key.Y] = VKEY_Y,
-            [Key.Z] = VKEY_Z,
-            [Key.Num0] = VKEY_0,
-            [Key.Num1] = VKEY_1,
-            [Key.Num2] = VKEY_2,
-            [Key.Num3] = VKEY_3,
-            [Key.Num4] = VKEY_4,
-            [Key.Num5] = VKEY_5,
-            [Key.Num6] = VKEY_6,
-            [Key.Num7] = VKEY_7,
-            [Key.Num8] = VKEY_8,
-            [Key.Num9] = VKEY_9,
-            [Key.NumpadNum0] = VKEY_NUMPAD0,
-            [Key.NumpadNum1] = VKEY_NUMPAD1,
-            [Key.NumpadNum2] = VKEY_NUMPAD2,
-            [Key.NumpadNum3] = VKEY_NUMPAD3,
-            [Key.NumpadNum4] = VKEY_NUMPAD4,
-            [Key.NumpadNum5] = VKEY_NUMPAD5,
-            [Key.NumpadNum6] = VKEY_NUMPAD6,
-            [Key.NumpadNum7] = VKEY_NUMPAD7,
-            [Key.NumpadNum8] = VKEY_NUMPAD8,
-            [Key.NumpadNum9] = VKEY_NUMPAD9,
-            [Key.Escape] = VKEY_ESCAPE,
-            [Key.Control] = VKEY_CONTROL,
-            [Key.Shift] = VKEY_SHIFT,
-            [Key.Alt] = VKEY_MENU,
-            [Key.LSystem] = VKEY_LWIN,
-            [Key.RSystem] = VKEY_RWIN,
-            [Key.LBracket] = VKEY_OEM_4,
-            [Key.RBracket] = VKEY_OEM_6,
-            [Key.SemiColon] = VKEY_OEM_1,
-            [Key.Comma] = VKEY_OEM_COMMA,
-            [Key.Period] = VKEY_OEM_PERIOD,
-            [Key.Apostrophe] = VKEY_OEM_7,
-            [Key.Slash] = VKEY_OEM_2,
-            [Key.BackSlash] = VKEY_OEM_5,
-            [Key.Tilde] = VKEY_OEM_3,
-            [Key.Equal] = VKEY_OEM_PLUS,
-            [Key.Space] = VKEY_SPACE,
-            [Key.Return] = VKEY_RETURN,
-            [Key.BackSpace] = VKEY_BACK,
-            [Key.Tab] = VKEY_TAB,
-            [Key.PageUp] = VKEY_PRIOR,
-            [Key.PageDown] = VKEY_NEXT,
-            [Key.End] = VKEY_END,
-            [Key.Home] = VKEY_HOME,
-            [Key.Insert] = VKEY_INSERT,
-            [Key.Delete] = VKEY_DELETE,
-            [Key.Minus] = VKEY_OEM_MINUS,
-            [Key.NumpadAdd] = VKEY_ADD,
-            [Key.NumpadSubtract] = VKEY_SUBTRACT,
-            [Key.NumpadDivide] = VKEY_DIVIDE,
-            [Key.NumpadMultiply] = VKEY_MULTIPLY,
-            [Key.NumpadDecimal] = VKEY_DECIMAL,
-            [Key.Left] = VKEY_LEFT,
-            [Key.Right] = VKEY_RIGHT,
-            [Key.Up] = VKEY_UP,
-            [Key.Down] = VKEY_DOWN,
-            [Key.F1] = VKEY_F1,
-            [Key.F2] = VKEY_F2,
-            [Key.F3] = VKEY_F3,
-            [Key.F4] = VKEY_F4,
-            [Key.F5] = VKEY_F5,
-            [Key.F6] = VKEY_F6,
-            [Key.F7] = VKEY_F7,
-            [Key.F8] = VKEY_F8,
-            [Key.F9] = VKEY_F9,
-            [Key.F10] = VKEY_F10,
-            [Key.F11] = VKEY_F11,
-            [Key.F12] = VKEY_F12,
-            [Key.F13] = VKEY_F13,
-            [Key.F14] = VKEY_F14,
-            [Key.F15] = VKEY_F15,
-            [Key.Pause] = VKEY_PAUSE,
-        };
-
-        public BrowserControl()
-        {
-            CanKeyboardFocus = true;
-            KeyboardFocusOnClick = true;
-            MouseFilter = MouseFilterMode.Stop;
-
-            IoCManager.InjectDependencies(this);
-        }
-
-        protected override void EnteredTree()
-        {
-            base.EnteredTree();
-
-            _cef.CheckInitialized();
-
-            DebugTools.AssertNull(_data);
-
-            // A funny render handler that will allow us to render to the control.
-            var renderer = new ControlRenderHandler(this);
-
-            // A funny web cef client. This can actually be shared by multiple browsers, but I'm not sure how the
-            // rendering would work in that case? TODO CEF: Investigate a way to share the web client?
-            var client = new RobustCefClient(renderer, _requestHandler, new RobustLoadHandler());
-
-            var info = CefWindowInfo.Create();
-
-            // FUNFACT: If you DO NOT set these below and set info.Width/info.Height instead, you get an external window
-            // Good to know, huh? Setup is the same, except you can pass a dummy render handler to the CEF client.
-            info.SetAsWindowless(IntPtr.Zero, false); // TODO CEF: Pass parent handle?
-            info.WindowlessRenderingEnabled = true;
-
-            var settings = new CefBrowserSettings()
-            {
-                WindowlessFrameRate = 60
-            };
-
-            // Create the web browser! And by default, we go to about:blank.
-            var browser = CefBrowserHost.CreateBrowserSync(info, client, settings, _startUrl);
-
-            var texture = _clyde.CreateBlankTexture<Bgra32>(Vector2i.One);
-
-            _data = new LiveData(texture, client, browser, renderer);
-        }
-
-        protected override void ExitedTree()
-        {
-            base.ExitedTree();
-
-            DebugTools.AssertNotNull(_data);
-
-            _data!.Texture.Dispose();
-            _data.Browser.GetHost().CloseBrowser(true);
-            _data = null;
-        }
-
-        protected internal override void MouseMove(GUIMouseMoveEventArgs args)
-        {
-            base.MouseMove(args);
-
-            if (_data == null)
-                return;
-
-            // Logger.Debug();
-            var modifiers = CalcMouseModifiers();
-            var mouseEvent = new CefMouseEvent(
-                (int) args.RelativePosition.X, (int) args.RelativePosition.Y,
-                modifiers);
-
-            _data.Browser.GetHost().SendMouseMoveEvent(mouseEvent, false);
-        }
-
-        protected internal override void MouseExited()
-        {
-            base.MouseExited();
-
-            if (_data == null)
-                return;
-
-            var modifiers = CalcMouseModifiers();
-
-            _data.Browser.GetHost().SendMouseMoveEvent(new CefMouseEvent(0, 0, modifiers), true);
-        }
-
-        protected internal override void MouseWheel(GUIMouseWheelEventArgs args)
-        {
-            base.MouseWheel(args);
-
-            if (_data == null)
-                return;
-
-            var modifiers = CalcMouseModifiers();
-            var mouseEvent = new CefMouseEvent(
-                (int) args.RelativePosition.X, (int) args.RelativePosition.Y,
-                modifiers);
-
-            _data.Browser.GetHost().SendMouseWheelEvent(
-                mouseEvent,
-                (int) args.Delta.X * ScrollSpeed,
-                (int) args.Delta.Y * ScrollSpeed);
-        }
-
-        bool IRawInputControl.RawKeyEvent(in GuiRawKeyEvent guiRawEvent)
-        {
-            if (_data == null)
-                return false;
-
-            var host = _data.Browser.GetHost();
-
-            if (guiRawEvent.Key is Key.MouseLeft or Key.MouseMiddle or Key.MouseRight)
-            {
-                var key = guiRawEvent.Key switch
-                {
-                    Key.MouseLeft => CefMouseButtonType.Left,
-                    Key.MouseMiddle => CefMouseButtonType.Middle,
-                    Key.MouseRight => CefMouseButtonType.Right,
-                    _ => default // not possible
-                };
-
-                var mouseEvent = new CefMouseEvent(
-                    guiRawEvent.MouseRelative.X, guiRawEvent.MouseRelative.Y,
-                    CefEventFlags.None);
-
-                // Logger.Debug($"MOUSE: {guiRawEvent.Action} {guiRawEvent.Key} {guiRawEvent.ScanCode} {key}");
-
-                // TODO: double click support?
-                host.SendMouseClickEvent(mouseEvent, key, guiRawEvent.Action == RawKeyAction.Up, 1);
-            }
-            else
-            {
-                // TODO: Handle left/right modifier keys??
-                if (!_keyMap.TryGetValue(guiRawEvent.Key, out var vkKey))
-                    vkKey = default;
-
-                // Logger.Debug($"{guiRawEvent.Action} {guiRawEvent.Key} {guiRawEvent.ScanCode} {vkKey}");
-
-                var lParam = 0;
-                lParam |= (guiRawEvent.ScanCode & 0xFF) << 16;
-                if (guiRawEvent.Action != RawKeyAction.Down)
-                    lParam |= 1 << 30;
-
-                if (guiRawEvent.Action == RawKeyAction.Up)
-                    lParam |= 1 << 31;
-
-                var modifiers = CalcModifiers(guiRawEvent.Key);
-
-                host.SendKeyEvent(new CefKeyEvent
-                {
-                    // Repeats are sent as key downs, I guess?
-                    EventType = guiRawEvent.Action == RawKeyAction.Up
-                        ? CefKeyEventType.KeyUp
-                        : CefKeyEventType.RawKeyDown,
-                    NativeKeyCode = lParam,
-                    // NativeKeyCode = guiRawEvent.ScanCode,
-                    WindowsKeyCode = (int) vkKey,
-                    IsSystemKey = false, // TODO
-                    Modifiers = modifiers
-                });
-
-                if (guiRawEvent.Action != RawKeyAction.Up && guiRawEvent.Key == Key.Return)
-                {
-                    host.SendKeyEvent(new CefKeyEvent
-                    {
-                        EventType = CefKeyEventType.Char,
-                        WindowsKeyCode = '\r',
-                        NativeKeyCode = lParam,
-                        Modifiers = modifiers
-                    });
-                }
-            }
-
-            return true;
-        }
-
-        private CefEventFlags CalcModifiers(Key key)
-        {
-            CefEventFlags modifiers = default;
-
-            if (_inputMgr.IsKeyDown(Key.Control))
-                modifiers |= CefEventFlags.ControlDown;
-
-            if (_inputMgr.IsKeyDown(Key.Alt))
-                modifiers |= CefEventFlags.AltDown;
-
-            if (_inputMgr.IsKeyDown(Key.Shift))
-                modifiers |= CefEventFlags.ShiftDown;
-
-            if (_inputMgr.IsKeyDown(Key.Shift))
-                modifiers |= CefEventFlags.ShiftDown;
-
-            return modifiers;
-        }
-
-        private CefEventFlags CalcMouseModifiers()
-        {
-            CefEventFlags modifiers = default;
-
-            if (_inputMgr.IsKeyDown(Key.Control))
-                modifiers |= CefEventFlags.ControlDown;
-
-            if (_inputMgr.IsKeyDown(Key.Alt))
-                modifiers |= CefEventFlags.AltDown;
-
-            if (_inputMgr.IsKeyDown(Key.Shift))
-                modifiers |= CefEventFlags.ShiftDown;
-
-            if (_inputMgr.IsKeyDown(Key.Shift))
-                modifiers |= CefEventFlags.ShiftDown;
-
-            if (_inputMgr.IsKeyDown(Key.MouseLeft))
-                modifiers |= CefEventFlags.LeftMouseButton;
-
-            if (_inputMgr.IsKeyDown(Key.MouseMiddle))
-                modifiers |= CefEventFlags.MiddleMouseButton;
-
-            if (_inputMgr.IsKeyDown(Key.MouseRight))
-                modifiers |= CefEventFlags.RightMouseButton;
-
-            return modifiers;
-        }
-
-        protected internal override void TextEntered(GUITextEventArgs args)
-        {
-            base.TextEntered(args);
-
-            if (_data == null)
-                return;
-
-            var host = _data.Browser.GetHost();
-
-            Span<char> buf = stackalloc char[2];
-            var written = args.AsRune.EncodeToUtf16(buf);
-
-            for (var i = 0; i < written; i++)
-            {
-                host.SendKeyEvent(new CefKeyEvent
-                {
-                    EventType = CefKeyEventType.Char,
-                    WindowsKeyCode = buf[i],
-                    Character = buf[i],
-                    UnmodifiedCharacter = buf[i]
-                });
-            }
-        }
-
-        protected override void Resized()
-        {
-            base.Resized();
-
-            if (_data == null)
-                return;
-
-            _data.Browser.GetHost().NotifyMoveOrResizeStarted();
-            _data.Browser.GetHost().WasResized();
-            _data.Texture.Dispose();
-            _data.Texture = _clyde.CreateBlankTexture<Bgra32>((PixelWidth, PixelHeight));
-        }
-
-        protected internal override void Draw(DrawingHandleScreen handle)
-        {
-            base.Draw(handle);
-
-            if (_data == null)
-                return;
-
-            var bufImg = _data.Renderer.Buffer.Buffer;
-
-            _data.Texture.SetSubImage(
-                Vector2i.Zero,
-                bufImg,
-                new UIBox2i(
-                    0, 0,
-                    Math.Min(PixelWidth, bufImg.Width),
-                    Math.Min(PixelHeight, bufImg.Height)));
-
-            handle.DrawTexture(_data.Texture, Vector2.Zero);
-        }
-
-        public void StopLoad()
-        {
-            if (_data == null)
-                throw new InvalidOperationException();
-
-            _data.Browser.StopLoad();
-        }
-
-        public void Reload()
-        {
-            if (_data == null)
-                throw new InvalidOperationException();
-
-            _data.Browser.Reload();
-        }
-
-        public bool GoBack()
-        {
-            if (_data == null)
-                throw new InvalidOperationException();
-
-            if (!_data.Browser.CanGoBack)
-                return false;
-
-            _data.Browser.GoBack();
-            return true;
-        }
-
-        public bool GoForward()
-        {
-            if (_data == null)
-                throw new InvalidOperationException();
-
-            if (!_data.Browser.CanGoForward)
-                return false;
-
-            _data.Browser.GoForward();
-            return true;
-        }
-
-        public void ExecuteJavaScript(string code)
-        {
-            if (_data == null)
-                throw new InvalidOperationException();
-
-            // TODO: this should not run until the browser is done loading seriously does this even work?
-            _data.Browser.GetMainFrame().ExecuteJavaScript(code, string.Empty, 1);
-        }
-
-        public void AddResourceRequestHandler(Action<RequestHandlerContext> handler)
-        {
-            _requestHandler.AddResourceRequestHandler(handler);
-        }
-
-        public void RemoveResourceRequestHandler(Action<RequestHandlerContext> handler)
-        {
-            _requestHandler.RemoveResourceRequestHandler(handler);
-        }
-
-        public void AddBeforeBrowseHandler(Action<BeforeBrowseContext> handler)
-        {
-            _requestHandler.AddBeforeBrowseHandler(handler);
-        }
-
-        public void RemoveBeforeBrowseHandler(Action<BeforeBrowseContext> handler)
-        {
-            _requestHandler.RemoveBeforeBrowseHandler(handler);
-        }
-
-        private sealed class LiveData
-        {
-            public OwnedTexture Texture;
-            public readonly RobustCefClient Client;
-            public readonly CefBrowser Browser;
-            public readonly ControlRenderHandler Renderer;
-
-            public LiveData(
-                OwnedTexture texture,
-                RobustCefClient client,
-                CefBrowser browser,
-                ControlRenderHandler renderer)
-            {
-                Texture = texture;
-                Client = client;
-                Browser = browser;
-                Renderer = renderer;
-            }
-        }
-    }
-
-    internal class ControlRenderHandler : CefRenderHandler
-    {
-        public ImageBuffer Buffer { get; }
-        private Control _control;
-
-        internal ControlRenderHandler(Control control)
-        {
-            Buffer = new ImageBuffer(control);
-            _control = control;
-        }
-
-        protected override CefAccessibilityHandler? GetAccessibilityHandler() => null;
-
-        protected override void GetViewRect(CefBrowser browser, out CefRectangle rect)
-        {
-            if (_control.Disposed)
-            {
-                rect = new CefRectangle();
-                return;
-            }
-
-            // TODO CEF: Do we need to pass real screen coords? Cause what we do already works...
-            //var screenCoords = _control.ScreenCoordinates;
-            //rect = new CefRectangle((int) screenCoords.X, (int) screenCoords.Y, (int)Math.Max(_control.Size.X, 1), (int)Math.Max(_control.Size.Y, 1));
-
-            // We do the max between size and 1 because it will LITERALLY CRASH WITHOUT AN ERROR otherwise.
-            rect = new CefRectangle(0, 0, (int) Math.Max(_control.Size.X, 1), (int) Math.Max(_control.Size.Y, 1));
-        }
-
-        protected override bool GetScreenInfo(CefBrowser browser, CefScreenInfo screenInfo)
-        {
-            if (_control.Disposed)
-                return false;
-
-            // TODO CEF: Get actual scale factor?
-            screenInfo.DeviceScaleFactor = 1.0f;
-
-            return true;
-        }
-
-        protected override void OnPopupSize(CefBrowser browser, CefRectangle rect)
-        {
-            if (_control.Disposed)
-                return;
-        }
-
-        protected override void OnPaint(CefBrowser browser, CefPaintElementType type, CefRectangle[] dirtyRects,
-            IntPtr buffer, int width, int height)
-        {
-            if (_control.Disposed)
-                return;
-
-            foreach (var dirtyRect in dirtyRects)
-            {
-                Buffer.UpdateBuffer(width, height, buffer, dirtyRect);
-            }
-        }
-
-        protected override void OnAcceleratedPaint(CefBrowser browser, CefPaintElementType type,
-            CefRectangle[] dirtyRects, IntPtr sharedHandle)
-        {
-            // Unused, but we're forced to implement it so.. NOOP.
-        }
-
-        protected override void OnScrollOffsetChanged(CefBrowser browser, double x, double y)
-        {
-            if (_control.Disposed)
-                return;
-        }
-
-        protected override void OnImeCompositionRangeChanged(CefBrowser browser, CefRange selectedRange,
-            CefRectangle[] characterBounds)
-        {
-            if (_control.Disposed)
-                return;
-        }
-    }
-}

Robust.Client.CEF/BrowserWindowCreateParameters.cs

@@ -1,16 +0,0 @@
-namespace Robust.Client.CEF
-{
-    public sealed class BrowserWindowCreateParameters
-    {
-        public int Width { get; set; }
-        public int Height { get; set; }
-
-        public string Url { get; set; } = "about:blank";
-
-        public BrowserWindowCreateParameters(int width, int height)
-        {
-            Width = width;
-            Height = height;
-        }
-    }
-}

Robust.Client.CEF/CefKeyCodes.cs

@@ -1,225 +0,0 @@
-
-using System.Diagnostics.CodeAnalysis;
-
-namespace Robust.Client.CEF
-{
-    [SuppressMessage("ReSharper", "InconsistentNaming")]
-    [SuppressMessage("ReSharper", "UnusedMember.Global")]
-    [SuppressMessage("ReSharper", "IdentifierTypo")]
-    [SuppressMessage("ReSharper", "CA1069")]
-    [SuppressMessage("ReSharper", "CommentTypo")]
-    internal static class CefKeyCodes
-    {
-        // Taken from https://chromium.googlesource.com/chromium/src/+/refs/heads/main/ui/events/keycodes/keyboard_codes_posix.h
-        // See also https://docs.microsoft.com/en-us/windows/win32/inputdev/virtual-key-codes
-        public enum ChromiumKeyboardCode
-        {
-            VKEY_CANCEL = 0x03,
-            VKEY_BACK = 0x08,
-            VKEY_TAB = 0x09,
-            VKEY_BACKTAB = 0x0A,
-            VKEY_CLEAR = 0x0C,
-            VKEY_RETURN = 0x0D,
-            VKEY_SHIFT = 0x10,
-            VKEY_CONTROL = 0x11,
-            VKEY_MENU = 0x12,
-            VKEY_PAUSE = 0x13,
-            VKEY_CAPITAL = 0x14,
-            VKEY_KANA = 0x15,
-            VKEY_HANGUL = 0x15,
-            VKEY_PASTE = 0x16,
-            VKEY_JUNJA = 0x17,
-            VKEY_FINAL = 0x18,
-            VKEY_HANJA = 0x19,
-            VKEY_KANJI = 0x19,
-            VKEY_ESCAPE = 0x1B,
-            VKEY_CONVERT = 0x1C,
-            VKEY_NONCONVERT = 0x1D,
-            VKEY_ACCEPT = 0x1E,
-            VKEY_MODECHANGE = 0x1F,
-            VKEY_SPACE = 0x20,
-            VKEY_PRIOR = 0x21,
-            VKEY_NEXT = 0x22,
-            VKEY_END = 0x23,
-            VKEY_HOME = 0x24,
-            VKEY_LEFT = 0x25,
-            VKEY_UP = 0x26,
-            VKEY_RIGHT = 0x27,
-            VKEY_DOWN = 0x28,
-            VKEY_SELECT = 0x29,
-            VKEY_PRINT = 0x2A,
-            VKEY_EXECUTE = 0x2B,
-            VKEY_SNAPSHOT = 0x2C, // Print Screen / SysRq
-            VKEY_INSERT = 0x2D,
-            VKEY_DELETE = 0x2E,
-            VKEY_HELP = 0x2F,
-            VKEY_0 = 0x30,
-            VKEY_1 = 0x31,
-            VKEY_2 = 0x32,
-            VKEY_3 = 0x33,
-            VKEY_4 = 0x34,
-            VKEY_5 = 0x35,
-            VKEY_6 = 0x36,
-            VKEY_7 = 0x37,
-            VKEY_8 = 0x38,
-            VKEY_9 = 0x39,
-            VKEY_A = 0x41,
-            VKEY_B = 0x42,
-            VKEY_C = 0x43,
-            VKEY_D = 0x44,
-            VKEY_E = 0x45,
-            VKEY_F = 0x46,
-            VKEY_G = 0x47,
-            VKEY_H = 0x48,
-            VKEY_I = 0x49,
-            VKEY_J = 0x4A,
-            VKEY_K = 0x4B,
-            VKEY_L = 0x4C,
-            VKEY_M = 0x4D,
-            VKEY_N = 0x4E,
-            VKEY_O = 0x4F,
-            VKEY_P = 0x50,
-            VKEY_Q = 0x51,
-            VKEY_R = 0x52,
-            VKEY_S = 0x53,
-            VKEY_T = 0x54,
-            VKEY_U = 0x55,
-            VKEY_V = 0x56,
-            VKEY_W = 0x57,
-            VKEY_X = 0x58,
-            VKEY_Y = 0x59,
-            VKEY_Z = 0x5A,
-            VKEY_LWIN = 0x5B,
-            VKEY_COMMAND = VKEY_LWIN, // Provide the Mac name for convenience.
-            VKEY_RWIN = 0x5C,
-            VKEY_APPS = 0x5D,
-            VKEY_SLEEP = 0x5F,
-            VKEY_NUMPAD0 = 0x60,
-            VKEY_NUMPAD1 = 0x61,
-            VKEY_NUMPAD2 = 0x62,
-            VKEY_NUMPAD3 = 0x63,
-            VKEY_NUMPAD4 = 0x64,
-            VKEY_NUMPAD5 = 0x65,
-            VKEY_NUMPAD6 = 0x66,
-            VKEY_NUMPAD7 = 0x67,
-            VKEY_NUMPAD8 = 0x68,
-            VKEY_NUMPAD9 = 0x69,
-            VKEY_MULTIPLY = 0x6A,
-            VKEY_ADD = 0x6B,
-            VKEY_SEPARATOR = 0x6C,
-            VKEY_SUBTRACT = 0x6D,
-            VKEY_DECIMAL = 0x6E,
-            VKEY_DIVIDE = 0x6F,
-            VKEY_F1 = 0x70,
-            VKEY_F2 = 0x71,
-            VKEY_F3 = 0x72,
-            VKEY_F4 = 0x73,
-            VKEY_F5 = 0x74,
-            VKEY_F6 = 0x75,
-            VKEY_F7 = 0x76,
-            VKEY_F8 = 0x77,
-            VKEY_F9 = 0x78,
-            VKEY_F10 = 0x79,
-            VKEY_F11 = 0x7A,
-            VKEY_F12 = 0x7B,
-            VKEY_F13 = 0x7C,
-            VKEY_F14 = 0x7D,
-            VKEY_F15 = 0x7E,
-            VKEY_F16 = 0x7F,
-            VKEY_F17 = 0x80,
-            VKEY_F18 = 0x81,
-            VKEY_F19 = 0x82,
-            VKEY_F20 = 0x83,
-            VKEY_F21 = 0x84,
-            VKEY_F22 = 0x85,
-            VKEY_F23 = 0x86,
-            VKEY_F24 = 0x87,
-            VKEY_NUMLOCK = 0x90,
-            VKEY_SCROLL = 0x91,
-            VKEY_LSHIFT = 0xA0,
-            VKEY_RSHIFT = 0xA1,
-            VKEY_LCONTROL = 0xA2,
-            VKEY_RCONTROL = 0xA3,
-            VKEY_LMENU = 0xA4,
-            VKEY_RMENU = 0xA5,
-            VKEY_BROWSER_BACK = 0xA6,
-            VKEY_BROWSER_FORWARD = 0xA7,
-            VKEY_BROWSER_REFRESH = 0xA8,
-            VKEY_BROWSER_STOP = 0xA9,
-            VKEY_BROWSER_SEARCH = 0xAA,
-            VKEY_BROWSER_FAVORITES = 0xAB,
-            VKEY_BROWSER_HOME = 0xAC,
-            VKEY_VOLUME_MUTE = 0xAD,
-            VKEY_VOLUME_DOWN = 0xAE,
-            VKEY_VOLUME_UP = 0xAF,
-            VKEY_MEDIA_NEXT_TRACK = 0xB0,
-            VKEY_MEDIA_PREV_TRACK = 0xB1,
-            VKEY_MEDIA_STOP = 0xB2,
-            VKEY_MEDIA_PLAY_PAUSE = 0xB3,
-            VKEY_MEDIA_LAUNCH_MAIL = 0xB4,
-            VKEY_MEDIA_LAUNCH_MEDIA_SELECT = 0xB5,
-            VKEY_MEDIA_LAUNCH_APP1 = 0xB6,
-            VKEY_MEDIA_LAUNCH_APP2 = 0xB7,
-            VKEY_OEM_1 = 0xBA,
-            VKEY_OEM_PLUS = 0xBB,
-            VKEY_OEM_COMMA = 0xBC,
-            VKEY_OEM_MINUS = 0xBD,
-            VKEY_OEM_PERIOD = 0xBE,
-            VKEY_OEM_2 = 0xBF,
-            VKEY_OEM_3 = 0xC0,
-            VKEY_OEM_4 = 0xDB,
-            VKEY_OEM_5 = 0xDC,
-            VKEY_OEM_6 = 0xDD,
-            VKEY_OEM_7 = 0xDE,
-            VKEY_OEM_8 = 0xDF,
-            VKEY_OEM_102 = 0xE2,
-            VKEY_OEM_103 = 0xE3, // GTV KEYCODE_MEDIA_REWIND
-            VKEY_OEM_104 = 0xE4, // GTV KEYCODE_MEDIA_FAST_FORWARD
-            VKEY_PROCESSKEY = 0xE5,
-            VKEY_PACKET = 0xE7,
-            VKEY_OEM_ATTN = 0xF0, // JIS DomKey::ALPHANUMERIC
-            VKEY_OEM_FINISH = 0xF1, // JIS DomKey::KATAKANA
-            VKEY_OEM_COPY = 0xF2, // JIS DomKey::HIRAGANA
-            VKEY_DBE_SBCSCHAR = 0xF3, // JIS DomKey::HANKAKU
-            VKEY_DBE_DBCSCHAR = 0xF4, // JIS DomKey::ZENKAKU
-            VKEY_OEM_BACKTAB = 0xF5, // JIS DomKey::ROMAJI
-            VKEY_ATTN = 0xF6, // DomKey::ATTN or JIS DomKey::KANA_MODE
-            VKEY_CRSEL = 0xF7,
-            VKEY_EXSEL = 0xF8,
-            VKEY_EREOF = 0xF9,
-            VKEY_PLAY = 0xFA,
-            VKEY_ZOOM = 0xFB,
-            VKEY_NONAME = 0xFC,
-            VKEY_PA1 = 0xFD,
-            VKEY_OEM_CLEAR = 0xFE,
-            VKEY_UNKNOWN = 0,
-
-            // POSIX specific VKEYs. Note that as of Windows SDK 7.1, 0x97-9F, 0xD8-DA,
-            // and 0xE8 are unassigned.
-            VKEY_WLAN = 0x97,
-            VKEY_POWER = 0x98,
-            VKEY_ASSISTANT = 0x99,
-            VKEY_SETTINGS = 0x9A,
-            VKEY_PRIVACY_SCREEN_TOGGLE = 0x9B,
-            VKEY_BRIGHTNESS_DOWN = 0xD8,
-            VKEY_BRIGHTNESS_UP = 0xD9,
-            VKEY_KBD_BRIGHTNESS_DOWN = 0xDA,
-            VKEY_KBD_BRIGHTNESS_UP = 0xE8,
-
-            // Windows does not have a specific key code for AltGr. We use the unused 0xE1
-            // (VK_OEM_AX) code to represent AltGr, matching the behaviour of Firefox on
-            // Linux.
-            VKEY_ALTGR = 0xE1,
-
-            // Windows does not have a specific key code for Compose. We use the unused
-            // 0xE6 (VK_ICO_CLEAR) code to represent Compose.
-            VKEY_COMPOSE = 0xE6,
-
-            // Windows does not have specific key codes for Media Play and Media Pause. We
-            // use the unused 0xE9 (VK_OEM_RESET) and 0xEA (VK_OEM_JUMP) codes to
-            // represent them.
-            VKEY_MEDIA_PLAY = 0xE9,
-            VKEY_MEDIA_PAUSE = 0xEA,
-        };
-    }
-}

Robust.Client.CEF/CefManager.BrowserWindow.cs

@@ -1,186 +0,0 @@
-using System;
-using System.Collections.Generic;
-using Robust.Client.Graphics;
-using Robust.Shared.IoC;
-using Robust.Shared.Log;
-using Robust.Shared.ViewVariables;
-using Xilium.CefGlue;
-
-namespace Robust.Client.CEF
-{
-    public partial class CefManager
-    {
-        [Dependency] private readonly IClydeInternal _clyde = default!;
-
-        private readonly List<BrowserWindowImpl> _browserWindows = new();
-
-        public IEnumerable<IBrowserWindow> AllBrowserWindows => _browserWindows;
-
-        public IBrowserWindow CreateBrowserWindow(BrowserWindowCreateParameters createParams)
-        {
-            var mainHWnd = (_clyde.MainWindow as IClydeWindowInternal)?.WindowsHWnd ?? 0;
-
-            var info = CefWindowInfo.Create();
-            info.Width = createParams.Width;
-            info.Height = createParams.Height;
-            info.SetAsPopup(mainHWnd, "ss14cef");
-
-            var impl = new BrowserWindowImpl(this);
-
-            var lifeSpanHandler = new WindowLifeSpanHandler(impl);
-            var reqHandler = new RobustRequestHandler(Logger.GetSawmill("root"));
-            var client = new WindowCefClient(lifeSpanHandler, reqHandler);
-            var settings = new CefBrowserSettings();
-
-            impl.Browser = CefBrowserHost.CreateBrowserSync(info, client, settings, createParams.Url);
-            impl.RequestHandler = reqHandler;
-
-            _browserWindows.Add(impl);
-
-            return impl;
-        }
-
-        private sealed class BrowserWindowImpl : IBrowserWindow
-        {
-            private readonly CefManager _manager;
-            internal CefBrowser Browser = default!;
-            internal RobustRequestHandler RequestHandler = default!;
-
-            public Action<RequestHandlerContext>? OnResourceRequest { get; set; }
-
-            [ViewVariables(VVAccess.ReadWrite)]
-            public string Url
-            {
-                get
-                {
-                    CheckClosed();
-                    return Browser.GetMainFrame().Url;
-                }
-                set
-                {
-                    CheckClosed();
-                    Browser.GetMainFrame().LoadUrl(value);
-                }
-            }
-
-            [ViewVariables]
-            public bool IsLoading
-            {
-                get
-                {
-                    CheckClosed();
-                    return Browser.IsLoading;
-                }
-            }
-
-            public BrowserWindowImpl(CefManager manager)
-            {
-                _manager = manager;
-            }
-
-            public void StopLoad()
-            {
-                CheckClosed();
-                Browser.StopLoad();
-            }
-
-            public void Reload()
-            {
-                CheckClosed();
-                Browser.Reload();
-            }
-
-            public bool GoBack()
-            {
-                CheckClosed();
-                if (!Browser.CanGoBack)
-                    return false;
-
-                Browser.GoBack();
-                return true;
-            }
-
-            public bool GoForward()
-            {
-                CheckClosed();
-                if (!Browser.CanGoForward)
-                    return false;
-
-                Browser.GoForward();
-                return true;
-            }
-
-            public void ExecuteJavaScript(string code)
-            {
-                CheckClosed();
-                Browser.GetMainFrame().ExecuteJavaScript(code, string.Empty, 1);
-            }
-
-            public void AddResourceRequestHandler(Action<RequestHandlerContext> handler)
-            {
-                RequestHandler.AddResourceRequestHandler(handler);
-            }
-
-            public void RemoveResourceRequestHandler(Action<RequestHandlerContext> handler)
-            {
-                RequestHandler.RemoveResourceRequestHandler(handler);
-            }
-
-            public void Dispose()
-            {
-                if (Closed)
-                    return;
-
-                Browser.GetHost().CloseBrowser(true);
-                Closed = true;
-            }
-
-            public bool Closed { get; private set; }
-
-            public void OnClose()
-            {
-                Closed = true;
-                _manager._browserWindows.Remove(this);
-                Logger.Debug("Removing window");
-            }
-
-            private void CheckClosed()
-            {
-                if (Closed)
-                    throw new ObjectDisposedException("BrowserWindow");
-            }
-        }
-
-        private sealed class WindowCefClient : CefClient
-        {
-            private readonly CefLifeSpanHandler _lifeSpanHandler;
-            private readonly CefRequestHandler _requestHandler;
-
-            public WindowCefClient(CefLifeSpanHandler lifeSpanHandler, CefRequestHandler requestHandler)
-            {
-                _lifeSpanHandler = lifeSpanHandler;
-                _requestHandler = requestHandler;
-            }
-
-            protected override CefLifeSpanHandler GetLifeSpanHandler() => _lifeSpanHandler;
-            protected override CefRequestHandler GetRequestHandler() => _requestHandler;
-        }
-
-        private sealed class WindowLifeSpanHandler : CefLifeSpanHandler
-        {
-            private readonly BrowserWindowImpl _windowImpl;
-
-            public WindowLifeSpanHandler(BrowserWindowImpl windowImpl)
-            {
-                _windowImpl = windowImpl;
-            }
-
-            protected override void OnBeforeClose(CefBrowser browser)
-            {
-                base.OnBeforeClose(browser);
-
-                _windowImpl.OnClose();
-            }
-        }
-    }
-}

Robust.Client.CEF/CefManager.cs

@@ -1,104 +0,0 @@
-using System;
-using System.IO;
-using JetBrains.Annotations;
-using Robust.Shared.ContentPack;
-using Robust.Shared.Log;
-using Robust.Shared.Utility;
-
-// The library we're using right now. TODO CEF: Do we want to use something else? We will need to ship it ourselves if so.
-using Xilium.CefGlue;
-
-namespace Robust.Client.CEF
-{
-    // Register this with IoC.
-    // TODO CEF: think if making this inherit CefApp is a good idea...
-    // TODO CEF: A way to handle external window browsers...
-    [UsedImplicitly]
-    public partial class CefManager
-    {
-        private CefApp _app = default!;
-        private bool _initialized = false;
-
-        /// <summary>
-        ///     Call this to initialize CEF.
-        /// </summary>
-        public void Initialize()
-        {
-            DebugTools.Assert(!_initialized);
-
-            string subProcessName;
-            if (OperatingSystem.IsWindows())
-                subProcessName = "Robust.Client.CEF.exe";
-            else if (OperatingSystem.IsLinux())
-                subProcessName = "Robust.Client.CEF";
-            else
-                throw new NotSupportedException("Unsupported platform for CEF!");
-
-            var subProcessPath = PathHelpers.ExecutableRelativeFile(subProcessName);
-
-            var settings = new CefSettings()
-            {
-                WindowlessRenderingEnabled = true, // So we can render to our UI controls.
-                ExternalMessagePump = false, // Unsure, honestly. TODO CEF: Research this?
-                NoSandbox = true, // Not disabling the sandbox crashes CEF.
-                BrowserSubprocessPath = subProcessPath,
-                LocalesDirPath = Path.Combine(PathHelpers.GetExecutableDirectory(), "locales"),
-                ResourcesDirPath = PathHelpers.GetExecutableDirectory(),
-                RemoteDebuggingPort = 9222
-            };
-
-            Logger.Info($"CEF Version: {CefRuntime.ChromeVersion}");
-
-            // --------------------------- README --------------------------------------------------
-            // By the way! You're gonna need the CEF binaries in your client's bin folder.
-            // More specifically, version cef_binary_91.1.21+g9dd45fe+chromium-91.0.4472.114
-            // https://cef-builds.spotifycdn.com/cef_binary_91.1.21%2Bg9dd45fe%2Bchromium-91.0.4472.114_windows64_minimal.tar.bz2
-            // https://cef-builds.spotifycdn.com/cef_binary_91.1.21%2Bg9dd45fe%2Bchromium-91.0.4472.114_linux64_minimal.tar.bz2
-            // Here's how to get it to work:
-            // 1. Copy all the contents of "Release" to the bin folder.
-            // 2. Copy all the contents of "Resources" to the bin folder.
-            // Supposedly, you should just need libcef.so in Release and icudtl.dat in Resources...
-            // The rest might be optional.
-            // Maybe. Good luck! If you get odd crashes with no info and a weird exit code, use GDB!
-            // -------------------------------------------------------------------------------------
-
-            _app = new RobustCefApp();
-
-            // We pass no main arguments...
-            CefRuntime.Initialize(new CefMainArgs(null), settings, _app, IntPtr.Zero);
-
-            // TODO CEF: After this point, debugging breaks. No, literally. My client crashes but ONLY with the debugger.
-            // I have tried using the DEBUG and RELEASE versions of libcef.so, stripped or non-stripped...
-            // And nothing seemed to work. Odd.
-
-            _initialized = true;
-        }
-
-        public void CheckInitialized()
-        {
-            if (!_initialized)
-                throw new InvalidOperationException("CefManager has not been initialized!");
-        }
-
-        /// <summary>
-        ///     Needs to be called regularly for CEF to keep working.
-        /// </summary>
-        public void Update()
-        {
-            DebugTools.Assert(_initialized);
-
-            // Calling this makes CEF do its work, without using its own update loop.
-            CefRuntime.DoMessageLoopWork();
-        }
-
-        /// <summary>
-        ///     Call before program shutdown.
-        /// </summary>
-        public void Shutdown()
-        {
-            DebugTools.Assert(_initialized);
-
-            CefRuntime.Shutdown();
-        }
-    }
-}

Robust.Client.CEF/IBrowserControl.cs

@@ -1,48 +0,0 @@
-using System;
-
-namespace Robust.Client.CEF
-{
-    public interface IBrowserControl
-    {
-        /// <summary>
-        ///     Current URL of the browser. Set to load a new page.
-        /// </summary>
-        string Url { get; set; }
-
-        /// <summary>
-        ///     Whether the browser is currently loading a page.
-        /// </summary>
-        bool IsLoading { get; }
-
-        /// <summary>
-        ///     Stops loading the current page.
-        /// </summary>
-        void StopLoad();
-
-        /// <summary>
-        ///     Reload the current page.
-        /// </summary>
-        void Reload();
-
-        /// <summary>
-        ///     Navigate back.
-        /// </summary>
-        /// <returns>Whether the browser could navigate back.</returns>
-        bool GoBack();
-
-        /// <summary>
-        ///     Navigate forward.
-        /// </summary>
-        /// <returns>Whether the browser could navigate forward.</returns>
-        bool GoForward();
-
-        /// <summary>
-        ///     Execute arbitrary JavaScript on the current page.
-        /// </summary>
-        /// <param name="code">JavaScript code.</param>
-        void ExecuteJavaScript(string code);
-
-        void AddResourceRequestHandler(Action<RequestHandlerContext> handler);
-        void RemoveResourceRequestHandler(Action<RequestHandlerContext> handler);
-    }
-}

Robust.Client.CEF/IBrowserWindow.cs

@@ -1,9 +0,0 @@
-using System;
-
-namespace Robust.Client.CEF
-{
-    public interface IBrowserWindow : IBrowserControl, IDisposable
-    {
-        bool Closed { get; }
-    }
-}

Robust.Client.CEF/ImageBuffer.cs

@@ -1,42 +0,0 @@
-using System;
-using Robust.Client.UserInterface;
-using Robust.Client.Utility;
-using Robust.Shared.Maths;
-using SixLabors.ImageSharp;
-using SixLabors.ImageSharp.PixelFormats;
-using Xilium.CefGlue;
-
-namespace Robust.Client.CEF
-{
-    internal sealed class ImageBuffer
-    {
-        private readonly Control _control;
-
-        public ImageBuffer(Control control)
-        {
-            _control = control;
-        }
-
-        public Image<Bgra32> Buffer { get; private set; } = new(1, 1);
-
-        public unsafe void UpdateBuffer(int width, int height, IntPtr buffer, CefRectangle dirtyRect)
-        {
-            if (width != Buffer.Width || height != Buffer.Height)
-                UpdateSize(width, height);
-
-            var span = new ReadOnlySpan<Bgra32>((void*) buffer, width * height);
-
-            ImageSharpExt.Blit(
-                span,
-                width,
-                UIBox2i.FromDimensions(dirtyRect.X, dirtyRect.Y, dirtyRect.Width, dirtyRect.Height),
-                Buffer,
-                (dirtyRect.X, dirtyRect.Y));
-        }
-
-        private void UpdateSize(int width, int height)
-        {
-            Buffer = new Image<Bgra32>(width, height);
-        }
-    }
-}

Robust.Client.CEF/Program.cs

@@ -1,33 +0,0 @@
-using System;
-using Xilium.CefGlue;
-
-namespace Robust.Client.CEF
-{
-    public static class Program
-    {
-        // This was supposed to be the main entry for the subprocess program... It doesn't work.
-        public static int Main(string[] args)
-        {
-            // This is a workaround for this to work on UNIX.
-            var argv = args;
-            if (CefRuntime.Platform != CefRuntimePlatform.Windows)
-            {
-                argv = new string[args.Length + 1];
-                Array.Copy(args, 0, argv, 1, args.Length);
-                argv[0] = "-";
-            }
-
-            var mainArgs = new CefMainArgs(argv);
-
-            // This will block executing until the subprocess is shut down.
-            var code = CefRuntime.ExecuteProcess(mainArgs, null, IntPtr.Zero);
-
-            if (code != 0)
-            {
-                System.Console.WriteLine($"CEF Subprocess exited unsuccessfully with exit code {code}! Arguments: {string.Join(' ', argv)}");
-            }
-
-            return code;
-        }
-    }
-}

Robust.Client.CEF/RequestHandlerContext.cs

@@ -1,56 +0,0 @@
-using System;
-using System.IO;
-using System.Net;
-using Xilium.CefGlue;
-
-namespace Robust.Client.CEF
-{
-    public sealed class RequestHandlerContext
-    {
-        internal readonly CefRequest CefRequest;
-
-        public bool IsNavigation { get; }
-        public bool IsDownload { get; }
-        public string RequestInitiator { get; }
-
-        public string Url => CefRequest.Url;
-        public string Method => CefRequest.Method;
-
-        public bool IsHandled { get; private set; }
-
-        public bool IsCancelled { get; private set; }
-
-        internal IRequestResult? Result { get; private set; }
-
-        internal RequestHandlerContext(
-            bool isNavigation,
-            bool isDownload,
-            string requestInitiator,
-            CefRequest cefRequest)
-        {
-            CefRequest = cefRequest;
-            IsNavigation = isNavigation;
-            IsDownload = isDownload;
-            RequestInitiator = requestInitiator;
-        }
-
-        public void DoCancel()
-        {
-            CheckNotHandled();
-
-            IsHandled = true;
-            IsCancelled = true;
-        }
-
-        public void DoRespondStream(Stream stream, string contentType, HttpStatusCode code = HttpStatusCode.OK)
-        {
-            Result = new RequestResultStream(stream, contentType, code);
-        }
-
-        private void CheckNotHandled()
-        {
-            if (IsHandled)
-                throw new InvalidOperationException("Request has already been handled");
-        }
-    }
-}

Robust.Client.CEF/RequestResults.cs

@@ -1,93 +0,0 @@
-using System;
-using System.IO;
-using System.Net;
-using Xilium.CefGlue;
-
-namespace Robust.Client.CEF
-{
-    internal interface IRequestResult
-    {
-        CefResourceHandler MakeHandler();
-    }
-
-    internal sealed class RequestResultStream : IRequestResult
-    {
-        private readonly Stream _stream;
-        private readonly HttpStatusCode _code;
-        private readonly string _contentType;
-
-        public RequestResultStream(Stream stream, string contentType, HttpStatusCode code)
-        {
-            _stream = stream;
-            _code = code;
-            _contentType = contentType;
-        }
-
-        public CefResourceHandler MakeHandler()
-        {
-            return new Handler(_stream, _contentType, _code);
-        }
-
-        private sealed class Handler : CefResourceHandler
-        {
-            // TODO: async
-            // TODO: exception handling
-
-            private readonly Stream _stream;
-            private readonly HttpStatusCode _code;
-            private readonly string _contentType;
-
-            public Handler(Stream stream, string contentType, HttpStatusCode code)
-            {
-                _stream = stream;
-                _code = code;
-                _contentType = contentType;
-            }
-
-            protected override bool Open(CefRequest request, out bool handleRequest, CefCallback callback)
-            {
-                handleRequest = true;
-                return true;
-            }
-
-            protected override void GetResponseHeaders(CefResponse response, out long responseLength, out string? redirectUrl)
-            {
-                response.Status = (int) _code;
-                response.StatusText = _code.ToString();
-                response.MimeType = _contentType;
-
-                if (_stream.CanSeek)
-                    responseLength = _stream.Length;
-                else
-                    responseLength = -1;
-
-                redirectUrl = default;
-            }
-
-            protected override bool Skip(long bytesToSkip, out long bytesSkipped, CefResourceSkipCallback callback)
-            {
-                if (!_stream.CanSeek)
-                {
-                    bytesSkipped = -2;
-                    return false;
-                }
-
-                bytesSkipped = _stream.Seek(bytesToSkip, SeekOrigin.Begin);
-                return true;
-            }
-
-            protected override unsafe bool Read(IntPtr dataOut, int bytesToRead, out int bytesRead, CefResourceReadCallback callback)
-            {
-                var byteSpan = new Span<byte>((void*) dataOut, bytesToRead);
-
-                bytesRead = _stream.Read(byteSpan);
-
-                return bytesRead != 0;
-            }
-
-            protected override void Cancel()
-            {
-            }
-        }
-    }
-}

Robust.Client.CEF/Robust.Client.CEF.csproj

@@ -1,25 +0,0 @@
-<Project Sdk="Microsoft.NET.Sdk">
-    <Import Project="..\MSBuild\Robust.Properties.targets" />
-    <Import Project="..\MSBuild\Robust.Engine.props" />
-    <PropertyGroup>
-        <TargetFramework>net5.0</TargetFramework>
-        <PlatformTarget>x64</PlatformTarget>
-        <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
-        <OutputType>WinExe</OutputType>
-    </PropertyGroup>
-
-    <Import Project="..\MSBuild\Robust.DefineConstants.targets" />
-    <Target Name="RobustAfterBuild" AfterTargets="Build" />
-    <Import Project="..\MSBuild\Robust.Engine.targets" />
-
-    <ItemGroup>
-      <PackageReference Include="JetBrains.Annotations" Version="2020.3.0" />
-      <PackageReference Include="System.Drawing.Common" Version="5.0.2" />
-    </ItemGroup>
-
-    <ItemGroup>
-      <ProjectReference Include="..\cefglue\CefGlue\CefGlue.csproj" />
-      <ProjectReference Include="..\Robust.Client\Robust.Client.csproj" />
-    </ItemGroup>
-
-</Project>

Robust.Client.CEF/RobustCefApp.cs

@@ -1,48 +0,0 @@
-using System;
-using Robust.Shared.IoC;
-using Robust.Shared.Log;
-using Xilium.CefGlue;
-
-namespace Robust.Client.CEF
-{
-    internal class RobustCefApp : CefApp
-    {
-        private readonly BrowserProcessHandler _browserProcessHandler = new();
-        private readonly RenderProcessHandler _renderProcessHandler = new();
-
-        protected override CefBrowserProcessHandler GetBrowserProcessHandler()
-        {
-            return _browserProcessHandler;
-        }
-
-        protected override CefRenderProcessHandler GetRenderProcessHandler()
-        {
-            return _renderProcessHandler;
-        }
-
-        protected override void OnBeforeCommandLineProcessing(string processType, CefCommandLine commandLine)
-        {
-            // Disable zygote on Linux.
-            commandLine.AppendSwitch("--no-zygote");
-
-            //commandLine.AppendSwitch("--disable-gpu");
-            //commandLine.AppendSwitch("--disable-gpu-compositing");
-            //commandLine.AppendSwitch("--in-process-gpu");
-
-            commandLine.AppendSwitch("disable-threaded-scrolling", "1");
-            commandLine.AppendSwitch("disable-features", "TouchpadAndWheelScrollLatching,AsyncWheelEvents");
-
-            if(IoCManager.Instance != null)
-                Logger.Debug($"{commandLine}");
-        }
-
-        private class BrowserProcessHandler : CefBrowserProcessHandler
-        {
-        }
-
-        // TODO CEF: Research - Is this even needed?
-        private class RenderProcessHandler : CefRenderProcessHandler
-        {
-        }
-    }
-}

Robust.Client.CEF/RobustCefClient.cs

@@ -1,23 +0,0 @@
-using Xilium.CefGlue;
-
-namespace Robust.Client.CEF
-{
-    // Simple CEF client.
-    internal class RobustCefClient : CefClient
-    {
-        private readonly CefRenderHandler _renderHandler;
-        private readonly CefRequestHandler _requestHandler;
-        private readonly CefLoadHandler _loadHandler;
-
-        internal RobustCefClient(CefRenderHandler handler, CefRequestHandler requestHandler, CefLoadHandler loadHandler)
-        {
-            _renderHandler = handler;
-            _requestHandler = requestHandler;
-            _loadHandler = loadHandler;
-        }
-
-        protected override CefRenderHandler GetRenderHandler() => _renderHandler;
-        protected override CefRequestHandler GetRequestHandler() => _requestHandler;
-        protected override CefLoadHandler GetLoadHandler() => _loadHandler;
-    }
-}

Robust.Client.CEF/RobustLoadHandler.cs

@@ -1,17 +0,0 @@
-using Xilium.CefGlue;
-
-namespace Robust.Client.CEF
-{
-    public sealed class RobustLoadHandler : CefLoadHandler
-    {
-        protected override void OnLoadStart(CefBrowser browser, CefFrame frame, CefTransitionType transitionType)
-        {
-            base.OnLoadStart(browser, frame, transitionType);
-        }
-
-        protected override void OnLoadEnd(CefBrowser browser, CefFrame frame, int httpStatusCode)
-        {
-            base.OnLoadEnd(browser, frame, httpStatusCode);
-        }
-    }
-}

Robust.Client.CEF/RobustRequestHandler.cs

@@ -1,128 +0,0 @@
-using System;
-using System.Collections.Generic;
-using Robust.Shared.Log;
-using Xilium.CefGlue;
-
-namespace Robust.Client.CEF
-{
-    internal sealed class RobustRequestHandler : CefRequestHandler
-    {
-        private readonly ISawmill _sawmill;
-        private readonly List<Action<RequestHandlerContext>> _resourceRequestHandlers = new();
-        private readonly List<Action<BeforeBrowseContext>> _beforeBrowseHandlers = new();
-
-        public RobustRequestHandler(ISawmill sawmill)
-        {
-            _sawmill = sawmill;
-        }
-
-        public void AddResourceRequestHandler(Action<RequestHandlerContext> handler)
-        {
-            lock (_resourceRequestHandlers)
-            {
-                _resourceRequestHandlers.Add(handler);
-            }
-        }
-
-        public void RemoveResourceRequestHandler(Action<RequestHandlerContext> handler)
-        {
-            lock (_resourceRequestHandlers)
-            {
-                _resourceRequestHandlers.Remove(handler);
-            }
-        }
-
-        public void AddBeforeBrowseHandler(Action<BeforeBrowseContext> handler)
-        {
-            lock (_beforeBrowseHandlers)
-            {
-                _beforeBrowseHandlers.Add(handler);
-            }
-        }
-
-        public void RemoveBeforeBrowseHandler(Action<BeforeBrowseContext> handler)
-        {
-            lock (_beforeBrowseHandlers)
-            {
-                _beforeBrowseHandlers.Remove(handler);
-            }
-        }
-
-        protected override CefResourceRequestHandler? GetResourceRequestHandler(
-            CefBrowser browser,
-            CefFrame frame,
-            CefRequest request,
-            bool isNavigation,
-            bool isDownload,
-            string requestInitiator,
-            ref bool disableDefaultHandling)
-        {
-            lock (_resourceRequestHandlers)
-            {
-                _sawmill.Debug($"HANDLING REQUEST: {request.Url}");
-
-                var context = new RequestHandlerContext(isNavigation, isDownload, requestInitiator, request);
-
-                foreach (var handler in _resourceRequestHandlers)
-                {
-                    handler(context);
-
-                    if (context.IsHandled)
-                        disableDefaultHandling = true;
-
-                    if (context.IsCancelled)
-                        return null;
-
-                    if (context.Result != null)
-                        return new WrapReaderResourceHandler(context.Result.MakeHandler());
-                }
-            }
-
-            return null;
-        }
-
-        protected override bool OnBeforeBrowse(CefBrowser browser, CefFrame frame, CefRequest request, bool userGesture, bool isRedirect)
-        {
-            lock (_beforeBrowseHandlers)
-            {
-                var context = new BeforeBrowseContext(isRedirect, userGesture, request);
-
-                foreach (var handler in _beforeBrowseHandlers)
-                {
-                    handler(context);
-
-                    if (context.IsCancelled)
-                        return true;
-                }
-            }
-
-            return false;
-        }
-
-        private sealed class WrapReaderResourceHandler : CefResourceRequestHandler
-        {
-            private readonly CefResourceHandler _handler;
-
-            public WrapReaderResourceHandler(CefResourceHandler handler)
-            {
-                _handler = handler;
-            }
-
-            protected override CefCookieAccessFilter? GetCookieAccessFilter(
-                CefBrowser browser,
-                CefFrame frame,
-                CefRequest request)
-            {
-                return null;
-            }
-
-            protected override CefResourceHandler GetResourceHandler(
-                CefBrowser browser,
-                CefFrame frame,
-                CefRequest request)
-            {
-                return _handler;
-            }
-        }
-    }
-}

Robust.Client.Injectors/Program.cs

@@ -29,27 +29,26 @@ namespace Robust.Build.Tasks
         }
     }
 
-    //formatted according to https://github.com/dotnet/msbuild/blob/main/src/Shared/CanonicalError.cs#L57
     class ConsoleBuildEngine : IBuildEngine
     {
         public void LogErrorEvent(BuildErrorEventArgs e)
         {
-            Console.WriteLine($"{e.File} ({e.LineNumber},{e.ColumnNumber},{e.EndLineNumber},{e.EndColumnNumber}): XAMLIL ERROR {e.Code}: {e.Message}");
+            Console.WriteLine($"ERROR: {e.Code} {e.Message} in {e.File} {e.LineNumber}:{e.ColumnNumber}-{e.EndLineNumber}:{e.EndColumnNumber}");
         }
 
         public void LogWarningEvent(BuildWarningEventArgs e)
         {
-            Console.WriteLine($"{e.File} ({e.LineNumber},{e.ColumnNumber},{e.EndLineNumber},{e.EndColumnNumber}): XAMLIL WARNING {e.Code}: {e.Message}");
+            Console.WriteLine($"WARNING: {e.Code} {e.Message} in {e.File} {e.LineNumber}:{e.ColumnNumber}-{e.EndLineNumber}:{e.EndColumnNumber}");
         }
 
         public void LogMessageEvent(BuildMessageEventArgs e)
         {
-            Console.WriteLine($"{e.File} ({e.LineNumber},{e.ColumnNumber},{e.EndLineNumber},{e.EndColumnNumber}): XAMLIL MESSAGE {e.Code}: {e.Message}");
+            Console.WriteLine($"MESSAGE: {e.Code} {e.Message} in {e.File} {e.LineNumber}:{e.ColumnNumber}-{e.EndLineNumber}:{e.EndColumnNumber}");
         }
 
         public void LogCustomEvent(CustomBuildEventArgs e)
         {
-            Console.WriteLine(e.Message);
+            Console.WriteLine($"CUSTOM: {e.Message}");
         }
 
         public bool BuildProjectFile(string projectFileName, string[] targetNames, IDictionary globalProperties,

Robust.Client.Injectors/RobustXamlILCompiler.cs

@@ -1,6 +1,4 @@
-using System.Diagnostics;
-using System.Linq;
-using XamlX;
+using System.Linq;
 using XamlX.Ast;
 using XamlX.Emit;
 using XamlX.IL;
@@ -13,14 +11,11 @@ namespace Robust.Build.Tasks
     /// Emitters & Transformers based on:
     /// - https://github.com/AvaloniaUI/Avalonia/blob/c85fa2b9977d251a31886c2534613b4730fbaeaf/src/Markup/Avalonia.Markup.Xaml.Loader/CompilerExtensions/Transformers/AvaloniaXamlIlRootObjectScopeTransformer.cs
     /// - https://github.com/AvaloniaUI/Avalonia/blob/c85fa2b9977d251a31886c2534613b4730fbaeaf/src/Markup/Avalonia.Markup.Xaml.Loader/CompilerExtensions/Transformers/AddNameScopeRegistration.cs
-    /// - https://github.com/AvaloniaUI/Avalonia/blob/afb8ae6f3c517dae912729511483995b16cb31af/src/Markup/Avalonia.Markup.Xaml.Loader/CompilerExtensions/Transformers/IgnoredDirectivesTransformer.cs
     /// </summary>
     public class RobustXamlILCompiler : XamlILCompiler
     {
         public RobustXamlILCompiler(TransformerConfiguration configuration, XamlLanguageEmitMappings<IXamlILEmitter, XamlILNodeEmitResult> emitMappings, bool fillWithDefaults) : base(configuration, emitMappings, fillWithDefaults)
         {
-            Transformers.Insert(0, new IgnoredDirectivesTransformer());
-
             Transformers.Add(new AddNameScopeRegistration());
             Transformers.Add(new RobustMarkRootObjectScopeNode());
 
@@ -202,24 +197,5 @@ namespace Robust.Build.Tasks
                 }
             }
         }
-
-        class IgnoredDirectivesTransformer : IXamlAstTransformer
-        {
-            public IXamlAstNode Transform(AstTransformationContext context, IXamlAstNode node)
-            {
-                if (node is XamlAstObjectNode astNode)
-                {
-                    astNode.Children.RemoveAll(n =>
-                        n is XamlAstXmlDirective dir &&
-                        dir.Namespace == XamlNamespaces.Xaml2006 &&
-                        (dir.Name == "Class" ||
-                         dir.Name == "Precompile" ||
-                         dir.Name == "FieldModifier" ||
-                         dir.Name == "ClassModifier"));
-                }
-
-                return node;
-            }
-        }
     }
 }

Robust.Client.Injectors/XamlCompiler.cs

@@ -280,8 +280,8 @@ namespace Robust.Build.Tasks
                     }
                     catch (Exception e)
                     {
-                        engine.LogErrorEvent(new BuildErrorEventArgs("XAMLIL", "", res.FilePath, 0, 0, 0, 0,
-                            $"{res.FilePath}: {e.Message}", "", "CompileRobustXaml"));
+                        engine.LogWarningEvent(new BuildWarningEventArgs("XAMLIL", "", res.Uri, 0, 0, 0, 0,
+                            e.ToString(), "", "CompileRobustXaml"));
                     }
                 }
                 return true;

Robust.Client.NameGenerator/InvalidXamlRootTypeException.cs

@@ -1,19 +0,0 @@
-using System;
-using Microsoft.CodeAnalysis;
-
-namespace Robust.Client.NameGenerator
-{
-    public class InvalidXamlRootTypeException : Exception
-    {
-        public readonly INamedTypeSymbol ExpectedType;
-        public readonly INamedTypeSymbol ExpectedBaseType;
-        public readonly INamedTypeSymbol Actual;
-
-        public InvalidXamlRootTypeException(INamedTypeSymbol actual, INamedTypeSymbol expectedType, INamedTypeSymbol expectedBaseType)
-        {
-            Actual = actual;
-            ExpectedType = expectedType;
-            ExpectedBaseType = expectedBaseType;
-        }
-    }
-}

Robust.Client.NameGenerator/XamlUiPartialClassGenerator.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.IO;
 using System.Linq;
 using System.Text;
 using Microsoft.CodeAnalysis;
@@ -112,12 +111,6 @@ namespace Robust.Client.AutoGenerated
             compiler.Transform(parsed);
             var initialRoot = (XamlAstObjectNode) parsed.Root;
             var names = NameVisitor.GetNames(initialRoot);
-
-            var rootType = (INamedTypeSymbol)initialRoot.Type.GetClrType().Id;
-            var rootTypeString = rootType.ToString();
-            if (classSymbol.ToString() != rootTypeString && classSymbol.BaseType?.ToString() != rootTypeString)
-                throw new InvalidXamlRootTypeException(rootType, classSymbol, classSymbol.BaseType);
-
             var fieldAccess = classSymbol.IsSealed ? "private" : "protected";
             //var names = NameVisitor.GetNames((XamlAstObjectNode)XDocumentXamlParser.Parse(xamlFile).Root);
             var namedControls = names.Select(info => "        " +
@@ -154,10 +147,9 @@ namespace {nameSpace}
             foreach (var typeSymbol in symbols)
             {
                 var xamlFileName = $"{typeSymbol.Name}.xaml";
-                var xamlFileNameSep = $"{Path.DirectorySeparatorChar}{xamlFileName}";
-                var relevantXamlFiles = context.AdditionalFiles.Where(t => t.Path.EndsWith(xamlFileNameSep)).ToArray();
+                var relevantXamlFile = context.AdditionalFiles.FirstOrDefault(t => t.Path.EndsWith(xamlFileName));
 
-                if (relevantXamlFiles.Length == 0)
+                if (relevantXamlFile == null)
                 {
                     context.ReportDiagnostic(
                         Diagnostic.Create(
@@ -173,28 +165,13 @@ namespace {nameSpace}
                     continue;
                 }
 
-                if (relevantXamlFiles.Length > 1)
-                {
-                    context.ReportDiagnostic(
-                        Diagnostic.Create(
-                            new DiagnosticDescriptor(
-                                "RXN0002",
-                                $"Found multiple candidate XAML files for {typeSymbol}",
-                                $"Multiple files exist with name {xamlFileName}",
-                                "Usage",
-                                DiagnosticSeverity.Error,
-                                true),
-                            typeSymbol.Locations[0]));
-                    continue;
-                }
-
-                var txt = relevantXamlFiles[0].GetText()?.ToString();
+                var txt = relevantXamlFile.GetText()?.ToString();
                 if (txt == null)
                 {
                     context.ReportDiagnostic(
                         Diagnostic.Create(
                             new DiagnosticDescriptor(
-                                "RXN0004",
+                                "RXN0002",
                                 $"Unexpected empty Xaml-File was found at {xamlFileName}",
                                 "Expected Content due to a Class with the same name being annotated with [GenerateTypedNameReferences].",
                                 "Usage",
@@ -210,27 +187,12 @@ namespace {nameSpace}
                     var sourceCode = GenerateSourceCode(typeSymbol, txt, comp);
                     context.AddSource($"{typeSymbol.Name}.g.cs", SourceText.From(sourceCode, Encoding.UTF8));
                 }
-                catch (InvalidXamlRootTypeException invRootType)
-                {
-                    context.ReportDiagnostic(
-                        Diagnostic.Create(
-                            new DiagnosticDescriptor(
-                                "RXN0005",
-                                $"XAML-File {xamlFileName} has the wrong root type!",
-                                $"{xamlFileName}: Expected root type '{invRootType.ExpectedType}' or '{invRootType.ExpectedBaseType}', but got '{invRootType.Actual}'.",
-                                "Usage",
-                                DiagnosticSeverity.Error,
-                                true),
-                            Location.Create(xamlFileName, new TextSpan(0, 0),
-                                new LinePositionSpan(new LinePosition(0, 0), new LinePosition(0, 0)))));
-                    continue;
-                }
                 catch (Exception e)
                 {
                     context.ReportDiagnostic(
                         Diagnostic.Create(
                             new DiagnosticDescriptor(
-                                "RXN0003",
+                                "AXN0003",
                                 "Unhandled exception occured while generating typed Name references.",
                                 $"Unhandled exception occured while generating typed Name references: {e}",
                                 "Usage",
@@ -278,7 +240,7 @@ namespace {nameSpace}
                     context.ReportDiagnostic(
                         Diagnostic.Create(
                             new DiagnosticDescriptor(
-                                "RXN0006",
+                                "RXN0004",
                                 missingPartialKeywordMessage,
                                 missingPartialKeywordMessage,
                                 "Usage",

Robust.Client/Audio/Midi/MidiManager.cs

@@ -6,8 +6,6 @@ using System.Threading;
 using NFluidsynth;
 using Robust.Client.Graphics;
 using Robust.Client.ResourceManagement;
-using Robust.Shared;
-using Robust.Shared.Configuration;
 using Robust.Shared.ContentPack;
 using Robust.Shared.GameObjects;
 using Robust.Shared.IoC;
@@ -63,9 +61,8 @@ namespace Robust.Client.Audio.Midi
         [Dependency] private readonly IEyeManager _eyeManager = default!;
         [Dependency] private readonly IResourceManagerInternal _resourceManager = default!;
         [Dependency] private readonly IEntityManager _entityManager = default!;
-        [Dependency] private readonly IConfigurationManager _cfgMan = default!;
 
-        private SharedBroadphaseSystem _broadPhaseSystem = default!;
+        private SharedBroadPhaseSystem _broadPhaseSystem = default!;
 
         [ViewVariables]
         public bool IsAvailable
@@ -97,7 +94,7 @@ namespace Robust.Client.Audio.Midi
                 if (MathHelper.CloseTo(_volume, value))
                     return;
 
-                _cfgMan.SetCVar(CVars.MidiVolume, value);
+                _volume = value;
                 _volumeDirty = true;
             }
         }
@@ -134,12 +131,6 @@ namespace Robust.Client.Audio.Midi
         {
             if (FluidsynthInitialized || _failedInitialize) return;
 
-            _cfgMan.OnValueChanged(CVars.MidiVolume, value =>
-            {
-                _volume = value;
-                _volumeDirty = true;
-            }, true);
-
             _midiSawmill = Logger.GetSawmill("midi");
             _sawmill = Logger.GetSawmill("midi.fluidsynth");
             _loggerDelegate = LoggerDelegate;
@@ -175,7 +166,7 @@ namespace Robust.Client.Audio.Midi
             _midiThread = new Thread(ThreadUpdate);
             _midiThread.Start();
 
-            _broadPhaseSystem = EntitySystem.Get<SharedBroadphaseSystem>();
+            _broadPhaseSystem = EntitySystem.Get<SharedBroadPhaseSystem>();
             FluidsynthInitialized = true;
         }
 
@@ -225,7 +216,7 @@ namespace Robust.Client.Audio.Midi
                 // Since the last loaded soundfont takes priority, we load the fallback soundfont before the soundfont.
                 renderer.LoadSoundfont(FallbackSoundfont);
 
-                if (OperatingSystem.IsLinux())
+                if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
                 {
                     foreach (var filepath in LinuxSoundfonts)
                     {
@@ -243,12 +234,12 @@ namespace Robust.Client.Audio.Midi
                         break;
                     }
                 }
-                else if (OperatingSystem.IsMacOS())
+                else if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
                 {
                     if (File.Exists(OsxSoundfont) && SoundFont.IsSoundFont(OsxSoundfont))
                         renderer.LoadSoundfont(OsxSoundfont, true);
                 }
-                else if (OperatingSystem.IsWindows())
+                else if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
                 {
                     if (File.Exists(WindowsSoundfont) && SoundFont.IsSoundFont(WindowsSoundfont))
                         renderer.LoadSoundfont(WindowsSoundfont, true);

Robust.Client/Audio/Midi/MidiRenderer.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Runtime.Intrinsics.X86;
 using NFluidsynth;
 using Robust.Client.Graphics;
 using Robust.Shared.Asynchronous;
@@ -6,7 +7,7 @@ using Robust.Shared.GameObjects;
 using Robust.Shared.IoC;
 using Robust.Shared.Log;
 using Robust.Shared.Map;
-using Robust.Shared.Maths;
+using Robust.Shared.Utility;
 using Robust.Shared.ViewVariables;
 using MidiEvent = NFluidsynth.MidiEvent;
 
@@ -202,9 +203,7 @@ namespace Robust.Client.Audio.Midi
         private const int SampleRate = 44100;
         private const int Buffers = SampleRate / 2205;
         private readonly object _playerStateLock = new();
-        private bool _debugEvents = false;
         private SequencerClientId _synthRegister;
-        private SequencerClientId _debugRegister;
         public IClydeBufferedAudioSource Source { get; set; }
         IClydeBufferedAudioSource IMidiRenderer.Source => Source;
 
@@ -218,7 +217,7 @@ namespace Robust.Client.Audio.Midi
             set
             {
                 lock (_playerStateLock)
-                    for (var i = 0; i < _synth.MidiChannelCount; i++)
+                    for (var i = 0; i < 16; i++)
                         _synth.ProgramChange(i, value);
 
                 _midiProgram = value;
@@ -232,7 +231,7 @@ namespace Robust.Client.Audio.Midi
             set
             {
                 lock (_playerStateLock)
-                    for (var i = 0; i < _synth.MidiChannelCount; i++)
+                    for (var i = 0; i < 16; i++)
                         _synth.BankSelect(i, value);
 
                 _midiBank = value;
@@ -246,7 +245,7 @@ namespace Robust.Client.Audio.Midi
             set
             {
                 lock (_playerStateLock)
-                    for (var i = 0; i < _synth.MidiChannelCount; i++)
+                    for (var i = 0; i < 16; i++)
                         _synth.SoundFontSelect(i, value);
 
                 _midiSoundfont = value;
@@ -314,7 +313,6 @@ namespace Robust.Client.Audio.Midi
             _soundFontLoader = soundFontLoader;
             _synth = new Synth(_settings);
             _sequencer = new Sequencer(false);
-            _debugRegister = _sequencer.RegisterClient("honk", DumpSequencerEvent);
             _synthRegister = _sequencer.RegisterFluidsynth(_synth);
 
             _synth.AddSoundFontLoader(soundFontLoader);
@@ -324,27 +322,6 @@ namespace Robust.Client.Audio.Midi
             Source.StartPlaying();
         }
 
-        private void DumpSequencerEvent(uint time, SequencerEvent @event)
-        {
-            // ReSharper disable once UseStringInterpolation
-            _midiSawmill.Debug(string.Format(
-                "{0:D8}: {1} chan:{2:D2} key:{3:D5} bank:{4:D2} ctrl:{5:D5} dur:{6:D5} pitch:{7:D5} prog:{8:D3} val:{9:D5} vel:{10:D5}",
-                time,
-                @event.Type.ToString().PadLeft(22),
-                @event.Channel,
-                @event.Key,
-                @event.Bank,
-                @event.Control,
-                @event.Duration,
-                @event.Pitch,
-                @event.Program,
-                @event.Value,
-                @event.Velocity));
-
-            @event.Dest = _synthRegister;
-            _sequencer.SendNow(@event);
-        }
-
         public bool OpenInput()
         {
             if (Disposed)
@@ -451,6 +428,9 @@ namespace Robust.Client.Audio.Midi
         {
             if (Disposed) return;
 
+            // SSE needs this.
+            DebugTools.Assert(length % 4 == 0, "Sample length must be multiple of 4");
+
             var buffersProcessed = Source.GetNumberOfBuffersProcessed();
             if(buffersProcessed == Buffers) _midiSawmill.Warning("MIDI buffer overflow!");
             if (buffersProcessed == 0) return;
@@ -465,16 +445,36 @@ namespace Robust.Client.Audio.Midi
                 Source.GetBuffersProcessed(buffers);
 
                 lock (_playerStateLock)
-                {
-                    // _sequencer.Process(10);
                     _synth?.WriteSampleFloat(length * buffers.Length, audio, 0, Mono ? 1 : 2,
                         audio, Mono ? length * buffers.Length : 1, Mono ? 1 : 2);
-                }
+
                 if (Mono) // Turn audio to mono
                 {
                     var l = length * buffers.Length;
 
-                    NumericsHelpers.Add(audio[..l], audio[l..]);
+                    if (Sse.IsSupported)
+                    {
+                        fixed (float* ptr = audio)
+                        {
+                            for (var j = 0; j < l; j += 4)
+                            {
+                                var k = j + l;
+
+                                var jV = Sse.LoadVector128(ptr + j);
+                                var kV = Sse.LoadVector128(ptr + k);
+
+                                Sse.Store(j + ptr, Sse.Add(jV, kV));
+                            }
+                        }
+                    }
+                    else
+                    {
+                        for (var j = 0; j < l; j++)
+                        {
+                            var k = j + l;
+                            audio[j] = ((audio[k] + audio[j]));
+                        }
+                    }
                 }
 
                 for (var i = 0; i < buffers.Length; i++)
@@ -532,16 +532,16 @@ namespace Robust.Client.Audio.Midi
                 lock(_playerStateLock)
                     switch (midiEvent.Type)
                     {
-                        // Note Off - 0x80
-                        case 128:
-                            _synth.NoteOff(midiEvent.Channel, midiEvent.Key);
-                            break;
-
-                        // Note On 0x90
+                        // Note On 0x80
                         case 144:
                             _synth.NoteOn(midiEvent.Channel, midiEvent.Key, midiEvent.Velocity);
                             break;
 
+                        // Note Off - 0x90
+                        case 128:
+                            _synth.NoteOff(midiEvent.Channel, midiEvent.Key);
+                            break;
+
                         // After Touch - 0xA
                         case 160:
                             _synth.KeyPressure(midiEvent.Channel, midiEvent.Key, midiEvent.Value);
@@ -573,20 +573,10 @@ namespace Robust.Client.Audio.Midi
                         // Sometimes MIDI files spam these for no good reason and I can't find any info on what they are.
                         case 1:
                         case 5:
-                        // MetaEvent -- SetTempo - 0x51
                         case 81:
-                            // Already handled by the player.
-                            return;
                         // System Messages - 0xF0
                         case 240:
-                            switch ((byte)midiEvent.Control)
-                            {
-                                case 11:
-                                    _synth.AllNotesOff(midiEvent.Channel);
-                                    break;
-                            }
-
-                            break;
+                            return;
 
                         default:
                             _midiSawmill.Warning("Unhandled midi event of type {0}", midiEvent.Type, midiEvent);
@@ -607,7 +597,7 @@ namespace Robust.Client.Audio.Midi
             if (Disposed) return;
 
             var seqEv = (SequencerEvent) midiEvent;
-            seqEv.Dest = _debugEvents ? _debugRegister : _synthRegister;
+            seqEv.Dest = _synthRegister;
             _sequencer.SendAt(seqEv, time, absolute);
         }
 
@@ -630,15 +620,10 @@ namespace Robust.Client.Audio.Midi
         void IMidiRenderer.InternalDispose()
         {
             Source?.Dispose();
-            _driver?.Dispose();
-
-            // Do NOT dispose of the sequencer after the synth or it'll cause a segfault for some fucking reason.
-            _sequencer?.UnregisterClient(_debugRegister);
-            _sequencer?.UnregisterClient(_synthRegister);
-            _sequencer?.Dispose();
-
             _synth?.Dispose();
             _player?.Dispose();
+            _driver?.Dispose();
+            _sequencer?.Dispose();
         }
     }
 }

Robust.Client/BaseClient.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Net;
 using Robust.Client.Debugging;
 using Robust.Client.GameObjects;

Robust.Client/ClientIoC.cs

@@ -25,7 +25,6 @@ using Robust.Shared.GameObjects;
 using Robust.Shared.IoC;
 using Robust.Shared.Map;
 using Robust.Shared.Network;
-using Robust.Shared.Physics;
 using Robust.Shared.Players;
 using Robust.Shared.Prototypes;
 using Robust.Shared.Reflection;
@@ -47,15 +46,13 @@ namespace Robust.Client
             IoCManager.Register<IClientMapManager, ClientMapManager>();
             IoCManager.Register<IEntityManager, ClientEntityManager>();
             IoCManager.Register<IEntityLookup, EntityLookup>();
-            IoCManager.Register<IReflectionManager, ClientReflectionManager>();
-            IoCManager.Register<IConsoleHost, ClientConsoleHost>();
-            IoCManager.Register<IClientConsoleHost, ClientConsoleHost>();
             IoCManager.Register<IComponentFactory, ClientComponentFactory>();
             IoCManager.Register<ITileDefinitionManager, ClydeTileDefinitionManager>();
             IoCManager.Register<IClydeTileDefinitionManager, ClydeTileDefinitionManager>();
             IoCManager.Register<GameController, GameController>();
             IoCManager.Register<IGameController, GameController>();
             IoCManager.Register<IGameControllerInternal, GameController>();
+            IoCManager.Register<IReflectionManager, ClientReflectionManager>();
             IoCManager.Register<IResourceManager, ResourceCache>();
             IoCManager.Register<IResourceManagerInternal, ResourceCache>();
             IoCManager.Register<IResourceCache, ResourceCache>();
@@ -75,9 +72,10 @@ namespace Robust.Client
             IoCManager.Register<IDebugDrawingManager, DebugDrawingManager>();
             IoCManager.Register<ILightManager, LightManager>();
             IoCManager.Register<IDiscordRichPresence, DiscordRichPresence>();
+            IoCManager.Register<IClientConsoleHost, ClientConsoleHost>();
+            IoCManager.Register<IConsoleHost, ClientConsoleHost>();
             IoCManager.Register<IMidiManager, MidiManager>();
             IoCManager.Register<IAuthManager, AuthManager>();
-            IoCManager.Register<IPhysicsManager, PhysicsManager>();
             switch (mode)
             {
                 case GameController.DisplayMode.Headless:

Robust.Client/CommandLineArgs.cs

@@ -17,7 +17,6 @@ namespace Robust.Client
         public bool Launcher { get; }
         public string? Username { get; }
         public IReadOnlyCollection<(string key, string value)> CVars { get; }
-        public IReadOnlyCollection<(string key, string value)> LogLevels { get; }
 
         // Manual parser because C# has no good command line parsing libraries. Also dependencies bad.
         // Also I don't like spending 100ms parsing command line args. Do you?
@@ -32,7 +31,6 @@ namespace Robust.Client
             var launcher = false;
             string? username = null;
             var cvars = new List<(string, string)>();
-            var logLevels = new List<(string, string)>();
             var mountOptions = new MountOptions();
 
             using var enumerator = args.GetEnumerator();
@@ -126,26 +124,6 @@ namespace Robust.Client
 
                     mountOptions.DirMounts.Add(enumerator.Current);
                 }
-                else if (arg == "--loglevel")
-                {
-                    if (!enumerator.MoveNext())
-                    {
-                        C.WriteLine("Missing loglevel sawmill.");
-                        return false;
-                    }
-
-                    var loglevel = enumerator.Current;
-                    DebugTools.AssertNotNull(loglevel);
-                    var pos = loglevel.IndexOf('=');
-
-                    if (pos == -1)
-                    {
-                        C.WriteLine("Expected = in loglevel.");
-                        return false;
-                    }
-
-                    logLevels.Add((loglevel[..pos], loglevel[(pos + 1)..]));
-                }
                 else if (arg == "--help")
                 {
                     PrintHelp();
@@ -164,7 +142,6 @@ namespace Robust.Client
                 launcher,
                 username,
                 cvars,
-                logLevels,
                 connectAddress,
                 ss14Address,
                 mountOptions);
@@ -185,7 +162,6 @@ Options:
   --launcher          Run in launcher mode (no main menu, auto connect).
   --username          Override username.
   --cvar              Specifies an additional cvar overriding the config file. Syntax is <key>=<value>
-  --loglevel          Specifies an additional sawmill log level overriding the default values. Syntax is <key>=<value>
   --mount-dir         Resource directory to mount.
   --mount-zip         Resource zip to mount.
   --help              Display this help text and exit.
@@ -199,7 +175,6 @@ Options:
             bool launcher,
             string? username,
             IReadOnlyCollection<(string key, string value)> cVars,
-            IReadOnlyCollection<(string key, string value)> logLevels,
             string connectAddress, string? ss14Address,
             MountOptions mountOptions)
         {
@@ -209,7 +184,6 @@ Options:
             Launcher = launcher;
             Username = username;
             CVars = cVars;
-            LogLevels = logLevels;
             ConnectAddress = connectAddress;
             Ss14Address = ss14Address;
             MountOptions = mountOptions;

Robust.Client/Console/ClientConsoleHost.cs

@@ -36,7 +36,7 @@ namespace Robust.Client.Console
             Message = message;
         }
     }
-
+    
     /// <inheritdoc cref="IClientConsoleHost" />
     internal class ClientConsoleHost : ConsoleHost, IClientConsoleHost
     {
@@ -45,15 +45,11 @@ namespace Robust.Client.Console
         /// <inheritdoc />
         public void Initialize()
         {
-            NetManager.RegisterNetMessage<MsgConCmdReg>(HandleConCmdReg);
-            NetManager.RegisterNetMessage<MsgConCmdAck>(HandleConCmdAck);
-            NetManager.RegisterNetMessage<MsgConCmd>(ProcessCommand);
+            NetManager.RegisterNetMessage<MsgConCmdReg>(MsgConCmdReg.NAME, HandleConCmdReg);
+            NetManager.RegisterNetMessage<MsgConCmdAck>(MsgConCmdAck.NAME, HandleConCmdAck);
+            NetManager.RegisterNetMessage<MsgConCmd>(MsgConCmd.NAME, ProcessCommand);
 
-            _requestedCommands = false;
-            NetManager.Connected += OnNetworkConnected;
-
-            LoadConsoleCommands();
-            SendServerCommandRequest();
+            Reset();
             LogManager.RootSawmill.AddHandler(new DebugConsoleLogHandler(this));
         }
 
@@ -65,6 +61,17 @@ namespace Robust.Client.Console
             ExecuteCommand(null, text);
         }
 
+        /// <inheritdoc />
+        public void Reset()
+        {
+            AvailableCommands.Clear();
+            _requestedCommands = false;
+            NetManager.Connected += OnNetworkConnected;
+
+            LoadConsoleCommands();
+            SendServerCommandRequest();
+        }
+
         /// <inheritdoc />
         public event EventHandler<AddStringArgs>? AddString;
 
@@ -83,8 +90,6 @@ namespace Robust.Client.Console
             OutputText(text, true, true);
         }
 
-        public override event ConAnyCommandCallback? AnyCommandExecuted;
-
         /// <inheritdoc />
         public override void ExecuteCommand(ICommonSession? session, string command)
         {
@@ -92,7 +97,7 @@ namespace Robust.Client.Console
                 return;
 
             // echo the command locally
-            WriteLine(null, "> " + command);
+            WriteError(null, "> " + command);
 
             //Commands are processed locally and then sent to the server to be processed there again.
             var args = new List<string>();
@@ -105,11 +110,7 @@ namespace Robust.Client.Console
             {
                 var command1 = AvailableCommands[commandName];
                 args.RemoveAt(0);
-                var shell = new ConsoleShell(this, null);
-                var cmdArgs = args.ToArray();
-
-                AnyCommandExecuted?.Invoke(shell, commandName, command, cmdArgs);
-                command1.Execute(shell, command, cmdArgs);
+                command1.Execute(new ConsoleShell(this, null), command, args.ToArray());
             }
             else
                 WriteError(null, "Unknown command: " + commandName);
@@ -141,9 +142,6 @@ namespace Robust.Client.Console
         private void OutputText(string text, bool local, bool error)
         {
             AddString?.Invoke(this, new AddStringArgs(text, local, error));
-
-            var level = error ? LogLevel.Warning : LogLevel.Info;
-            Logger.LogS(level, "CON", text);
         }
 
         private void OnNetworkConnected(object? sender, NetChannelArgs netChannelArgs)

Robust.Client/Console/Commands/Debug.cs

@@ -27,7 +27,6 @@ using Robust.Shared.Reflection;
 using Robust.Shared.Serialization;
 using Robust.Shared.Utility;
 using Robust.Shared.ViewVariables;
-using static Robust.Client.UserInterface.Controls.BoxContainer;
 
 namespace Robust.Client.Console.Commands
 {
@@ -78,7 +77,7 @@ namespace Robust.Client.Console.Commands
                     message.Append($"net ID: {registration.NetID}");
                 }
 
-                message.Append($", References:");
+                message.Append($", NSE: {registration.NetworkSynchronizeExistence}, references:");
 
                 shell.WriteLine(message.ToString());
 
@@ -460,18 +459,13 @@ namespace Robust.Client.Console.Commands
 
         public void Execute(IConsoleShell shell, string argStr, string[] args)
         {
-            var uiMgr = IoCManager.Resolve<IUserInterfaceManager>();
+            var root = IoCManager.Resolve<IUserInterfaceManager>().RootControl;
             var res = IoCManager.Resolve<IResourceManager>();
 
             using (var stream = res.UserData.Create(new ResourcePath("/guidump.txt")))
             using (var writer = new StreamWriter(stream, EncodingHelpers.UTF8))
             {
-                foreach (var root in uiMgr.AllRoots)
-                {
-                    writer.WriteLine($"ROOT: {root}");
-                    _writeNode(root, 0, writer);
-                    writer.WriteLine("---------------");
-                }
+                _writeNode(root, 0, writer);
             }
 
             shell.WriteLine("Saved guidump");
@@ -481,7 +475,7 @@ namespace Robust.Client.Console.Commands
         {
             var indentation = new string(' ', indents * 2);
             writer.WriteLine("{0}{1}", indentation, control);
-            foreach (var (key, value) in PropertyValuesFor(control))
+            foreach (var (key, value) in _propertyValuesFor(control))
             {
                 writer.WriteLine("{2} * {0}: {1}", key, value, indentation);
             }
@@ -492,14 +486,14 @@ namespace Robust.Client.Console.Commands
             }
         }
 
-        internal static List<(string, string)> PropertyValuesFor(Control control)
+        private static List<(string, string)> _propertyValuesFor(Control control)
         {
             var members = new List<(string, string)>();
             var type = control.GetType();
 
             foreach (var fieldInfo in type.GetAllFields())
             {
-                if (!ViewVariablesUtility.TryGetViewVariablesAccess(fieldInfo, out _))
+                if (fieldInfo.GetCustomAttribute<ViewVariablesAttribute>() == null)
                 {
                     continue;
                 }
@@ -509,7 +503,7 @@ namespace Robust.Client.Console.Commands
 
             foreach (var propertyInfo in type.GetAllProperties())
             {
-                if (!ViewVariablesUtility.TryGetViewVariablesAccess(propertyInfo, out _))
+                if (propertyInfo.GetCustomAttribute<ViewVariablesAttribute>() == null)
                 {
                     continue;
                 }
@@ -542,10 +536,7 @@ namespace Robust.Client.Console.Commands
             var scroll = new ScrollContainer();
             tabContainer.AddChild(scroll);
             //scroll.SetAnchorAndMarginPreset(Control.LayoutPreset.Wide);
-            var vBox = new BoxContainer
-            {
-                Orientation = LayoutOrientation.Vertical
-            };
+            var vBox = new VBoxContainer();
             scroll.AddChild(vBox);
 
             var progressBar = new ProgressBar { MaxValue = 10, Value = 5 };
@@ -603,10 +594,7 @@ namespace Robust.Client.Console.Commands
             }
 
             var group = new ButtonGroup();
-            var vBoxRadioButtons = new BoxContainer
-            {
-                Orientation = LayoutOrientation.Vertical
-            };
+            var vBoxRadioButtons = new VBoxContainer();
             for (var i = 0; i < 10; i++)
             {
                 vBoxRadioButtons.AddChild(new Button
@@ -622,9 +610,8 @@ namespace Robust.Client.Console.Commands
 
             TabContainer.SetTabTitle(vBoxRadioButtons, "Radio buttons!!");
 
-            tabContainer.AddChild(new BoxContainer
+            tabContainer.AddChild(new VBoxContainer
             {
-                Orientation = LayoutOrientation.Vertical,
                 Name = "Slider",
                 Children =
                 {
@@ -632,9 +619,8 @@ namespace Robust.Client.Console.Commands
                 }
             });
 
-            tabContainer.AddChild(new SplitContainer
+            tabContainer.AddChild(new HSplitContainer
             {
-                Orientation = SplitContainer.SplitOrientation.Horizontal,
                 Children =
                 {
                     new PanelContainer
@@ -877,7 +863,7 @@ namespace Robust.Client.Console.Commands
             var chunkIndex = grid.LocalToChunkIndices(grid.MapToGrid(mousePos));
             var chunk = internalGrid.GetChunk(chunkIndex);
 
-            shell.WriteLine($"worldBounds: {chunk.CalcWorldAABB()} localBounds: {chunk.CalcLocalBounds()}");
+            shell.WriteLine($"worldBounds: {chunk.CalcWorldBounds()} localBounds: {chunk.CalcLocalBounds()}");
         }
     }
 

Robust.Client/Console/Commands/DebugAnchoredCommand.cs

@@ -1,19 +0,0 @@
-#if DEBUG
-using Robust.Client.Debugging;
-using Robust.Shared.Console;
-using Robust.Shared.GameObjects;
-
-namespace Robust.Client.Console.Commands
-{
-    public sealed class DebugAnchoredCommand : IConsoleCommand
-    {
-        public string Command => "showanchored";
-        public string Description => $"Shows anchored entities on a particular tile";
-        public string Help => $"{Command}";
-        public void Execute(IConsoleShell shell, string argStr, string[] args)
-        {
-            EntitySystem.Get<DebugAnchoringSystem>().Enabled ^= true;
-        }
-    }
-}
-#endif

Robust.Client/Console/Commands/GridChunkBBCommand.cs

@@ -1,17 +0,0 @@
-using Robust.Client.GameObjects;
-using Robust.Shared.Console;
-using Robust.Shared.GameObjects;
-
-namespace Robust.Client.Console.Commands
-{
-    public class GridChunkBBCommand : IConsoleCommand
-    {
-        public string Command => "showchunkbb";
-        public string Description => "Displays chunk bounds for the purposes of rendering";
-        public string Help => $"{Command}";
-        public void Execute(IConsoleShell shell, string argStr, string[] args)
-        {
-            EntitySystem.Get<GridChunkBoundsDebugSystem>().Enabled ^= true;
-        }
-    }
-}

Robust.Client/Console/Commands/LightBBCommand.cs

@@ -1,19 +0,0 @@
-#if DEBUG
-using Robust.Client.GameObjects;
-using Robust.Shared.Console;
-using Robust.Shared.GameObjects;
-
-namespace Robust.Client.Console.Commands
-{
-    internal sealed class LightDebugCommand : IConsoleCommand
-    {
-        public string Command => "lightbb";
-        public string Description => "Toggles whether to show light bounding boxes";
-        public string Help => $"{Command}";
-        public void Execute(IConsoleShell shell, string argStr, string[] args)
-        {
-            EntitySystem.Get<DebugLightTreeSystem>().Enabled ^= true;
-        }
-    }
-}
-#endif

Robust.Client/Console/Commands/Scripting.cs

@@ -1,5 +1,6 @@
 using Robust.Shared.Console;
 using Robust.Shared.IoC;
+using Robust.Shared.Localization;
 
 namespace Robust.Client.Console.Commands
 {
@@ -40,7 +41,7 @@ namespace Robust.Client.Console.Commands
             var mgr = IoCManager.Resolve<IScriptClient>();
             if (!mgr.CanScript)
             {
-                shell.WriteError("You do not have server side scripting permission.");
+                shell.WriteError(Loc.GetString("You do not have server side scripting permission."));
                 return;
             }
 

Robust.Client/Console/IClientConsoleHost.cs

@@ -11,6 +11,11 @@ namespace Robust.Client.Console
         /// </summary>
         void Initialize();
 
+        /// <summary>
+        /// Resets the console to a post-initialized state.
+        /// </summary>
+        void Reset();
+
         event EventHandler<AddStringArgs> AddString;
         event EventHandler<AddFormattedMessageArgs> AddFormatted;
 

Robust.Client/Console/ScriptClient.cs

@@ -17,11 +17,11 @@ namespace Robust.Client.Console
 
         public void Initialize()
         {
-            _netManager.RegisterNetMessage<MsgScriptStop>();
-            _netManager.RegisterNetMessage<MsgScriptEval>();
-            _netManager.RegisterNetMessage<MsgScriptStart>();
-            _netManager.RegisterNetMessage<MsgScriptResponse>(ReceiveScriptResponse);
-            _netManager.RegisterNetMessage<MsgScriptStartAck>(ReceiveScriptStartAckResponse);
+            _netManager.RegisterNetMessage<MsgScriptStop>(MsgScriptStop.NAME);
+            _netManager.RegisterNetMessage<MsgScriptEval>(MsgScriptEval.NAME);
+            _netManager.RegisterNetMessage<MsgScriptStart>(MsgScriptStart.NAME);
+            _netManager.RegisterNetMessage<MsgScriptResponse>(MsgScriptResponse.NAME, ReceiveScriptResponse);
+            _netManager.RegisterNetMessage<MsgScriptStartAck>(MsgScriptStartAck.NAME, ReceiveScriptStartAckResponse);
         }
 
         private void ReceiveScriptStartAckResponse(MsgScriptStartAck message)

Robust.Client/Console/ScriptConsoleClient.cs

@@ -1,4 +1,5 @@
 #if CLIENT_SCRIPTING
+using System;
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
 using System.Linq;
@@ -13,11 +14,11 @@ using Microsoft.CodeAnalysis.Text;
 using Robust.Client.UserInterface.CustomControls;
 using Robust.Client.ViewVariables;
 using Robust.Shared.IoC;
+using Robust.Shared.Localization;
+using Robust.Shared.Maths;
 using Robust.Shared.Reflection;
 using Robust.Shared.Scripting;
 using Robust.Shared.Utility;
-using SixLabors.ImageSharp;
-using Color = Robust.Shared.Maths.Color;
 
 #nullable enable
 
@@ -42,14 +43,14 @@ namespace Robust.Client.Console
 
         public ScriptConsoleClient()
         {
-            Title = "Robust C# Interactive (CLIENT)";
+            Title = Loc.GetString("Robust C# Interactive (CLIENT)");
             ScriptInstanceShared.InitDummy();
 
             _globals = new ScriptGlobalsImpl(this);
 
             IoCManager.InjectDependencies(this);
 
-            OutputPanel.AddText("Robust C# interactive console (CLIENT).");
+            OutputPanel.AddText(Loc.GetString(@"Robust C# interactive console (CLIENT)."));
             OutputPanel.AddText(">");
         }
 
@@ -117,7 +118,7 @@ namespace Robust.Client.Console
             }
             else
             {
-                var options = ScriptInstanceShared.GetScriptOptions(_reflectionManager).AddReferences(typeof(Image).Assembly);
+                var options = ScriptInstanceShared.GetScriptOptions(_reflectionManager);
                 newScript = CSharpScript.Create(code, options, typeof(ScriptGlobals));
             }
 

Robust.Client/Console/WatchWindow.cs

@@ -8,10 +8,11 @@ using Robust.Client.UserInterface;
 using Robust.Client.UserInterface.Controls;
 using Robust.Client.UserInterface.CustomControls;
 using Robust.Shared.IoC;
+using Robust.Shared.Localization;
+using Robust.Shared.Maths;
 using Robust.Shared.Reflection;
 using Robust.Shared.Scripting;
 using Robust.Shared.Timing;
-using static Robust.Client.UserInterface.Controls.BoxContainer;
 
 namespace Robust.Client.Console
 {
@@ -19,7 +20,7 @@ namespace Robust.Client.Console
     {
         private readonly IReflectionManager _reflectionManager;
 
-        private readonly BoxContainer _watchesVBox;
+        private readonly VBoxContainer _watchesVBox;
         private readonly LineEdit _addWatchEdit;
         private readonly Button _addWatchButton;
 
@@ -30,32 +31,29 @@ namespace Robust.Client.Console
 
             ScriptInstanceShared.InitDummy();
 
-            Title = "Watch Window";
+            Title = Loc.GetString("Watch Window");
 
-            var mainVBox = new BoxContainer
+            var mainVBox = new VBoxContainer
             {
-                Orientation = LayoutOrientation.Vertical,
                 MinSize = (500, 300),
                 Children =
                 {
-                    (_watchesVBox = new BoxContainer
+                    (_watchesVBox = new VBoxContainer
                     {
-                        Orientation = LayoutOrientation.Vertical,
                         VerticalExpand = true
                     }),
-                    new BoxContainer
+                    new HBoxContainer
                     {
-                        Orientation = LayoutOrientation.Horizontal,
                         Children =
                         {
                             (_addWatchEdit = new HistoryLineEdit
                             {
                                 HorizontalExpand = true,
-                                PlaceHolder = "Add watch (C# interactive)"
+                                PlaceHolder = Loc.GetString("Add watch (C# interactive)")
                             }),
                             (_addWatchButton = new Button
                             {
-                                Text = "Add"
+                                Text = Loc.GetString("Add")
                             })
                         }
                     }
@@ -109,9 +107,8 @@ namespace Robust.Client.Console
                 Button delButton;
                 _runner = runner;
 
-                AddChild(new BoxContainer
+                AddChild(new HBoxContainer
                 {
-                    Orientation = LayoutOrientation.Horizontal,
                     Children =
                     {
                         (_outputLabel = new Label
@@ -121,7 +118,7 @@ namespace Robust.Client.Console
                         }),
                         (delButton = new Button
                         {
-                            Text = "Remove"
+                            Text = Loc.GetString("Remove")
                         }),
                     }
                 });
@@ -171,9 +168,8 @@ namespace Robust.Client.Console
             public CompilationErrorControl(string message)
             {
                 Button delButton;
-                AddChild(new BoxContainer
+                AddChild(new HBoxContainer
                 {
-                    Orientation = LayoutOrientation.Horizontal,
                     Children =
                     {
                         new Label
@@ -182,7 +178,7 @@ namespace Robust.Client.Console
                             ClipText = true,
                             HorizontalExpand = true
                         },
-                        (delButton = new Button {Text = "Remove"})
+                        (delButton = new Button {Text = Loc.GetString("Remove")})
                     }
                 });
 

Robust.Client/ContentStart.cs

@@ -7,13 +7,13 @@ namespace Robust.Client
 #if FULL_RELEASE
             throw new System.InvalidOperationException("ContentStart.Start is not available on a full release.");
 #else
-            GameController.Start(args, new GameControllerOptions(), true);
+            GameController.Start(args, true);
 #endif
         }
 
         public static void StartLibrary(string[] args, GameControllerOptions options)
         {
-            GameController.Start(args, options, true, null);
+            GameController.Start(args, true, null, options);
         }
     }
 }

Robust.Client/Debugging/DebugAnchoringSystem.cs

@@ -1,96 +0,0 @@
-#if DEBUG
-using System.Text;
-using Robust.Client.Graphics;
-using Robust.Client.Input;
-using Robust.Client.UserInterface;
-using Robust.Client.UserInterface.Controls;
-using Robust.Shared.GameObjects;
-using Robust.Shared.IoC;
-using Robust.Shared.Map;
-using Robust.Shared.Maths;
-using Robust.Shared.Utility;
-
-namespace Robust.Client.Debugging
-{
-    public sealed class DebugAnchoringSystem : EntitySystem
-    {
-        [Dependency] private readonly IEyeManager _eyeManager = default!;
-        [Dependency] private readonly IInputManager _inputManager = default!;
-        [Dependency] private readonly IMapManager _mapManager = default!;
-
-        private Label? _label;
-
-        private (GridId GridId, TileRef Tile)? _hovered;
-
-        public bool Enabled
-        {
-            get => _enabled;
-            set
-            {
-                if (_enabled == value) return;
-
-                _enabled = value;
-
-                if (_enabled)
-                {
-                    _label = new Label();
-                    IoCManager.Resolve<IUserInterfaceManager>().StateRoot.AddChild(_label);
-                }
-                else
-                {
-                    IoCManager.Resolve<IUserInterfaceManager>().StateRoot.RemoveChild(_label!);
-                    _label = null;
-                    _hovered = null;
-                }
-            }
-        }
-
-        private bool _enabled;
-
-        public override void FrameUpdate(float frameTime)
-        {
-            base.FrameUpdate(frameTime);
-            if (!Enabled) return;
-
-            if (_label == null)
-            {
-                DebugTools.Assert($"Debug Label for {nameof(DebugAnchoringSystem)} is null!");
-                return;
-            }
-
-            var mouseSpot = _inputManager.MouseScreenPosition;
-            var spot = _eyeManager.ScreenToMap(mouseSpot);
-
-            if (!_mapManager.TryFindGridAt(spot, out var grid))
-            {
-                _label.Text = string.Empty;
-                _hovered = null;
-                return;
-            }
-
-            var tile = grid.GetTileRef(spot);
-            _label.Position = mouseSpot.Position + new Vector2(32, 0);
-
-            if (_hovered?.GridId == grid.Index && _hovered?.Tile == tile) return;
-
-            _hovered = (grid.Index, tile);
-
-            var text = new StringBuilder();
-
-            foreach (var ent in grid.GetAnchoredEntities(spot))
-            {
-                if (!EntityManager.TryGetEntity(ent, out var entity))
-                {
-                    text.AppendLine($"uid: {ent}, invalid");
-                }
-                else
-                {
-                    text.AppendLine($"uid: {ent}, {entity.Name}");
-                }
-            }
-
-            _label.Text = text.ToString();
-        }
-    }
-}
-#endif

Robust.Client/Debugging/DebugDrawing.cs

@@ -23,7 +23,7 @@ namespace Robust.Client.Debugging
         [Dependency] private readonly IOverlayManager _overlayManager = default!;
         [Dependency] private readonly IEyeManager _eyeManager = default!;
         [Dependency] private readonly IPrototypeManager _prototypeManager = default!;
-        [Dependency] private readonly IEntityLookup _lookup = default!;
+        [Dependency] private readonly IEntityManager _entityManager = default!;
         [Dependency] private readonly IMapManager _mapManager = default!;
         [Dependency] private readonly IInputManager _inputManager = default!;
 
@@ -70,7 +70,7 @@ namespace Robust.Client.Debugging
 
                 if (value && !_overlayManager.HasOverlay<EntityPositionOverlay>())
                 {
-                    _overlayManager.AddOverlay(new EntityPositionOverlay(_lookup, _eyeManager));
+                    _overlayManager.AddOverlay(new EntityPositionOverlay(_entityManager, _eyeManager));
                 }
                 else
                 {
@@ -130,17 +130,17 @@ namespace Robust.Client.Debugging
                 {
                     if (body != _hoverBodies[0])
                     {
-                        screenHandle.DrawString(_font, drawPos + new Vector2(0, row * lineHeight), "------");
+                        DrawString(screenHandle, _font, drawPos + new Vector2(0, row * lineHeight), "------");
                         row++;
                     }
 
-                    screenHandle.DrawString(_font, drawPos + new Vector2(0, row * lineHeight), $"Ent: {body.Owner}");
+                    DrawString(screenHandle, _font, drawPos + new Vector2(0, row * lineHeight), $"Ent: {body.Owner}");
                     row++;
-                    screenHandle.DrawString(_font, drawPos + new Vector2(0, row * lineHeight), $"Layer: {Convert.ToString(body.CollisionLayer, 2)}");
+                    DrawString(screenHandle, _font, drawPos + new Vector2(0, row * lineHeight), $"Layer: {Convert.ToString(body.CollisionLayer, 2)}");
                     row++;
-                    screenHandle.DrawString(_font, drawPos + new Vector2(0, row * lineHeight), $"Mask: {Convert.ToString(body.CollisionMask, 2)}");
+                    DrawString(screenHandle, _font, drawPos + new Vector2(0, row * lineHeight), $"Mask: {Convert.ToString(body.CollisionMask, 2)}");
                     row++;
-                    screenHandle.DrawString(_font, drawPos + new Vector2(0, row * lineHeight), $"Enabled: {body.CanCollide}, Hard: {body.Hard}, Anchored: {(body).BodyType == BodyType.Static}");
+                    DrawString(screenHandle, _font, drawPos + new Vector2(0, row * lineHeight), $"Enabled: {body.CanCollide}, Hard: {body.Hard}, Anchored: {(body).BodyType == BodyType.Static}");
                     row++;
                 }
 
@@ -158,36 +158,27 @@ namespace Robust.Client.Debugging
                 _hoverStartScreen = mouseScreenPos.Position;
 
                 var viewport = _eyeManager.GetWorldViewport();
-                var viewBounds = _eyeManager.GetWorldViewbounds();
 
                 if (viewport.IsEmpty()) return;
 
                 var mapId = _eyeManager.CurrentMap;
+                var sleepThreshold = IoCManager.Resolve<IConfigurationManager>().GetCVar(CVars.TimeToSleep);
                 var colorEdge = Color.Red.WithAlpha(0.33f);
                 var drawnJoints = new HashSet<Joint>();
 
-                foreach (var physBody in EntitySystem.Get<SharedBroadphaseSystem>().GetCollidingEntities(mapId, viewBounds))
+                foreach (var physBody in EntitySystem.Get<SharedBroadPhaseSystem>().GetCollidingEntities(mapId, viewport))
                 {
-                    if (physBody.Owner.HasComponent<MapGridComponent>()) continue;
-
                     // all entities have a TransformComponent
                     var transform = physBody.Owner.Transform;
 
-                    var worldBox = physBody.GetWorldAABB();
+                    var worldBox = physBody.GetWorldAABB(_mapManager);
                     if (worldBox.IsEmpty()) continue;
 
-                    var pTransform = physBody.GetTransform();
-
                     foreach (var fixture in physBody.Fixtures)
                     {
                         var shape = fixture.Shape;
-                        var sleepPercent = physBody.Awake ? 0.0f : 1.0f;
+                        var sleepPercent = physBody.Awake ? physBody.SleepTime / sleepThreshold : 1.0f;
                         shape.DebugDraw(drawing, transform.WorldMatrix, in viewport, sleepPercent);
-
-                        drawing.SetTransform(in Matrix3.Identity);
-
-                        var aabb = shape.ComputeAABB(pTransform, 0);
-                        worldHandle.DrawRect(aabb, Color.Blue, false);
                     }
 
                     foreach (var joint in physBody.Joints)
@@ -196,7 +187,6 @@ namespace Robust.Client.Debugging
                         drawnJoints.Add(joint);
 
                         joint.DebugDraw(drawing, in viewport);
-                        drawing.SetTransform(in Matrix3.Identity);
                     }
 
                     if (worldBox.Contains(mouseWorldPos))
@@ -209,6 +199,17 @@ namespace Robust.Client.Debugging
                 }
             }
 
+            private static void DrawString(DrawingHandleScreen handle, Font font, Vector2 pos, string str)
+            {
+                var baseLine = new Vector2(pos.X, font.GetAscent(1) + pos.Y);
+
+                foreach (var rune in str.EnumerateRunes())
+                {
+                    var advance = font.DrawChar(handle, rune, baseLine, 1, Color.White);
+                    baseLine += new Vector2(advance, 0);
+                }
+            }
+
             private class PhysDrawingAdapter : DebugDrawingHandle
             {
                 private readonly DrawingHandleWorld _handle;
@@ -269,14 +270,14 @@ namespace Robust.Client.Debugging
 
         private sealed class EntityPositionOverlay : Overlay
         {
-            private readonly IEntityLookup _lookup;
+            private readonly IEntityManager _entityManager;
             private readonly IEyeManager _eyeManager;
 
             public override OverlaySpace Space => OverlaySpace.WorldSpace;
 
-            public EntityPositionOverlay(IEntityLookup lookup, IEyeManager eyeManager)
+            public EntityPositionOverlay(IEntityManager entityManager, IEyeManager eyeManager)
             {
-                _lookup = lookup;
+                _entityManager = entityManager;
                 _eyeManager = eyeManager;
             }
 
@@ -285,17 +286,18 @@ namespace Robust.Client.Debugging
                 const float stubLength = 0.25f;
 
                 var worldHandle = (DrawingHandleWorld) args.DrawingHandle;
-                var viewport = _eyeManager.GetWorldViewport();
-
-                foreach (var entity in _lookup.GetEntitiesIntersecting(_eyeManager.CurrentMap, viewport))
+                foreach (var entity in _entityManager.GetEntities())
                 {
                     var transform = entity.Transform;
+                    if (transform.MapID != _eyeManager.CurrentMap ||
+                        !_eyeManager.GetWorldViewport().Contains(transform.WorldPosition))
+                    {
+                        continue;
+                    }
 
                     var center = transform.WorldPosition;
-                    var worldRotation = transform.WorldRotation;
-
-                    var xLine = worldRotation.RotateVec(Vector2.UnitX);
-                    var yLine = worldRotation.RotateVec(Vector2.UnitY);
+                    var xLine = transform.WorldRotation.RotateVec(Vector2.UnitX);
+                    var yLine = transform.WorldRotation.RotateVec(Vector2.UnitY);
 
                     worldHandle.DrawLine(center, center + xLine * stubLength, Color.Red);
                     worldHandle.DrawLine(center, center + yLine * stubLength, Color.Green);

Robust.Client/Debugging/DebugDrawingManager.cs

@@ -1,12 +1,12 @@
+using Robust.Shared.IoC;
+using Robust.Shared.Network.Messages;
 using System;
 using System.Collections.Generic;
 using Robust.Client.Graphics;
-using Robust.Shared.Enums;
-using Robust.Shared.IoC;
 using Robust.Shared.Maths;
-using Robust.Shared.Network;
-using Robust.Shared.Network.Messages;
 using Robust.Shared.Timing;
+using Robust.Shared.Enums;
+using Robust.Shared.Network;
 
 namespace Robust.Client.Debugging
 {
@@ -54,7 +54,7 @@ namespace Robust.Client.Debugging
 
         public void Initialize()
         {
-            _net.RegisterNetMessage<MsgRay>(HandleDrawRay);
+            _net.RegisterNetMessage<MsgRay>(MsgRay.NAME, HandleDrawRay);
         }
 
         private void HandleDrawRay(MsgRay msg)

Robust.Client/Debugging/DebugPhysicsSystem.cs

@@ -28,7 +28,6 @@ using Robust.Shared.Enums;
 using Robust.Shared.GameObjects;
 using Robust.Shared.IoC;
 using Robust.Shared.Maths;
-using Robust.Shared.Physics;
 using Robust.Shared.Physics.Collision;
 using Robust.Shared.Physics.Dynamics;
 using Robust.Shared.Physics.Dynamics.Contacts;
@@ -41,8 +40,6 @@ namespace Robust.Client.Debugging
          * Used for debugging shapes, controllers, joints, contacts
          */
 
-        [Dependency] private readonly IPhysicsManager _physicsManager = default!;
-
         private const int MaxContactPoints = 2048;
         internal int PointCount;
 
@@ -82,7 +79,8 @@ namespace Robust.Client.Debugging
                 CollisionManager.GetPointStates(out state1, out state2, oldManifold, manifold);
 
                 Span<Vector2> points = stackalloc Vector2[2];
-                contact.GetWorldManifold(_physicsManager, out var normal, points);
+                Vector2 normal;
+                contact.GetWorldManifold(out normal, points);
 
                 for (int i = 0; i < manifold.PointCount && PointCount < MaxContactPoints; ++i)
                 {

Robust.Client/GameController/GameController.Loader.cs

@@ -11,7 +11,7 @@ namespace Robust.Client
         {
             public void Main(IMainArgs args)
             {
-                Start(args.Args, new GameControllerOptions(), contentStart: false, args);
+                Start(args.Args, contentStart: false, args);
             }
         }
     }

Robust.Client/GameController/GameController.Standalone.cs

@@ -22,10 +22,10 @@ namespace Robust.Client
 
         public static void Main(string[] args)
         {
-            Start(args, new GameControllerOptions());
+            Start(args);
         }
 
-        public static void Start(string[] args, GameControllerOptions options, bool contentStart = false, IMainArgs? loaderArgs=null)
+        public static void Start(string[] args, bool contentStart = false, IMainArgs? loaderArgs=null, GameControllerOptions? options = null)
         {
             if (_hasStarted)
             {
@@ -40,7 +40,7 @@ namespace Robust.Client
             }
         }
 
-        private static void ParsedMain(CommandLineArgs args, bool contentStart, IMainArgs? loaderArgs, GameControllerOptions options)
+        private static void ParsedMain(CommandLineArgs args, bool contentStart, IMainArgs? loaderArgs, GameControllerOptions? options)
         {
             IoCManager.InitThread();
 
@@ -51,13 +51,15 @@ namespace Robust.Client
             var gc = IoCManager.Resolve<GameController>();
             gc.SetCommandLineArgs(args);
             gc._loaderArgs = loaderArgs;
+            if(options != null)
+                gc.Options = options;
 
             // When the game is ran with the startup executable being content,
             // we have to disable the separate load context.
             // Otherwise the content assemblies will be loaded twice which causes *many* fun bugs.
             gc.ContentStart = contentStart;
 
-            gc.Run(mode, options);
+            gc.Run(mode);
         }
 
         public void OverrideMainLoop(IGameLoop gameLoop)
@@ -65,9 +67,9 @@ namespace Robust.Client
             _mainLoop = gameLoop;
         }
 
-        public void Run(DisplayMode mode, GameControllerOptions options, Func<ILogHandler>? logHandlerFactory = null)
+        public void Run(DisplayMode mode, Func<ILogHandler>? logHandlerFactory = null)
         {
-            if (!StartupSystemSplash(options, logHandlerFactory))
+            if (!StartupSystemSplash(logHandlerFactory))
             {
                 Logger.Fatal("Failed to start game controller!");
                 return;

Robust.Client/GameController/GameController.cs

@@ -2,7 +2,6 @@ using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Net;
-using System.Runtime;
 using System.Threading.Tasks;
 using Robust.Client.Audio.Midi;
 using Robust.Client.Console;
@@ -76,12 +75,14 @@ namespace Robust.Client
         public GameControllerOptions Options { get; private set; } = new();
         public InitialLaunchState LaunchState { get; private set; } = default!;
 
+        public bool LoadConfigAndUserData { get; set; } = true;
+
         public void SetCommandLineArgs(CommandLineArgs args)
         {
             _commandLineArgs = args;
         }
 
-        internal bool StartupContinue(DisplayMode displayMode)
+        private bool StartupContinue(DisplayMode displayMode)
         {
             _clyde.InitializePostWindowing();
             _clyde.SetWindowTitle(Options.DefaultWindowTitle);
@@ -92,9 +93,9 @@ namespace Robust.Client
             // Disable load context usage on content start.
             // This prevents Content.Client being loaded twice and things like csi blowing up because of it.
             _modLoader.SetUseLoadContext(!ContentStart);
-            _modLoader.SetEnableSandboxing(Options.Sandboxing);
+            _modLoader.SetEnableSandboxing(false && Options.Sandboxing);
 
-            if (!_modLoader.TryLoadModulesFrom(Options.AssemblyDirectory, Options.ContentModulePrefix))
+            if (!_modLoader.TryLoadModulesFrom(new ResourcePath("/Assemblies/"), Options.ContentModulePrefix))
             {
                 Logger.Fatal("Errors while loading content assemblies.");
                 return false;
@@ -140,7 +141,6 @@ namespace Robust.Client
 
             _authManager.LoadFromEnv();
 
-            GCSettings.LargeObjectHeapCompactionMode = GCLargeObjectHeapCompactionMode.CompactOnce;
             GC.Collect();
 
             // Setup main loop
@@ -196,35 +196,12 @@ namespace Robust.Client
             return true;
         }
 
-        internal bool StartupSystemSplash(GameControllerOptions options, Func<ILogHandler>? logHandlerFactory)
+        private bool StartupSystemSplash(Func<ILogHandler>? logHandlerFactory)
         {
-            Options = options;
             ReadInitialLaunchState();
 
             SetupLogging(_logManager, logHandlerFactory ?? (() => new ConsoleLogHandler()));
 
-            if (_commandLineArgs != null)
-            {
-                foreach (var (sawmill, level) in _commandLineArgs.LogLevels)
-                {
-                    LogLevel? logLevel;
-                    if (level == "null")
-                        logLevel = null;
-                    else
-                    {
-                        if (!Enum.TryParse<LogLevel>(level, out var result))
-                        {
-                            System.Console.WriteLine($"LogLevel {level} does not exist!");
-                            continue;
-                        }
-                        logLevel = result;
-                    }
-                    _logManager.GetSawmill(sawmill).Level = logLevel;
-                }
-            }
-
-            ProgramShared.PrintRuntimeInfo(_logManager.RootSawmill);
-
             // Figure out user data directory.
             var userDataDir = GetUserDataDir();
 
@@ -235,7 +212,7 @@ namespace Robust.Client
             _configurationManager.LoadCVarsFromAssembly(typeof(GameController).Assembly); // Client
             _configurationManager.LoadCVarsFromAssembly(typeof(IConfigurationManager).Assembly); // Shared
 
-            if (Options.LoadConfigAndUserData)
+            if (LoadConfigAndUserData)
             {
                 var configFile = Path.Combine(userDataDir, Options.ConfigFileName);
                 if (File.Exists(configFile))
@@ -257,24 +234,15 @@ namespace Robust.Client
                 _configurationManager.OverrideConVars(_commandLineArgs.CVars);
             }
 
-            {
-                // Handle GameControllerOptions implicit CVar overrides.
-                _configurationManager.OverrideConVars(new []
-                {
-                    (CVars.DisplayWindowIconSet.Name, options.WindowIconSet.ToString()),
-                    (CVars.DisplaySplashLogo.Name, options.SplashLogo.ToString())
-                });
-            }
-
             ProfileOptSetup.Setup(_configurationManager);
 
-            _resourceCache.Initialize(Options.LoadConfigAndUserData ? userDataDir : null);
+            _resourceCache.Initialize(LoadConfigAndUserData ? userDataDir : null);
 
             var mountOptions = _commandLineArgs != null
                 ? MountOptions.Merge(_commandLineArgs.MountOptions, Options.MountOptions) : Options.MountOptions;
 
-            ProgramShared.DoMounts(_resourceCache, mountOptions, Options.ContentBuildDirectory, Options.AssemblyDirectory,
-                Options.LoadContentResources, _loaderArgs != null && !Options.ResourceMountDisabled, ContentStart);
+            ProgramShared.DoMounts(_resourceCache, mountOptions, Options.ContentBuildDirectory,
+                _loaderArgs != null && !Options.ResourceMountDisabled, ContentStart);
 
             if (_loaderArgs != null)
             {
@@ -481,10 +449,8 @@ namespace Robust.Client
             Clyde,
         }
 
-        internal void Cleanup()
+        private void Cleanup()
         {
-            _modLoader.Shutdown();
-
             _networkManager.Shutdown("Client shutting down");
             _midiManager.Shutdown();
             IoCManager.Resolve<IEntityLookup>().Shutdown();

Robust.Client/GameControllerOptions.cs

@@ -42,41 +42,16 @@ namespace Robust.Client
         /// </summary>
         public string ContentBuildDirectory { get; init; } = "Content.Client";
 
-        /// <summary>
-        ///     Directory to load all assemblies from.
-        /// </summary>
-        public ResourcePath AssemblyDirectory { get; init; } = new(@"/Assemblies/");
-
         /// <summary>
         ///     Directory to load all prototypes from.
         /// </summary>
         public ResourcePath PrototypeDirectory { get; init; } = new(@"/Prototypes/");
 
-        /// <summary>
-        /// Directory resource path containing window icons to load.
-        /// </summary>
-        public ResourcePath WindowIconSet { get; init; } = new("/Textures/Logo/icon");
-
-        /// <summary>
-        /// Resource path for splash image to show when the game starts up.
-        /// </summary>
-        public ResourcePath SplashLogo { get; init; } = new("/Textures/Logo/logo.png");
-
         /// <summary>
         ///     Whether to disable mounting the "Resources/" folder on FULL_RELEASE.
         /// </summary>
         public bool ResourceMountDisabled { get; init; } = false;
 
-        /// <summary>
-        ///     Whether to mount content resources when not on FULL_RELEASE.
-        /// </summary>
-        public bool LoadContentResources { get; init; } = true;
-
-        /// <summary>
-        ///     Whether to load config and user data.
-        /// </summary>
-        public bool LoadConfigAndUserData { get; init; } = true;
-
         /// <summary>
         ///     Whether to disable command line args server auto-connecting.
         /// </summary>

Robust.Client/GameObjects/ClientComponentFactory.cs

@@ -1,15 +1,12 @@
-using Robust.Shared.Console;
 using Robust.Shared.Containers;
 using Robust.Shared.GameObjects;
-using Robust.Shared.IoC;
-using Robust.Shared.Reflection;
+using Robust.Shared.Physics;
 
 namespace Robust.Client.GameObjects
 {
-    internal class ClientComponentFactory : ComponentFactory
+    public class ClientComponentFactory : ComponentFactory
     {
-        public ClientComponentFactory(IDynamicTypeFactoryInternal typeFactory, IReflectionManager reflectionManager, IConsoleHost conHost)
-            : base(typeFactory, reflectionManager, conHost)
+        public ClientComponentFactory()
         {
             // Required for the engine to work
             RegisterIgnore("KeyBindingInput");
@@ -25,9 +22,10 @@ namespace Robust.Client.GameObjects
             RegisterClass<InputComponent>();
             RegisterClass<SpriteComponent>();
             RegisterClass<ClientOccluderComponent>();
-            RegisterClass<OccluderTreeComponent>();
             RegisterClass<EyeComponent>();
             RegisterClass<AppearanceComponent>();
+            RegisterClass<AppearanceTestComponent>();
+            RegisterClass<SnapGridComponent>();
             RegisterClass<AnimationPlayerComponent>();
             RegisterClass<TimerComponent>();
 

Robust.Client/GameObjects/ClientEntityManager.cs

@@ -1,10 +1,14 @@
 using System;
 using System.Collections.Generic;
+using System.Linq;
+using JetBrains.Annotations;
 using Prometheus;
 using Robust.Client.GameStates;
-using Robust.Client.Player;
+using Robust.Shared.Exceptions;
 using Robust.Shared.GameObjects;
 using Robust.Shared.IoC;
+using Robust.Shared.Log;
+using Robust.Shared.Map;
 using Robust.Shared.Network;
 using Robust.Shared.Network.Messages;
 using Robust.Shared.Timing;
@@ -17,7 +21,6 @@ namespace Robust.Client.GameObjects
     /// </summary>
     public sealed class ClientEntityManager : EntityManager, IClientEntityManagerInternal
     {
-        [Dependency] private readonly IPlayerManager _playerManager = default!;
         [Dependency] private readonly IClientNetManager _networkManager = default!;
         [Dependency] private readonly IClientGameStateManager _gameStateManager = default!;
         [Dependency] private readonly IGameTiming _gameTiming = default!;
@@ -64,7 +67,7 @@ namespace Robust.Client.GameObjects
         /// <inheritdoc />
         public void SetupNetworking()
         {
-            _networkManager.RegisterNetMessage<MsgEntity>(HandleEntityNetworkMessage);
+            _networkManager.RegisterNetMessage<MsgEntity>(MsgEntity.NAME, HandleEntityNetworkMessage);
         }
 
         public override void TickUpdate(float frameTime, Histogram? histogram)
@@ -109,15 +112,13 @@ namespace Robust.Client.GameObjects
         [Obsolete("Component Messages are deprecated, use Entity Events instead.")]
         public void SendComponentNetworkMessage(INetChannel? channel, IEntity entity, IComponent component, ComponentMessage message)
         {
-            var netId = ComponentFactory.GetRegistration(component.GetType()).NetID;
-
-            if (!netId.HasValue)
+            if (!component.NetID.HasValue)
                 throw new ArgumentException($"Component {component.Name} does not have a NetID.", nameof(component));
 
             var msg = _networkManager.CreateNetMessage<MsgEntity>();
             msg.Type = EntityMessageType.ComponentMessage;
             msg.EntityUid = entity.Uid;
-            msg.NetId = netId.Value;
+            msg.NetId = component.NetID.Value;
             msg.ComponentMessage = message;
             msg.SourceTick = _gameTiming.CurTick;
 
@@ -147,11 +148,7 @@ namespace Robust.Client.GameObjects
                     return;
 
                 case EntityMessageType.SystemMessage:
-                    var msg = message.SystemMessage;
-                    var sessionType = typeof(EntitySessionMessage<>).MakeGenericType(msg.GetType());
-                    var sessionMsg = Activator.CreateInstance(sessionType, new EntitySessionEventArgs(_playerManager.LocalPlayer!.Session), msg)!;
-                    ReceivedSystemMessage?.Invoke(this, msg);
-                    ReceivedSystemMessage?.Invoke(this, sessionMsg);
+                    ReceivedSystemMessage?.Invoke(this, message.SystemMessage);
                     return;
             }
         }

Robust.Client/GameObjects/Components/Appearance/AppearanceComponent.cs

@@ -84,23 +84,6 @@ namespace Robust.Client.GameObjects
             if (curState is not AppearanceComponentState actualState)
                 return;
 
-            var stateDiff = data.Count != actualState.Data.Count;
-
-            if (!stateDiff)
-            {
-                foreach (var (key, value) in data)
-                {
-                    if (!actualState.Data.TryGetValue(key, out var stateValue) ||
-                        !value.Equals(stateValue))
-                    {
-                        stateDiff = true;
-                        break;
-                    }
-                }
-            }
-
-            if (!stateDiff) return;
-
             data = actualState.Data;
             MarkDirty();
         }
@@ -121,7 +104,7 @@ namespace Robust.Client.GameObjects
             _appearanceDirty = false;
         }
 
-        protected override void Initialize()
+        public override void Initialize()
         {
             base.Initialize();
 
@@ -158,4 +141,22 @@ namespace Robust.Client.GameObjects
         {
         }
     }
+
+    sealed class AppearanceTestComponent : Component
+    {
+        public override string Name => "AppearanceTest";
+
+        float time;
+        bool state;
+
+        public void OnUpdate(float frameTime)
+        {
+            time += frameTime;
+            if (time > 1)
+            {
+                time -= 1;
+                Owner.GetComponent<AppearanceComponent>().SetData("test", state = !state);
+            }
+        }
+    }
 }

Robust.Client/GameObjects/Components/Eye/EyeComponent.cs

@@ -116,7 +116,7 @@ namespace Robust.Client.GameObjects
         public MapCoordinates? Position => _eye?.Position;
 
         /// <inheritdoc />
-        protected override void Initialize()
+        public override void Initialize()
         {
             base.Initialize();
 
@@ -156,7 +156,7 @@ namespace Robust.Client.GameObjects
             VisibilityMask = state.VisibilityMask;
         }
 
-        protected override void OnRemove()
+        public override void OnRemove()
         {
             base.OnRemove();
 

Robust.Client/GameObjects/Components/Input/InputComponent.cs

@@ -1,5 +1,7 @@
 using Robust.Shared.GameObjects;
 using Robust.Shared.Input;
+using Robust.Shared.Prototypes;
+using Robust.Shared.Serialization;
 using Robust.Shared.Serialization.Manager.Attributes;
 using Robust.Shared.ViewVariables;
 
@@ -8,7 +10,7 @@ namespace Robust.Client.GameObjects
     /// <summary>
     ///     Defines data fields used in the <see cref="InputSystem"/>.
     /// </summary>
-    public class InputComponent : Component
+    class InputComponent : Component
     {
         /// <inheritdoc />
         public override string Name => "Input";

Robust.Client/GameObjects/Components/Light/ClientOccluderComponent.cs

@@ -34,11 +34,11 @@ namespace Robust.Client.GameObjects
 
             if (Owner.Transform.Anchored)
             {
-                AnchorStateChanged();
+                SnapGridOnPositionChanged();
             }
         }
 
-        public void AnchorStateChanged()
+        public void SnapGridOnPositionChanged()
         {
             SendDirty();
 

Robust.Client/GameObjects/Components/Light/PointLightComponent.cs

@@ -1,6 +1,11 @@
+using System;
+using System.Collections.Generic;
 using Robust.Client.Graphics;
+using Robust.Client.ResourceManagement;
 using Robust.Shared.Animations;
 using Robust.Shared.GameObjects;
+using Robust.Shared.IoC;
+using Robust.Shared.Map;
 using Robust.Shared.Maths;
 using Robust.Shared.Serialization;
 using Robust.Shared.Serialization.Manager.Attributes;
@@ -9,46 +14,41 @@ using Robust.Shared.ViewVariables;
 namespace Robust.Client.GameObjects
 {
     [RegisterComponent]
-    [ComponentReference(typeof(SharedPointLightComponent))]
-    public class PointLightComponent : SharedPointLightComponent, ISerializationHooks
+    [ComponentReference(typeof(IPointLightComponent))]
+    public class PointLightComponent : Component, IPointLightComponent, ISerializationHooks
     {
+        [Dependency] private readonly IResourceCache _resourceCache = default!;
+
+        public override string Name => "PointLight";
+        public override uint? NetID => NetIDs.POINT_LIGHT;
+
         internal bool TreeUpdateQueued { get; set; }
 
         [ViewVariables(VVAccess.ReadWrite)]
         [Animatable]
-        public override Color Color
+        public Color Color
         {
             get => _color;
-            set => base.Color = value;
+            set => _color = value;
+        }
+
+        [ViewVariables(VVAccess.ReadWrite)]
+        public Vector2 Offset
+        {
+            get => _offset;
+            set => _offset = value;
         }
 
         [ViewVariables(VVAccess.ReadWrite)]
         [Animatable]
-        public override bool Enabled
+        public bool Enabled
         {
             get => _enabled;
-            set
-            {
-                if (_enabled == value) return;
-                base.Enabled = value;
-                Owner.EntityManager.EventBus.RaiseLocalEvent(Owner.Uid, new PointLightUpdateEvent());
-            }
+            set => _enabled = value;
         }
 
         [ViewVariables(VVAccess.ReadWrite)]
-        public bool ContainerOccluded
-        {
-            get => _containerOccluded;
-            set
-            {
-                if (_containerOccluded == value) return;
-
-                _containerOccluded = value;
-                Owner.EntityManager.EventBus.RaiseLocalEvent(Owner.Uid, new PointLightUpdateEvent());
-            }
-        }
-
-        private bool _containerOccluded;
+        public bool ContainerOccluded { get; set; }
 
         /// <summary>
         ///     Determines if the light mask should automatically rotate with the entity. (like a flashlight)
@@ -71,6 +71,7 @@ namespace Robust.Client.GameObjects
             set => _rotation = value;
         }
 
+        /// <inheritdoc />
         /// <summary>
         /// The resource path to the mask texture the light will use.
         /// </summary>
@@ -80,9 +81,8 @@ namespace Robust.Client.GameObjects
             get => _maskPath;
             set
             {
-                if (_maskPath?.Equals(value) != false) return;
                 _maskPath = value;
-                EntitySystem.Get<PointLightSystem>().UpdateMask(this);
+                UpdateMask();
             }
         }
 
@@ -117,11 +117,36 @@ namespace Robust.Client.GameObjects
         public bool VisibleNested
         {
             get => _visibleNested;
-            set => _visibleNested = value;
+            set
+            {
+                if (_visibleNested == value) return;
+                _visibleNested = value;
+                if (value)
+                {
+                    if (Owner.Transform.Parent == null) return;
+
+                    _lightOnParent = true;
+                }
+                else
+                {
+                    if (!_lightOnParent) return;
+
+                    _lightOnParent = false;
+                }
+            }
         }
 
+        [DataField("radius")]
+        private float _radius = 5f;
         [DataField("nestedvisible")]
         private bool _visibleNested = true;
+        private bool _lightOnParent;
+        [DataField("color")]
+        private Color _color = Color.White;
+        [DataField("offset")]
+        private Vector2 _offset = Vector2.Zero;
+        [DataField("enabled")]
+        private bool _enabled = true;
         [DataField("autoRot")]
         private bool _maskAutoRotate;
         private Angle _rotation;
@@ -130,27 +155,110 @@ namespace Robust.Client.GameObjects
         [DataField("softness")]
         private float _softness = 1f;
         [DataField("mask")]
-        internal string? _maskPath;
+        private string? _maskPath;
 
         /// <summary>
         ///     Radius, in meters.
         /// </summary>
         [ViewVariables(VVAccess.ReadWrite)]
         [Animatable]
-        public override float Radius
+        public float Radius
         {
             get => _radius;
             set
             {
-                if (MathHelper.CloseTo(value, _radius)) return;
-
-                base.Radius = value;
+                _radius = MathF.Max(value, 0.01f); // setting radius to 0 causes exceptions, so just use a value close enough to zero that it's unnoticeable.
                 Owner.EntityManager.EventBus.RaiseEvent(EventSource.Local, new PointLightRadiusChangedEvent(this));
             }
         }
 
+        private void UpdateMask()
+        {
+            if (_maskPath is not null)
+                Mask = _resourceCache.GetResource<TextureResource>(_maskPath);
+            else
+                Mask = null;
+        }
+
+        /// <summary>
+        /// What MapId we are intersecting for RenderingTreeSystem.
+        /// </summary>
         [ViewVariables]
-        internal RenderingTreeComponent? RenderTree { get; set; }
+        internal MapId IntersectingMapId { get; set; } = MapId.Nullspace;
+
+        /// <summary>
+        /// What grids we're on for RenderingTreeSystem.
+        /// </summary>
+        [ViewVariables]
+        internal List<GridId> IntersectingGrids = new();
+
+        void ISerializationHooks.AfterDeserialization()
+        {
+            if (_maskPath != null)
+            {
+                Mask = IoCManager.Resolve<IResourceCache>().GetResource<TextureResource>(_maskPath);
+            }
+        }
+
+        public override void Initialize()
+        {
+            base.Initialize();
+            UpdateMask();
+        }
+
+        /// <inheritdoc />
+        public override void HandleMessage(ComponentMessage message, IComponent? component)
+        {
+            base.HandleMessage(message, component);
+
+            if (message is ParentChangedMessage msg)
+            {
+                HandleTransformParentChanged(msg);
+            }
+        }
+
+        private void HandleTransformParentChanged(ParentChangedMessage obj)
+        {
+            // TODO: this does not work for things nested multiply layers deep.
+            if (!VisibleNested)
+            {
+                return;
+            }
+
+            if (obj.NewParent != null && obj.NewParent.IsValid())
+            {
+                _lightOnParent = true;
+            }
+            else
+            {
+                _lightOnParent = false;
+            }
+        }
+
+        public override void OnRemove()
+        {
+            base.OnRemove();
+
+            var map = Owner.Transform.MapID;
+            if (map != MapId.Nullspace)
+            {
+                Owner.EntityManager.EventBus.RaiseEvent(EventSource.Local,
+                    new RenderTreeRemoveLightEvent(this, map));
+            }
+        }
+
+        /// <inheritdoc />
+        public override void HandleComponentState(ComponentState? curState, ComponentState? nextState)
+        {
+            if (curState == null)
+                return;
+
+            var newState = (PointLightComponentState) curState;
+            Enabled = newState.Enabled;
+            Radius = newState.Radius;
+            Offset = newState.Offset;
+            Color = newState.Color;
+        }
     }
 
     public class PointLightRadiusChangedEvent : EntityEventArgs
@@ -162,9 +270,4 @@ namespace Robust.Client.GameObjects
             PointLightComponent = pointLightComponent;
         }
     }
-
-    internal sealed class PointLightUpdateEvent : EntityEventArgs
-    {
-
-    }
 }

Robust.Client/GameObjects/Components/Renderable/ISpriteComponent.cs

@@ -228,6 +228,6 @@ namespace Robust.Client.GameObjects
         /// <summary>
         ///     Calculate sprite bounding box in world-space coordinates.
         /// </summary>
-        Box2 CalculateBoundingBox(Vector2 worldPos);
+        Box2 CalculateBoundingBox();
     }
 }

Robust.Client/GameObjects/Components/Renderable/SpriteBoundsOverlay.cs

@@ -1,90 +0,0 @@
-using System.Collections.Generic;
-using Robust.Client.Graphics;
-using Robust.Client.Graphics.Clyde;
-using Robust.Shared.Console;
-using Robust.Shared.Enums;
-using Robust.Shared.GameObjects;
-using Robust.Shared.IoC;
-using Robust.Shared.Maths;
-using Robust.Shared.Utility;
-
-namespace Robust.Client.GameObjects
-{
-    public sealed class ShowSpriteBBCommand : IConsoleCommand
-    {
-        public string Command => "showspritebb";
-        public string Description => "Toggle whether sprite bounds are shown";
-        public string Help => $"{Command}";
-        public void Execute(IConsoleShell shell, string argStr, string[] args)
-        {
-            EntitySystem.Get<SpriteBoundsSystem>().Enabled ^= true;
-        }
-    }
-
-    public sealed class SpriteBoundsSystem : EntitySystem
-    {
-        private SpriteBoundsOverlay? _overlay;
-
-        public bool Enabled
-        {
-            get => _enabled;
-            set
-            {
-                if (_enabled == value) return;
-
-                _enabled = value;
-
-                if (_enabled)
-                {
-                    DebugTools.AssertNull(_overlay);
-                    var overlayManager = IoCManager.Resolve<IOverlayManager>();
-                    _overlay = new SpriteBoundsOverlay(EntitySystem.Get<RenderingTreeSystem>(), IoCManager.Resolve<IEyeManager>());
-                    overlayManager.AddOverlay(_overlay);
-                }
-                else
-                {
-                    if (_overlay == null) return;
-                    var overlayManager = IoCManager.Resolve<IOverlayManager>();
-                    overlayManager.RemoveOverlay(_overlay);
-                    _overlay = null;
-                }
-            }
-        }
-
-        private bool _enabled;
-    }
-
-    public class SpriteBoundsOverlay : Overlay
-    {
-        public override OverlaySpace Space => OverlaySpace.WorldSpace;
-
-        private readonly IEyeManager _eyeManager = default!;
-        private RenderingTreeSystem _renderTree;
-
-        public SpriteBoundsOverlay(RenderingTreeSystem renderTree, IEyeManager eyeManager)
-        {
-            _renderTree = renderTree;
-            _eyeManager = eyeManager;
-        }
-
-        protected internal override void Draw(in OverlayDrawArgs args)
-        {
-            var handle = args.WorldHandle;
-            var currentMap = _eyeManager.CurrentMap;
-            var viewport = _eyeManager.GetWorldViewbounds();
-
-            foreach (var comp in _renderTree.GetRenderTrees(currentMap, viewport))
-            {
-                var localAABB = comp.Owner.Transform.InvWorldMatrix.TransformBox(viewport);
-
-                foreach (var sprite in comp.SpriteTree.QueryAabb(localAABB))
-                {
-                    var worldPos = sprite.Owner.Transform.WorldPosition;
-                    var bounds = sprite.CalculateBoundingBox(worldPos);
-                    handle.DrawRect(bounds, Color.Red.WithAlpha(0.2f));
-                    handle.DrawRect(bounds.Scale(0.2f).Translated(-new Vector2(0f, bounds.Extents.Y)), Color.Blue.WithAlpha(0.5f));
-                }
-            }
-        }
-    }
-}

Robust.Client/GameObjects/Components/Renderable/SpriteComponent.cs

@@ -42,13 +42,7 @@ namespace Robust.Client.GameObjects
         public override bool Visible
         {
             get => _visible;
-            set
-            {
-                if (_visible == value) return;
-                _visible = value;
-
-                Owner.EntityManager.EventBus.RaiseLocalEvent(Owner.Uid, new SpriteUpdateEvent());
-            }
+            set => _visible = value;
         }
 
         [DataField("drawdepth", customTypeSerializer: typeof(ConstantSerializer<DrawDepthTag>))]
@@ -131,8 +125,17 @@ namespace Robust.Client.GameObjects
         [DataField("directional")]
         private bool _directional = true;
 
+        /// <summary>
+        /// What MapId we are intersecting for RenderingTreeSystem.
+        /// </summary>
         [ViewVariables]
-        internal RenderingTreeComponent? RenderTree { get; set; } = null;
+        internal MapId IntersectingMapId { get; set; } = MapId.Nullspace;
+
+        /// <summary>
+        /// What grids we're on for RenderingTreeSystem.
+        /// </summary>
+        [ViewVariables]
+        internal List<GridId> IntersectingGrids { get; } = new();
 
         [DataField("layerDatums")]
         private List<PrototypeLayerData> LayerDatums
@@ -149,7 +152,7 @@ namespace Robust.Client.GameObjects
             }
             set
             {
-                if (value == null) return;
+                if(value == null) return;
 
                 Layers.Clear();
                 foreach (var layerDatum in value)
@@ -159,12 +162,11 @@ namespace Robust.Client.GameObjects
                     if (!string.IsNullOrWhiteSpace(layerDatum.RsiPath))
                     {
                         var path = TextureRoot / layerDatum.RsiPath;
-
-                        if (IoCManager.Resolve<IResourceCache>().TryGetResource(path, out RSIResource? resource))
+                        try
                         {
-                            layer.RSI = resource.RSI;
+                            layer.RSI = IoCManager.Resolve<IResourceCache>().GetResource<RSIResource>(path).RSI;
                         }
-                        else
+                        catch
                         {
                             Logger.ErrorS(LogCategory, "Unable to load layer RSI '{0}'.", path);
                         }
@@ -263,7 +265,7 @@ namespace Robust.Client.GameObjects
                 }
 
                 _layerMapShared = true;
-                QueueUpdateIsInert();
+                UpdateIsInert();
             }
         }
 
@@ -306,30 +308,17 @@ namespace Robust.Client.GameObjects
         }
 
         [DataField("sprite", readOnly: true)] private string? rsi;
-        [DataField("layers", readOnly: true)] private List<PrototypeLayerData> layerDatums = new();
+        [DataField("layers", readOnly: true)] private List<PrototypeLayerData> layerDatums = new ();
 
         [DataField("state", readOnly: true)] private string? state;
         [DataField("texture", readOnly: true)] private string? texture;
 
         [ViewVariables(VVAccess.ReadWrite)]
-        public bool ContainerOccluded
-        {
-            get => _containerOccluded;
-            set
-            {
-                if (_containerOccluded == value) return;
-                _containerOccluded = value;
-                Owner.EntityManager.EventBus.RaiseLocalEvent(Owner.Uid, new SpriteUpdateEvent());
-            }
-        }
-
-        private bool _containerOccluded;
+        public bool ContainerOccluded { get; set; }
 
         [ViewVariables(VVAccess.ReadWrite)]
         public bool TreeUpdateQueued { get; set; }
 
-        [ViewVariables(VVAccess.ReadWrite)] private bool _inertUpdateQueued;
-
         [ViewVariables(VVAccess.ReadWrite)]
         public ShaderInstance? PostShader { get; set; }
 
@@ -359,13 +348,13 @@ namespace Robust.Client.GameObjects
                 if (!string.IsNullOrWhiteSpace(rsi))
                 {
                     var rsiPath = TextureRoot / rsi;
-                    if(IoCManager.Resolve<IResourceCache>().TryGetResource(rsiPath, out RSIResource? resource))
+                    try
                     {
-                        BaseRSI = resource.RSI;
+                        BaseRSI = IoCManager.Resolve<IResourceCache>().GetResource<RSIResource>(rsiPath).RSI;
                     }
-                    else
+                    catch (Exception e)
                     {
-                        Logger.ErrorS(LogCategory, "Unable to load RSI '{0}'.", rsiPath);
+                        Logger.ErrorS(SpriteComponent.LogCategory, "Unable to load RSI '{0}'. Trace:\n{1}", rsiPath, e);
                     }
                 }
             }
@@ -493,7 +482,7 @@ namespace Robust.Client.GameObjects
 
         public int AddBlankLayer(int? newIndex = null)
         {
-            var layer = new Layer(this) { Visible = false };
+            var layer = new Layer(this) {Visible = false};
             return AddLayer(layer, newIndex);
         }
 
@@ -522,13 +511,13 @@ namespace Robust.Client.GameObjects
 
         public int AddLayer(Texture? texture, int? newIndex = null)
         {
-            var layer = new Layer(this) { Texture = texture };
+            var layer = new Layer(this) {Texture = texture};
             return AddLayer(layer, newIndex);
         }
 
         public int AddLayer(RSI.StateId stateId, int? newIndex = null)
         {
-            var layer = new Layer(this) { State = stateId };
+            var layer = new Layer(this) {State = stateId};
             if (BaseRSI != null && BaseRSI.TryGetState(stateId, out var state))
             {
                 layer.AnimationTimeLeft = state.GetDelay(0);
@@ -574,7 +563,7 @@ namespace Robust.Client.GameObjects
 
         public int AddLayer(RSI.StateId stateId, RSI? rsi, int? newIndex = null)
         {
-            var layer = new Layer(this) { State = stateId, RSI = rsi };
+            var layer = new Layer(this) {State = stateId, RSI = rsi};
             if (rsi != null && rsi.TryGetState(stateId, out var state))
             {
                 layer.AnimationTimeLeft = state.GetDelay(0);
@@ -630,7 +619,7 @@ namespace Robust.Client.GameObjects
                 index = Layers.Count - 1;
             }
 
-            QueueUpdateIsInert();
+            UpdateIsInert();
             return index;
         }
 
@@ -657,7 +646,7 @@ namespace Robust.Client.GameObjects
                 }
             }
 
-            QueueUpdateIsInert();
+            UpdateIsInert();
         }
 
         public void RemoveLayer(object layerKey)
@@ -1212,12 +1201,13 @@ namespace Robust.Client.GameObjects
         public IEnumerable<ISpriteLayer> AllLayers => Layers;
 
         // Lobby SpriteView rendering path
-        internal void Render(DrawingHandleWorld drawingHandle, Angle eyeRotation, Angle worldRotation, Direction? overrideDirection = null)
+        internal void Render(DrawingHandleWorld drawingHandle, Angle worldRotation, Direction? overrideDirection = null)
         {
-            RenderInternal(drawingHandle, eyeRotation, worldRotation, Vector2.Zero, overrideDirection);
+            RenderInternal(drawingHandle, worldRotation, Vector2.Zero, overrideDirection);
         }
 
-        [DataField("noRot")] private bool _screenLock = false;
+        [DataField("noRot")]
+        private bool _screenLock = true;
 
         [DataField("overrideDir")]
         private Direction _overrideDirection = Direction.East;
@@ -1238,7 +1228,7 @@ namespace Robust.Client.GameObjects
         public bool EnableDirectionOverride { get => _enableOverrideDirection; set => _enableOverrideDirection = value; }
 
         // Sprite rendering path
-        internal void Render(DrawingHandleWorld drawingHandle, Angle eyeRotation, in Angle worldRotation, in Vector2 worldPosition)
+        internal void Render(DrawingHandleWorld drawingHandle, in Angle worldRotation, in Vector2 worldPosition)
         {
             Direction? overrideDir = null;
             if (_enableOverrideDirection)
@@ -1246,29 +1236,27 @@ namespace Robust.Client.GameObjects
                 overrideDir = _overrideDirection;
             }
 
-            RenderInternal(drawingHandle, eyeRotation, worldRotation, worldPosition, overrideDir);
+            RenderInternal(drawingHandle, worldRotation, worldPosition, overrideDir);
         }
 
-        private void CalcModelMatrix(int numDirs, Angle eyeRotation, Angle worldRotation, Vector2 worldPosition, out Matrix3 modelMatrix)
+        private void CalcModelMatrix(int numDirs, Angle worldRotation, Vector2 worldPosition, out Matrix3 modelMatrix)
         {
             Angle angle;
 
             if (_screenLock)
             {
-                // Negate the eye rotation in the model matrix, so that later when the view matrix is applied the
-                // sprite will be locked upright to the screen
-                angle = new Angle(-eyeRotation.Theta);
+                angle = Angle.Zero;
             }
             else
             {
-                angle = CalcRectWorldAngle(worldRotation + eyeRotation, numDirs) - eyeRotation;
+                angle = CalcRectWorldAngle(worldRotation, numDirs);
             }
 
             var sWorldRotation = angle;
             modelMatrix = Matrix3.CreateTransform(in worldPosition, in sWorldRotation);
         }
 
-        private void RenderInternal(DrawingHandleWorld drawingHandle, Angle eyeRotation, Angle worldRotation, Vector2 worldPosition, Direction? overrideDirection)
+        private void RenderInternal(DrawingHandleWorld drawingHandle, Angle worldRotation, Vector2 worldPosition, Direction? overrideDirection)
         {
             var localMatrix = GetLocalMatrix();
 
@@ -1281,17 +1269,17 @@ namespace Robust.Client.GameObjects
 
                 var numDirs = GetLayerDirectionCount(layer);
 
-                CalcModelMatrix(numDirs, eyeRotation, worldRotation, worldPosition, out var modelMatrix);
+                CalcModelMatrix(numDirs, worldRotation, worldPosition, out var modelMatrix);
                 Matrix3.Multiply(ref localMatrix, ref modelMatrix, out var transformMatrix);
                 drawingHandle.SetTransform(in transformMatrix);
 
-                RenderLayer(drawingHandle, layer, eyeRotation, worldRotation, overrideDirection);
+                RenderLayer(drawingHandle, layer, worldRotation, overrideDirection);
             }
         }
 
-        private void RenderLayer(DrawingHandleWorld drawingHandle, Layer layer, Angle eyeRotation, Angle worldRotation, Direction? overrideDirection)
+        private void RenderLayer(DrawingHandleWorld drawingHandle, Layer layer, Angle worldRotation, Direction? overrideDirection)
         {
-            var texture = GetRenderTexture(layer, worldRotation + eyeRotation, overrideDirection);
+            var texture = GetRenderTexture(layer, worldRotation, overrideDirection);
 
             if (layer.Shader != null)
             {
@@ -1300,8 +1288,8 @@ namespace Robust.Client.GameObjects
 
             var layerColor = color * layer.Color;
 
-            var position = -(Vector2)texture.Size / (2f * EyeManager.PixelsPerMeter) + layer.Offset;
-            var textureSize = texture.Size / (float)EyeManager.PixelsPerMeter;
+            var position = -(Vector2) texture.Size / (2f * EyeManager.PixelsPerMeter) + layer.Offset;
+            var textureSize = texture.Size / (float) EyeManager.PixelsPerMeter;
             var quad = Box2.FromDimensions(position, textureSize);
 
             // TODO: Implement layer-specific rotation and scale.
@@ -1321,7 +1309,7 @@ namespace Robust.Client.GameObjects
         public static Angle CalcRectWorldAngle(Angle worldAngle, int numDirections)
         {
             var theta = worldAngle.Theta;
-            var segSize = (MathF.PI * 2) / (numDirections * 2);
+            var segSize = (MathF.PI*2) / (numDirections * 2);
             var segments = (int)(theta / segSize);
             var odd = segments % 2;
             var result = theta - (segments * segSize) - (odd * segSize);
@@ -1371,6 +1359,18 @@ namespace Robust.Client.GameObjects
             return texture;
         }
 
+        public override void OnRemove()
+        {
+            base.OnRemove();
+
+            var map = Owner.Transform.MapID;
+            if (map != MapId.Nullspace)
+            {
+                Owner.EntityManager.EventBus.RaiseEvent(EventSource.Local,
+                    new RenderTreeRemoveSpriteEvent(this, map));
+            }
+        }
+
         public void FrameUpdate(float delta)
         {
             foreach (var t in Layers)
@@ -1421,7 +1421,7 @@ namespace Robust.Client.GameObjects
             if (curState == null)
                 return;
 
-            var thestate = (SpriteComponentState)curState;
+            var thestate = (SpriteComponentState) curState;
 
             Visible = thestate.Visible;
             DrawDepth = thestate.DrawDepth;
@@ -1509,25 +1509,8 @@ namespace Robust.Client.GameObjects
             };
         }
 
-        private void QueueUpdateIsInert()
+        private void UpdateIsInert()
         {
-            // Look this was an easy way to get bounds checks for layer updates.
-            // If you really want it optimal you'll need to comb through all 2k lines of spritecomponent.
-            if (Owner?.EntityManager?.EventBus != null)
-                UpdateBounds();
-
-            if (_inertUpdateQueued)
-                return;
-
-            _inertUpdateQueued = true;
-            // Yes that null check is valid because of that stupid fucking dummy IEntity.
-            // Who thought that was a good idea.
-            Owner?.EntityManager?.EventBus?.RaiseEvent(EventSource.Local, new SpriteUpdateInertEvent {Sprite = this});
-        }
-
-        internal void DoUpdateIsInert()
-        {
-            _inertUpdateQueued = false;
             IsInert = true;
 
             foreach (var layer in Layers)
@@ -1630,11 +1613,11 @@ namespace Robust.Client.GameObjects
         }
 
         /// <inheritdoc/>
-        public Box2 CalculateBoundingBox(Vector2 worldPos)
+        public Box2 CalculateBoundingBox()
         {
             // fast check for empty sprites
             if (Layers.Count == 0)
-                return new Box2(worldPos, worldPos);
+                return new Box2();
 
             // we need to calculate bounding box taking into account all nested layers
             // because layers can have offsets, scale or rotation we need to calculate a new BB
@@ -1657,15 +1640,11 @@ namespace Robust.Client.GameObjects
                 new Box2Rotated(spriteBox, Rotation).CalcBoundingBox() : spriteBox;
 
             // move it all to world transform system (with sprite offset)
-            var worldBB = spriteBB.Translated(Offset + worldPos);
+            var worldPosition = Owner.Transform.WorldPosition;
+            var worldBB = spriteBB.Translated(Offset + worldPosition);
             return worldBB;
         }
 
-        internal void UpdateBounds()
-        {
-            Owner.EntityManager.EventBus.RaiseLocalEvent(Owner.Uid, new SpriteUpdateEvent());
-        }
-
         /// <summary>
         ///     Enum to "offset" a cardinal direction.
         /// </summary>
@@ -1721,19 +1700,7 @@ namespace Robust.Client.GameObjects
             public bool AutoAnimated = true;
 
             [ViewVariables(VVAccess.ReadWrite)]
-            public Vector2 Offset
-            {
-                get => _offset;
-                set
-                {
-                    if (_offset.EqualsApprox(value)) return;
-
-                    _offset = value;
-                    _parent.UpdateBounds();
-                }
-            }
-
-            private Vector2 _offset;
+            public Vector2 Offset { get; set; }
 
             [ViewVariables]
             public DirectionOffset DirOffset { get; set; }
@@ -1893,14 +1860,14 @@ namespace Robust.Client.GameObjects
             {
                 AutoAnimated = value;
 
-                _parent.QueueUpdateIsInert();
+                _parent.UpdateIsInert();
             }
 
             public void SetVisible(bool value)
             {
                 Visible = value;
 
-                _parent.QueueUpdateIsInert();
+                _parent.UpdateIsInert();
             }
 
             public void SetRsi(RSI? rsi)
@@ -1932,7 +1899,7 @@ namespace Robust.Client.GameObjects
                     }
                 }
 
-                _parent.QueueUpdateIsInert();
+                _parent.UpdateIsInert();
             }
 
             public void SetState(RSI.StateId stateId)
@@ -1964,7 +1931,7 @@ namespace Robust.Client.GameObjects
                 AnimationTime = 0;
                 AnimationTimeLeft = state.GetDelay(0);
 
-                _parent.QueueUpdateIsInert();
+                _parent.UpdateIsInert();
             }
 
             public void SetTexture(Texture? texture)
@@ -1972,7 +1939,7 @@ namespace Robust.Client.GameObjects
                 State = default;
                 Texture = texture;
 
-                _parent.QueueUpdateIsInert();
+                _parent.UpdateIsInert();
             }
 
             public void SetOffset(Vector2 offset)
@@ -2005,6 +1972,7 @@ namespace Robust.Client.GameObjects
                 // TODO: scale & rotation for layers is currently unimplemented.
                 return Box2.CenteredAround(Offset, PixelSize / EyeManager.PixelsPerMeter);
             }
+
         }
 
         void IAnimationProperties.SetAnimatableProperty(string name, object value)
@@ -2023,13 +1991,13 @@ namespace Robust.Client.GameObjects
             switch (layerProp)
             {
                 case "texture":
-                    LayerSetTexture(index, (string)value);
+                    LayerSetTexture(index, (string) value);
                     return;
                 case "state":
-                    LayerSetState(index, (string)value);
+                    LayerSetState(index, (string) value);
                     return;
                 case "color":
-                    LayerSetColor(index, (Color)value);
+                    LayerSetColor(index, (Color) value);
                     return;
                 default:
                     throw new ArgumentException($"Unknown layer property '{layerProp}'");
@@ -2074,7 +2042,7 @@ namespace Robust.Client.GameObjects
                 yield break;
             }
 
-            var dummy = new DummyIconEntity { Prototype = prototype };
+            var dummy = new DummyIconEntity {Prototype = prototype};
             var spriteComponent = dummy.AddComponent<SpriteComponent>();
 
             if (prototype.Components.TryGetValue("Appearance", out _))
@@ -2118,7 +2086,7 @@ namespace Robust.Client.GameObjects
                 return GetFallbackState(resourceCache);
             }
 
-            var dummy = new DummyIconEntity { Prototype = prototype };
+            var dummy = new DummyIconEntity {Prototype = prototype};
             var spriteComponent = dummy.AddComponent<SpriteComponent>();
             dummy.Delete();
 
@@ -2155,7 +2123,7 @@ namespace Robust.Client.GameObjects
             {
                 var typeFactory = IoCManager.Resolve<IDynamicTypeFactoryInternal>();
                 var serializationManager = IoCManager.Resolve<ISerializationManager>();
-                var comp = (T)typeFactory.CreateInstanceUnchecked(typeof(T));
+                var comp = (T) typeFactory.CreateInstanceUnchecked(typeof(T));
                 _components[typeof(T)] = comp;
                 comp.Owner = this;
 
@@ -2189,7 +2157,7 @@ namespace Robust.Client.GameObjects
 
             public T GetComponent<T>()
             {
-                return (T)_components[typeof(T)];
+                return (T) _components[typeof(T)];
             }
 
             public IComponent GetComponent(Type type)
@@ -2201,7 +2169,7 @@ namespace Robust.Client.GameObjects
             {
                 component = null;
                 if (!_components.TryGetValue(typeof(T), out var value)) return false;
-                component = (T)value;
+                component = (T) value;
                 return true;
             }
 
@@ -2257,14 +2225,4 @@ namespace Robust.Client.GameObjects
         }
         #endregion
     }
-
-    internal sealed class SpriteUpdateEvent : EntityEventArgs
-    {
-
-    }
-
-    internal struct SpriteUpdateInertEvent
-    {
-        public SpriteComponent Sprite;
-    }
 }

Robust.Client/GameObjects/Components/RenderingTreeComponent.cs

@@ -1,63 +0,0 @@
-using Robust.Shared.GameObjects;
-using Robust.Shared.Maths;
-using Robust.Shared.Physics;
-
-namespace Robust.Client.GameObjects
-{
-    [RegisterComponent]
-    public sealed class RenderingTreeComponent : Component
-    {
-        public override string Name => "RenderingTree";
-
-        internal DynamicTree<SpriteComponent> SpriteTree { get; private set; } = new(SpriteAabbFunc);
-        internal DynamicTree<PointLightComponent> LightTree { get; private set; } = new(LightAabbFunc);
-
-        private static Box2 SpriteAabbFunc(in SpriteComponent value)
-        {
-            var worldPos = value.Owner.Transform.WorldPosition;
-            var worldRot = value.Owner.Transform.WorldRotation;
-            var bounds = new Box2Rotated(value.CalculateBoundingBox(worldPos), worldRot, worldPos);
-            var tree = RenderingTreeSystem.GetRenderTree(value.Owner);
-
-            var localAABB = tree?.Owner.Transform.InvWorldMatrix.TransformBox(bounds) ?? bounds.CalcBoundingBox();
-
-            return localAABB;
-        }
-
-        private static Box2 LightAabbFunc(in PointLightComponent value)
-        {
-            var worldPos = value.Owner.Transform.WorldPosition;
-            var tree = RenderingTreeSystem.GetRenderTree(value.Owner);
-            var boxSize = value.Radius * 2;
-
-            var localPos = tree?.Owner.Transform.InvWorldMatrix.Transform(worldPos) ?? worldPos;
-
-            return Box2.CenteredAround(localPos, (boxSize, boxSize));
-        }
-
-        internal static Box2 SpriteAabbFunc(SpriteComponent value, Vector2? worldPos = null, Angle? worldRot = null)
-        {
-            worldPos ??= value.Owner.Transform.WorldPosition;
-            worldRot ??= value.Owner.Transform.WorldRotation;
-            var bounds = new Box2Rotated(value.CalculateBoundingBox(worldPos.Value), worldRot.Value, worldPos.Value);
-            var tree = RenderingTreeSystem.GetRenderTree(value.Owner);
-
-            var localAABB = tree?.Owner.Transform.InvWorldMatrix.TransformBox(bounds) ?? bounds.CalcBoundingBox();
-
-            return localAABB;
-        }
-
-        internal static Box2 LightAabbFunc(PointLightComponent value, Vector2? worldPos = null)
-        {
-            // Lights are circles so don't need entity's rotation
-
-            worldPos ??= value.Owner.Transform.WorldPosition;
-            var tree = RenderingTreeSystem.GetRenderTree(value.Owner);
-            var boxSize = value.Radius * 2;
-
-            var localPos = tree?.Owner.Transform.InvWorldMatrix.Transform(worldPos.Value) ?? worldPos.Value;
-
-            return Box2.CenteredAround(localPos, (boxSize, boxSize));
-        }
-    }
-}

Robust.Client/GameObjects/Components/UserInterface/ClientUserInterfaceComponent.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using Robust.Client.Player;
 using Robust.Shared.GameObjects;
 using Robust.Shared.IoC;
 using Robust.Shared.Reflection;
@@ -86,10 +85,6 @@ namespace Robust.Client.GameObjects
                 SendMessage(new CloseBoundInterfaceMessage(), uiKey);
             _openInterfaces.Remove(uiKey);
             boundUserInterface.Dispose();
-
-            var playerSession = IoCManager.Resolve<IPlayerManager>().LocalPlayer?.Session;
-            if(playerSession != null)
-                Owner.EntityManager.EventBus.RaiseLocalEvent(Owner.Uid, new BoundUIClosedEvent(uiKey, Owner.Uid, playerSession));
         }
 
         internal void SendMessage(BoundUserInterfaceMessage message, object uiKey)

Robust.Client/GameObjects/EntitySystems/AppearanceTestSystem.cs

@@ -0,0 +1,15 @@
+using Robust.Shared.GameObjects;
+
+namespace Robust.Client.GameObjects
+{
+    class AppearanceTestSystem : EntitySystem
+    {
+        public override void Update(float frameTime)
+        {
+            foreach (var appearanceTestComponent in EntityManager.ComponentManager.EntityQuery<AppearanceTestComponent>(true))
+            {
+                appearanceTestComponent.OnUpdate(frameTime);
+            }
+        }
+    }
+}

Robust.Client/GameObjects/EntitySystems/AudioSystem.cs

@@ -1,6 +1,4 @@
-using System;
 using System.Collections.Generic;
-using System.IO;
 using JetBrains.Annotations;
 using Robust.Client.Audio;
 using Robust.Client.Graphics;
@@ -10,7 +8,6 @@ using Robust.Shared.GameObjects;
 using Robust.Shared.IoC;
 using Robust.Shared.Log;
 using Robust.Shared.Map;
-using Robust.Shared.Maths;
 using Robust.Shared.Physics;
 using Robust.Shared.Physics.Broadphase;
 using Robust.Shared.Player;
@@ -26,7 +23,8 @@ namespace Robust.Client.GameObjects
         [Dependency] private readonly IClydeAudio _clyde = default!;
         [Dependency] private readonly IEyeManager _eyeManager = default!;
         [Dependency] private readonly IEntityManager _entityManager = default!;
-        [Dependency] private readonly SharedBroadphaseSystem _broadPhaseSystem = default!;
+
+        private SharedBroadPhaseSystem _broadPhaseSystem = default!;
 
         private readonly List<PlayingStream> _playingClydeStreams = new();
 
@@ -40,6 +38,7 @@ namespace Robust.Client.GameObjects
             SubscribeNetworkEvent<StopAudioMessageClient>(StopAudioMessageHandler);
 
             SubscribeLocalEvent<SoundSystem.QueryAudioSystem>((ev => ev.Audio = this));
+            _broadPhaseSystem = Get<SharedBroadPhaseSystem>();
         }
 
         private void StopAudioMessageHandler(StopAudioMessageClient ev)
@@ -99,8 +98,6 @@ namespace Robust.Client.GameObjects
             // Update positions of streams every frame.
             try
             {
-                var ourPos = _eyeManager.CurrentEye.Position.Position;
-
                 foreach (var stream in _playingClydeStreams)
                 {
                     if (!stream.Source.IsPlaying)
@@ -144,7 +141,7 @@ namespace Robust.Client.GameObjects
                         }
                         else
                         {
-                            var sourceRelative = ourPos - pos.Position;
+                            var sourceRelative = _eyeManager.CurrentEye.Position.Position - pos.Position;
                             var occlusion = 0f;
                             if (sourceRelative.Length > 0)
                             {
@@ -158,54 +155,14 @@ namespace Robust.Client.GameObjects
                                     stream.TrackingEntity);
                             }
 
-                            var distance = MathF.Max(stream.ReferenceDistance, MathF.Min(sourceRelative.Length, stream.MaxDistance));
-                            float gain;
-
-                            // Technically these are formulas for gain not decibels but EHHHHHHHH.
-                            switch (stream.Attenuation)
-                            {
-                                case Attenuation.Default:
-                                    gain = 1f;
-                                    break;
-                                // You thought I'd implement clamping per source? Hell no that's just for the overall OpenAL setting
-                                // I didn't even wanna implement this much for linear but figured it'd be cleaner.
-                                case Attenuation.InverseDistanceClamped:
-                                case Attenuation.InverseDistance:
-                                    gain = stream.ReferenceDistance /
-                                           (stream.ReferenceDistance + stream.RolloffFactor * (distance - stream.ReferenceDistance));
-
-                                    break;
-                                case Attenuation.LinearDistanceClamped:
-                                case Attenuation.LinearDistance:
-                                    gain = 1f - stream.RolloffFactor * (distance - stream.ReferenceDistance) /
-                                        (stream.MaxDistance - stream.ReferenceDistance);
-
-                                    break;
-                                case Attenuation.ExponentDistanceClamped:
-                                case Attenuation.ExponentDistance:
-                                    gain = MathF.Pow((distance / stream.ReferenceDistance),
-                                        (-stream.RolloffFactor));
-                                    break;
-                                default:
-                                    throw new ArgumentOutOfRangeException($"No implemented attenuation for {stream.Attenuation.ToString()}");
-                            }
-
-                            var volume = MathF.Pow(10, stream.Volume / 10);
-                            var actualGain = MathF.Max(0f, volume * gain);
-
-                            stream.Source.SetVolumeDirect(actualGain);
+                            stream.Source.SetVolume(stream.Volume);
                             stream.Source.SetOcclusion(occlusion);
                         }
 
-                        SetAudioPos(stream, stream.Attenuation != Attenuation.NoAttenuation ? pos.Position : ourPos);
-
-                        void SetAudioPos(PlayingStream stream, Vector2 pos)
+                        if (!stream.Source.SetPosition(pos.Position))
                         {
-                            if (!stream.Source.SetPosition(pos))
-                            {
-                                Logger.Warning("Interrupting positional audio, can't set position.");
-                                stream.Source.StopPlaying();
-                            }
+                            Logger.Warning("Interrupting positional audio, can't set position.");
+                            stream.Source.StopPlaying();
                         }
 
                         if (stream.TrackingEntity != null)
@@ -262,10 +219,6 @@ namespace Robust.Client.GameObjects
             var playing = new PlayingStream
             {
                 Source = source,
-                Attenuation = audioParams?.Attenuation ?? Attenuation.Default,
-                MaxDistance = audioParams?.MaxDistance ?? float.MaxValue,
-                ReferenceDistance = audioParams?.ReferenceDistance ?? 1f,
-                RolloffFactor = audioParams?.RolloffFactor ?? 1f,
                 Volume = audioParams?.Volume ?? 0
             };
             _playingClydeStreams.Add(playing);
@@ -301,7 +254,7 @@ namespace Robust.Client.GameObjects
             if (!source.SetPosition(entity.Transform.WorldPosition))
             {
                 source.Dispose();
-                Logger.Warning($"Can't play positional audio \"{stream.Name}\", can't set position.");
+                Logger.Warning("Can't play positional audio, can't set position.");
                 return null;
             }
 
@@ -312,10 +265,6 @@ namespace Robust.Client.GameObjects
             {
                 Source = source,
                 TrackingEntity = entity,
-                Attenuation = audioParams?.Attenuation ?? Attenuation.Default,
-                MaxDistance = audioParams?.MaxDistance ?? float.MaxValue,
-                ReferenceDistance = audioParams?.ReferenceDistance ?? 1f,
-                RolloffFactor = audioParams?.RolloffFactor ?? 1f,
                 Volume = audioParams?.Volume ?? 0
             };
             _playingClydeStreams.Add(playing);
@@ -352,7 +301,7 @@ namespace Robust.Client.GameObjects
             if (!source.SetPosition(coordinates.ToMapPos(EntityManager)))
             {
                 source.Dispose();
-                Logger.Warning($"Can't play positional audio \"{stream.Name}\", can't set position.");
+                Logger.Warning("Can't play positional audio, can't set position.");
                 return null;
             }
 
@@ -363,10 +312,6 @@ namespace Robust.Client.GameObjects
             {
                 Source = source,
                 TrackingCoordinates = coordinates,
-                Attenuation = audioParams?.Attenuation ?? Attenuation.Default,
-                MaxDistance = audioParams?.MaxDistance ?? float.MaxValue,
-                ReferenceDistance = audioParams?.ReferenceDistance ?? 1f,
-                RolloffFactor = audioParams?.RolloffFactor ?? 1f,
                 Volume = audioParams?.Volume ?? 0
             };
             _playingClydeStreams.Add(playing);
@@ -382,9 +327,6 @@ namespace Robust.Client.GameObjects
 
             source.SetPitch(audioParams.Value.PitchScale);
             source.SetVolume(audioParams.Value.Volume);
-            source.SetRolloffFactor(audioParams.Value.RolloffFactor);
-            source.SetMaxDistance(audioParams.Value.MaxDistance);
-            source.SetReferenceDistance(audioParams.Value.ReferenceDistance);
             source.SetPlaybackPosition(audioParams.Value.PlayOffsetSeconds);
             source.IsLooping = audioParams.Value.Loop;
         }
@@ -398,27 +340,6 @@ namespace Robust.Client.GameObjects
             public bool Done;
             public float Volume;
 
-            public float MaxDistance;
-            public float ReferenceDistance;
-            public float RolloffFactor;
-
-            public Attenuation Attenuation
-            {
-                get => _attenuation;
-                set
-                {
-                    if (value == _attenuation) return;
-                    _attenuation = value;
-                    if (_attenuation != Attenuation.Default)
-                    {
-                        // Need to disable default attenuation when using a custom one
-                        // Damn Sloth wanting linear ambience sounds so they smoothly cut-off and are short-range
-                        Source.SetRolloffFactor(0f);
-                    }
-                }
-            }
-            private Attenuation _attenuation = Attenuation.Default;
-
             public void Stop()
             {
                 Source.StopPlaying();

Robust.Client/GameObjects/EntitySystems/ClientContainerSystem.cs

@@ -0,0 +1,94 @@
+using System.Collections.Generic;
+using Robust.Shared.Containers;
+using Robust.Shared.GameObjects;
+
+namespace Robust.Client.GameObjects
+{
+    public class ClientContainerSystem : ContainerSystem
+    {
+        private readonly HashSet<IEntity> _updateQueue = new();
+
+        public override void Initialize()
+        {
+            base.Initialize();
+
+            SubscribeLocalEvent<UpdateContainerOcclusionMessage>(UpdateContainerOcclusion);
+
+            UpdatesBefore.Add(typeof(SpriteSystem));
+        }
+
+        private void UpdateContainerOcclusion(UpdateContainerOcclusionMessage ev)
+        {
+            _updateQueue.Add(ev.Entity);
+        }
+
+        public override void FrameUpdate(float frameTime)
+        {
+            base.FrameUpdate(frameTime);
+
+            foreach (var toUpdate in _updateQueue)
+            {
+                if (toUpdate.Deleted)
+                {
+                    continue;
+                }
+
+                UpdateEntityRecursively(toUpdate);
+            }
+
+            _updateQueue.Clear();
+        }
+
+        private static void UpdateEntityRecursively(IEntity entity)
+        {
+            // TODO: Since we are recursing down,
+            // we could cache ShowContents data here to speed it up for children.
+            // Am lazy though.
+            UpdateEntity(entity);
+
+            foreach (var child in entity.Transform.Children)
+            {
+                UpdateEntityRecursively(child.Owner);
+            }
+        }
+
+        private static void UpdateEntity(IEntity entity)
+        {
+            if (entity.TryGetComponent(out SpriteComponent? sprite))
+            {
+                sprite.ContainerOccluded = false;
+
+                // We have to recursively scan for containers upwards in case of nested containers.
+                var tempParent = entity;
+                while (tempParent.TryGetContainer(out var container))
+                {
+                    if (!container.ShowContents)
+                    {
+                        sprite.ContainerOccluded = true;
+                        break;
+                    }
+
+                    tempParent = container.Owner;
+                }
+            }
+
+            if (entity.TryGetComponent(out PointLightComponent? light))
+            {
+                light.ContainerOccluded = false;
+
+                // We have to recursively scan for containers upwards in case of nested containers.
+                var tempParent = entity;
+                while (tempParent.TryGetContainer(out var container))
+                {
+                    if (container.OccludesLight)
+                    {
+                        light.ContainerOccluded = true;
+                        break;
+                    }
+
+                    tempParent = container.Owner;
+                }
+            }
+        }
+    }
+}

Robust.Client/GameObjects/EntitySystems/ClientOccluderSystem.cs

@@ -35,7 +35,7 @@ namespace Robust.Client.GameObjects
 
             SubscribeLocalEvent<OccluderDirtyEvent>(HandleDirtyEvent);
 
-            SubscribeLocalEvent<ClientOccluderComponent, AnchorStateChangedEvent>(HandleAnchorChanged);
+            SubscribeLocalEvent<ClientOccluderComponent, SnapGridPositionChangedEvent>(HandleSnapGridMove);
         }
 
         public override void FrameUpdate(float frameTime)
@@ -62,9 +62,9 @@ namespace Robust.Client.GameObjects
             }
         }
 
-        private static void HandleAnchorChanged(EntityUid uid, ClientOccluderComponent component, ref AnchorStateChangedEvent args)
+        private static void HandleSnapGridMove(EntityUid uid, ClientOccluderComponent component, SnapGridPositionChangedEvent args)
         {
-            component.AnchorStateChanged();
+            component.SnapGridOnPositionChanged();
         }
 
         private void HandleDirtyEvent(OccluderDirtyEvent ev)

Robust.Client/GameObjects/EntitySystems/ContainerSystem.cs

@@ -1,238 +0,0 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using Robust.Shared.Containers;
-using Robust.Shared.GameObjects;
-using Robust.Shared.GameStates;
-using Robust.Shared.IoC;
-using Robust.Shared.Serialization;
-using static Robust.Shared.Containers.ContainerManagerComponent;
-
-namespace Robust.Client.GameObjects
-{
-    public class ContainerSystem : SharedContainerSystem
-    {
-        [Dependency] private readonly IRobustSerializer _serializer = default!;
-        [Dependency] private readonly IDynamicTypeFactoryInternal _dynFactory = default!;
-
-        private readonly HashSet<IEntity> _updateQueue = new();
-
-        public readonly Dictionary<EntityUid, IContainer> ExpectedEntities = new();
-
-        public override void Initialize()
-        {
-            base.Initialize();
-
-            SubscribeLocalEvent<UpdateContainerOcclusionMessage>(UpdateContainerOcclusion);
-            SubscribeLocalEvent<EntityInitializedMessage>(HandleEntityInitialized);
-            SubscribeLocalEvent<ContainerManagerComponent, ComponentHandleState>(HandleComponentState);
-
-            UpdatesBefore.Add(typeof(SpriteSystem));
-        }
-
-        private void UpdateContainerOcclusion(UpdateContainerOcclusionMessage ev)
-        {
-            _updateQueue.Add(ev.Entity);
-        }
-
-        private void HandleEntityInitialized(EntityInitializedMessage ev)
-        {
-            if (!ExpectedEntities.TryGetValue(ev.Entity.Uid, out var container))
-                return;
-
-            RemoveExpectedEntity(ev.Entity.Uid);
-
-            if (container.Deleted)
-                return;
-
-            container.Insert(ev.Entity);
-        }
-
-        private void HandleComponentState(EntityUid uid, ContainerManagerComponent component, ref ComponentHandleState args)
-        {
-            if (args.Current is not ContainerManagerComponentState cast)
-                return;
-
-            // Delete now-gone containers.
-            List<string>? toDelete = null;
-            foreach (var (id, container) in component.Containers)
-            {
-                if (!cast.ContainerSet.Any(data => data.Id == id))
-                {
-                    container.EmptyContainer(true);
-                    container.Shutdown();
-                    toDelete ??= new List<string>();
-                    toDelete.Add(id);
-                }
-            }
-
-            if (toDelete != null)
-            {
-                foreach (var dead in toDelete)
-                {
-                    component.Containers.Remove(dead);
-                }
-            }
-
-            // Add new containers and update existing contents.
-
-            foreach (var (containerType, id, showEnts, occludesLight, entityUids) in cast.ContainerSet)
-            {
-                if (!component.Containers.TryGetValue(id, out var container))
-                {
-                    container = ContainerFactory(component, containerType, id);
-                    component.Containers.Add(id, container);
-                }
-
-                // sync show flag
-                container.ShowContents = showEnts;
-                container.OccludesLight = occludesLight;
-
-                // Remove gone entities.
-                List<IEntity>? toRemove = null;
-                foreach (var entity in container.ContainedEntities)
-                {
-                    if (!entityUids.Contains(entity.Uid))
-                    {
-                        toRemove ??= new List<IEntity>();
-                        toRemove.Add(entity);
-                    }
-                }
-
-                if (toRemove != null)
-                {
-                    foreach (var goner in toRemove)
-                        container.Remove(goner);
-                }
-
-                // Remove entities that were expected, but have been removed from the container.
-                List<EntityUid>? removedExpected = null;
-                foreach (var entityUid in container.ExpectedEntities)
-                {
-                    if (!entityUids.Contains(entityUid))
-                    {
-                        removedExpected ??= new List<EntityUid>();
-                        removedExpected.Add(entityUid);
-                    }
-                }
-
-                if (removedExpected != null)
-                {
-                    foreach (var entityUid in removedExpected)
-                        RemoveExpectedEntity(entityUid);
-                }
-
-                // Add new entities.
-                foreach (var entityUid in entityUids)
-                {
-                    if (!EntityManager.TryGetEntity(entityUid, out var entity))
-                    {
-                        AddExpectedEntity(entityUid, container);
-                        continue;
-                    }
-
-                    if (!container.ContainedEntities.Contains(entity))
-                        container.Insert(entity);
-                }
-            }
-        }
-
-        private IContainer ContainerFactory(ContainerManagerComponent component, string containerType, string id)
-        {
-            var type = _serializer.FindSerializedType(typeof(IContainer), containerType);
-            if (type is null) throw new ArgumentException($"Container of type {containerType} for id {id} cannot be found.");
-
-            var newContainer = _dynFactory.CreateInstanceUnchecked<BaseContainer>(type);
-            newContainer.ID = id;
-            newContainer.Manager = component;
-            return newContainer;
-        }
-
-        public void AddExpectedEntity(EntityUid uid, IContainer container)
-        {
-            if (ExpectedEntities.ContainsKey(uid))
-                return;
-
-            ExpectedEntities.Add(uid, container);
-            container.ExpectedEntities.Add(uid);
-        }
-
-        public void RemoveExpectedEntity(EntityUid uid)
-        {
-            if (!ExpectedEntities.TryGetValue(uid, out var container))
-                return;
-
-            ExpectedEntities.Remove(uid);
-            container.ExpectedEntities.Remove(uid);
-        }
-
-        public override void FrameUpdate(float frameTime)
-        {
-            base.FrameUpdate(frameTime);
-
-            foreach (var toUpdate in _updateQueue)
-            {
-                if (toUpdate.Deleted)
-                {
-                    continue;
-                }
-
-                UpdateEntityRecursively(toUpdate);
-            }
-
-            _updateQueue.Clear();
-        }
-
-        private static void UpdateEntityRecursively(IEntity entity)
-        {
-            // TODO: Since we are recursing down,
-            // we could cache ShowContents data here to speed it up for children.
-            // Am lazy though.
-            UpdateEntity(entity);
-
-            foreach (var child in entity.Transform.Children)
-            {
-                UpdateEntityRecursively(child.Owner);
-            }
-        }
-
-        private static void UpdateEntity(IEntity entity)
-        {
-            if (entity.TryGetComponent(out SpriteComponent? sprite))
-            {
-                sprite.ContainerOccluded = false;
-
-                // We have to recursively scan for containers upwards in case of nested containers.
-                var tempParent = entity;
-                while (tempParent.TryGetContainer(out var container))
-                {
-                    if (!container.ShowContents)
-                    {
-                        sprite.ContainerOccluded = true;
-                        break;
-                    }
-
-                    tempParent = container.Owner;
-                }
-            }
-
-            if (entity.TryGetComponent(out PointLightComponent? light))
-            {
-                light.ContainerOccluded = false;
-
-                // We have to recursively scan for containers upwards in case of nested containers.
-                var tempParent = entity;
-                while (tempParent.TryGetContainer(out var container))
-                {
-                    if (container.OccludesLight)
-                    {
-                        light.ContainerOccluded = true;
-                        break;
-                    }
-
-                    tempParent = container.Owner;
-                }
-            }
-        }
-    }
-}

Robust.Client/GameObjects/EntitySystems/DebugGridTileLookupSystem.cs

@@ -1,133 +0,0 @@
-#if DEBUG
-using System;
-using System.Text;
-using Robust.Client.Graphics;
-using Robust.Client.Input;
-using Robust.Client.UserInterface;
-using Robust.Client.UserInterface.Controls;
-using Robust.Shared.Console;
-using Robust.Shared.GameObjects;
-using Robust.Shared.IoC;
-using Robust.Shared.Map;
-using Robust.Shared.Maths;
-
-namespace Robust.Client.GameObjects
-{
-    internal sealed class DebugGridTileLookupSystem : EntitySystem
-    {
-        [Dependency] private readonly IEyeManager _eyeManager = default!;
-        [Dependency] private readonly IInputManager _inputManager = default!;
-        [Dependency] private readonly IMapManager _mapManager = default!;
-
-        public bool Enabled
-        {
-            get => _enabled;
-            set
-            {
-                if (_enabled == value) return;
-                _enabled = value;
-
-                if (_enabled)
-                {
-                    _label.Visible = true;
-                    LastTile = default;
-                }
-                else
-                {
-                    _label.Text = null;
-                    _label.Visible = false;
-                }
-            }
-        }
-
-        private bool _enabled;
-
-        private (GridId Grid, Vector2i Indices) LastTile;
-
-        // Label and shit that follows cursor
-        private Label _label = new()
-        {
-            Visible = false,
-        };
-
-        public override void Initialize()
-        {
-            base.Initialize();
-            SubscribeNetworkEvent<SendGridTileLookupMessage>(HandleSentEntities);
-            IoCManager.Resolve<IUserInterfaceManager>().StateRoot.AddChild(_label);
-        }
-
-        public override void Shutdown()
-        {
-            base.Shutdown();
-            IoCManager.Resolve<IUserInterfaceManager>().StateRoot.RemoveChild(_label);
-        }
-
-        private void RequestEntities(GridId gridId, Vector2i indices)
-        {
-            if (gridId == GridId.Invalid) return;
-            RaiseNetworkEvent(new RequestGridTileLookupMessage(gridId, indices));
-        }
-
-        private void HandleSentEntities(SendGridTileLookupMessage message)
-        {
-            if (!Enabled) return;
-            var text = new StringBuilder();
-            text.AppendLine($"GridId: {LastTile.Grid}, Tile: {LastTile.Indices}");
-
-            for (var i = 0; i < message.Entities.Count; i++)
-            {
-                var uid = message.Entities[i];
-
-                if (!EntityManager.TryGetEntity(uid, out var entity)) continue;
-
-                text.AppendLine(entity.ToString());
-            }
-
-            _label.Text = text.ToString();
-        }
-
-        public override void FrameUpdate(float frameTime)
-        {
-            base.FrameUpdate(frameTime);
-            if (!Enabled) return;
-
-            var mousePos = _inputManager.MouseScreenPosition;
-            var worldPos = _eyeManager.ScreenToMap(mousePos);
-
-            GridId gridId;
-            Vector2i tile;
-
-            if (_mapManager.TryFindGridAt(worldPos, out var grid))
-            {
-                gridId = grid.Index;
-                tile = grid.WorldToTile(worldPos.Position);
-            }
-            else
-            {
-                gridId = GridId.Invalid;
-                tile = new Vector2i((int) MathF.Floor(worldPos.Position.X), (int) MathF.Floor(worldPos.Position.Y));
-            }
-
-            LayoutContainer.SetPosition(_label, mousePos.Position);
-
-            if ((gridId, tile).Equals(LastTile)) return;
-
-            _label.Text = null;
-            LastTile = (gridId, tile);
-            RequestEntities(gridId, tile);
-        }
-    }
-
-    internal sealed class RequestTileEntities : IConsoleCommand
-    {
-        public string Command => "tilelookup";
-        public string Description => "Used for debugging GridTileLookupSystem";
-        public string Help => $"{Command}";
-        public void Execute(IConsoleShell shell, string argStr, string[] args)
-        {
-            EntitySystem.Get<DebugGridTileLookupSystem>().Enabled ^= true;
-        }
-    }
-}
-#endif

Robust.Client/GameObjects/EntitySystems/DebugLightTreeSystem.cs

@@ -1,85 +0,0 @@
-#if DEBUG
-using Robust.Client.Graphics;
-using Robust.Shared.Enums;
-using Robust.Shared.GameObjects;
-using Robust.Shared.IoC;
-using Robust.Shared.Map;
-using Robust.Shared.Maths;
-
-namespace Robust.Client.GameObjects
-{
-    internal sealed class DebugLightTreeSystem : EntitySystem
-    {
-        private DebugLightOverlay? _lightOverlay;
-
-        public bool Enabled
-        {
-            get => _enabled;
-            set
-            {
-                if (_enabled == value) return;
-
-                _enabled = value;
-                var overlayManager = IoCManager.Resolve<IOverlayManager>();
-
-                if (_enabled)
-                {
-                    _lightOverlay = new DebugLightOverlay(
-                        IoCManager.Resolve<IEntityLookup>(),
-                        IoCManager.Resolve<IEyeManager>(),
-                        IoCManager.Resolve<IMapManager>(),
-                        Get<RenderingTreeSystem>());
-
-                    overlayManager.AddOverlay(_lightOverlay);
-                }
-                else
-                {
-                    overlayManager.RemoveOverlay(_lightOverlay!);
-                    _lightOverlay = null;
-                }
-            }
-        }
-
-        private bool _enabled;
-
-        private sealed class DebugLightOverlay : Overlay
-        {
-            private IEntityLookup _lookup;
-            private IEyeManager _eyeManager;
-            private IMapManager _mapManager;
-
-            private RenderingTreeSystem _tree;
-
-            public override OverlaySpace Space => OverlaySpace.WorldSpace;
-
-            public DebugLightOverlay(IEntityLookup lookup, IEyeManager eyeManager, IMapManager mapManager, RenderingTreeSystem tree)
-            {
-                _lookup = lookup;
-                _eyeManager = eyeManager;
-                _mapManager = mapManager;
-                _tree = tree;
-            }
-
-            protected internal override void Draw(in OverlayDrawArgs args)
-            {
-                var map = _eyeManager.CurrentMap;
-                if (map == MapId.Nullspace) return;
-
-                var viewport = _eyeManager.GetWorldViewbounds();
-                var worldBounds = viewport.CalcBoundingBox();
-
-                foreach (var tree in _tree.GetRenderTrees(map, viewport))
-                {
-                    foreach (var light in tree.LightTree)
-                    {
-                        var aabb = _lookup.GetWorldAabbFromEntity(light.Owner);
-                        if (!aabb.Intersects(worldBounds)) continue;
-
-                        args.WorldHandle.DrawRect(aabb, Color.Green.WithAlpha(0.1f));
-                    }
-                }
-            }
-        }
-    }
-}
-#endif

Robust.Client/GameObjects/EntitySystems/EyeUpdateSystem.cs

@@ -2,12 +2,10 @@
 using JetBrains.Annotations;
 using Robust.Client.Graphics;
 using Robust.Client.Physics;
-using Robust.Client.Player;
 using Robust.Shared.GameObjects;
 using Robust.Shared.Input;
 using Robust.Shared.Input.Binding;
 using Robust.Shared.IoC;
-using Robust.Shared.Map;
 using Robust.Shared.Maths;
 
 #nullable enable
@@ -22,12 +20,12 @@ namespace Robust.Client.GameObjects
     {
         // How fast the camera rotates in radians
         private const float CameraRotateSpeed = MathF.PI;
+        private const float CameraSnapTolerance = 0.01f;
 
-        [Dependency] private readonly IEyeManager _eyeManager = default!;
-        [Dependency] private readonly IMapManager _mapManager = default!;
-        [Dependency] private readonly IPlayerManager _playerManager = default!;
-
-        private bool _isLerping = false;
+#pragma warning disable 649, CS8618
+        // ReSharper disable once NotNullMemberIsNotInitialized
+        [Dependency] private readonly IEyeManager _eyeManager;
+#pragma warning restore 649, CS8618
 
         /// <inheritdoc />
         public override void Initialize()
@@ -57,9 +55,6 @@ namespace Robust.Client.GameObjects
         public override void FrameUpdate(float frameTime)
         {
             var currentEye = _eyeManager.CurrentEye;
-
-            // TODO: Content should have its own way of handling this. We should have a default behavior that they can overwrite.
-            /*
             var inputSystem = EntitySystemManager.GetEntitySystem<InputSystem>();
 
             var direction = 0;
@@ -79,23 +74,17 @@ namespace Robust.Client.GameObjects
                 currentEye.Rotation += CameraRotateSpeed * frameTime * direction;
                 currentEye.Rotation = currentEye.Rotation.Reduced();
             }
-            */
-
-            var playerTransform = _playerManager.LocalPlayer?.ControlledEntity?.Transform;
-
-            if (playerTransform == null) return;
-
-            var gridId = playerTransform.GridID;
-
-            var parent = gridId != GridId.Invalid && EntityManager.TryGetEntity(_mapManager.GetGrid(gridId).GridEntityId, out var gridEnt) ?
-                gridEnt.Transform
-                : _mapManager.GetMapEntity(playerTransform.MapID).Transform;
-
-            if (!_isLerping)
+            else
             {
-                // TODO: Detect parent change and start lerping
-                var parentRotation = parent.WorldRotation;
-                currentEye.Rotation = -parentRotation;
+                // snap to cardinal directions
+                var closestDir = currentEye.Rotation.GetCardinalDir().ToVec();
+                var currentDir = currentEye.Rotation.ToVec();
+
+                var dot = Vector2.Dot(closestDir, currentDir);
+                if (MathHelper.CloseTo(dot, 1, CameraSnapTolerance))
+                {
+                    currentEye.Rotation = closestDir.ToAngle();
+                }
             }
 
             foreach (var eyeComponent in EntityManager.ComponentManager.EntityQuery<EyeComponent>(true))

Robust.Client/GameObjects/EntitySystems/GridChunkBoundsDebugSystem.cs

@@ -1,86 +0,0 @@
-using Robust.Client.Graphics;
-using Robust.Shared.Enums;
-using Robust.Shared.GameObjects;
-using Robust.Shared.IoC;
-using Robust.Shared.Map;
-using Robust.Shared.Maths;
-using Robust.Shared.Utility;
-
-namespace Robust.Client.GameObjects
-{
-    public class GridChunkBoundsDebugSystem : EntitySystem
-    {
-        private GridChunkBoundsOverlay? _overlay;
-
-        public bool Enabled
-        {
-            get => _enabled;
-            set
-            {
-                if (_enabled == value) return;
-
-                _enabled = value;
-
-                if (_enabled)
-                {
-                    DebugTools.Assert(_overlay == null);
-                    _overlay = new GridChunkBoundsOverlay(
-                        IoCManager.Resolve<IEntityManager>(),
-                        IoCManager.Resolve<IEyeManager>(),
-                        IoCManager.Resolve<IMapManager>());
-
-                    IoCManager.Resolve<IOverlayManager>().AddOverlay(_overlay);
-                }
-                else
-                {
-                    IoCManager.Resolve<IOverlayManager>().RemoveOverlay(_overlay!);
-                    _overlay = null;
-                }
-            }
-        }
-
-        private bool _enabled;
-    }
-
-    internal sealed class GridChunkBoundsOverlay : Overlay
-    {
-        private readonly IEntityManager _entityManager;
-        private readonly IEyeManager _eyeManager;
-        private readonly IMapManager _mapManager;
-
-        public override OverlaySpace Space => OverlaySpace.WorldSpace;
-
-        public GridChunkBoundsOverlay(IEntityManager entManager, IEyeManager eyeManager, IMapManager mapManager)
-        {
-            _entityManager = entManager;
-            _eyeManager = eyeManager;
-            _mapManager = mapManager;
-        }
-
-        protected internal override void Draw(in OverlayDrawArgs args)
-        {
-            var currentMap = _eyeManager.CurrentMap;
-            var viewport = _eyeManager.GetWorldViewport();
-
-            foreach (var grid in _mapManager.FindGridsIntersecting(currentMap, viewport))
-            {
-                var gridEnt = _entityManager.GetEntity(grid.GridEntityId);
-
-                if (!_entityManager.ComponentManager.TryGetComponent<PhysicsComponent>(gridEnt.Uid, out var body)) continue;
-
-                var transform = body.GetTransform();
-
-                foreach (var fixture in body.Fixtures)
-                {
-                    for (var i = 0; i < fixture.Shape.ChildCount; i++)
-                    {
-                        var aabb = fixture.Shape.ComputeAABB(transform, i);
-
-                        args.WorldHandle.DrawRect(aabb, Color.Green.WithAlpha(0.2f));
-                        args.WorldHandle.DrawRect(aabb, Color.Red.WithAlpha(0.5f), false);
-                    }
-                }
-            }
-        }
-    }
-}

Robust.Client/GameObjects/EntitySystems/GridFixtureSystem.cs

@@ -1,9 +0,0 @@
-using Robust.Shared.GameObjects;
-
-namespace Robust.Client.GameObjects
-{
-    internal sealed class GridFixtureSystem : SharedGridFixtureSystem
-    {
-
-    }
-}

Robust.Client/GameObjects/EntitySystems/InputSystem.cs

@@ -173,24 +173,4 @@ namespace Robust.Client.GameObjects
             AttachedEntity = attachedEntity;
         }
     }
-
-    public class PlayerAttachedEvent : EntityEventArgs
-    {
-        public PlayerAttachedEvent(IEntity entity)
-        {
-            Entity = entity;
-        }
-
-        public IEntity Entity { get; }
-    }
-
-    public class PlayerDetachedEvent : EntityEventArgs
-    {
-        public PlayerDetachedEvent(IEntity entity)
-        {
-            Entity = entity;
-        }
-
-        public IEntity Entity { get; }
-    }
 }

Robust.Client/GameObjects/EntitySystems/MapSystem.cs

@@ -1,9 +0,0 @@
-using Robust.Shared.GameObjects;
-
-namespace Robust.Client.GameObjects
-{
-    internal sealed class MapSystem : SharedMapSystem
-    {
-
-    }
-}

Robust.Client/GameObjects/EntitySystems/PointLightSystem.cs

@@ -1,44 +0,0 @@
-using Robust.Client.ResourceManagement;
-using Robust.Shared.GameObjects;
-using Robust.Shared.IoC;
-using Robust.Shared.Map;
-
-namespace Robust.Client.GameObjects
-{
-    public sealed class PointLightSystem : SharedPointLightSystem
-    {
-        [Dependency] private readonly IResourceCache _resourceCache = default!;
-
-        public override void Initialize()
-        {
-            base.Initialize();
-            SubscribeLocalEvent<PointLightComponent, ComponentInit>(HandleInit);
-            SubscribeLocalEvent<PointLightComponent, ComponentRemove>(HandleRemove);
-        }
-
-        private void HandleInit(EntityUid uid, PointLightComponent component, ComponentInit args)
-        {
-            UpdateMask(component);
-        }
-
-        private void HandleRemove(EntityUid uid, PointLightComponent component, ComponentRemove args)
-        {
-            var ent = EntityManager.GetEntity(uid);
-            var map = ent.Transform.MapID;
-            // TODO: Just make this update the tree directly and not allocate
-            if (map != MapId.Nullspace)
-            {
-                EntityManager.EventBus.RaiseEvent(EventSource.Local,
-                    new RenderTreeRemoveLightEvent(component, map));
-            }
-        }
-
-        internal void UpdateMask(PointLightComponent component)
-        {
-            if (component._maskPath is not null)
-                component.Mask = _resourceCache.GetResource<TextureResource>(component._maskPath);
-            else
-                component.Mask = null;
-        }
-    }
-}

Robust.Client/GameObjects/EntitySystems/RenderingTreeSystem.cs

@@ -3,11 +3,8 @@ using System.Drawing;
 using System.Linq;
 using JetBrains.Annotations;
 using Robust.Client.Physics;
-using Robust.Shared;
-using Robust.Shared.Configuration;
 using Robust.Shared.GameObjects;
 using Robust.Shared.IoC;
-using Robust.Shared.Log;
 using Robust.Shared.Map;
 using Robust.Shared.Maths;
 using Robust.Shared.Physics;
@@ -21,44 +18,23 @@ namespace Robust.Client.GameObjects
     [UsedImplicitly]
     public sealed class RenderingTreeSystem : EntitySystem
     {
-        internal const string LoggerSawmill = "rendertree";
-
         // Nullspace is not indexed. Keep that in mind.
 
-        [Dependency] private readonly IMapManager _mapManager = default!;
+        [Dependency] private readonly IMapManagerInternal _mapManager = default!;
+
+        private readonly Dictionary<MapId, Dictionary<GridId, MapTrees>> _gridTrees = new();
 
         private readonly List<SpriteComponent> _spriteQueue = new();
         private readonly List<PointLightComponent> _lightQueue = new();
 
-        private HashSet<EntityUid> _checkedChildren = new();
-
-        /// <summary>
-        /// <see cref="CVars.MaxLightRadius"/>
-        /// </summary>
-        public float MaxLightRadius { get; private set; }
-
-        internal IEnumerable<RenderingTreeComponent> GetRenderTrees(MapId mapId, Box2Rotated worldBounds)
+        internal DynamicTree<SpriteComponent> GetSpriteTreeForMap(MapId map, GridId grid)
         {
-            if (mapId == MapId.Nullspace) yield break;
-
-            foreach (var grid in _mapManager.FindGridsIntersecting(mapId, worldBounds))
-            {
-                yield return EntityManager.GetEntity(grid.GridEntityId).GetComponent<RenderingTreeComponent>();
-            }
-
-            yield return _mapManager.GetMapEntity(mapId).GetComponent<RenderingTreeComponent>();
+            return _gridTrees[map][grid].SpriteTree;
         }
 
-        internal IEnumerable<RenderingTreeComponent> GetRenderTrees(MapId mapId, Box2 worldAABB)
+        internal DynamicTree<PointLightComponent> GetLightTreeForMap(MapId map, GridId grid)
         {
-            if (mapId == MapId.Nullspace) yield break;
-
-            foreach (var grid in _mapManager.FindGridsIntersecting(mapId, worldAABB))
-            {
-                yield return EntityManager.GetEntity(grid.GridEntityId).GetComponent<RenderingTreeComponent>();
-            }
-
-            yield return _mapManager.GetMapEntity(mapId).GetComponent<RenderingTreeComponent>();
+            return _gridTrees[map][grid].LightTree;
         }
 
         public override void Initialize()
@@ -70,65 +46,20 @@ namespace Robust.Client.GameObjects
             UpdatesAfter.Add(typeof(PhysicsSystem));
 
             _mapManager.MapCreated += MapManagerOnMapCreated;
+            _mapManager.MapDestroyed += MapManagerOnMapDestroyed;
             _mapManager.OnGridCreated += MapManagerOnGridCreated;
-
-            // Due to how recursion works, this must be done.
-            SubscribeLocalEvent<MoveEvent>(AnythingMoved);
+            _mapManager.OnGridRemoved += MapManagerOnGridRemoved;
 
             SubscribeLocalEvent<SpriteComponent, EntMapIdChangedMessage>(SpriteMapChanged);
+            SubscribeLocalEvent<SpriteComponent, MoveEvent>(SpriteMoved);
             SubscribeLocalEvent<SpriteComponent, EntParentChangedMessage>(SpriteParentChanged);
-            SubscribeLocalEvent<SpriteComponent, ComponentRemove>(RemoveSprite);
-            SubscribeLocalEvent<SpriteComponent, SpriteUpdateEvent>(HandleSpriteUpdate);
+            SubscribeLocalEvent<SpriteComponent, RenderTreeRemoveSpriteEvent>(RemoveSprite);
 
             SubscribeLocalEvent<PointLightComponent, EntMapIdChangedMessage>(LightMapChanged);
+            SubscribeLocalEvent<PointLightComponent, MoveEvent>(LightMoved);
             SubscribeLocalEvent<PointLightComponent, EntParentChangedMessage>(LightParentChanged);
             SubscribeLocalEvent<PointLightComponent, PointLightRadiusChangedEvent>(PointLightRadiusChanged);
             SubscribeLocalEvent<PointLightComponent, RenderTreeRemoveLightEvent>(RemoveLight);
-            SubscribeLocalEvent<PointLightComponent, PointLightUpdateEvent>(HandleLightUpdate);
-
-            SubscribeLocalEvent<RenderingTreeComponent, ComponentRemove>(HandleTreeRemove);
-
-            var configManager = IoCManager.Resolve<IConfigurationManager>();
-            configManager.OnValueChanged(CVars.MaxLightRadius, value => MaxLightRadius = value, true);
-        }
-
-        private void HandleLightUpdate(EntityUid uid, PointLightComponent component, PointLightUpdateEvent args)
-        {
-            if (component.TreeUpdateQueued) return;
-            QueueLightUpdate(component);
-        }
-
-        private void HandleSpriteUpdate(EntityUid uid, SpriteComponent component, SpriteUpdateEvent args)
-        {
-            if (component.TreeUpdateQueued) return;
-            QueueSpriteUpdate(component);
-        }
-
-        private void AnythingMoved(ref MoveEvent args)
-        {
-            AnythingMovedSubHandler(args.Sender.Transform);
-        }
-
-        private void AnythingMovedSubHandler(ITransformComponent sender)
-        {
-            // To avoid doing redundant updates (and we don't need to update a grid's children ever)
-            if (!_checkedChildren.Add(sender.Owner.Uid) ||
-                sender.Owner.HasComponent<RenderingTreeComponent>()) return;
-
-            // This recursive search is needed, as MoveEvent is defined to not care about indirect events like children.
-            // WHATEVER YOU DO, DON'T REPLACE THIS WITH SPAMMING EVENTS UNLESS YOU HAVE A GUARANTEE IT WON'T LAG THE GC.
-            // (Struct-based events ok though)
-            // Ironically this was lagging the GC lolz
-            if (sender.Owner.TryGetComponent(out SpriteComponent? sprite))
-                QueueSpriteUpdate(sprite);
-
-            if (sender.Owner.TryGetComponent(out PointLightComponent? light))
-                QueueLightUpdate(light);
-
-            foreach (ITransformComponent child in sender.Children)
-            {
-                AnythingMovedSubHandler(child);
-            }
         }
 
         // For the RemoveX methods
@@ -142,22 +73,33 @@ namespace Robust.Client.GameObjects
             QueueSpriteUpdate(component);
         }
 
-        private void SpriteParentChanged(EntityUid uid, SpriteComponent component, ref EntParentChangedMessage args)
+        private void SpriteMoved(EntityUid uid, SpriteComponent component, MoveEvent args)
         {
             QueueSpriteUpdate(component);
         }
 
-        private void RemoveSprite(EntityUid uid, SpriteComponent component, ComponentRemove args)
+        private void SpriteParentChanged(EntityUid uid, SpriteComponent component, EntParentChangedMessage args)
+        {
+            QueueSpriteUpdate(component);
+        }
+
+        private void RemoveSprite(EntityUid uid, SpriteComponent component, RenderTreeRemoveSpriteEvent args)
         {
             ClearSprite(component);
         }
 
         private void ClearSprite(SpriteComponent component)
         {
-            if (component.RenderTree == null) return;
+            if (_gridTrees.TryGetValue(component.IntersectingMapId, out var gridTrees))
+            {
+                foreach (var gridId in component.IntersectingGrids)
+                {
+                    if (!gridTrees.TryGetValue(gridId, out var tree)) continue;
+                    tree.SpriteTree.Remove(component);
+                }
+            }
 
-            component.RenderTree.SpriteTree.Remove(component);
-            component.RenderTree = null;
+            component.IntersectingGrids.Clear();
         }
 
         private void QueueSpriteUpdate(SpriteComponent component)
@@ -166,6 +108,22 @@ namespace Robust.Client.GameObjects
 
             component.TreeUpdateQueued = true;
             _spriteQueue.Add(component);
+
+            foreach (var child in component.Owner.Transform.Children)
+            {
+                QueueSpriteUpdate(child.Owner);
+            }
+        }
+
+        private void QueueSpriteUpdate(IEntity entity)
+        {
+            if (!entity.TryGetComponent(out SpriteComponent? spriteComponent)) return;
+            QueueSpriteUpdate(spriteComponent);
+
+            foreach (var child in entity.Transform.Children)
+            {
+                QueueSpriteUpdate(child.Owner);
+            }
         }
         #endregion
 
@@ -175,7 +133,12 @@ namespace Robust.Client.GameObjects
             QueueLightUpdate(component);
         }
 
-        private void LightParentChanged(EntityUid uid, PointLightComponent component, ref EntParentChangedMessage args)
+        private void LightMoved(EntityUid uid, PointLightComponent component, MoveEvent args)
+        {
+            QueueLightUpdate(component);
+        }
+
+        private void LightParentChanged(EntityUid uid, PointLightComponent component, EntParentChangedMessage args)
         {
             QueueLightUpdate(component);
         }
@@ -192,10 +155,16 @@ namespace Robust.Client.GameObjects
 
         private void ClearLight(PointLightComponent component)
         {
-            if (component.RenderTree == null) return;
+            if (_gridTrees.TryGetValue(component.IntersectingMapId, out var gridTrees))
+            {
+                foreach (var gridId in component.IntersectingGrids)
+                {
+                    if (!gridTrees.TryGetValue(gridId, out var tree)) continue;
+                    tree.LightTree.Remove(component);
+                }
+            }
 
-            component.RenderTree.LightTree.Remove(component);
-            component.RenderTree = null;
+            component.IntersectingGrids.Clear();
         }
 
         private void QueueLightUpdate(PointLightComponent component)
@@ -204,6 +173,22 @@ namespace Robust.Client.GameObjects
 
             component.TreeUpdateQueued = true;
             _lightQueue.Add(component);
+
+            foreach (var child in component.Owner.Transform.Children)
+            {
+                QueueLightUpdate(child.Owner);
+            }
+        }
+
+        private void QueueLightUpdate(IEntity entity)
+        {
+            if (!entity.TryGetComponent(out PointLightComponent? lightComponent)) return;
+            QueueLightUpdate(lightComponent);
+
+            foreach (var child in entity.Transform.Children)
+            {
+                QueueLightUpdate(child.Owner);
+            }
         }
         #endregion
 
@@ -211,23 +196,31 @@ namespace Robust.Client.GameObjects
         {
             base.Shutdown();
             _mapManager.MapCreated -= MapManagerOnMapCreated;
+            _mapManager.MapDestroyed -= MapManagerOnMapDestroyed;
             _mapManager.OnGridCreated -= MapManagerOnGridCreated;
+            _mapManager.OnGridRemoved -= MapManagerOnGridRemoved;
         }
 
-        private void HandleTreeRemove(EntityUid uid, RenderingTreeComponent component, ComponentRemove args)
+        private void MapManagerOnMapDestroyed(object? sender, MapEventArgs e)
         {
-            foreach (var sprite in component.SpriteTree)
+            foreach (var (_, gridTree) in _gridTrees[e.Map])
             {
-                sprite.RenderTree = null;
+                foreach (var comp in gridTree.LightTree)
+                {
+                    comp.IntersectingGrids.Clear();
+                }
+
+                foreach (var comp in gridTree.SpriteTree)
+                {
+                    comp.IntersectingGrids.Clear();
+                }
+
+                // Just in case?
+                gridTree.LightTree.Clear();
+                gridTree.SpriteTree.Clear();
             }
 
-            foreach (var light in component.LightTree)
-            {
-                light.RenderTree = null;
-            }
-
-            component.SpriteTree.Clear();
-            component.LightTree.Clear();
+            _gridTrees.Remove(e.Map);
         }
 
         private void MapManagerOnMapCreated(object? sender, MapEventArgs e)
@@ -237,124 +230,166 @@ namespace Robust.Client.GameObjects
                 return;
             }
 
-            _mapManager.GetMapEntity(e.Map).EnsureComponent<RenderingTreeComponent>();
+            _gridTrees.Add(e.Map, new Dictionary<GridId, MapTrees>
+            {
+                {GridId.Invalid, new MapTrees()}
+            });
         }
 
         private void MapManagerOnGridCreated(MapId mapId, GridId gridId)
         {
-            EntityManager.GetEntity(_mapManager.GetGrid(gridId).GridEntityId).EnsureComponent<RenderingTreeComponent>();
+            _gridTrees[mapId].Add(gridId, new MapTrees());
         }
 
-        internal static RenderingTreeComponent? GetRenderTree(IEntity entity)
+        private void MapManagerOnGridRemoved(MapId mapId, GridId gridId)
         {
-            if (entity.Transform.MapID == MapId.Nullspace ||
-                entity.HasComponent<RenderingTreeComponent>()) return null;
+            var gridTree = _gridTrees[mapId][gridId];
 
-            var parent = entity.Transform.Parent?.Owner;
-
-            while (true)
+            foreach (var sprite in gridTree.SpriteTree)
             {
-                if (parent == null) break;
-
-                if (parent.TryGetComponent(out RenderingTreeComponent? comp)) return comp;
-                parent = parent.Transform.Parent?.Owner;
+                sprite.IntersectingGrids.Remove(gridId);
             }
 
-            return null;
-        }
+            foreach (var light in gridTree.LightTree)
+            {
+                light.IntersectingGrids.Remove(gridId);
+            }
 
-        private bool IsVisible(SpriteComponent component)
-        {
-            return component.Visible && !component.ContainerOccluded;
+            // Clear in case
+            gridTree.LightTree.Clear();
+            gridTree.SpriteTree.Clear();
+            _gridTrees[mapId].Remove(gridId);
         }
 
         public override void FrameUpdate(float frameTime)
         {
-            _checkedChildren.Clear();
-
             foreach (var sprite in _spriteQueue)
             {
-                sprite.TreeUpdateQueued = false;
-                if (!IsVisible(sprite))
-                {
-                    ClearSprite(sprite);
-                    continue;
-                }
-
-                var oldMapTree = sprite.RenderTree;
-                var newMapTree = GetRenderTree(sprite.Owner);
-                // TODO: Temp PVS guard
-                var worldPos = sprite.Owner.Transform.WorldPosition;
-
-                if (float.IsNaN(worldPos.X) || float.IsNaN(worldPos.Y))
-                {
-                    ClearSprite(sprite);
-                    continue;
-                }
-
-                var aabb = RenderingTreeComponent.SpriteAabbFunc(sprite, worldPos);
+                var mapId = sprite.Owner.Transform.MapID;
 
                 // If we're on a new map then clear the old one.
-                if (oldMapTree != newMapTree)
+                if (sprite.IntersectingMapId != mapId)
                 {
                     ClearSprite(sprite);
-                    newMapTree?.SpriteTree.Add(sprite, aabb);
-                }
-                else
-                {
-                    newMapTree?.SpriteTree.Update(sprite, aabb);
                 }
 
-                sprite.RenderTree = newMapTree;
+                sprite.IntersectingMapId = mapId;
+
+                if (mapId == MapId.Nullspace) continue;
+
+                var mapTree = _gridTrees[mapId];
+                var aabb = MapTrees.SpriteAabbFunc(sprite);
+                var intersectingGrids = _mapManager.FindGridIdsIntersecting(mapId, aabb, true).ToList();
+
+                // Remove from old
+                foreach (var gridId in sprite.IntersectingGrids)
+                {
+                    if (intersectingGrids.Contains(gridId)) continue;
+                    mapTree[gridId].SpriteTree.Remove(sprite);
+                }
+
+                // Rebuild in the update below
+                sprite.IntersectingGrids.Clear();
+
+                // Update / add to new
+                foreach (var gridId in intersectingGrids)
+                {
+                    var translated = aabb.Translated(gridId == GridId.Invalid
+                        ? Vector2.Zero
+                        : -_mapManager.GetGrid(gridId).WorldPosition);
+
+                    mapTree[gridId].SpriteTree.AddOrUpdate(sprite, translated);
+
+                    sprite.IntersectingGrids.Add(gridId);
+                }
+
+                sprite.TreeUpdateQueued = false;
             }
 
             foreach (var light in _lightQueue)
             {
-                light.TreeUpdateQueued = false;
-
-                if (!light.Enabled || light.ContainerOccluded)
-                {
-                    ClearLight(light);
-                    continue;
-                }
-
-                var oldMapTree = light.RenderTree;
-                var newMapTree = GetRenderTree(light.Owner);
-                // TODO: Temp PVS guard
-                var worldPos = light.Owner.Transform.WorldPosition;
-
-                if (float.IsNaN(worldPos.X) || float.IsNaN(worldPos.Y))
-                {
-                    ClearLight(light);
-                    continue;
-                }
-
-                // TODO: Events need a bit of cleanup so we only validate this on initialize and radius changed events
-                // this is fine for now IMO as it's 1 float check for every light that moves
-                if (light.Radius > MaxLightRadius)
-                {
-                    Logger.WarningS(LoggerSawmill, $"Light radius for {light.Owner} set above max radius of {MaxLightRadius}. This may lead to pop-in.");
-                }
-
-                var aabb = RenderingTreeComponent.LightAabbFunc(light, worldPos);
+                var mapId = light.Owner.Transform.MapID;
 
                 // If we're on a new map then clear the old one.
-                if (oldMapTree != newMapTree)
+                if (light.IntersectingMapId != mapId)
                 {
                     ClearLight(light);
-                    newMapTree?.LightTree.Add(light, aabb);
-                }
-                else
-                {
-                    newMapTree?.LightTree.Update(light, aabb);
                 }
 
-                light.RenderTree = newMapTree;
+                light.IntersectingMapId = mapId;
+
+                if (mapId == MapId.Nullspace) continue;
+
+                var mapTree = _gridTrees[mapId];
+                var aabb = MapTrees.LightAabbFunc(light);
+                var intersectingGrids = _mapManager.FindGridIdsIntersecting(mapId, aabb, true).ToList();
+
+                // Remove from old
+                foreach (var gridId in intersectingGrids)
+                {
+                    if (intersectingGrids.Contains(gridId)) continue;
+                    mapTree[gridId].LightTree.Remove(light);
+                }
+
+                // Rebuild in the update below
+                light.IntersectingGrids.Clear();
+
+                // Update / add to new
+                foreach (var gridId in intersectingGrids)
+                {
+                    var translated = aabb.Translated(gridId == GridId.Invalid
+                        ? Vector2.Zero
+                        : -_mapManager.GetGrid(gridId).WorldPosition);
+
+                    mapTree[gridId].LightTree.AddOrUpdate(light, translated);
+                    light.IntersectingGrids.Add(gridId);
+                }
+
+                light.TreeUpdateQueued = false;
             }
 
             _spriteQueue.Clear();
             _lightQueue.Clear();
         }
+
+        private sealed class MapTrees
+        {
+            public readonly DynamicTree<SpriteComponent> SpriteTree;
+            public readonly DynamicTree<PointLightComponent> LightTree;
+
+            public MapTrees()
+            {
+                SpriteTree = new DynamicTree<SpriteComponent>(SpriteAabbFunc);
+                LightTree = new DynamicTree<PointLightComponent>(LightAabbFunc);
+            }
+
+            internal static Box2 SpriteAabbFunc(in SpriteComponent value)
+            {
+                var worldPos = value.Owner.Transform.WorldPosition;
+
+                return new Box2(worldPos, worldPos);
+            }
+
+            internal static Box2 LightAabbFunc(in PointLightComponent value)
+            {
+                var worldPos = value.Owner.Transform.WorldPosition;
+
+                var boxSize = value.Radius * 2;
+                return Box2.CenteredAround(worldPos, (boxSize, boxSize));
+            }
+        }
+    }
+
+    internal class RenderTreeRemoveSpriteEvent : EntityEventArgs
+    {
+        public RenderTreeRemoveSpriteEvent(SpriteComponent sprite, MapId map)
+        {
+            Sprite = sprite;
+            Map = map;
+        }
+
+        public SpriteComponent Sprite { get; }
+        public MapId Map { get; }
     }
 
     internal class RenderTreeRemoveLightEvent : EntityEventArgs

Robust.Client/GameObjects/EntitySystems/SpriteSystem.cs

@@ -1,9 +1,9 @@
-using System.Collections.Generic;
-using JetBrains.Annotations;
+using JetBrains.Annotations;
 using Robust.Client.Graphics;
 using Robust.Shared.GameObjects;
 using Robust.Shared.IoC;
 using Robust.Shared.Map;
+using Robust.Shared.Maths;
 
 namespace Robust.Client.GameObjects
 {
@@ -14,31 +14,22 @@ namespace Robust.Client.GameObjects
     public class SpriteSystem : EntitySystem
     {
         [Dependency] private readonly IEyeManager _eyeManager = default!;
-        [Dependency] private readonly RenderingTreeSystem _treeSystem = default!;
+        [Dependency] private readonly IMapManager _mapManager = default!;
 
-        private readonly Queue<SpriteComponent> _inertUpdateQueue = new();
+        private RenderingTreeSystem _treeSystem = default!;
 
         public override void Initialize()
         {
             base.Initialize();
-
-            SubscribeLocalEvent<SpriteUpdateInertEvent>(QueueUpdateInert);
-        }
-
-        private void QueueUpdateInert(SpriteUpdateInertEvent ev)
-        {
-            _inertUpdateQueue.Enqueue(ev.Sprite);
+            _treeSystem = Get<RenderingTreeSystem>();
         }
 
         /// <inheritdoc />
         public override void FrameUpdate(float frameTime)
         {
-            while (_inertUpdateQueue.TryDequeue(out var sprite))
-            {
-                sprite.DoUpdateIsInert();
-            }
-
-            var pvsBounds = _eyeManager.GetWorldViewbounds();
+            // So we could calculate the correct size of the entities based on the contents of their sprite...
+            // Or we can just assume that no entity is larger than 10x10 and get a stupid easy check.
+            var pvsBounds = _eyeManager.GetWorldViewport().Enlarged(5);
 
             var currentMap = _eyeManager.CurrentMap;
             if (currentMap == MapId.Nullspace)
@@ -46,11 +37,13 @@ namespace Robust.Client.GameObjects
                 return;
             }
 
-            foreach (var comp in _treeSystem.GetRenderTrees(currentMap, pvsBounds))
+            foreach (var gridId in _mapManager.FindGridIdsIntersecting(currentMap, pvsBounds, true))
             {
-                var bounds = comp.Owner.Transform.InvWorldMatrix.TransformBox(pvsBounds);
+                var gridBounds = gridId == GridId.Invalid ? pvsBounds : pvsBounds.Translated(-_mapManager.GetGrid(gridId).WorldPosition);
 
-                comp.SpriteTree.QueryAabb(ref frameTime, (ref float state, in SpriteComponent value) =>
+                var mapTree = _treeSystem.GetSpriteTreeForMap(currentMap, gridId);
+
+                mapTree.QueryAabb(ref frameTime, (ref float state, in SpriteComponent value) =>
                 {
                     if (value.IsInert)
                     {
@@ -59,7 +52,7 @@ namespace Robust.Client.GameObjects
 
                     value.FrameUpdate(state);
                     return true;
-                }, bounds, true);
+                }, gridBounds, approx: true);
             }
         }
     }