space-wizards/RobustToolbox
1
0
Fork 0
mirror of https://github.com/space-wizards/RobustToolbox.git synced 2026-09-15 14:52:35 +02:00
Code Issues Packages Projects Releases Wiki Activity
9,929 Commits 58 Branches 1,291 Tags
v271.2.1
Commit Graph
308 Commits
Author SHA1 Message Date
PJB3005 65b8d0cce2 Add network serialization float NaN sanitization 
Apparently cheat clients have figured out that none of SS14's code does validation against NaN inputs. Uh oh.

IRobustSerializer can now be configured to remove NaN values when reading. This is intended to be set on the server to completely block the issue.

Added "Unsafe" float types that can be used to bypass the new configurable behavior, in case somebody *really* needs NaNs.

An alternative option was to make a "SafeFloat" type, and only apply the sanitization to that. The problem is that would require updating hundreds if not thousands of messages in SS14, and probably significantly confuse contributors on "when use what." Blocking NaNs by default is likely to cause little issues while ensuring the entire exploit is guaranteed impossible.
 2026-01-25 03:45:50 +01:00
PJB3005 e308b89fe6 Log string map size 2025-12-22 17:56:16 +01:00
PJB3005 bb81d88653 Add [NotContentImplementable] to shared interfaces 2025-12-20 16:49:35 +01:00
PJB3005 ddfa12808c Fix some roslyn tests 2025-12-17 16:55:33 +01:00
slarticodefastGitHubMoonyPJB3005
 		4747e5a05a Add and update a lot of documentation (#6337) 
* Serialization docs

Co-authored-by: Moony <moonheart08@users.noreply.github.com>

* ECS docs

Co-authored-by: Moony <moonheart08@users.noreply.github.com>

* scattered docs

Co-authored-by: Moony <moonheart08@users.noreply.github.com>

* Fixes

---------

Co-authored-by: Moony <moonheart08@users.noreply.github.com>
Co-authored-by: PJB3005 <pieterjan.briers+git@gmail.com>
 2025-12-15 20:26:17 +01:00
Pieter-Jan BriersandGitHub d161c3b3b8 Add FormattedString type (#6339) 
This is basically a lightweight marker type saying "this string contains markup". Intended to avoid injection accidents if people don't realize they should escape stuff.
 2025-12-15 19:36:16 +01:00
PJB3005 fe35a24e88 Basic prototype string interning 
From my extremely rough and unscientific tests, this saves like 15 MB of client memory on the main menu. Probably also just improves load speed on startup too.

It's per file to keep the implementation simple.
 2025-12-09 12:31:50 +01:00
PJB3005 6bbeaeeba6 Fix NetBitArraySerializer compatibility. 
Apparently NetSerializer treats IDynamicTypeSerializer and IStaticTypeSerializer differently for sealed types??
 2025-12-02 00:51:04 +01:00
PJB3005 b267cd6fb4 Actually add NetBitArraySerializer to RobustSerializer 
oops

#6301
 2025-11-15 18:46:01 +01:00
PJB3005 83ad6042a7 Fix BitArray serialization for .NET 10 
Fixes #6301
 2025-11-15 18:41:43 +01:00
Leon FriedrichGitHubmetalgearsloth
 		8b7fbfa646 Add two new custom yaml serializers (#6253) 
* Add two new custom yaml serializers

* make ComponentNameSerializer ignore ignored components

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
 2025-10-27 23:05:46 +11:00
Leon FriedrichandGitHub 912b6da20a Fix serialization of data-records with get-only properties (#6204) 
* Fix serialization of data-records with get-only properties

* even less nesting

* asserts
 2025-09-17 19:11:12 +02:00
Pieter-Jan BriersandGitHub f02cd0083a Make SpriteSpecifier.Texture fail validation if it contains ".rsi" (#6155) 
No pointing to PNGs inside RSIs.
 2025-09-02 22:05:13 +02:00
JohnandGitHub fb0ec52f8c Fix TimeSpan overflow on Read (#6170) 
A lot of areas use TimeSpan.MaxValue but when saved and read the current time is added which results in an overflow.
A check is now performed to prevent this.
 2025-08-30 00:59:39 +02:00
PGrayandGitHub 23c90c0c45 Serialization: Make null literal check culture-invariant (#6136) 
Use StringComparison.OrdinalIgnoreCase instead of ToLower() to avoid culture-sensitive casing issues (e.g., Turkish-i) when detecting YAML null literals.
 2025-08-12 13:28:30 +02:00
Pieter-Jan BriersandGitHub dcbe0505dc Revert "Add WeakEntityReference (#5577)" (#6112) 
This reverts commit c3489d4ded.
 2025-07-29 18:22:17 +02:00
Leon FriedrichGitHubTayrtahn
 		c3489d4ded Add WeakEntityReference (#5577) 
* Add WeakEntityReference

* Use NetEntity

* release notes

* A

* Fix merge conflicts

* comments

* A

* Add network serialization test

* Add ToPrettyString support for WeakEntityReference?

* inheritdoc

* Add GetWeakReference methods

* Not-nullable too

* Make EntitySystem proxy method signatures match EntityManager

* Add TryGetEntity

* interface

* fix test

* De-ref GetWeakReference methods

---------

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
 2025-07-29 11:12:49 -04:00
Pieter-Jan BriersandGitHub cdd3afaa4c Remove redundant custom math types (#6078) 
Vector3, Vector4, Matrix4, and Quaternion are now gone. Use System.Numerics instead.

This commit is just replacing usages, cleaning up using declarations, and moving over the (couple) helpers that are actually important.
 2025-07-23 01:15:27 +02:00
NemanjaandGitHub ceeb002692 Mark ValidatePrototypeIdAttribute as obsolete (#6062) 2025-07-12 15:20:08 +02:00
ErrantGitHubPJB3005
 		4851e913b0 More TimespanSerializer improvements (#5910) 
* improved public TryTimeSpan

* don't want any locale shenanigans or misconceptions with the input

* missed a test line

* also support capitalized time unit indicators

* Doesn't need to be nullable.

---------

Co-authored-by: PJB3005 <pieterjan.briers+git@gmail.com>
 2025-07-11 20:37:39 +02:00
TayrtahnandGitHub a45b72a1c5 IRobustCloneable and generator support (#5692) 
* Add IRobustCloneable and check for it in compnet generator.

* Redo compnetgenerator support; add test

* Disconnect client at end of test

* Actually test for client entities

* Cleanup

* Cleanup 2
 2025-06-27 20:37:43 +02:00
Pieter-Jan BriersGitHubTayrtahn
 		c73b54862e Add analyzers to detect some prototype misuse (#6048) 
* Add analyzers to detect some prototype misuse

Detects people marking prototype as NetSerializable.

Detects people creating new prototype instances themselves.

* Update Robust.Analyzers/PrototypeNetSerializableAnalyzer.cs

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>

---------

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
 2025-06-26 22:24:23 +02:00
PJB3005 c152fb8953 Fix culture-based parsing in TimespanSerializer 2025-06-17 16:03:20 +02:00
TayrtahnandGitHub fa6bd8f7ba Cleanup TypeSerializer Logger warnings (#5966) 2025-05-24 20:23:28 +02:00
Leon FriedrichGitHubmetalgearslothmetalgearsloth
 		15d5b9aa02 Move parts of SpriteComponent to SpriteSystem (#5602) 
* Partial sprite component ECS

* release notes

* tests

* Why

* SetSnapCardinals

* NoRotation

* DirectionOverride

* This is why I love distinct overrides that take in object

* LayerSetData

* ISerializationHooks continue to haunt me

* Relocate SetShader

* LayerSetSprite

* LayerSetTexture

* yipeeeee

* LayerSetRsi

* Remove GetFallbackState

* LayerSet Scale,Rotation,Color,Visible

* Fix LayerSetRsi

* LayerSetOffset

* LayerSetDirOffset

* Add overrides that take in a Layer

* LayerSetAnimationTime

* LayerSetRenderingStrategy

* Reduce Resolves, Add Layer.Index

* Access

* Try fix NREs

* Asserts

* LayerGetState

* Cleanup

* Merge helper partial classes

* partial rendering

* GetLayerDirectionCount

* Cache local bounds

* RenderLayer

* RefreshCachedState

* RoundToCardinalAngle

* Fix the pr

* Fix debug assert

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
 2025-05-10 21:56:53 +10:00
Leon FriedrichandGitHub d24854d94f Improve yaml validation errors for ignored prototypes (#5886) 
* Improve yaml validation errors for ignored prototypes

* release notes

* Comments
 2025-05-10 21:37:42 +10:00
ErrantGitHubPieter-Jan Briers
 		eb5ed12270 Serialize TimeSpan from text (#5865) 
* timespanserializer cleanup

* string reading

* high speed, low drag

* unit tests

* Update Robust.Shared/Serialization/TypeSerializers/Implementations/TimespanSerializer.cs

---------

Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
 2025-05-05 00:57:01 +02:00
dffdff2423andGitHub 8905a3fe14 Add documentation to the serializer interfaces and remove ITypeReaderWriter (#5897) 
* Add documentation to the serializer interfaces

* Remove ITypeReaderWriter and fix the docs

* Fix spelling errors and incorrect docstrings
 2025-05-04 04:03:17 +02:00
Leon FriedrichandGitHub 2f8f4f2f7a Make MappingDataNode use string keys (#5783) 
* string keys

* obsoletions

* Fix ValueTupleSerializer

* Release notes

* fix release note conflict

* cleanup

* Fix yaml validator & tests

* cleanup release notes

* a

* enumerator allocations

* Also sequence enumerator alloc
 2025-04-18 19:01:34 +10:00
Leon FriedrichandGitHub 3800c5707e Add new SerializationManager.PushComposition overload (#5785) 2025-04-12 12:58:40 +10:00
DrSmugleafandGitHub 9f73e0398a Make MappingDataNode.Equals take 2952 times less time to run when loading maps (#5781) 2025-03-27 12:52:29 +11:00
metalgearslothandGitHub 56eae5ad08 Reduce EntityManager.IsDefault allocations (#5741) 
* Reduce EntityManager.IsDefault allocations

We don't actually need the MappingDataNode so we can avoid allocating the entire class per entity.

* Adjust this order
 2025-03-12 19:42:08 +11:00
Leon FriedrichGitHubmetalgearsloth
 		fbc706f37b Refactor map loading & saving (#5572) 
* Refactor map loading & saving

* test fixes

* ISerializationManager tweaks

* Fix component composition

* Try fix entity deserialization component composition

* comments

* CL

* error preinit

* a

* cleanup

* error if version is too new

* Add AlwaysPushSerializationTest

* Add auto-inclusion test

* Better categorization

* Combine test components

* Save -> TrySave

Also better handling for saving multiple entities individually

* Create new partial class for map loading

* Add OrphanSerializationTest

* Include MapIds in BeforeSerializationEvent

* Addd LifetimeSerializationTest

* Add TestMixedLifetimeSerialization

* Add CategorizationTest

* explicitly serialize list of nullspace entities

* Add backwards compatibility test

* Version comments

also fixes wrong v4 format

* add MapMergeTest

* Add NetEntity support

* Optimize EntityDeserializer

Avoid unnecessary component deserialization

* fix assert & other bugs

* fucking containers strike again

* Fix deletion of pre-init entities

* fix release note merge conflict

* Update Robust.Shared/Map/MapManager.GridCollection.cs

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* VV

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
 2025-02-16 21:25:07 +11:00
metalgearslothandGitHub ea1cc5e446 Planet lighting pre-reqs (#5490) 
* Add another lookup overload

* Fix RenderInRenderTarget

See the linked issue for what happens.

* Also this one

* stuff

* Fix stencilling

* fixes

* mix blend

* fix

* blur fixes

* Tile flag

* Minor tweak

* Fixes

* Render state fixes

* Fixes

* Fix stupidity

* More state render bug fixes

* MapUid on overlay draw

* Remove blur comment

* Fixes

* Fixes

* Remove

* Engine vibe
 2025-02-16 19:29:32 +11:00
Leon FriedrichandGitHub afaef645b0 Fix MappingDataNode.TryAddCopy() (#5677) 2025-02-14 14:10:13 +11:00
Leon FriedrichandGitHub bdef9e3401 Fix reloading prototypes with AlwaysPushInheritance (#5612) 2025-01-31 15:38:13 +11:00
PJB3005 eaaa70437a Reduce DynamicMethod use in Serv3 
Data definitions created individual read/write methods for every single field that can be serialized. This was extremely inefficient and likely caused lots of overhead.

These methods are necessary because, in some cases, we can't directly use expression trees to write fields. But... we can still do it most of the time! So now for most data fields we can avoid a DynamicMethod entirely.
 2025-01-16 15:10:35 +01:00
Pieter-Jan BriersandGitHub dfc4894c8b Dependencies update & cleanup (#5590) 
* Dependencies update & cleanup

Fixes security vuln warnings etc

* Remove ILReader dependency

RIP in piss FastAccessors.
 2025-01-08 02:19:27 +01:00
Leon FriedrichandGitHub 80dbf02af4 Log errors when encountering entity data fields (#5578) 
* Log errors when encountering entity data fields

* Cleanup & comments

* Remove unnecessary GetGenericTypeDefinition
 2025-01-07 16:54:25 +01:00
metalgearslothGitHubElectroJr
 		9837c33de7 Add sourcegenned field deltas (#5155) 
* Remove full "delta" states

* Update MapGridComponentState

* abstract ComponentState

* Release notes

* Fix tests

* Fix nullable errors

* A

* Sourcegen component deltas

* Audio deltas + methids

* Also eye

* Optimise out the dictionary

* Minor fixes

* Physics deltas

* Also this

* Fix field deltas

* remove old release notes

* Make IComponentDelta implement IComponent

* add sourcegen launch settings

* make silent error loud

* Review

* UI deltas

* Slimmer

* Sourcegen bandaid

---------

Co-authored-by: ElectroJr <leonsfriedrich@gmail.com>
 2024-12-21 15:48:33 +11:00
Pieter-Jan Briers c83c6f9592 Fix RobustSerializer breaking for non-seekable streams. 
Shows up in replay loading from zip files, as the stream may be compressed. The statistics code in RobustSerializer assumes the stream is always seekable (by accessing .Position).

Now we don't run the statistics logic when reading/writing non-seekable-streams.
 2024-10-10 04:31:37 +02:00
Pieter-Jan BriersandGitHub b1e1a0cd88 Quick warning fixes (#5417) 2024-09-01 04:54:28 +02:00
SlamBamActionmanandGitHub e5995d4edc Add ObjectSerializer, AppearanceComponent.AppearanceDataInit, and AppearanceSystem.AppendData (#5324) 
* V1 commit

* V2 Commit, ObjectSerializer

* Make sure write for objects have the !type:<T> set

* Added AppearanceDataInit

* Change to AppearanceDataInit setting to AppearanceData the moment it itself gets set; ComponentInit is too late. Forgive me sloth.

* RELEASE-NOTES.md

* Fix release notes

* Fix release-notes for realsies
 2024-08-28 22:43:58 +10:00
metalgearslothandGitHub 679c31199d Add comments to sermanager attributes (#5384) 
I always forget which is which.
 2024-08-25 20:02:31 +10:00
Pieter-Jan BriersandGitHub 7fbcfeaa8f Warning fixes (#5275) 
* Warning fixes in Robust.Shared

* Robust.Client warning fixes

* Fix test failure

Test failures were due to broken system registrations for the client RobustUnitTest. It was accidentally registering some server systems, which means DebugPhysicsSystem wasn't gettings its dependencies properly.

Fixing this meant pulling half a dozen extra dependencies that client ContainerSystem and TransformSystem are supposed to have, but didn't.
 2024-07-10 01:38:32 +02:00
Leon FriedrichandGitHub f285c62674 Rework entity prototype categories (#5061) 
* Improve entity categories

* A
 2024-06-02 14:10:11 +10:00
eoineoineoinandGitHub 56c30edf04 Replace Matrix3 with System.Numerics.Matrix3x2 (#5078) 
* Delete Matrix3. Replace with System.Numerics.Matrix3x2

* Feedback

* release notes
 2024-06-02 14:08:47 +10:00
TayrtahnandGitHub da7abc6580 Add analyzer and fixer for redundant DataField tag arguments (#5134) 
* Add analyzer and fixer for redundant DataField tag arguments

* Share Tag autogeneration logic
 2024-05-17 07:44:03 +02:00
AmyGitHubamylizzle
 		41c40f1a94 Fix checking wrong property in TryGetVariableType() (#5120) 
Co-authored-by: amylizzle <amylizzle@users.noreply.github.com>
 2024-05-14 08:44:19 +10:00
AmyGitHubamylizzle
 		ccbb6ddec7 Add method for getting type of var (#5070) 
Co-authored-by: amylizzle <amylizzle@users.noreply.github.com>
 2024-05-06 20:39:32 +02:00