space-wizards/RobustToolbox
1
0
Fork 0
mirror of https://github.com/space-wizards/RobustToolbox.git synced 2026-02-15 03:30:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup TypeSerializer Logger warnings (#5966)

Browse Source
This commit is contained in:
Tayrtahn
2025-05-24 14:23:28 -04:00
committed by GitHub
parent 2398cbcf26
commit fa6bd8f7ba
4 changed files with 37 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
Robust.Shared/Serialization/TypeSerializers/Implementations/Custom/Prototype/PrototypeFlagsTypeSerializer.cs
View File

@@ -45,8 +45,11 @@ namespace Robust.Shared.Serialization.TypeSerializers.Implementations.Custom.Pro
IDependencyCollection dependencies, SerializationHookContext hookCtx, ISerializationContext? context = null,
ISerializationManager.InstantiationDelegate<PrototypeFlags<T>>? instanceProvider = null)
{
if(instanceProvider != null)
Logger.Warning($"Provided value to a Read-call for a {nameof(PrototypeFlags<T>)}. Ignoring...");
if (instanceProvider != null)
{
var sawmill = dependencies.Resolve<ILogManager>().GetSawmill("szr");
sawmill.Warning($"Provided value to a Read-call for a {nameof(PrototypeFlags<T>)}. Ignoring...");
}
var flags = new List<string>(node.Sequence.Count);
@@ -78,8 +81,11 @@ namespace Robust.Shared.Serialization.TypeSerializers.Implementations.Custom.Pro
IDependencyCollection dependencies, SerializationHookContext hookCtx, ISerializationContext? context = null,
ISerializationManager.InstantiationDelegate<PrototypeFlags<T>>? instanceProvider = null)
{
if(instanceProvider != null)
Logger.Warning($"Provided value to a Read-call for a {nameof(PrototypeFlags<T>)}. Ignoring...");
if (instanceProvider != null)
{
var sawmill = dependencies.Resolve<ILogManager>().GetSawmill("szr");
sawmill.Warning($"Provided value to a Read-call for a {nameof(PrototypeFlags<T>)}. Ignoring...");
}
return new PrototypeFlags<T>(node.Value);
}

6
Robust.Shared/Serialization/TypeSerializers/Implementations/Generic/DictionarySerializer.cs
View File

@@ -153,7 +153,8 @@ public sealed class DictionarySerializer<TKey, TValue> :
{
if (instanceProvider != null)
{
Logger.Warning(
var sawmill = dependencies.Resolve<ILogManager>().GetSawmill("szr");
sawmill.Warning(
$"Provided value to a Read-call for a {nameof(FrozenDictionary<TKey, TValue>)}. Ignoring...");
}
@@ -180,7 +181,8 @@ public sealed class DictionarySerializer<TKey, TValue> :
{
if (instanceProvider != null)
{
Logger.Warning(
var sawmill = dependencies.Resolve<ILogManager>().GetSawmill("szr");
sawmill.Warning(
$"Provided value to a Read-call for a {nameof(IReadOnlyDictionary<TKey, TValue>)}. Ignoring...");
}

10
Robust.Shared/Serialization/TypeSerializers/Implementations/Generic/HashSetSerializer.cs
View File

@@ -45,7 +45,10 @@ namespace Robust.Shared.Serialization.TypeSerializers.Implementations.Generic
SerializationHookContext hookCtx, ISerializationContext? context = null, ISerializationManager.InstantiationDelegate<FrozenSet<T>>? instanceProvider = null)
{
if (instanceProvider != null)
Logger.Warning($"Provided value to a Read-call for a {nameof(FrozenSet<T>)}. Ignoring...");
{
var sawmill = dependencies.Resolve<ILogManager>().GetSawmill("szr");
sawmill.Warning($"Provided value to a Read-call for a {nameof(FrozenSet<T>)}. Ignoring...");
}
var array = new T[node.Sequence.Count];
var i = 0;
@@ -65,7 +68,10 @@ namespace Robust.Shared.Serialization.TypeSerializers.Implementations.Generic
ISerializationManager.InstantiationDelegate<ImmutableHashSet<T>>? instanceProvider)
{
if (instanceProvider != null)
Logger.Warning($"Provided value to a Read-call for a {nameof(ImmutableHashSet<T>)}. Ignoring...");
{
var sawmill = dependencies.Resolve<ILogManager>().GetSawmill("szr");
sawmill.Warning($"Provided value to a Read-call for a {nameof(ImmutableHashSet<T>)}. Ignoring...");
}
var set = ImmutableHashSet.CreateBuilder<T>();
foreach (var dataNode in node.Sequence)

21
Robust.Shared/Serialization/TypeSerializers/Implementations/Generic/ListSerializers.cs
View File

@@ -127,8 +127,11 @@ namespace Robust.Shared.Serialization.TypeSerializers.Implementations.Generic
SerializationHookContext hookCtx, ISerializationContext? context,
ISerializationManager.InstantiationDelegate<IReadOnlyList<T>>? instanceProvider)
{
if(instanceProvider != null)
Logger.Warning($"Provided value to a Read-call for a {nameof(IReadOnlySet<T>)}. Ignoring...");
if (instanceProvider != null)
{
var sawmill = dependencies.Resolve<ILogManager>().GetSawmill("szr");
sawmill.Warning($"Provided value to a Read-call for a {nameof(IReadOnlySet<T>)}. Ignoring...");
}
var list = new List<T>();
@@ -146,8 +149,11 @@ namespace Robust.Shared.Serialization.TypeSerializers.Implementations.Generic
SerializationHookContext hookCtx, ISerializationContext? context,
ISerializationManager.InstantiationDelegate<IReadOnlyCollection<T>>? instanceProvider)
{
if(instanceProvider != null)
Logger.Warning($"Provided value to a Read-call for a {nameof(IReadOnlyCollection<T>)}. Ignoring...");
if (instanceProvider != null)
{
var sawmill = dependencies.Resolve<ILogManager>().GetSawmill("szr");
sawmill.Warning($"Provided value to a Read-call for a {nameof(IReadOnlyCollection<T>)}. Ignoring...");
}
var list = new List<T>();
@@ -165,8 +171,11 @@ namespace Robust.Shared.Serialization.TypeSerializers.Implementations.Generic
SerializationHookContext hookCtx, ISerializationContext? context,
ISerializationManager.InstantiationDelegate<ImmutableList<T>>? instanceProvider)
{
if(instanceProvider != null)
Logger.Warning($"Provided value to a Read-call for a {nameof(ImmutableList<T>)}. Ignoring...");
if (instanceProvider != null)
{
var sawmill = dependencies.Resolve<ILogManager>().GetSawmill("szr");
sawmill.Warning($"Provided value to a Read-call for a {nameof(ImmutableList<T>)}. Ignoring...");
}
var list = ImmutableList.CreateBuilder<T>();