space-wizards/RobustToolbox
1
0
Fork 0
mirror of https://github.com/space-wizards/RobustToolbox.git synced 2026-02-15 03:30:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

Make SpriteSpecifier.Texture fail validation if it contains ".rsi" (#6155)

Browse Source 
No pointing to PNGs inside RSIs.
This commit is contained in:
Pieter-Jan Briers
2025-09-02 22:05:13 +02:00
committed by GitHub
parent c2c8af16d0
commit f02cd0083a
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Robust.Shared/Serialization/TypeSerializers/Implementations/SpriteSpecifierSerializer.cs
View File

@@ -112,7 +112,11 @@ namespace Robust.Shared.Serialization.TypeSerializers.Implementations
IDependencyCollection dependencies,
ISerializationContext? context)
{
return serializationManager.ValidateNode<ResPath>(new ValueDataNode($"{TextureRoot / node.Value}"), context);
var path = TextureRoot / node.Value;
if (path.ToString().Contains(".rsi/"))
return new ErrorNode(node, "Texture paths may not be inside RSI files.");
return serializationManager.ValidateNode<ResPath>(new ValueDataNode(path.ToString()), context);
}
ValidationNode ITypeValidator<SpriteSpecifier, MappingDataNode>.Validate(