Commit Graph
24 Commits
Author SHA1 Message Date
de4d255841 Analyzer to enforce classes to be either [Virtual], abstract, or sealed. (#2469)
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2022-02-05 19:31:58 +01:00
Leon FriedrichandGitHub 7609a49c17 Make AudioSystem no longer automatically add players in range. (#2299)
* make adding entities in range optional

* Revert "make adding entities in range optional"

This reverts commit bd707b9f4e.

* remove AudioSystem filter modifications
2021-12-11 16:32:17 -08:00
Vera Aguilera Puerto 4f92301d25 More manual fixes. 2021-12-03 17:35:20 +01:00
Vera Aguilera Puerto 7a06db60cf Inline UID 2021-12-03 15:53:10 +01:00
Leon FriedrichandGitHub bef4f75419 Fix AudioParams DataDefinition (#2283) 2021-11-28 15:00:23 +01:00
Vera Aguilera Puerto 78d01fd25d Remove every ITransformComponent usage. 2021-11-08 12:44:03 +01:00
ShadowCommander d8499f2e60 Merge branch 'master' into fix-sound 2021-10-10 02:24:55 -07:00
Vera Aguilera Puerto fdcaa83b63 AudioSystem uses TryGet for ITransformComponent. 2021-10-01 12:48:24 +02:00
Vera Aguilera Puerto 0fce2e438a Add EntityUid overloads for SoundSystem, AudioSystem. 2021-09-28 11:41:15 +02:00
ShadowCommander 2d6eebfae2 Rename GridCoordinates to FallbackCoordinates and move GetFallbackCoordinates to shared 2021-08-28 02:29:47 -07:00
ShadowCommander 5540d643ef Change from MapCoordinates to GridCoordinates 2021-08-12 01:45:07 -07:00
ShadowCommander 76c1d9f97b Change Audio to also use MapCoordinates as a fallback 2021-08-10 20:42:46 -07:00
Vera Aguilera PuertoandGitHub 2b589215aa Improves the Filter API. (#1747)
- Recipients is now of type `IEnumerable<ICommonSession>`.
    - This way, people need to use the Filter API to modify the recipients, instead of being allowed to modify the underlying collection directly.
- Underlying collection is now a HashSet.
    - We want no duplicates at all. This will ensure that while being quite performant.
- Removes `IFilter`.
    - Let's face it, everyone is gonna end up using `Filter` instead as it has a much more convenient API, and nothing else will EVER implement `IFilter`. For this reason, I've just gone ahead and removed it. Every method used `Filter` already, anyway.
- Adds EntitySystem `RaiseNetworkEvent` overload that takes in a `Filter`.
    - This deduplicates a lot of code that enumerated the recipients and raised a network event per each one.
- Made AddPlayersByPvs aware of `net.pvs` and `net.maxupdaterange`, has a range multiplier parameter.
    - Now it will simply add all players to the filter if PVS is disabled, and add all players in range if it's enabled.
    - The range multiplier parameter allows us to make the PVS filter a bit more permissive, and generally better. The range is doubled by default, as it was already before.
- Adds `AddInRange` method to filters.
    - This is useful for the AudioSystem, and the PVS methods use it, too!
- Adds `RemoveByVisibility` method to filters.
    - This will remove all recipients that don't have a visibility flag in their entity's EyeComponent from the filter.
    - (This will be VERY useful for Ghost Pointing, for example)
- Adds `Clone` method to filters.
    - This is useful in cases where methods take in a filter and want to modify it without modifying the original instance. (See AudioSystem)
2021-05-08 22:27:47 +02:00
AcruidandGitHub 92f44b390e SoundSystem Improvements (#1649) 2021-03-21 16:35:52 +01:00
AcruidandGitHub 06e62b031a SoundSystem (#1604)
* Adds the SoundSystem static proxy class for the AudioSystem.
Added a shared IAudioSystem interface for the future.

* Moved ConnectedClient property from IPlayerSession down to ICommonSession.

* Connected up the SoundSystem to the client/server AudioSystems.

* Converted client calls over to the new system.

* Marked the old serverside functions to play sound obsolete, use the new ones from the IAudioSystem.

* Added ISharedPlayerManager to the IoC registration.
2021-03-01 20:22:28 -08:00
AcruidandGitHub 2183cd7ca1 Massive Namespace Cleanup (#1544)
* Removed the Interfaces folder.
* All objects inside the GameObjects subfolders are now in the GameObjects namespace.
* Added a Resharper DotSettings file to mark the GameObjects subfolders as not providing namespaces.
* Simplified Robust.client.Graphics namespace.
* Automated remove redundant using statements.
2021-02-10 23:27:19 -08:00
DrSmugleafandGitHub 8a5b7f5146 Add AudioSystem extension methods for the client and server (#1532) 2021-02-05 17:23:36 +11:00
0a67cecfa5 Replace every usage of GridCoordinates with EntityCoordinates (#1280)
* Added struct skeleton for EntityCoordinates.

* Polish EntityCoordinates, add tests, add EntityCoordinates to Transforms

* Doc cleanup

* Remove useless code

* Return offset 0 when you don't have a parent

* Test for making sure EntityCoordinates for entities without parents have offset 0

* Use parent transform's GridId for GetGridId.

* Adds various methods, checks and tests

* Replace GridCoordinates with EntityCoordinates

* EyeManager.WorldToScreen fix

* Address reviews

* Fix za buildo

* Fix one transform test

* Fix the remaining tests

* Remove duplicate

* Remove another merge duplicate

* Fix property

* Rename most usages of GridCoordinates to EntityCoordinates.

* Add WithEntityId method to EntityCoordinates.

* Fix EntityCoordinates usage in GetEntitiesInRange

* Remove cursed IMapGrid method, change naming.

* Makes GridTileLookupSystem use EntityCoordinates

Co-authored-by: Acruid <shatter66@gmail.com>
Co-authored-by: Víctor Aguilera Puerto <zddm@outlook.es>
2020-09-06 16:09:19 +02:00
31f44027a1 Add PlayerSession exclude for audiosystem (#1243)
Co-authored-by: Metal Gear Sloth <metalgearsloth@gmail.com>
2020-08-21 14:53:38 +02:00
SoulSlothandGitHub fe1e37d8df Fix melee audio on entity destruction (#1192) 2020-08-15 00:30:45 +02:00
Pieter-Jan BriersandGitHub 0d3cd41382 Enable NRTs on Robust.Server (#1118) 2020-06-09 14:18:29 +02:00
Víctor Aguilera PuertoandGitHub 251f0422b6 Add distance to AudioSystem (#1079)
* Add distance to AudioSystem

* Fix warning

* Rewrite distance thing.

* Better unchecked

* Whoops.

* Raise default distance to 25
2020-06-09 14:09:56 +02:00
Pieter-Jan Briers 2a614e9c3d Squashed commit of the following (PR #1081 + fixes):
commit 46881727ce4107bf61e12cbbdbfa702381debb93
Author: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
Date:   Fri Jun 5 23:27:02 2020 +0200

    Fix playing stream storage.

commit 4beef7d66e48c7517ec14f21e0a3ce8db1de57c8
Merge: 6138c00e3 c32f21bea
Author: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
Date:   Fri Jun 5 22:45:11 2020 +0200

    Merge branch 'master' into audio

commit 6138c00e3c
Author: FL-OZ <anotherscuffed@gmail.com>
Date:   Fri Jun 5 14:23:52 2020 -0500

    refine audiosystem changes

commit 21f9c389e8
Author: FL-OZ <anotherscuffed@gmail.com>
Date:   Mon Jun 1 00:50:49 2020 -0500

    remove unused variable

commit ee0cf99edf
Author: FL-OZ <anotherscuffed@gmail.com>
Date:   Fri May 29 00:26:41 2020 -0500

    I THINK that fixed the crash. Not sure exactly what though.

commit 4a2e0b3b18
Author: FL-OZ <anotherscuffed@gmail.com>
Date:   Fri May 29 00:22:30 2020 -0500

    Remove bloat.

commit 1cddcac705
Author: FL-OZ <anotherscuffed@gmail.com>
Date:   Thu May 28 15:35:32 2020 -0500

    fix everything

commit c45dc8fb9d
Author: FL-OZ <anotherscuffed@gmail.com>
Date:   Thu May 28 01:36:45 2020 -0500

    Add server side sound event stopping.
2020-06-05 23:28:14 +02:00
SilverandGitHub 25926a17b7 Renames SS14.* to Robust.* (#793)
RobustToolbox projects should be named Robust.* 

This PR changes the RobustToolbox projects from SS14.* to Robust.*

Updates SS14.* prefixes/namespaces to Robust.*
Updates SpaceStation14.sln to RobustToolbox.sln
Updates MSBUILD/SS14.* to MSBUILD/Robust.*
Updates CSProject and MSBuild references for the above
Updates git_helper.py
Removes Runserver and Runclient as they are unusable
2019-04-15 20:24:59 -06:00