increase Loc.GetString log level to warning (#6361)

* increase loglevel to warning

* add release notes

---------

Co-authored-by: PJB3005 <pieterjan.briers+git@gmail.com>
This commit is contained in:
slarticodefast
2025-12-31 19:49:05 +01:00
committed by GitHub
parent dd41a7ce44
commit de2dafe507
3 changed files with 6 additions and 5 deletions

View File

@@ -47,7 +47,7 @@ END TEMPLATE-->
### Other
*None yet*
ILocalizationManager.GetString now logs a warning when failing to find a string. In cases where you expect this to happen use TryGetString instead.
### Internal

View File

@@ -29,6 +29,7 @@ namespace Robust.Shared.Localization
/// <param name="messageId">Unique Identifier for a translated message.</param>
/// <returns>
/// The language appropriate message if available, otherwise the messageId is returned.
/// Logs a warning if the message does not exist.
/// </returns>
string GetString(string messageId);

View File

@@ -67,7 +67,7 @@ namespace Robust.Shared.Localization
if (!TryGetString(messageId, out var msg))
{
_logSawmill.Debug("Unknown messageId ({culture}): {messageId}", _defaultCulture.Value.Item1.Name,
_logSawmill.Warning("Unknown messageId ({culture}): {messageId}", _defaultCulture.Value.Item1.Name,
messageId);
msg = messageId;
}
@@ -85,7 +85,7 @@ namespace Robust.Shared.Localization
if (TryGetString(messageId, out var argMsg, arg))
return argMsg;
_logSawmill.Debug("Unknown messageId ({culture}): {messageId}", _defaultCulture.Value.Item1.Name,
_logSawmill.Warning("Unknown messageId ({culture}): {messageId}", _defaultCulture.Value.Item1.Name,
messageId);
return messageId;
}
@@ -98,7 +98,7 @@ namespace Robust.Shared.Localization
if (TryGetString(messageId, out var argMsg, arg1, arg2))
return argMsg;
_logSawmill.Debug("Unknown messageId ({culture}): {messageId}", _defaultCulture.Value.Item1.Name,
_logSawmill.Warning("Unknown messageId ({culture}): {messageId}", _defaultCulture.Value.Item1.Name,
messageId);
return messageId;
}
@@ -111,7 +111,7 @@ namespace Robust.Shared.Localization
if (TryGetString(messageId, out var argMsg, args))
return argMsg;
_logSawmill.Debug("Unknown messageId ({culture}): {messageId}", _defaultCulture.Value.Item1.Name,
_logSawmill.Warning("Unknown messageId ({culture}): {messageId}", _defaultCulture.Value.Item1.Name,
messageId);
return messageId;
}