diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index a7cd4182a..b1c5b9542 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -47,7 +47,7 @@ END TEMPLATE--> ### Other -*None yet* +ILocalizationManager.GetString now logs a warning when failing to find a string. In cases where you expect this to happen use TryGetString instead. ### Internal diff --git a/Robust.Shared/Localization/ILocalizationManager.cs b/Robust.Shared/Localization/ILocalizationManager.cs index 7d04c5016..c7d0fcef3 100644 --- a/Robust.Shared/Localization/ILocalizationManager.cs +++ b/Robust.Shared/Localization/ILocalizationManager.cs @@ -29,6 +29,7 @@ namespace Robust.Shared.Localization /// Unique Identifier for a translated message. /// /// The language appropriate message if available, otherwise the messageId is returned. + /// Logs a warning if the message does not exist. /// string GetString(string messageId); diff --git a/Robust.Shared/Localization/LocalizationManager.cs b/Robust.Shared/Localization/LocalizationManager.cs index 508e5c640..cc719c620 100644 --- a/Robust.Shared/Localization/LocalizationManager.cs +++ b/Robust.Shared/Localization/LocalizationManager.cs @@ -67,7 +67,7 @@ namespace Robust.Shared.Localization if (!TryGetString(messageId, out var msg)) { - _logSawmill.Debug("Unknown messageId ({culture}): {messageId}", _defaultCulture.Value.Item1.Name, + _logSawmill.Warning("Unknown messageId ({culture}): {messageId}", _defaultCulture.Value.Item1.Name, messageId); msg = messageId; } @@ -85,7 +85,7 @@ namespace Robust.Shared.Localization if (TryGetString(messageId, out var argMsg, arg)) return argMsg; - _logSawmill.Debug("Unknown messageId ({culture}): {messageId}", _defaultCulture.Value.Item1.Name, + _logSawmill.Warning("Unknown messageId ({culture}): {messageId}", _defaultCulture.Value.Item1.Name, messageId); return messageId; } @@ -98,7 +98,7 @@ namespace Robust.Shared.Localization if (TryGetString(messageId, out var argMsg, arg1, arg2)) return argMsg; - _logSawmill.Debug("Unknown messageId ({culture}): {messageId}", _defaultCulture.Value.Item1.Name, + _logSawmill.Warning("Unknown messageId ({culture}): {messageId}", _defaultCulture.Value.Item1.Name, messageId); return messageId; } @@ -111,7 +111,7 @@ namespace Robust.Shared.Localization if (TryGetString(messageId, out var argMsg, args)) return argMsg; - _logSawmill.Debug("Unknown messageId ({culture}): {messageId}", _defaultCulture.Value.Item1.Name, + _logSawmill.Warning("Unknown messageId ({culture}): {messageId}", _defaultCulture.Value.Item1.Name, messageId); return messageId; }