fix: Enable Offbrand medical system on mobs #3

Closed

wylab wants to merge 99 commits from fix/enable-offbrand-medical into master

pull from: fix/enable-offbrand-medical

merge into: wylab:master

wylab:master

wylab:upstream-sync

wylab:feature/blood-cult

wylab:fix/labeler-conflict-url-encode

wylab:backup-master-20251223

wylab:april-fools-2025

wylab:sponsor

wylab:patch-test

wylab:april-fools-2024

wylab:sponsor-ghosts

wylab:net-maxpeers

wylab:april-fools

wylab:posters-locale

wylab:corvax/scan-translate

wylab:corvax/player-slots-manager

wylab:assaultops-gamemode

wylab:icarus

Conversation 2 Commits 99 Files Changed 961 +33672 -2839

wylab commented 2025-12-20 06:27:37 +01:00

Owner

Copy Link

Summary

The _Offbrand medical code (wounds, surgery, vitals) was ported but the prototype changes to enable it on mobs were missing. This adds the required parent entities to make the medical system actually work.

Changes

BaseMobSpecies now inherits:

• BaseMobWoundable - wound system
• BaseMobPain - pain system
• BaseMobSurgery - surgery construction graph

BaseMobSpeciesOrganic now inherits:

• BaseMobHeartrate - heart rate, blood pressure, SpO2
• BaseMobBrain - brain damage tracking
• BaseMobCryostasis - cryo healing factor
• BaseMobLungDamage - lung damage system

MobBloodstream is commented out as BaseMobHeartrate provides its own blood management.

Why this was needed

The health scanner was showing the standard SS14 menu because mobs didn't have the _Offbrand components (WoundableComponent, HeartrateComponent, BrainDamageComponent, etc.). The WoundableHealthAnalyzerSystem.TakeSample() method returns null if the target doesn't have WoundableComponent, so the extended vitals weren't being displayed.

Test plan

• Spawn as human, use health analyzer on yourself
• Should now show advanced vitals (heart rate, blood pressure, brain health, lung health, SpO2)
• Test surgery system works (incision, clamping, retraction)
• Test pain system activates when damaged

🤖 Generated with Claude Code

## Summary The _Offbrand medical code (wounds, surgery, vitals) was ported but the prototype changes to **enable it on mobs** were missing. This adds the required parent entities to make the medical system actually work. ### Changes **BaseMobSpecies** now inherits: - `BaseMobWoundable` - wound system - `BaseMobPain` - pain system - `BaseMobSurgery` - surgery construction graph **BaseMobSpeciesOrganic** now inherits: - `BaseMobHeartrate` - heart rate, blood pressure, SpO2 - `BaseMobBrain` - brain damage tracking - `BaseMobCryostasis` - cryo healing factor - `BaseMobLungDamage` - lung damage system `MobBloodstream` is commented out as `BaseMobHeartrate` provides its own blood management. ### Why this was needed The health scanner was showing the standard SS14 menu because mobs didn't have the _Offbrand components (WoundableComponent, HeartrateComponent, BrainDamageComponent, etc.). The `WoundableHealthAnalyzerSystem.TakeSample()` method returns null if the target doesn't have `WoundableComponent`, so the extended vitals weren't being displayed. ## Test plan - [ ] Spawn as human, use health analyzer on yourself - [ ] Should now show advanced vitals (heart rate, blood pressure, brain health, lung health, SpO2) - [ ] Test surgery system works (incision, clamping, retraction) - [ ] Test pain system activates when damaged 🤖 Generated with [Claude Code](https://claude.com/claude-code)

wylab added 1 commit 2025-12-20 06:27:37 +01:00

fix: Enable Offbrand medical system on mobs ... ec0a4748d6

The _Offbrand medical code (wounds, surgery, vitals) was ported but the
prototype changes to enable it on mobs were missing. This adds the
required parent entities to BaseMobSpecies and BaseMobSpeciesOrganic:

BaseMobSpecies now inherits:
- BaseMobWoundable (wound system)
- BaseMobPain (pain system)
- BaseMobSurgery (surgery construction graph)

BaseMobSpeciesOrganic now inherits:
- BaseMobHeartrate (heart rate, blood pressure, SpO2)
- BaseMobBrain (brain damage tracking)
- BaseMobCryostasis (cryo healing factor)
- BaseMobLungDamage (lung damage system)

MobBloodstream is commented out as BaseMobHeartrate provides its own
blood management.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

wylab added 1 commit 2025-12-20 06:35:36 +01:00

fix: Keep MobBloodstream to avoid null damage issue ... c8cfd80dab

The _Offbrand base_mob.yml sets bloodlossDamage to null, but
BloodstreamComponent requires it (required: true). Need to port the
API changes from ss14-wl that make this field nullable before we can
fully replace MobBloodstream.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

wylab added 1 commit 2025-12-20 07:21:36 +01:00

feat: Add advanced vitals display to Health Analyzer UI ... 5556151de6

Port health analyzer UI enhancements from ss14-wl:
- Add WoundableData to HealthAnalyzerScannedUserMessage
- Display heart rate, blood pressure, SpO2, EtCO2, brain/heart/lung health
- Add tooltip system for detailed metric explanations
- Make BloodstreamComponent fields nullable for non-bloodstream entities
- Add EffectiveBleedLevel property with null-safety

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

wylab added 1 commit 2025-12-20 07:34:58 +01:00

fix: Add missing woundableData param in CryoPodSystem ... d2e2981d3d

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

wylab added 1 commit 2025-12-20 08:05:33 +01:00

fix: Remove required: true from nullable BloodstreamComponent fields ... 1312d760d4

Fixes YAML linter crash - nullable fields can't be required.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

wylab added 1 commit 2025-12-20 08:12:06 +01:00

fix: Make DamageBleedModifiers nullable for _Offbrand medical system ... 6648f8ab68

_Offbrand/base_mob.yml sets damageBleedModifiers: null which requires the C# field to be nullable.

wylab added 1 commit 2025-12-20 09:41:07 +01:00

Fix suicide tests for brain-damage suicides f740f55071

wylab added 2 commits 2025-12-20 20:14:46 +01:00

Ignore Claude artifacts 685bfffa70

Add Wylab overrides for Offbrand dependencies b4934e57b4

wylab added 3 commits 2025-12-21 02:00:58 +01:00

Update RobustToolbox for _Wylab overrides 60ffe0e5d6

Revert "Update RobustToolbox for _Wylab overrides" ... cdba1abffd

This reverts commit 60ffe0e5d6.

Apply Offbrand dependencies in base prototypes 6bab1afefd

wylab added 1 commit 2025-12-21 20:41:22 +01:00

Align tests and gamemodes with WL 608528498b

wylab added 1 commit 2025-12-21 21:40:23 +01:00

Sync integration tests with WL 5bfee2ab24

wylab added 1 commit 2025-12-21 22:01:05 +01:00

Revert "Align tests and gamemodes with WL" ... b523aeb3d4

This reverts commit 608528498b.

wylab added 1 commit 2025-12-21 22:08:58 +01:00

Add WL execution and CCVars shared types ab200c99a0

wylab added 1 commit 2025-12-21 23:16:51 +01:00

Align WL execution with upstream battery 25b5b38d9c

wylab added 1 commit 2025-12-21 23:24:36 +01:00

Fix PowerTest battery API calls d033a8a1b9

wylab added 1 commit 2025-12-21 23:52:19 +01:00

Fix JobTest session lookup 7c5c5fa405

wylab added 1 commit 2025-12-22 00:55:22 +01:00

chore: trigger CI c6af53f36f

wylab added 1 commit 2025-12-22 01:26:05 +01:00

chore: retrigger CI a844e194bb

wylab added 1 commit 2025-12-22 02:20:21 +01:00

ci: restore 40-minute integration test timeout e3dc4d3a3d

wylab added 1 commit 2025-12-22 03:55:38 +01:00

Port offmed-staging offbrand changes 430b1af938

wylab added 1 commit 2025-12-22 04:03:15 +01:00

Add server PowerCell system 119cbc9142

wylab added 1 commit 2025-12-22 04:17:15 +01:00

Add power cell shim and microwave event f8b28633fa

wylab added 1 commit 2025-12-22 04:24:24 +01:00

Allow shared power cell draw toggle b2d530b1b5

wylab added 1 commit 2025-12-22 04:41:38 +01:00

Use shared microwave event 6c36c1b97c

wylab added 1 commit 2025-12-22 08:11:14 +01:00

Port offmed-staging power cell behavior c2ff349ffb

wylab added 1 commit 2025-12-22 09:32:05 +01:00

Fix power cell access and event handlers fa8d9b5ba1

wylab added 1 commit 2025-12-22 10:30:53 +01:00

Port predicted powercell system ae76275c8c

wylab added 1 commit 2025-12-22 10:43:25 +01:00

Move BeingMicrowavedEvent to shared 75d3b2df49

wylab added 1 commit 2025-12-22 10:57:52 +01:00

Fix PowerCellSystem namespace imports d61fdb2ac6

wylab added 1 commit 2025-12-22 16:46:17 +01:00

Sync charger and battery systems with upstream cfe3ef8efe

wylab added 1 commit 2025-12-22 16:58:59 +01:00

Fix execution namespace in suicide tests 0c7699938c

wylab closed this pull request 2025-12-23 05:46:58 +01:00

wylab deleted branch fix/enable-offbrand-medical 2025-12-23 05:46:59 +01:00

wylab commented 2025-12-23 05:52:31 +01:00

Author

Owner

Copy Link

Closed: Offmed feature removed from codebase in clean fork reset (2025-12-23).

Closed: Offmed feature removed from codebase in clean fork reset (2025-12-23).

wylab commented 2025-12-23 06:10:29 +01:00

Author

Owner

Copy Link

Closed as part of clean fork reset. The offbrand medical system was removed from the codebase - wylab fork now tracks space-syndicate/master with curated customizations only.

Closed as part of clean fork reset. The offbrand medical system was removed from the codebase - wylab fork now tracks space-syndicate/master with curated customizations only.

Some checks are pending

Hide all checks

Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Failing after 14m47s

Required

Details

Build & Test Map Renderer / Build & Test Debug (pull_request) Has been skipped

Required

Details

CRLF Check / CRLF Check (pull_request) Successful in 43s

Details

RGA schema validator / YAML RGA schema validator (pull_request) Successful in 28s

Required

Details

Map file schema validator / YAML map schema validator (pull_request) Successful in 3m15s

Required

Details

YAML Linter / YAML Linter (pull_request) Failing after 3m18s

Required

Details

Check Merge Conflicts / check-conflicts (pull_request_target) Successful in 2s

Details

Labels: PR / labeler (pull_request_target) Successful in 24s

Details

Labels: Size / size-label (pull_request_target) Successful in 1s

Details

Test Packaging / Test Packaging (pull_request) Successful in 30m44s

Required

Details

Build & Test Debug / build (ubuntu-latest) (pull_request) Failing after 52m15s

Required

Details

Build & Test Debug / Build & Test Debug (pull_request) Has been skipped

Required

Details

RSI Validator / Validate RSIs (pull_request)

Required

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

S: Merge Conflict

PR has merge conflicts that need to be resolved

No Label

Milestone

No items

No Milestone

Assignees

Clear assignees

wylab

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: wylab/wylab-station-14#3