Fix compiler warnings

This commit is contained in:
Pieter-Jan Briers
2020-05-28 17:44:31 +02:00
parent 6a1249a922
commit 9eeb1d1afa
8 changed files with 10 additions and 16 deletions

View File

@@ -30,8 +30,6 @@ namespace Robust.Client
[Dependency] private readonly IPlayerManager _playMan;
[Dependency] private readonly IStateManager _stateManager;
[Dependency] private readonly IConfigurationManager _configManager;
[Dependency] private readonly IClientEntityManager _entityManager;

View File

@@ -54,7 +54,6 @@ namespace Robust.Client
[Dependency] private readonly IClientConsole _console;
[Dependency] private readonly ITimerManager _timerManager;
[Dependency] private readonly IClientEntityManager _entityManager;
[Dependency] private readonly IEyeManager _eyeManager;
[Dependency] private readonly IPlacementManager _placementManager;
[Dependency] private readonly IClientGameStateManager _gameStateManager;
[Dependency] private readonly IOverlayManagerInternal _overlayManager;
@@ -64,7 +63,6 @@ namespace Robust.Client
[Dependency] private readonly IDiscordRichPresence _discord;
[Dependency] private readonly IClydeInternal _clyde;
[Dependency] private readonly IFontManagerInternal _fontManager;
[Dependency] private readonly ILocalizationManager _localizationManager;
[Dependency] private readonly IModLoader _modLoader;
[Dependency] private readonly ISignalHandler _signalHandler;
[Dependency] private readonly IClientConGroupController _conGroupController;

View File

@@ -58,8 +58,7 @@ namespace Robust.Server
[Dependency] private readonly IServerNetManager _network;
[Dependency] private readonly ISystemConsoleManager _systemConsole;
[Dependency] private readonly ITaskManager _taskManager;
[Dependency] private readonly ILocalizationManager _localizationManager;
[Dependency] private IRuntimeLog runtimeLog;
[Dependency] private readonly IRuntimeLog runtimeLog;
[Dependency] private readonly IModLoader _modLoader;
[Dependency] private readonly IWatchdogApi _watchdogApi;
[Dependency] private readonly IScriptHost _scriptHost;

View File

@@ -25,10 +25,6 @@ namespace Robust.Server.GameObjects.Components.UserInterface
/// <seealso cref="BoundUserInterface"/>
public sealed class ServerUserInterfaceComponent : SharedUserInterfaceComponent
{
#pragma warning disable 649
[Dependency] private readonly IPlayerManager _playerManager;
#pragma warning restore 649
private readonly Dictionary<object, BoundUserInterface> _interfaces =
new Dictionary<object, BoundUserInterface>();

View File

@@ -44,7 +44,6 @@ namespace Robust.Server.Maps
[Dependency] private readonly IPauseManager _pauseManager;
[Dependency] private readonly IComponentManager _componentManager;
[Dependency] private readonly IComponentFactory _componentFactory;
[Dependency] private readonly IPrototypeManager _prototypeManager;
#pragma warning restore 649

View File

@@ -35,13 +35,13 @@ namespace Robust.Shared.GameObjects
/// <summary>
/// If the message is from the client, the client's session.
/// </summary>
public readonly ICommonSession Session;
public readonly ICommonSession? Session;
/// <summary>
/// Constructs a new instance of <see cref="NetworkComponentMessage"/>.
/// </summary>
/// <param name="netMsg">Raw network message containing the component message.</param>
public NetworkComponentMessage(MsgEntity netMsg, ICommonSession session = null)
public NetworkComponentMessage(MsgEntity netMsg, ICommonSession? session = null)
{
DebugTools.Assert(netMsg.Type == EntityMessageType.ComponentMessage);

View File

@@ -45,7 +45,7 @@ namespace Robust.Shared.Interfaces.Serialization
return new YamlCustomFormatSerializer<T>(this);
}
private class DoNothing<T> : WithFormat<T>
private class DoNothing : WithFormat<T>
{
public override Type Format => typeof(T);
public override T FromCustomFormat(object obj) { return (T)obj; }
@@ -68,6 +68,6 @@ namespace Robust.Shared.Interfaces.Serialization
/// <summary>
/// The identity format i.e. the format which represents a value as itself.
/// </summary>
public static readonly WithFormat<T> NoFormat = new DoNothing<T>();
public static readonly WithFormat<T> NoFormat = new DoNothing();
}
}

View File

@@ -243,7 +243,11 @@ namespace Robust.UnitTesting
INetChannel IClientNetManager.ServerChannel => ServerChannel;
public ClientConnectionState ClientConnectState => ClientConnectionState.NotConnecting;
public event Action<ClientConnectionState> ClientConnectStateChanged;
public event Action<ClientConnectionState> ClientConnectStateChanged
{
add { }
remove { }
}
private IntegrationNetChannel ServerChannel
{