Enable nullability for Robust.Shared.Maths

Robust.Shared.Maths/Angle.cs

@@ -152,7 +152,7 @@ namespace Robust.Shared.Maths
         }
 
         /// <inheritdoc />
-        public override bool Equals(object obj)
+        public override bool Equals(object? obj)
         {
             if (ReferenceEquals(null, obj)) return false;
             return obj is Angle angle && Equals(angle);

Robust.Shared.Maths/Box2.cs

@@ -173,7 +173,7 @@ namespace Robust.Shared.Maths
                    Bottom.Equals(other.Bottom);
         }
 
-        public override bool Equals(object obj)
+        public override bool Equals(object? obj)
         {
             if (obj is null) return false;
             return obj is Box2 box2 && Equals(box2);

Robust.Shared.Maths/Box2Rotated.cs

@@ -66,7 +66,7 @@ namespace Robust.Shared.Maths
         }
 
         /// <inheritdoc />
-        public override bool Equals(object obj)
+        public override bool Equals(object? obj)
         {
             if (ReferenceEquals(null, obj)) return false;
             return obj is Box2Rotated other && Equals(other);

Robust.Shared.Maths/Box2i.cs

@@ -79,7 +79,7 @@ namespace Robust.Shared.Maths
         }
 
         // override object.Equals
-        public override bool Equals(object obj)
+        public override bool Equals(object? obj)
         {
             if (obj is Box2i box)
             {

Robust.Shared.Maths/Circle.cs

@@ -79,7 +79,7 @@ namespace Robust.Shared.Maths
         }
 
         /// <inheritdoc />
-        public override bool Equals(object obj)
+        public override bool Equals(object? obj)
         {
             if (ReferenceEquals(null, obj)) return false;
             return obj is Circle circle && Equals(circle);

Robust.Shared.Maths/Color.cs

@@ -185,7 +185,7 @@ namespace Robust.Shared.Maths
         /// </summary>
         /// <param name="obj">An object to compare to.</param>
         /// <returns>True obj is a Color4 structure with the same components as this Color4; false otherwise.</returns>
-        public override bool Equals(object obj)
+        public override bool Equals(object? obj)
         {
             if (!(obj is Color))
                 return false;
@@ -1817,8 +1817,7 @@ namespace Robust.Shared.Maths
         private static readonly Dictionary<Color, string> DefaultColorsInverted =
             DefaultColors.ToLookup(pair => pair.Value).ToDictionary(i => i.Key, i => i.First().Key);
 
-        [CanBeNull]
-        public string Name()
+        public string? Name()
         {
             return DefaultColorsInverted.TryGetValue(this, out var name) ? name : null;
         }

Robust.Shared.Maths/Matrix4.cs

@@ -1094,7 +1094,7 @@ namespace Robust.Shared.Maths
         /// </summary>
         /// <param name="obj">The object to compare with this matrix.</param>
         /// <returns>True if the instances are equal; false otherwise.</returns>
-        public override bool Equals(object obj)
+        public override bool Equals(object? obj)
         {
             if (!(obj is Matrix4))
                 return false;

Robust.Shared.Maths/Quaternion.cs

@@ -822,12 +822,12 @@ namespace Robust.Shared.Maths
         /// <summary>
         /// Compares this object instance to another object for equality.
         /// </summary>
-        /// <param name="other">The other object to be used in the comparison.</param>
+        /// <param name="obj">The other object to be used in the comparison.</param>
         /// <returns>True if both objects are Quaternions of equal value. Otherwise it returns false.</returns>
-        public override bool Equals(object obj)
+        public override bool Equals(object? obj)
         {
-            if (obj is Quaternion == false) return false;
-            return this == (Quaternion) obj;
+            if (obj is Quaternion quaternion) return this == quaternion;
+            return false;
         }
 
         #endregion public override bool Equals (object o)

Robust.Shared.Maths/Robust.Shared.Maths.csproj

@@ -10,6 +10,7 @@
     <Configurations>Debug;Release</Configurations>
     <Platforms>x64</Platforms>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
+    <Nullable>enable</Nullable>
   </PropertyGroup>
   <Import Project="..\MSBuild\Robust.DefineConstants.targets" />
   <ItemGroup>

Robust.Shared.Maths/UIBox2.cs

@@ -126,7 +126,7 @@ namespace Robust.Shared.Maths
                    Bottom.Equals(other.Bottom);
         }
 
-        public override bool Equals(object obj)
+        public override bool Equals(object? obj)
         {
             if (obj is null) return false;
             return obj is UIBox2 box2 && Equals(box2);

Robust.Shared.Maths/UIBox2i.cs

@@ -88,7 +88,7 @@ namespace Robust.Shared.Maths
         }
 
         // override object.Equals
-        public override bool Equals(object obj)
+        public override bool Equals(object? obj)
         {
             if (obj is UIBox2i box)
             {

Robust.Shared.Maths/Vector2.cs

@@ -302,7 +302,7 @@ namespace Robust.Shared.Maths
         /// </summary>
         /// <param name="obj">Other object to check.</param>
         /// <returns>True if Object and vector are equal.</returns>
-        public override bool Equals(object obj)
+        public override bool Equals(object? obj)
         {
             return obj is Vector2 vec && Equals(vec);
         }

Robust.Shared.Maths/Vector2i.cs

@@ -58,7 +58,7 @@ namespace Robust.Shared.Maths
         /// </summary>
         /// <param name="obj">Other object to check.</param>
         /// <returns>True if Object and vector are equal.</returns>
-        public override bool Equals(object obj)
+        public override bool Equals(object? obj)
         {
             if (ReferenceEquals(null, obj)) return false;
             return obj is Vector2i && Equals((Vector2i) obj);

Robust.Shared.Maths/Vector2u.cs

@@ -51,7 +51,7 @@ namespace Robust.Shared.Maths
         /// </summary>
         /// <param name="obj">Other object to check.</param>
         /// <returns>True if Object and vector are equal.</returns>
-        public override bool Equals(object obj)
+        public override bool Equals(object? obj)
         {
             if (ReferenceEquals(null, obj)) return false;
             return obj is Vector2u vec && Equals(vec);

Robust.Shared.Maths/Vector3.cs

@@ -1086,7 +1086,7 @@ namespace Robust.Shared.Maths
         /// </summary>
         /// <param name="obj">The object to compare to.</param>
         /// <returns>True if the instances are equal; false otherwise.</returns>
-        public override bool Equals(object obj)
+        public override bool Equals(object? obj)
         {
             if (!(obj is Vector3))
                 return false;

Robust.Shared.Maths/Vector4.cs

@@ -876,7 +876,7 @@ namespace Robust.Shared.Maths
         /// </summary>
         /// <param name="obj">The object to compare to.</param>
         /// <returns>True if the instances are equal; false otherwise.</returns>
-        public override bool Equals(object obj)
+        public override bool Equals(object? obj)
         {
             if (!(obj is Vector4))
                 return false;