reworks benchmarks db stuff (#3314)

Robust.Benchmarks/Exporters/SQLExporter.cs

@@ -3,6 +3,7 @@ using System.Collections.Generic;
 using System.ComponentModel.DataAnnotations.Schema;
 using System.Diagnostics.CodeAnalysis;
 using System.Linq;
+using System.Text;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 using BenchmarkDotNet.Exporters;
@@ -80,7 +81,10 @@ public sealed class SQLExporter : IExporter
             }));
 
             ctx.Database.Migrate();
-            ctx.BenchmarkRuns.Add(BenchmarkRun.FromSummary(summary, gitHash));
+            foreach (var run in BenchmarkRun.FromSummary(summary, gitHash))
+            {
+                ctx.BenchmarkRuns.Add(run);
+            }
             ctx.SaveChanges();
         }
         finally
@@ -131,6 +135,7 @@ class JsonOverrideTypeHandlerResolverFactory : TypeHandlerResolverFactory
             => null; // Let the built-in resolver do this
     }
 }
+
 public sealed class DesignTimeContextFactoryPostgres : IDesignTimeDbContextFactory<BenchmarkContext>
 {
     public BenchmarkContext CreateDbContext(string[] args)
@@ -154,42 +159,39 @@ public class BenchmarkRun
     public int Id { get; set; }
     public string GitHash { get; set; } = string.Empty;
 
-    [Column(TypeName = "timestamptz")]
-    public DateTime RunDate { get; set; }
+    [Column(TypeName = "timestamptz")] public DateTime RunDate { get; set; }
 
     public string Name { get; set; } = string.Empty;
 
+    public string ParameterMapping { get; set; } = string.Empty;
+
     [Column(TypeName = "jsonb")]
-    public BenchmarkRunReport[] Reports { get; set; } = Array.Empty<BenchmarkRunReport>();
+    public Statistics Statistics { get; set; } = default!;
 
-    public static BenchmarkRun FromSummary(Summary summary, string gitHash)
+    public static IEnumerable<BenchmarkRun> FromSummary(Summary summary, string gitHash)
     {
-        return new BenchmarkRun
+        var runDate = DateTime.Now;
+        var name = summary.BenchmarksCases.First().FolderInfo;
+
+        foreach (var benchmarkReport in summary.Reports)
         {
-            Reports = summary.Reports.Select(r => new BenchmarkRunReport
+            var paramString = new StringBuilder();
+            var parameters = benchmarkReport.BenchmarkCase.Parameters.Items;
+            for (var i = 0; i < parameters.Count; i++)
             {
-                Parameters = r.BenchmarkCase.Parameters.Items.Select(p => new BenchmarkRunParameter
-                {
-                    Name = p.Name,
-                    Value = p.Value
-                }).ToArray(),
-                Statistics = r.ResultStatistics
-            }).ToArray(),
-            Name = summary.BenchmarksCases.First().FolderInfo,
-            RunDate = DateTime.UtcNow,
-            GitHash = gitHash
-        };
+                var parameter = parameters[i];
+                paramString.Append($"{parameter.Name}={parameter.Value}");
+                if (i < parameters.Count - 1) paramString.Append(',');
+            }
+
+            yield return new BenchmarkRun
+            {
+                Name = name,
+                RunDate = runDate,
+                GitHash = gitHash,
+                ParameterMapping = paramString.ToString(),
+                Statistics = benchmarkReport.ResultStatistics ?? new Statistics()
+            };
+        }
     }
 }
-
-public class BenchmarkRunReport
-{
-    public BenchmarkRunParameter[] Parameters { get; set; } = Array.Empty<BenchmarkRunParameter>();
-    public Statistics Statistics { get; set; } = default!;
-}
-
-public class BenchmarkRunParameter
-{
-    public string Name { get; set; } = string.Empty;
-    public object Value { get; set; } = default!;
-}

Robust.Benchmarks/Migrations/20221009235705_db.Designer.cs

@@ -0,0 +1,62 @@
+// <auto-generated />
+using System;
+using BenchmarkDotNet.Mathematics;
+using Microsoft.EntityFrameworkCore;
+using Microsoft.EntityFrameworkCore.Infrastructure;
+using Microsoft.EntityFrameworkCore.Migrations;
+using Microsoft.EntityFrameworkCore.Storage.ValueConversion;
+using Npgsql.EntityFrameworkCore.PostgreSQL.Metadata;
+using Robust.Benchmarks.Exporters;
+
+#nullable disable
+
+namespace Robust.Benchmarks.Migrations
+{
+    [DbContext(typeof(BenchmarkContext))]
+    [Migration("20221009235705_db")]
+    partial class db
+    {
+        protected override void BuildTargetModel(ModelBuilder modelBuilder)
+        {
+#pragma warning disable 612, 618
+            modelBuilder
+                .HasAnnotation("ProductVersion", "6.0.4")
+                .HasAnnotation("Relational:MaxIdentifierLength", 63);
+
+            NpgsqlModelBuilderExtensions.UseIdentityByDefaultColumns(modelBuilder);
+
+            modelBuilder.Entity("Robust.Benchmarks.Exporters.BenchmarkRun", b =>
+                {
+                    b.Property<int>("Id")
+                        .ValueGeneratedOnAdd()
+                        .HasColumnType("integer");
+
+                    NpgsqlPropertyBuilderExtensions.UseIdentityByDefaultColumn(b.Property<int>("Id"));
+
+                    b.Property<string>("GitHash")
+                        .IsRequired()
+                        .HasColumnType("text");
+
+                    b.Property<string>("Name")
+                        .IsRequired()
+                        .HasColumnType("text");
+
+                    b.Property<string>("ParameterMapping")
+                        .IsRequired()
+                        .HasColumnType("text");
+
+                    b.Property<DateTime>("RunDate")
+                        .HasColumnType("timestamptz");
+
+                    b.Property<Statistics>("Statistics")
+                        .IsRequired()
+                        .HasColumnType("jsonb");
+
+                    b.HasKey("Id");
+
+                    b.ToTable("BenchmarkRuns");
+                });
+#pragma warning restore 612, 618
+        }
+    }
+}

Robust.Benchmarks/Migrations/20221009235705_db.cs

@@ -0,0 +1,36 @@
+using Microsoft.EntityFrameworkCore.Migrations;
+
+#nullable disable
+
+namespace Robust.Benchmarks.Migrations
+{
+    public partial class db : Migration
+    {
+        protected override void Up(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.RenameColumn(
+                name: "Reports",
+                table: "BenchmarkRuns",
+                newName: "Statistics");
+
+            migrationBuilder.AddColumn<string>(
+                name: "ParameterMapping",
+                table: "BenchmarkRuns",
+                type: "text",
+                nullable: false,
+                defaultValue: "");
+        }
+
+        protected override void Down(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.DropColumn(
+                name: "ParameterMapping",
+                table: "BenchmarkRuns");
+
+            migrationBuilder.RenameColumn(
+                name: "Statistics",
+                table: "BenchmarkRuns",
+                newName: "Reports");
+        }
+    }
+}

Robust.Benchmarks/Migrations/BenchmarkContextModelSnapshot.cs

@@ -1,5 +1,6 @@
 // <auto-generated />
 using System;
+using BenchmarkDotNet.Mathematics;
 using Microsoft.EntityFrameworkCore;
 using Microsoft.EntityFrameworkCore.Infrastructure;
 using Microsoft.EntityFrameworkCore.Storage.ValueConversion;
@@ -17,7 +18,7 @@ namespace Robust.Benchmarks.Migrations
         {
 #pragma warning disable 612, 618
             modelBuilder
-                .HasAnnotation("ProductVersion", "6.0.0")
+                .HasAnnotation("ProductVersion", "6.0.4")
                 .HasAnnotation("Relational:MaxIdentifierLength", 63);
 
             NpgsqlModelBuilderExtensions.UseIdentityByDefaultColumns(modelBuilder);
@@ -38,13 +39,17 @@ namespace Robust.Benchmarks.Migrations
                         .IsRequired()
                         .HasColumnType("text");
 
-                    b.Property<BenchmarkRunReport[]>("Reports")
+                    b.Property<string>("ParameterMapping")
                         .IsRequired()
-                        .HasColumnType("jsonb");
+                        .HasColumnType("text");
 
                     b.Property<DateTime>("RunDate")
                         .HasColumnType("timestamptz");
 
+                    b.Property<Statistics>("Statistics")
+                        .IsRequired()
+                        .HasColumnType("jsonb");
+
                     b.HasKey("Id");
 
                     b.ToTable("BenchmarkRuns");

Robust.Benchmarks/Migrations/TypeIApparentlyHaveToKeep.cs

@@ -0,0 +1,16 @@
+using System;
+using BenchmarkDotNet.Mathematics;
+
+namespace Robust.Benchmarks.Migrations;
+
+public class BenchmarkRunReport
+{
+    public BenchmarkRunParameter[] Parameters { get; set; } = Array.Empty<BenchmarkRunParameter>();
+    public Statistics Statistics { get; set; } = default!;
+}
+
+public class BenchmarkRunParameter
+{
+    public string Name { get; set; } = string.Empty;
+    public object Value { get; set; } = default!;
+}