space-wizards/RobustToolbox
1
0
Fork 0
mirror of https://github.com/space-wizards/RobustToolbox.git synced 2026-02-15 03:30:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix crash on startup with more than 255 CVars

Browse Source
This commit is contained in:
DrSmugleaf
2025-08-21 05:28:03 -07:00
parent 9a3ebd0f1d
commit 7fa0100194
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Robust.Shared/Network/Messages/MsgConVars.cs
View File

@@ -2,7 +2,6 @@
using System.Collections.Generic;
using Lidgren.Network;
using Robust.Shared.Log;
using Robust.Shared.Maths;
using Robust.Shared.Serialization;
using Robust.Shared.Timing;
@@ -11,7 +10,7 @@ namespace Robust.Shared.Network.Messages
public sealed class MsgConVars : NetMessage
{
// Max buffer could potentially be 255 * 128 * 1024 = ~33MB, so if MaxMessageSize starts being a problem it can be increased.
private const int MaxMessageSize = 0x4000; // Arbitrarily chosen as a 'sane' value as the maximum size of the entire message.
private const int MaxMessageSize = 0x8000; // Arbitrarily chosen as a 'sane' value as the maximum size of the entire message.
private const int MaxNameSize = 4 * 32; // UTF8 Max char size is 4 bytes, 32 chars.
private const int MaxStringValSize = 4 * 256; // UTF8 Max char size is 4 bytes, 256 chars.
@@ -82,11 +81,11 @@ namespace Robust.Shared.Network.Messages
if(NetworkedVars == null)
throw new InvalidOperationException($"{nameof(NetworkedVars)} collection is null.");
if(NetworkedVars.Count > byte.MaxValue)
if(NetworkedVars.Count > short.MaxValue)
throw new InvalidOperationException($"{nameof(NetworkedVars)} collection count is greater than {short.MaxValue}.");
buffer.WriteVariableUInt32(Tick.Value);
buffer.Write((byte)NetworkedVars.Count);
buffer.Write((short)NetworkedVars.Count);
foreach (var (name, value) in NetworkedVars)
{