space-wizards/RobustToolbox
1
0
Fork 0
mirror of https://github.com/space-wizards/RobustToolbox.git synced 2026-02-15 03:30:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add transform recursion check (#3983)

Browse Source
This commit is contained in:
Leon Friedrich
2023-05-01 16:11:21 +12:00
committed by GitHub
parent 2efed72eba
commit 381c856dd4
1 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
Robust.Shared/GameObjects/Systems/SharedTransformSystem.Component.cs
View File

@@ -472,6 +472,21 @@ public abstract partial class SharedTransformSystem
QueueDel(uid);
throw new InvalidOperationException($"Attempted to re-parent to a terminating object. Entity: {ToPrettyString(uid)}, new parent: {ToPrettyString(value.EntityId)}");
}
// TODO maybe don't wrap this in DEBUG check once querying components is faster.
#if DEBUG
if (xform.MapUid == newParent.MapUid)
{
var recursiveXform = newParent;
while (recursiveXform.ParentUid.IsValid())
{
if (recursiveXform.ParentUid == uid)
throw new InvalidOperationException($"Attempted to parent an entity to one of its descendants! {ToPrettyString(uid)}");
recursiveXform = xformQuery.GetComponent(recursiveXform.ParentUid);
}
}
#endif
}
if (xform._parent.IsValid())