space-wizards/RobustToolbox
1
0
Fork 0
mirror of https://github.com/space-wizards/RobustToolbox.git synced 2026-02-14 19:29:36 +01:00
Code Issues Packages Projects Releases Wiki Activity

Run disconnect callbacks after removing channel from lists

Browse Source 
Similar to the previous changes to player sessions, but now one layer lower.

Fixed ServerSendToAll from the relevant callbacks sending to a disconnected channel.
This commit is contained in:
PJB3005
2025-08-07 00:44:06 +02:00
parent a1cdd60602
commit 07fbd5263c
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
RELEASE-NOTES.md
View File

@@ -35,7 +35,7 @@ END TEMPLATE-->
### Breaking changes
*None yet*
* When a player disconnects, the relevant callbacks are now fired *after* removing the channel from `INetManager`.
### New features

7
Robust.Shared/Network/NetManager.cs
View File

@@ -827,6 +827,10 @@ namespace Robust.Shared.Network
_assignedUsernames.Remove(channel.UserName);
_assignedUserIds.Remove(channel.UserId);
_channels.Remove(connection);
peer.RemoveChannel(channel);
channel.EncryptionChannel?.Complete();
#if EXCEPTION_TOLERANCE
try
{
@@ -842,9 +846,6 @@ namespace Robust.Shared.Network
_logger.Error("Caught exception in OnDisconnected handler:\n{0}", e);
}
#endif
_channels.Remove(connection);
peer.RemoveChannel(channel);
channel.EncryptionChannel?.Complete();
if (IsClient)
{