* feat: Add @botaccount review command for manual PR reviews (#131)
- Add detection for 'review' command in PR and issue comments
- Implement handleManualPRReview function with authorization checks
- Reuse existing PR review logic with manual-pr-review operation type
- Configure PR review tools with broad research access and controlled write access
- Support manual triggering of comprehensive PR reviews on demand
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* style: Apply pre-commit formatting changes
* test: Update test expectation for new operationType parameter
* fix: Improve PR detection for manual review command
- Add pull_request property to GitHubIssue interface for PR comments
- Handle both direct PR objects and issues with pull_request metadata
- Fix TypeScript compilation errors and linting issues
* fix: Improve pre-commit hook to fail on issues instead of auto-fixing
- Use format:check instead of format to detect issues without auto-fixing
- Use proper error handling with clear error messages
- Provide helpful instructions on how to fix issues
- Make commit behavior more predictable and transparent
* style: Fix whitespace formatting
---------
Co-authored-by: Claude <noreply@anthropic.com>
* Remove claude-config directory
* fix: Re-enable and update skipped check suite tests
Update two previously skipped tests in githubController-check-suite.test.js
to match the current implementation:
- "should skip PR review when not all check suites are complete" - Updated to
test the current getCheckSuitesForRef logic instead of deprecated
getCombinedStatus functionality
- "should handle check suites API errors gracefully" - Updated to test error
handling in the getCheckSuitesForRef call
- Fixed "should skip PR review when already reviewed at same commit" test to
properly mock workflow name matching
All tests now pass and align with the current check suite processing logic
that uses smart check suite analysis instead of combined status.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
This commit addresses critical TypeScript compilation errors and test failures
that were preventing the successful completion of Phase 2 TypeScript migration
as outlined in issue #102.
## Key Fixes
### TypeScript Type Safety
- Add comprehensive null safety checks for optional payload properties (`issue`, `pr`, `checkSuite`, `comment`)
- Fix return type mismatches in `WebhookHandler` interface implementation
- Properly type array declarations (`meaningfulSuites`, `skippedSuites`, `timeoutSuites`)
- Transform GitHub API responses to match custom TypeScript interfaces
- Replace logical OR (`||`) with nullish coalescing (`??`) for better type safety
### Jest/Testing Infrastructure
- Modernize Jest configuration by moving ts-jest options from deprecated `globals` to transform array
- Fix module import compatibility for dual CommonJS/ESM support in test files
- Update test expectations to match actual TypeScript function return values
- Fix AWS credential provider test to handle synchronous vs asynchronous method calls
### GitHub API Integration
- Fix type mapping in `getCheckSuitesForRef` to return properly typed `GitHubCheckSuitesResponse`
- Add missing properties to timeout suite objects for consistent type structure
- Remove unnecessary async/await where functions are not asynchronous
### Code Quality Improvements
- Update import statements to use `type` imports where appropriate
- Improve error handling with proper catch blocks for async operations
- Enhance code formatting and consistency across TypeScript files
## Test Results
- ✅ All TypeScript compilation errors resolved (`npm run typecheck` passes)
- ✅ Unit tests now compile and run successfully
- ✅ ESLint warnings reduced to minor style issues only
- ✅ Maintains 100% backward compatibility with existing JavaScript code
## Impact
This fix completes the TypeScript infrastructure setup and resolves blocking
issues for Phase 2 migration, enabling:
- Strict type checking across the entire codebase
- Improved developer experience with better IDE support
- Enhanced code reliability through compile-time error detection
- Seamless coexistence of JavaScript and TypeScript during transition
Fixes issue #102 (Phase 2: Convert JavaScript Source Code to TypeScript)
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* feat: implement wait-for-all-checks PR review trigger
This change modifies the PR review triggering logic to wait for ALL check suites
to complete successfully before triggering a single PR review, preventing duplicate
reviews from different check suites (build, security scans, etc.).
Key changes:
- Added PR_REVIEW_WAIT_FOR_ALL_CHECKS env var (default: true)
- Added PR_REVIEW_DEBOUNCE_MS for configurable delay (default: 5000ms)
- Implemented checkAllCheckSuitesComplete() function that queries GitHub API
- Made PR_REVIEW_TRIGGER_WORKFLOW optional (only used when wait-for-all is false)
- Updated tests to handle new behavior
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* fix: correct indentation and remove test-results from git
- Fix ESLint indentation errors in claudeService.js
- Remove test-results directory from git tracking (added to .gitignore)
🤖 Generated with Claude Code (https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* feat: add Claude CLI database sharing and backup system
- Mount host ~/.claude directory in container for shared context
- Add .dockerignore to optimize build context
- Create backup script with daily/weekly retention strategy
- Add cron setup for automated backups to /backup partition
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* fix: add missing makeGitHubRequest function to githubService
The checkAllCheckSuitesComplete function was failing because it tried to call
githubService.makeGitHubRequest which didn't exist. This was causing PR reviews
to never trigger with the 'Waiting for other check suites to complete' message.
Added the missing function to make direct GitHub API requests using Octokit.
* fix: add URL validation to makeGitHubRequest to prevent SSRF vulnerability
* refactor: remove makeGitHubRequest to fix SSRF vulnerability
- Replace makeGitHubRequest with getCheckSuitesForRef using Octokit
- Simplify getWorkflowNameFromCheckSuite to use app info from webhook
- Fix tests to match new implementation
- Add PR review environment variables to .env file
---------
Co-authored-by: Jonathan Flatt <jonflatt@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: ClaudeBot <claude@example.com>
- Remove complex error response tracking from tests
- Simplify all responses to standard webhook success format
- Update test expectations to match new selective workflow triggering
- Remove outdated test scenarios that don't apply to new implementation
- All tests now pass with cleaner, more focused assertions
The tests now properly reflect our simplified approach:
- Single environment variable controls which workflow triggers reviews
- Standard webhook responses for all scenarios
- Repository-independent configuration
- No complex error result tracking
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Add PR_REVIEW_TRIGGER_WORKFLOW environment variable for precise control
- Make automated PR reviews repository-independent
- Fix Docker security scan conditional logic in pr.yml
- Add security job dependencies to docker-build job
- Filter out CodeQL/analysis-only workflows from triggering PR reviews
- Update documentation with new configuration options
- Partial test fixes for new workflow filtering logic
This prevents multiple PR reviews from different check suites and makes
the system work across any repository with proper configuration.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
Resolved conflicts:
- Updated PR review prompt to include commit SHA tracking
- Integrated new features from main (PR labels, deduplication)
- Maintained comprehensive GitHub API instructions format
- Replace basic PR review workflow with detailed GitHub API instructions
- Add inline comment creation using gh api commands with proper parameters
- Include commit ID retrieval for line-specific comments
- Add comprehensive review submission with batch comments
- Provide clear guidance on review event types (APPROVE, REQUEST_CHANGES, COMMENT)
- Add file-type specific review focus areas
- Include multi-file output strategies for different PR sizes
- Update tests to match new prompt format and add GitHub service mocks
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Add hasReviewedPRAtCommit() to check for existing reviews at specific commit SHA
- Add managePRLabels() to manage review status labels (in-progress, complete)
- Remove Combined Status API check that was incompatible with GitHub Actions
- Update PR reviews to include commit SHA for tracking
- Add comprehensive test coverage for deduplication logic
This prevents duplicate PR reviews when multiple check_suite events occur
and provides clear visual indicators of review status through labels.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Fix SHA extraction to use PR's actual commit SHA, not check suite SHA
- Add parallel processing for multiple PRs using Promise.allSettled
- Implement detailed status tracking for each PR review attempt
- Fix error handling to properly report failures and skipped reviews
- Add comprehensive unit tests for all edge cases
- Ensure mutually exclusive counting of success/failure/skipped states
This ensures the automated PR review process correctly verifies the right
commit status and provides clear feedback on what happened with each PR.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Fixed issue where PR reviews weren't being triggered when all checks passed
- Corrected logic to process all PRs in a check_suite event
- Fixed test data to include required SHA values for multiple PR handling
- Removed early return that prevented processing multiple PRs
- Cleaned up debugging code
The webhook now correctly:
1. Detects when check_suite completes with success
2. Verifies all status checks have passed using Combined Status API
3. Triggers Claude review for each associated PR
4. Handles multiple PRs in a single check_suite event
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
Added detailed logging to understand why PR reviews aren't being triggered.
This will help identify if the issue is with the action type or pull_requests array.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Fixed githubController.test.js by adding proper secureCredentials mock
- Fixed githubService.test.js by adding logger and secureCredentials mocks
- Applied code formatting with Prettier across all files
- All tests now pass successfully
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Add GitHub Actions workflows for CI, security scanning, and deployment
- Implement automated PR review system triggered by successful check suites
- Add ESLint and Prettier for code quality and formatting
- Configure Dependabot for automated dependency updates
- Add comprehensive test coverage for check suite webhook events
- Include Docker builds and container registry publishing
- Add security scanning with CodeQL, npm audit, and TruffleHog
- Create PR and issue templates for better collaboration
- Add comprehensive CI/CD documentation
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
