forked from claude-did-this/claude-hub
fix(pr-review): implement smart wait-for-all-checks logic
Fixes automated PR review triggering by implementing intelligent check suite analysis: Key improvements: - Smart categorization of check suites (meaningful vs skipped vs timed-out) - Handles conditional jobs that never start (5min timeout) - Skips explicitly neutral/skipped check suites - Prevents waiting for stale in-progress jobs (30min timeout) - Enhanced logging for better debugging - Backwards compatible with existing configuration New environment variables: - PR_REVIEW_MAX_WAIT_MS: Max wait for stale jobs (default: 30min) - PR_REVIEW_CONDITIONAL_TIMEOUT_MS: Timeout for conditional jobs (default: 5min) This resolves issues where PR reviews weren't triggering due to overly strict wait-for-all logic that didn't account for skipped/conditional CI jobs. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -23,10 +23,12 @@ services:
|
||||
- DEFAULT_BRANCH=${DEFAULT_BRANCH:-main}
|
||||
- CLAUDE_USE_CONTAINERS=1
|
||||
- CLAUDE_CONTAINER_IMAGE=claudecode:latest
|
||||
# Wait for all checks by default, or use specific workflow trigger
|
||||
# Smart wait for all meaningful checks by default, or use specific workflow trigger
|
||||
- PR_REVIEW_WAIT_FOR_ALL_CHECKS=${PR_REVIEW_WAIT_FOR_ALL_CHECKS:-true}
|
||||
- PR_REVIEW_TRIGGER_WORKFLOW=${PR_REVIEW_TRIGGER_WORKFLOW:-}
|
||||
- PR_REVIEW_DEBOUNCE_MS=${PR_REVIEW_DEBOUNCE_MS:-5000}
|
||||
- PR_REVIEW_MAX_WAIT_MS=${PR_REVIEW_MAX_WAIT_MS:-1800000}
|
||||
- PR_REVIEW_CONDITIONAL_TIMEOUT_MS=${PR_REVIEW_CONDITIONAL_TIMEOUT_MS:-300000}
|
||||
# Point to secret files instead of env vars
|
||||
- GITHUB_TOKEN_FILE=/run/secrets/github_token
|
||||
- ANTHROPIC_API_KEY_FILE=/run/secrets/anthropic_api_key
|
||||
|
||||
Reference in New Issue
Block a user