mirror of
https://github.com/space-wizards/space-station-14.git
synced 2026-02-14 19:29:53 +01:00
Ban database refactor (#42495) * Ban DB refactor seems to work at a basic level for PostgreSQL * New ban creation API Supports all the new functionality (multiple players/addresses/hwids/roles/rounds per ban). * Make the migration irreversible * Re-implement ban notifications The server ID check is no longer done as admins may want to place bans spanning multiple rounds irrelevant of the source server. * Fix some split query warnings * Implement migration on SQLite * More comments * Remove required from ban reason SS14.Admin changes would like this * More missing AsSplitQuery() calls * Fix missing ban type filter * Fix old CreateServerBan API with permanent time * Fix department and role ban commands with permanent time * Re-add banhits navigation property Dropped this on accident, SS14.Admin needs it. * More ban API fixes. * Don't fetch ban exemption info for role bans Not relevant, reduces query performance * Regenerate migrations * Fix adminnotes command for players that never connected Would blow up handling null player records. Not a new bug introduced by the refactor, but I ran into it. * Great shame... I accidentally committed submodule update... * Update GDPR scripts * Fix sandbox violation * Fix bans with duplicate info causing DB exceptions Most notably happened with role bans, as multiple departments may include the same role.
493 lines
16 KiB
C#
493 lines
16 KiB
C#
using System.Collections.Immutable;
|
|
using System.Linq;
|
|
using System.Text;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using Content.Server.Chat.Managers;
|
|
using Content.Server.Database;
|
|
using Content.Server.GameTicking;
|
|
using Content.Shared.CCVar;
|
|
using Content.Shared.Database;
|
|
using Content.Shared.Players;
|
|
using Content.Shared.Players.PlayTimeTracking;
|
|
using Content.Shared.Roles;
|
|
using Robust.Server.Player;
|
|
using Robust.Shared.Asynchronous;
|
|
using Robust.Shared.Collections;
|
|
using Robust.Shared.Configuration;
|
|
using Robust.Shared.Enums;
|
|
using Robust.Shared.Network;
|
|
using Robust.Shared.Player;
|
|
using Robust.Shared.Prototypes;
|
|
using Robust.Shared.Timing;
|
|
using Robust.Shared.Utility;
|
|
|
|
namespace Content.Server.Administration.Managers;
|
|
|
|
public sealed partial class BanManager : IBanManager, IPostInjectInit
|
|
{
|
|
[Dependency] private readonly IConfigurationManager _cfg = default!;
|
|
[Dependency] private readonly IChatManager _chat = default!;
|
|
[Dependency] private readonly IServerDbManager _db = default!;
|
|
[Dependency] private readonly ServerDbEntryManager _entryManager = default!;
|
|
[Dependency] private readonly IGameTiming _gameTiming = default!;
|
|
[Dependency] private readonly ILocalizationManager _localizationManager = default!;
|
|
[Dependency] private readonly ILogManager _logManager = default!;
|
|
[Dependency] private readonly INetManager _netManager = default!;
|
|
[Dependency] private readonly IPlayerManager _playerManager = default!;
|
|
[Dependency] private readonly IPrototypeManager _prototypeManager = default!;
|
|
[Dependency] private readonly IEntitySystemManager _systems = default!;
|
|
[Dependency] private readonly ITaskManager _taskManager = default!;
|
|
[Dependency] private readonly UserDbDataManager _userDbData = default!;
|
|
|
|
private ISawmill _sawmill = default!;
|
|
|
|
public const string SawmillId = "admin.bans";
|
|
public const string DbTypeAntag = "Antag";
|
|
public const string DbTypeJob = "Job";
|
|
|
|
private readonly Dictionary<ICommonSession, List<BanDef>> _cachedRoleBans = new();
|
|
// Cached ban exemption flags are used to handle
|
|
private readonly Dictionary<ICommonSession, ServerBanExemptFlags> _cachedBanExemptions = new();
|
|
|
|
public void Initialize()
|
|
{
|
|
_netManager.RegisterNetMessage<MsgRoleBans>();
|
|
|
|
_db.SubscribeToJsonNotification<BanNotificationData>(
|
|
_taskManager,
|
|
_sawmill,
|
|
BanNotificationChannel,
|
|
ProcessBanNotification,
|
|
OnDatabaseNotificationEarlyFilter);
|
|
|
|
_userDbData.AddOnLoadPlayer(CachePlayerData);
|
|
_userDbData.AddOnPlayerDisconnect(ClearPlayerData);
|
|
}
|
|
|
|
private async Task CachePlayerData(ICommonSession player, CancellationToken cancel)
|
|
{
|
|
var flags = await _db.GetBanExemption(player.UserId, cancel);
|
|
|
|
var netChannel = player.Channel;
|
|
ImmutableArray<byte>? hwId = netChannel.UserData.HWId.Length == 0 ? null : netChannel.UserData.HWId;
|
|
var modernHwids = netChannel.UserData.ModernHWIds;
|
|
var roleBans = await _db.GetBansAsync(
|
|
netChannel.RemoteEndPoint.Address,
|
|
player.UserId,
|
|
hwId,
|
|
modernHwids,
|
|
false,
|
|
type: BanType.Role);
|
|
|
|
var userRoleBans = new List<BanDef>();
|
|
foreach (var ban in roleBans)
|
|
{
|
|
userRoleBans.Add(ban);
|
|
}
|
|
|
|
cancel.ThrowIfCancellationRequested();
|
|
_cachedBanExemptions[player] = flags;
|
|
_cachedRoleBans[player] = userRoleBans;
|
|
|
|
SendRoleBans(player);
|
|
}
|
|
|
|
private void ClearPlayerData(ICommonSession player)
|
|
{
|
|
_cachedBanExemptions.Remove(player);
|
|
}
|
|
|
|
public void Restart()
|
|
{
|
|
// Clear out players that have disconnected.
|
|
var toRemove = new ValueList<ICommonSession>();
|
|
foreach (var player in _cachedRoleBans.Keys)
|
|
{
|
|
if (player.Status == SessionStatus.Disconnected)
|
|
toRemove.Add(player);
|
|
}
|
|
|
|
foreach (var player in toRemove)
|
|
{
|
|
_cachedRoleBans.Remove(player);
|
|
}
|
|
|
|
// Check for expired bans
|
|
foreach (var roleBans in _cachedRoleBans.Values)
|
|
{
|
|
roleBans.RemoveAll(ban => DateTimeOffset.Now > ban.ExpirationTime);
|
|
}
|
|
}
|
|
|
|
#region Server Bans
|
|
public async void CreateServerBan(CreateServerBanInfo banInfo)
|
|
{
|
|
var (banDef, expires) = await CreateBanDef(banInfo, BanType.Server, null);
|
|
|
|
await _db.AddBanAsync(banDef);
|
|
|
|
if (_cfg.GetCVar(CCVars.ServerBanResetLastReadRules))
|
|
{
|
|
// Reset their last read rules. They probably need a refresher!
|
|
foreach (var (userId, _) in banInfo.Users)
|
|
{
|
|
await _db.SetLastReadRules(userId, null);
|
|
}
|
|
}
|
|
|
|
var adminName = banInfo.BanningAdmin == null
|
|
? Loc.GetString("system-user")
|
|
: (await _db.GetPlayerRecordByUserId(banInfo.BanningAdmin.Value))?.LastSeenUserName ?? Loc.GetString("system-user");
|
|
|
|
var targetName = banInfo.Users.Count == 0
|
|
? "null"
|
|
: string.Join(", ", banInfo.Users.Select(u => $"{u.UserName} ({u.UserId})"));
|
|
|
|
var addressRangeString = banInfo.AddressRanges.Count != 0
|
|
? "null"
|
|
: string.Join(", ", banInfo.AddressRanges.Select(a => $"{a.Address}/{a.Mask}"));
|
|
|
|
var hwidString = banInfo.HWIds.Count == 0
|
|
? "null"
|
|
: string.Join(", ", banInfo.HWIds);
|
|
|
|
var expiresString = expires == null ? Loc.GetString("server-ban-string-never") : $"{expires}";
|
|
|
|
var key = _cfg.GetCVar(CCVars.AdminShowPIIOnBan) ? "server-ban-string" : "server-ban-string-no-pii";
|
|
|
|
var logMessage = Loc.GetString(
|
|
key,
|
|
("admin", adminName),
|
|
("severity", banDef.Severity),
|
|
("expires", expiresString),
|
|
("name", targetName),
|
|
("ip", addressRangeString),
|
|
("hwid", hwidString),
|
|
("reason", banInfo.Reason));
|
|
|
|
_sawmill.Info(logMessage);
|
|
_chat.SendAdminAlert(logMessage);
|
|
|
|
KickMatchingConnectedPlayers(banDef, "newly placed ban");
|
|
}
|
|
|
|
private NoteSeverity GetSeverityForServerBan(CreateBanInfo banInfo, CVarDef<string> defaultCVar)
|
|
{
|
|
if (banInfo.Severity != null)
|
|
return banInfo.Severity.Value;
|
|
|
|
if (Enum.TryParse(_cfg.GetCVar(defaultCVar), true, out NoteSeverity parsedSeverity))
|
|
return parsedSeverity;
|
|
|
|
_sawmill.Error($"CVar {defaultCVar.Name} has invalid ban severity!");
|
|
return NoteSeverity.None;
|
|
}
|
|
|
|
private void KickMatchingConnectedPlayers(BanDef def, string source)
|
|
{
|
|
foreach (var player in _playerManager.Sessions)
|
|
{
|
|
if (BanMatchesPlayer(player, def))
|
|
{
|
|
KickForBanDef(player, def);
|
|
_sawmill.Info($"Kicked player {player.Name} ({player.UserId}) through {source}");
|
|
}
|
|
}
|
|
}
|
|
|
|
private bool BanMatchesPlayer(ICommonSession player, BanDef ban)
|
|
{
|
|
var playerInfo = new BanMatcher.PlayerInfo
|
|
{
|
|
UserId = player.UserId,
|
|
Address = player.Channel.RemoteEndPoint.Address,
|
|
HWId = player.Channel.UserData.HWId,
|
|
ModernHWIds = player.Channel.UserData.ModernHWIds,
|
|
// It's possible for the player to not have cached data loading yet due to coincidental timing.
|
|
// If this is the case, we assume they have all flags to avoid false-positives.
|
|
ExemptFlags = _cachedBanExemptions.GetValueOrDefault(player, ServerBanExemptFlags.All),
|
|
IsNewPlayer = false,
|
|
};
|
|
|
|
return BanMatcher.BanMatches(ban, playerInfo);
|
|
}
|
|
|
|
private void KickForBanDef(ICommonSession player, BanDef def)
|
|
{
|
|
var message = def.FormatBanMessage(_cfg, _localizationManager);
|
|
player.Channel.Disconnect(message);
|
|
}
|
|
|
|
#endregion
|
|
|
|
#region Role Bans
|
|
|
|
public async void CreateRoleBan(CreateRoleBanInfo banInfo)
|
|
{
|
|
ImmutableArray<BanRoleDef> roleDefs =
|
|
[
|
|
.. ToBanRoleDef(banInfo.JobPrototypes),
|
|
.. ToBanRoleDef(banInfo.AntagPrototypes),
|
|
];
|
|
|
|
if (roleDefs.Length == 0)
|
|
throw new ArgumentException("Must specify at least one role to ban!");
|
|
|
|
var (banDef, expires) = await CreateBanDef(banInfo, BanType.Role, roleDefs);
|
|
|
|
await AddRoleBan(banDef);
|
|
|
|
var length = expires == null
|
|
? Loc.GetString("cmd-roleban-inf")
|
|
: Loc.GetString("cmd-roleban-until", ("expires", expires));
|
|
|
|
var targetName = banInfo.Users.Count == 0
|
|
? "null"
|
|
: string.Join(", ", banInfo.Users.Select(u => $"{u.UserName} ({u.UserId})"));
|
|
|
|
_chat.SendAdminAlert(Loc.GetString(
|
|
"cmd-roleban-success",
|
|
("target", targetName),
|
|
("role", string.Join(", ", roleDefs)),
|
|
("reason", banInfo.Reason),
|
|
("length", length)));
|
|
|
|
foreach (var (userId, _) in banInfo.Users)
|
|
{
|
|
if (_playerManager.TryGetSessionById(userId, out var session))
|
|
SendRoleBans(session);
|
|
}
|
|
}
|
|
|
|
private async Task<(BanDef Ban, DateTimeOffset? Expires)> CreateBanDef(
|
|
CreateBanInfo banInfo,
|
|
BanType type,
|
|
ImmutableArray<BanRoleDef>? roleBans)
|
|
{
|
|
if (banInfo.Users.Count == 0 && banInfo.HWIds.Count == 0 && banInfo.AddressRanges.Count == 0)
|
|
throw new ArgumentException("Must specify at least one user, HWID, or address range");
|
|
|
|
DateTimeOffset? expires = null;
|
|
if (banInfo.Duration is { } duration)
|
|
expires = DateTimeOffset.Now + duration;
|
|
|
|
ImmutableArray<int> roundIds;
|
|
if (banInfo.RoundIds.Count > 0)
|
|
{
|
|
roundIds = [..banInfo.RoundIds];
|
|
}
|
|
else if (_systems.TryGetEntitySystem<GameTicker>(out var ticker) && ticker.RoundId != 0)
|
|
{
|
|
roundIds = [ticker.RoundId];
|
|
}
|
|
else
|
|
{
|
|
roundIds = [];
|
|
}
|
|
|
|
return (new BanDef(
|
|
null,
|
|
type,
|
|
[..banInfo.Users.Select(u => u.UserId)],
|
|
[..banInfo.AddressRanges],
|
|
[..banInfo.HWIds],
|
|
DateTimeOffset.Now,
|
|
expires,
|
|
roundIds,
|
|
await GetPlayTime(banInfo),
|
|
banInfo.Reason,
|
|
GetSeverityForServerBan(banInfo, CCVars.ServerBanDefaultSeverity),
|
|
banInfo.BanningAdmin,
|
|
null,
|
|
roles: roleBans), expires);
|
|
}
|
|
|
|
private async Task<TimeSpan> GetPlayTime(CreateBanInfo banInfo)
|
|
{
|
|
var firstPlayer = banInfo.Users.FirstOrNull()?.UserId;
|
|
if (firstPlayer == null)
|
|
return TimeSpan.Zero;
|
|
|
|
return (await _db.GetPlayTimes(firstPlayer.Value))
|
|
.Find(p => p.Tracker == PlayTimeTrackingShared.TrackerOverall)
|
|
?.TimeSpent ?? TimeSpan.Zero;
|
|
}
|
|
|
|
private IEnumerable<BanRoleDef> ToBanRoleDef<T>(IEnumerable<ProtoId<T>> protoIds) where T : class, IPrototype
|
|
{
|
|
return protoIds.Select(protoId =>
|
|
{
|
|
// TODO: I have no idea if this check is necessary. The previous code was a complete mess,
|
|
// so out of safety I'm leaving this in.
|
|
if (_prototypeManager.HasIndex<JobPrototype>(protoId) && _prototypeManager.HasIndex<AntagPrototype>(protoId))
|
|
{
|
|
throw new InvalidOperationException(
|
|
$"Creating role ban for {protoId}: cannot create role ban, role is both JobPrototype and AntagPrototype.");
|
|
}
|
|
|
|
// Don't trust the input: make sure the role actually exists.
|
|
if (!_prototypeManager.HasIndex(protoId))
|
|
throw new UnknownPrototypeException(protoId, typeof(T));
|
|
|
|
return new BanRoleDef(PrototypeKindToDbType<T>(), protoId);
|
|
});
|
|
}
|
|
|
|
private static string PrototypeKindToDbType<T>() where T : class, IPrototype
|
|
{
|
|
if (typeof(T) == typeof(JobPrototype))
|
|
return DbTypeJob;
|
|
|
|
if (typeof(T) == typeof(AntagPrototype))
|
|
return DbTypeAntag;
|
|
|
|
throw new ArgumentException($"Unknown prototype kind for role bans: {typeof(T)}");
|
|
}
|
|
|
|
private async Task AddRoleBan(BanDef banDef)
|
|
{
|
|
banDef = await _db.AddBanAsync(banDef);
|
|
|
|
foreach (var user in banDef.UserIds)
|
|
{
|
|
if (_playerManager.TryGetSessionById(user, out var player)
|
|
&& _cachedRoleBans.TryGetValue(player, out var cachedBans))
|
|
{
|
|
cachedBans.Add(banDef);
|
|
}
|
|
}
|
|
}
|
|
|
|
public async Task<string> PardonRoleBan(int banId, NetUserId? unbanningAdmin, DateTimeOffset unbanTime)
|
|
{
|
|
var ban = await _db.GetBanAsync(banId);
|
|
|
|
if (ban == null)
|
|
{
|
|
return $"No ban found with id {banId}";
|
|
}
|
|
|
|
if (ban.Type != BanType.Role)
|
|
throw new InvalidOperationException("Ban was not a role ban!");
|
|
|
|
if (ban.Unban != null)
|
|
{
|
|
var response = new StringBuilder("This ban has already been pardoned");
|
|
|
|
if (ban.Unban.UnbanningAdmin != null)
|
|
{
|
|
response.Append($" by {ban.Unban.UnbanningAdmin.Value}");
|
|
}
|
|
|
|
response.Append($" in {ban.Unban.UnbanTime}.");
|
|
return response.ToString();
|
|
}
|
|
|
|
await _db.AddUnbanAsync(new UnbanDef(banId, unbanningAdmin, DateTimeOffset.Now));
|
|
|
|
foreach (var user in ban.UserIds)
|
|
{
|
|
if (_playerManager.TryGetSessionById(user, out var session)
|
|
&& _cachedRoleBans.TryGetValue(session, out var roleBans))
|
|
{
|
|
roleBans.RemoveAll(roleBan => roleBan.Id == ban.Id);
|
|
SendRoleBans(session);
|
|
}
|
|
|
|
}
|
|
|
|
return $"Pardoned ban with id {banId}";
|
|
}
|
|
|
|
public HashSet<ProtoId<JobPrototype>>? GetJobBans(NetUserId playerUserId)
|
|
{
|
|
return GetRoleBans<JobPrototype>(playerUserId);
|
|
}
|
|
|
|
public HashSet<ProtoId<AntagPrototype>>? GetAntagBans(NetUserId playerUserId)
|
|
{
|
|
return GetRoleBans<AntagPrototype>(playerUserId);
|
|
}
|
|
|
|
private HashSet<ProtoId<T>>? GetRoleBans<T>(NetUserId playerUserId) where T : class, IPrototype
|
|
{
|
|
if (!_playerManager.TryGetSessionById(playerUserId, out var session))
|
|
return null;
|
|
|
|
return GetRoleBans<T>(session);
|
|
}
|
|
|
|
private HashSet<ProtoId<T>>? GetRoleBans<T>(ICommonSession playerSession) where T : class, IPrototype
|
|
{
|
|
if (!_cachedRoleBans.TryGetValue(playerSession, out var roleBans))
|
|
return null;
|
|
|
|
var dbType = PrototypeKindToDbType<T>();
|
|
|
|
return roleBans
|
|
.SelectMany(ban => ban.Roles!.Value)
|
|
.Where(role => role.RoleType == dbType)
|
|
.Select(role => new ProtoId<T>(role.RoleId))
|
|
.ToHashSet();
|
|
}
|
|
|
|
public HashSet<BanRoleDef>? GetRoleBans(NetUserId playerUserId)
|
|
{
|
|
if (!_playerManager.TryGetSessionById(playerUserId, out var session))
|
|
return null;
|
|
|
|
return _cachedRoleBans.TryGetValue(session, out var roleBans)
|
|
? roleBans.SelectMany(banDef => banDef.Roles ?? []).ToHashSet()
|
|
: null;
|
|
}
|
|
|
|
public bool IsRoleBanned(ICommonSession player, List<ProtoId<JobPrototype>> jobs)
|
|
{
|
|
return IsRoleBanned<JobPrototype>(player, jobs);
|
|
}
|
|
|
|
public bool IsRoleBanned(ICommonSession player, List<ProtoId<AntagPrototype>> antags)
|
|
{
|
|
return IsRoleBanned<AntagPrototype>(player, antags);
|
|
}
|
|
|
|
private bool IsRoleBanned<T>(ICommonSession player, List<ProtoId<T>> roles) where T : class, IPrototype
|
|
{
|
|
var bans = GetRoleBans(player.UserId);
|
|
|
|
if (bans is null || bans.Count == 0)
|
|
return false;
|
|
|
|
var dbType = PrototypeKindToDbType<T>();
|
|
|
|
// ReSharper disable once ForeachCanBeConvertedToQueryUsingAnotherGetEnumerator
|
|
foreach (var role in roles)
|
|
{
|
|
if (bans.Contains(new BanRoleDef(dbType, role)))
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
public void SendRoleBans(ICommonSession pSession)
|
|
{
|
|
var bans = new MsgRoleBans()
|
|
{
|
|
JobBans = (GetRoleBans<JobPrototype>(pSession) ?? []).ToList(),
|
|
AntagBans = (GetRoleBans<AntagPrototype>(pSession) ?? []).ToList(),
|
|
};
|
|
|
|
_sawmill.Debug($"Sent role bans to {pSession.Name}");
|
|
_netManager.ServerSendMessage(bans, pSession.Channel);
|
|
}
|
|
|
|
#endregion
|
|
|
|
public void PostInject()
|
|
{
|
|
_sawmill = _logManager.GetSawmill(SawmillId);
|
|
}
|
|
}
|