mirror of
https://github.com/space-wizards/space-station-14.git
synced 2026-02-14 19:29:53 +01:00
Ban database refactor (#42495) * Ban DB refactor seems to work at a basic level for PostgreSQL * New ban creation API Supports all the new functionality (multiple players/addresses/hwids/roles/rounds per ban). * Make the migration irreversible * Re-implement ban notifications The server ID check is no longer done as admins may want to place bans spanning multiple rounds irrelevant of the source server. * Fix some split query warnings * Implement migration on SQLite * More comments * Remove required from ban reason SS14.Admin changes would like this * More missing AsSplitQuery() calls * Fix missing ban type filter * Fix old CreateServerBan API with permanent time * Fix department and role ban commands with permanent time * Re-add banhits navigation property Dropped this on accident, SS14.Admin needs it. * More ban API fixes. * Don't fetch ban exemption info for role bans Not relevant, reduces query performance * Regenerate migrations * Fix adminnotes command for players that never connected Would blow up handling null player records. Not a new bug introduced by the refactor, but I ran into it. * Great shame... I accidentally committed submodule update... * Update GDPR scripts * Fix sandbox violation * Fix bans with duplicate info causing DB exceptions Most notably happened with role bans, as multiple departments may include the same role.
146 lines
5.1 KiB
C#
146 lines
5.1 KiB
C#
using System.Linq;
|
|
using Content.Server.Administration.Managers;
|
|
using Content.Shared.Administration;
|
|
using Content.Shared.CCVar;
|
|
using Content.Shared.Database;
|
|
using Robust.Server.Player;
|
|
using Robust.Shared.Configuration;
|
|
using Robust.Shared.Console;
|
|
|
|
|
|
namespace Content.Server.Administration.Commands;
|
|
|
|
[AdminCommand(AdminFlags.Ban)]
|
|
public sealed class BanCommand : LocalizedCommands
|
|
{
|
|
|
|
[Dependency] private readonly IPlayerLocator _locator = default!;
|
|
[Dependency] private readonly IBanManager _bans = default!;
|
|
[Dependency] private readonly IConfigurationManager _cfg = default!;
|
|
[Dependency] private readonly IPlayerManager _playerManager = default!;
|
|
[Dependency] private readonly ILogManager _logManager = default!;
|
|
|
|
public override string Command => "ban";
|
|
|
|
public override async void Execute(IConsoleShell shell, string argStr, string[] args)
|
|
{
|
|
string target;
|
|
string reason;
|
|
uint minutes;
|
|
if (!Enum.TryParse(_cfg.GetCVar(CCVars.ServerBanDefaultSeverity), out NoteSeverity severity))
|
|
{
|
|
_logManager.GetSawmill("admin.server_ban")
|
|
.Warning("Server ban severity could not be parsed from config! Defaulting to high.");
|
|
severity = NoteSeverity.High;
|
|
}
|
|
|
|
switch (args.Length)
|
|
{
|
|
case 2:
|
|
target = args[0];
|
|
reason = args[1];
|
|
minutes = 0;
|
|
break;
|
|
case 3:
|
|
target = args[0];
|
|
reason = args[1];
|
|
|
|
if (!uint.TryParse(args[2], out minutes))
|
|
{
|
|
shell.WriteLine(Loc.GetString("cmd-ban-invalid-minutes", ("minutes", args[2])));
|
|
shell.WriteLine(Help);
|
|
return;
|
|
}
|
|
|
|
break;
|
|
case 4:
|
|
target = args[0];
|
|
reason = args[1];
|
|
|
|
if (!uint.TryParse(args[2], out minutes))
|
|
{
|
|
shell.WriteLine(Loc.GetString("cmd-ban-invalid-minutes", ("minutes", args[2])));
|
|
shell.WriteLine(Help);
|
|
return;
|
|
}
|
|
|
|
if (!Enum.TryParse(args[3], ignoreCase: true, out severity))
|
|
{
|
|
shell.WriteLine(Loc.GetString("cmd-ban-invalid-severity", ("severity", args[3])));
|
|
shell.WriteLine(Help);
|
|
return;
|
|
}
|
|
|
|
break;
|
|
default:
|
|
shell.WriteLine(Loc.GetString("cmd-ban-invalid-arguments"));
|
|
shell.WriteLine(Help);
|
|
return;
|
|
}
|
|
|
|
var located = await _locator.LookupIdByNameOrIdAsync(target);
|
|
var player = shell.Player;
|
|
|
|
if (located == null)
|
|
{
|
|
shell.WriteError(Loc.GetString("cmd-ban-player"));
|
|
return;
|
|
}
|
|
|
|
var targetUid = located.UserId;
|
|
var targetHWid = located.LastHWId;
|
|
|
|
var banInfo = new CreateServerBanInfo(reason);
|
|
banInfo.WithBanningAdmin(player?.UserId);
|
|
banInfo.AddUser(targetUid, target);
|
|
banInfo.AddHWId(targetHWid);
|
|
if (minutes > 0)
|
|
banInfo.WithMinutes(minutes);
|
|
banInfo.WithSeverity(severity);
|
|
|
|
_bans.CreateServerBan(banInfo);
|
|
}
|
|
|
|
public override CompletionResult GetCompletion(IConsoleShell shell, string[] args)
|
|
{
|
|
if (args.Length == 1)
|
|
{
|
|
var options = _playerManager.Sessions.Select(c => c.Name).OrderBy(c => c).ToArray();
|
|
return CompletionResult.FromHintOptions(options, LocalizationManager.GetString("cmd-ban-hint"));
|
|
}
|
|
|
|
if (args.Length == 2)
|
|
return CompletionResult.FromHint(LocalizationManager.GetString("cmd-ban-hint-reason"));
|
|
|
|
if (args.Length == 3)
|
|
{
|
|
var durations = new CompletionOption[]
|
|
{
|
|
new("0", LocalizationManager.GetString("cmd-ban-hint-duration-1")),
|
|
new("1440", LocalizationManager.GetString("cmd-ban-hint-duration-2")),
|
|
new("4320", LocalizationManager.GetString("cmd-ban-hint-duration-3")),
|
|
new("10080", LocalizationManager.GetString("cmd-ban-hint-duration-4")),
|
|
new("20160", LocalizationManager.GetString("cmd-ban-hint-duration-5")),
|
|
new("43800", LocalizationManager.GetString("cmd-ban-hint-duration-6")),
|
|
};
|
|
|
|
return CompletionResult.FromHintOptions(durations, LocalizationManager.GetString("cmd-ban-hint-duration"));
|
|
}
|
|
|
|
if (args.Length == 4)
|
|
{
|
|
var severities = new CompletionOption[]
|
|
{
|
|
new("none", Loc.GetString("admin-note-editor-severity-none")),
|
|
new("minor", Loc.GetString("admin-note-editor-severity-low")),
|
|
new("medium", Loc.GetString("admin-note-editor-severity-medium")),
|
|
new("high", Loc.GetString("admin-note-editor-severity-high")),
|
|
};
|
|
|
|
return CompletionResult.FromHintOptions(severities, Loc.GetString("cmd-ban-hint-severity"));
|
|
}
|
|
|
|
return CompletionResult.Empty;
|
|
}
|
|
}
|