* Drunk moment
* push
* fix test fails + a smidge of cleanup
* two smidges of cleanup
* Unpredicted so don't need the workaround
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* LOCKED THE FUCK IN
* Forgot this little fella
* Crying
* All entity effects ported, needs cleanup still
* Commit
* HEHEHEHAW
* Shelve for now
* fixe
* Big
* First big chunk of changes
* Big if true
* Commit
* IT BUILDS!!!
* Fix LINTER fails
* Cleanup
* Scale working, cut down on some evil code
* Delete old Entity Effects
* Accidentally breaking shit by fixing bugs
* Fix a bunch of effects not working
* Fix reagent thresholds
* Update damage
* Wait don't change the gas metabolisms A
* Cleanup
* more fixes
* Eh
* Misc fixes and jank
* Remove two things, add bullshit, change condition to inverted
* Remove unused "Shared" system structure
* Namespace fix
* merge conflicts/cleanup
* More fixes
* Guidebook text begins
* Shelve
* Push
* More shit to push
* Fix
* Fix merg conflicts
* BLOOD FOR THE BLOOD GOD!!!
* Mild cleanup and lists
* Fix localization and comments
* Shuffle localization around a bit.
* All done?
* Nearly everything
* Is this the end?
* Whoops forgot to remove that TODO
* Get rid of some warnings for good measure...
* It's done
* Should make those virtual in case we want to override them tbqh...
* Update Content.Shared/EntityEffects/Effects/Botany/PlantAttributes/PlantDestroySeeds.cs
Co-authored-by: Pok <113675512+Pok27@users.noreply.github.com>
* Fix test fails real
* Add to codeowners
* Documentation to everything
* Forgot to push whoops
* Standardize Condition names
* Fix up metabolism a little as a treat
* review
* add IsServer checks
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
Co-authored-by: Pok <113675512+Pok27@users.noreply.github.com>
* Initial commit
* Minor fix
* Why is this uncommented here? Hmmm
* No wait this can't be here, oops
* Do better time
* Also guidebook
* Review changes
* Add rejuvination, fix mispredicts
* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115)
This then resulted in TryIndex() getting modified to log errors (94f98073b0), which is incorrect as it causes false-positive errors in proper uses of the API: external data validation. (#39098)
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes#39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* alert cleanup and API
* I expect update loops to be at the top.
* Address review
* Address review x 2
* Merg my PR
* Fix
* Update Content.Shared/Alert/AlertsSystem.cs
webedit
Co-authored-by: Perry Fraser <perryprog@users.noreply.github.com>
* FIX THAT TEST FAIL!!!!
* Me when I forget to actually give you alerts
* Hammedborgar
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
Co-authored-by: Perry Fraser <perryprog@users.noreply.github.com>
* The only commit that matters
* I had to stop playing with my cat to push this change
* Yaml removal
* Proper drunk status effect and remove shitcode
* Review changes
* whoops
* Whoops x2
* Update master fix merge conflicts
* Fix merge conflicts
* Dunk Component kill
* MORE RELAYS
* Holy fucking breaking changes
* Ough
* 46 file diff
* Fix bad commits
* Erm what the test fail?
* Fix those last two
* Merge conflicts
* Me when I fix the merge conflicts
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* feat: add a component for rejuvenateable effects
* feat: let god mode'd entities get buffs
* fix: handle old status effect system
Didn't realize BeforeStatusEffectAddedEvent was called by both systems,
oops.
* refactor: rename to RejuvenateRemovedStatusEffect
* fix: make forced sleeping a debuff again
Missed in rebase.
* refactor: make BeforeStatusEffectAdded two events
* spectra
* documentation
* added into liquid anomaly
* Update TemporaryStealthComponent.cs
* Update TemporaryStealthComponent.cs
* integrated
* new system
* mark old status effect system as obsolete
* ForcedSleeping new status effect
* work with reagents
* networking???
* Revert "integrated"
This reverts commit bca02b82ba.
* Revert "Update TemporaryStealthComponent.cs"
This reverts commit 4a5be8c4b7.
* Revert "Update TemporaryStealthComponent.cs"
This reverts commit a4875bcb41.
* Revert "added into liquid anomaly"
This reverts commit df5086b14b.
* Revert "documentation"
This reverts commit 3629b94667.
* Revert "spectra"
This reverts commit 2d03d88c16.
* drowsiness status effect remove
* reagents work
* polish, remove test changes
* first Fildrance review part
* Update misc.yml
* more fildrance review
* final part
* fix trailing spaces
* sleeping status effect
* drowsiness status effect
* Create ModifyStatusEffect.cs
* some tweak
* Yay!!! Manual networking
* minor nitpick
* oopsie
* refactor: xml-docs, notnullwhen attributes, whitespaces
* fildrance and emo review
* refactor: simplify check in SharedStatusEffectsSystem by using pattern matching, TryEffectsWithComp now returns set of Entity<T, StatusEffectComponent>
---------
Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
