From 946a516d7210db5749a54fa61110d3fef4894418 Mon Sep 17 00:00:00 2001 From: ScarKy0 <106310278+ScarKy0@users.noreply.github.com> Date: Wed, 3 Jun 2026 21:03:40 +0200 Subject: [PATCH] Make NumberObjective Max inclusive (#44228) * yeah * comment * Apply suggestion from @slarticodefast --------- Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> --- .../Objectives/Components/NumberObjectiveComponent.cs | 4 ++-- Content.Server/Objectives/Systems/NumberObjectiveSystem.cs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Content.Server/Objectives/Components/NumberObjectiveComponent.cs b/Content.Server/Objectives/Components/NumberObjectiveComponent.cs index d4f4508b586..93ecd5ba9e6 100644 --- a/Content.Server/Objectives/Components/NumberObjectiveComponent.cs +++ b/Content.Server/Objectives/Components/NumberObjectiveComponent.cs @@ -16,13 +16,13 @@ public sealed partial class NumberObjectiveComponent : Component public int Target; /// - /// Minimum number for target to roll. + /// Minimum number for target to roll. (Inclusive) /// [DataField(required: true)] public int Min; /// - /// Maximum number for target to roll. + /// Maximum number for target to roll. (Inclusive) /// [DataField(required: true)] public int Max; diff --git a/Content.Server/Objectives/Systems/NumberObjectiveSystem.cs b/Content.Server/Objectives/Systems/NumberObjectiveSystem.cs index d2b8b905ac8..06dd1067bc5 100644 --- a/Content.Server/Objectives/Systems/NumberObjectiveSystem.cs +++ b/Content.Server/Objectives/Systems/NumberObjectiveSystem.cs @@ -23,7 +23,7 @@ public sealed partial class NumberObjectiveSystem : EntitySystem private void OnAssigned(EntityUid uid, NumberObjectiveComponent comp, ref ObjectiveAssignedEvent args) { - comp.Target = _random.Next(comp.Min, comp.Max); + comp.Target = _random.Next(comp.Min, comp.Max + 1); } private void OnAfterAssign(EntityUid uid, NumberObjectiveComponent comp, ref ObjectiveAfterAssignEvent args)