Files
RobustToolbox/Robust.Shared/Localization/LocalizationManager.Entity.cs
Ygg01 9240c94e59 Write Errors when a duplicate localization key is found. (#4885)
* Update Linguini to v0.8.1

* Add tests and verify desired behavior has been reached.

* Remove duplicate messages.

* Minor fix to message output. Add Wrapper for Fluent errors.

* Restart the test pipeline.

* Restart the test pipeline.

* Make so test don't do an early bailout.

* Ensure all errors get written rather than bailing on first.

* Fix text breakage.

* Remove obsolete // TODO LINGUINI

* line wrapping conventions

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
Co-authored-by: ElectroJr <leonsfriedrich@gmail.com>
2024-06-05 15:23:41 +10:00

152 lines
5.7 KiB
C#

using System.Collections.Concurrent;
using System.Collections.Generic;
using System.Collections.Immutable;
using System.Diagnostics.CodeAnalysis;
using System.Linq;
using Linguini.Bundle;
using Linguini.Bundle.Errors;
using Robust.Shared.GameObjects;
using Robust.Shared.GameObjects.Components.Localization;
using Robust.Shared.IoC;
using Robust.Shared.Prototypes;
namespace Robust.Shared.Localization
{
internal sealed partial class LocalizationManager
{
// Concurrent dict so that multiple threads "reading" .Name won't cause a concurrent write issue
// when the cache gets populated.
private readonly ConcurrentDictionary<string, EntityLocData> _entityCache = new();
private void FlushEntityCache()
{
_logSawmill.Debug("Flushing entity localization cache.");
_entityCache.Clear();
}
private bool TryGetEntityLocAttrib(EntityUid entity, string attribute, [NotNullWhen(true)] out string? value)
{
if (_entMan.TryGetComponent(entity, out GrammarComponent? grammar) &&
grammar.Attributes.TryGetValue(attribute, out value))
{
return true;
}
if (_entMan.GetComponent<MetaDataComponent>(entity).EntityPrototype is not {} prototype)
{
value = null;
return false;
}
var data = GetEntityData(prototype.ID);
return data.Attributes.TryGetValue(attribute, out value);
}
// Flush caches conservatively on prototype/localization changes.
private void OnPrototypesReloaded(PrototypesReloadedEventArgs args)
{
if (args.WasModified<EntityPrototype>())
FlushEntityCache();
}
private EntityLocData CalcEntityLoc(string prototypeId)
{
string? name = null;
string? desc = null;
string? suffix = null;
Dictionary<string, string>? attributes = null;
foreach (var prototype in _prototype.EnumerateParents<EntityPrototype>(prototypeId, true))
{
var locId = prototype?.CustomLocalizationID ?? $"ent-{prototypeId}";
if (TryGetMessage(locId, out var bundle, out var msg))
{
// Localization override exists.
var msgAttrs = msg.Attributes;
if (name == null && msg.Value != null)
{
// Only set name if the value isn't empty.
// So that you can override *only* a desc/suffix.
name = bundle.FormatPattern(msg.Value, null, out var fmtErr);
WriteWarningForErrs(fmtErr, locId);
}
if (msgAttrs.Count != 0)
{
foreach (var (attrId, pattern) in msg.Attributes)
{
var attrib = attrId.ToString();
if (attrib.Equals("desc")
|| attrib.Equals("suffix"))
continue;
attributes ??= new Dictionary<string, string>();
if (!attributes.ContainsKey(attrib))
{
var value = bundle.FormatPattern(pattern, null, out var errors);
WriteWarningForErrs(errors, locId);
attributes[attrib] = value;
}
}
var allErrors = new List<FluentError>();
if (desc == null
&& !bundle.TryGetMessage(locId, "desc", null, out var err1, out desc))
{
desc = null;
allErrors.AddRange(err1);
}
if (suffix == null
&& !bundle.TryGetMessage(locId, "suffix", null, out var err, out suffix))
{
suffix = null;
}
WriteWarningForErrs(allErrors, locId);
}
}
name ??= prototype?.SetName;
desc ??= prototype?.SetDesc;
suffix ??= prototype?.SetSuffix;
if (prototype?.LocProperties != null && prototype.LocProperties.Count != 0)
{
foreach (var (attrib, value) in prototype.LocProperties)
{
attributes ??= new Dictionary<string, string>();
if (!attributes.ContainsKey(attrib))
{
attributes[attrib] = value;
}
}
}
}
// Attempt to infer suffix from entity categories
if (suffix == null)
{
var suffixes = _prototype.Index<EntityPrototype>(prototypeId).Categories
.Where(x => x.Suffix != null)
.Select(x => GetString(x.Suffix!));
suffix = string.Join(", ", suffixes);
}
return new EntityLocData(
name ?? "",
desc ?? "",
suffix,
attributes?.ToImmutableDictionary() ?? ImmutableDictionary<string, string>.Empty);
}
public EntityLocData GetEntityData(string prototypeId)
{
return _entityCache.GetOrAdd(prototypeId, (id, t) => t.CalcEntityLoc(id), this);
}
}
}