space-wizards/RobustToolbox
1
0
Fork 0
mirror of https://github.com/space-wizards/RobustToolbox.git synced 2026-02-15 03:30:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

Analyzer to check that notnullableflag is being properly used (#3569)

Browse Source
This commit is contained in:
Paul Ritter
2022-12-21 00:11:04 +01:00
committed by GitHub
parent a0b067a062
commit bafbdb6363
39 changed files with 338 additions and 132 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Robust.UnitTesting/Shared/Serialization/CompositionTest.cs
View File

@@ -40,7 +40,7 @@ public sealed class CompositionTest : SerializationTest
};
var finalMapping = Serialization.PushComposition<CompositionTestClass, MappingDataNode>(new[] { parent1, parent2 }, child);
var val = Serialization.Read<CompositionTestClass>(finalMapping);
var val = Serialization.Read<CompositionTestClass>(finalMapping, notNullableOverride: true);
Assert.That(val.ChildValue, Is.EqualTo(1));
Assert.That(val.Parent1Value, Is.EqualTo(1));

20
Robust.UnitTesting/Shared/Serialization/DataRecordTest.cs
View File

@@ -57,7 +57,7 @@ public sealed class DataRecordTest : SerializationTest
{"anotherTest", "2"}
};
var val = Serialization.Read<TwoIntRecord>(mapping);
var val = Serialization.Read<TwoIntRecord>(mapping, notNullableOverride: true);
Assert.Multiple(() =>
{
@@ -83,7 +83,7 @@ public sealed class DataRecordTest : SerializationTest
public void OneByteOneDefaultIntRecordTest()
{
var mapping = new MappingDataNode {{"a", "1"}};
var val = Serialization.Read<OneByteOneDefaultIntRecord>(mapping);
var val = Serialization.Read<OneByteOneDefaultIntRecord>(mapping, notNullableOverride: true);
Assert.Multiple(() =>
{
@@ -96,7 +96,7 @@ public sealed class DataRecordTest : SerializationTest
public void OneLongRecordTest()
{
var mapping = new MappingDataNode {{"a", "1"}};
var val = Serialization.Read<OneLongRecord>(mapping);
var val = Serialization.Read<OneLongRecord>(mapping, notNullableOverride: true);
Assert.That(val.A, Is.EqualTo(1));
}
@@ -105,7 +105,7 @@ public sealed class DataRecordTest : SerializationTest
public void OneLongMinValueRecordTest()
{
var mapping = new MappingDataNode {{"a", long.MinValue.ToString()}};
var val = Serialization.Read<OneLongRecord>(mapping);
var val = Serialization.Read<OneLongRecord>(mapping, notNullableOverride: true);
Assert.That(val.A, Is.EqualTo(long.MinValue));
}
@@ -114,7 +114,7 @@ public sealed class DataRecordTest : SerializationTest
public void OneLongMaxValueRecordTest()
{
var mapping = new MappingDataNode {{"a", long.MaxValue.ToString()}};
var val = Serialization.Read<OneLongRecord>(mapping);
var val = Serialization.Read<OneLongRecord>(mapping, notNullableOverride: true);
Assert.That(val.A, Is.EqualTo(long.MaxValue));
}
@@ -123,7 +123,7 @@ public sealed class DataRecordTest : SerializationTest
public void OneLongDefaultRecordTest()
{
var mapping = new MappingDataNode();
var val = Serialization.Read<OneLongDefaultRecord>(mapping);
var val = Serialization.Read<OneLongDefaultRecord>(mapping, notNullableOverride: true);
Assert.That(val.A, Is.EqualTo(5));
}
@@ -132,7 +132,7 @@ public sealed class DataRecordTest : SerializationTest
public void OneULongRecordMaxValueTest()
{
var mapping = new MappingDataNode {{"a", ulong.MaxValue.ToString()}};
var val = Serialization.Read<OneULongRecord>(mapping);
var val = Serialization.Read<OneULongRecord>(mapping, notNullableOverride: true);
Assert.That(val.A, Is.EqualTo(ulong.MaxValue));
}
@@ -141,7 +141,7 @@ public sealed class DataRecordTest : SerializationTest
public void PrototypeTest()
{
var mapping = new MappingDataNode {{"id", "ABC"}};
var val = Serialization.Read<PrototypeRecord>(mapping);
var val = Serialization.Read<PrototypeRecord>(mapping, notNullableOverride: true);
Assert.That(val.ID, Is.EqualTo("ABC"));
}
@@ -167,7 +167,7 @@ public sealed class DataRecordTest : SerializationTest
}
}
};
var val = Serialization.Read<IntStructHolder>(mapping);
var val = Serialization.Read<IntStructHolder>(mapping, notNullableOverride: true);
Assert.That(val.Struct.Value, Is.EqualTo(42));
}
@@ -190,7 +190,7 @@ public sealed class DataRecordTest : SerializationTest
}
}
};
var val = Serialization.Read<TwoIntStructHolder>(mapping);
var val = Serialization.Read<TwoIntStructHolder>(mapping, notNullableOverride: true);
Assert.Multiple(() =>
{

2
Robust.UnitTesting/Shared/Serialization/IncludeTest.cs
View File

@@ -36,7 +36,7 @@ public sealed class IncludeTest : RobustUnitTest
mapping.Add("f1", "1");
mapping.Add("f2", "true");
var val = serv3Mgr.Read<ReadWriteTestDataDefinition>(mapping);
var val = serv3Mgr.Read<ReadWriteTestDataDefinition>(mapping, notNullableOverride: true);
Assert.That(val.F1, Is.EqualTo(1));
Assert.That(val.Nested.F1, Is.EqualTo(1));

2
Robust.UnitTesting/Shared/Serialization/PropertyAndFieldDefinitionTest.cs
View File

@@ -35,7 +35,7 @@ namespace Robust.UnitTesting.Shared.Serialization
mapping.Add(GetOnlyPropertyWithOtherAttributeFieldTargetedName, new ValueDataNode("25"));
mapping.Add(GetOnlyPropertyFieldTargetedAndOtherAttributeName, new ValueDataNode("30"));
var definition = Serialization.Read<PropertyAndFieldDefinitionTestDefinition>(mapping);
var definition = Serialization.Read<PropertyAndFieldDefinitionTestDefinition>(mapping, notNullableOverride: true);
Assert.NotNull(definition);

2
Robust.UnitTesting/Shared/Serialization/SerializationPriorityTest.cs
View File

@@ -34,7 +34,7 @@ namespace Robust.UnitTesting.Shared.Serialization
var mapping = yamlStream.Documents[0].RootNode.ToDataNodeCast<SequenceDataNode>().Cast<MappingDataNode>(0);
var component = serializationManager.Read<PriorityTestComponent>(mapping);
var component = serializationManager.Read<PriorityTestComponent>(mapping, notNullableOverride: true);
Assert.That(component.Strings.Count, Is.EqualTo(3));
Assert.That(component.First, Is.EqualTo("A"));

18
Robust.UnitTesting/Shared/Serialization/SerializationTests/DataDefinitionTests.cs
View File

@@ -147,7 +147,7 @@ public sealed partial class DataDefinitionTests : SerializationTest
public void Read_NT_NV<T>(string fieldName, DataNode node, Func<T> value, Func<T> altValue)
{
var mapping = new MappingDataNode{ { fieldName, ValueDataNode.Null() } };
var res = Serialization.Read<DataDefTestDummy>(mapping);
var res = Serialization.Read<DataDefTestDummy>(mapping, notNullableOverride: true);
Assert.Null(GetValue(res, fieldName));
}
@@ -155,7 +155,7 @@ public sealed partial class DataDefinitionTests : SerializationTest
public void Read_NT_RV_AND_RT_RV<T>(string fieldName, DataNode node, Func<T> value, Func<T> altValue)
{
var mapping = new MappingDataNode{ { fieldName, node } };
var res = Serialization.Read<DataDefTestDummy>(mapping);
var res = Serialization.Read<DataDefTestDummy>(mapping, notNullableOverride: true);
Assert.That(GetValue(res, fieldName), Is.EqualTo(value()));
}
@@ -163,7 +163,7 @@ public sealed partial class DataDefinitionTests : SerializationTest
public void Read_RT_NV<T>(string fieldName, DataNode node, Func<T> value, Func<T> altValue)
{
var mapping = new MappingDataNode{ { fieldName, ValueDataNode.Null() } };
Assert.That(() => Serialization.Read<DataDefTestDummy>(mapping), Throws.InstanceOf<NullNotAllowedException>());
Assert.That(() => Serialization.Read<DataDefTestDummy>(mapping, notNullableOverride: true), Throws.InstanceOf<NullNotAllowedException>());
}
[TestCaseSource(nameof(NullableFieldsData))]
@@ -208,7 +208,7 @@ public sealed partial class DataDefinitionTests : SerializationTest
SetValue(source, fieldName, null);
var target = new DataDefTestDummy();
SetValue(target, fieldName, null);
Serialization.CopyTo(source, ref target);
Serialization.CopyTo(source, ref target, notNullableOverride: true);
Assert.NotNull(target);
Assert.Null(GetValue(target!, fieldName));
}
@@ -220,7 +220,7 @@ public sealed partial class DataDefinitionTests : SerializationTest
SetValue(source, fieldName, null);
var target = new DataDefTestDummy();
SetValue(target, fieldName, altValue());
Serialization.CopyTo(source, ref target);
Serialization.CopyTo(source, ref target, notNullableOverride: true);
Assert.NotNull(target);
Assert.Null(GetValue(target!, fieldName));
}
@@ -232,7 +232,7 @@ public sealed partial class DataDefinitionTests : SerializationTest
SetValue(source, fieldName, value());
var target = new DataDefTestDummy();
SetValue(target, fieldName, null);
Serialization.CopyTo(source, ref target);
Serialization.CopyTo(source, ref target, notNullableOverride: true);
Assert.NotNull(target);
Assert.That(GetValue(target!, fieldName), Is.EqualTo(value()));
}
@@ -244,7 +244,7 @@ public sealed partial class DataDefinitionTests : SerializationTest
SetValue(source, fieldName, value());
var target = new DataDefTestDummy();
SetValue(target, fieldName, altValue());
Serialization.CopyTo(source, ref target);
Serialization.CopyTo(source, ref target, notNullableOverride: true);
Assert.NotNull(target);
Assert.That(GetValue(target!, fieldName), Is.EqualTo(value()));
}
@@ -258,7 +258,7 @@ public sealed partial class DataDefinitionTests : SerializationTest
SetValue(source, fieldName, null);
var target = new DataDefTestDummy();
SetValue(target, fieldName, null);
Assert.That(() => Serialization.CopyTo(source, ref target), Throws.InstanceOf<NullNotAllowedException>());
Assert.That(() => Serialization.CopyTo(source, ref target, notNullableOverride: true), Throws.InstanceOf<NullNotAllowedException>());
}
[TestCaseSource(nameof(RegularFieldsData))]
@@ -270,7 +270,7 @@ public sealed partial class DataDefinitionTests : SerializationTest
SetValue(source, fieldName, null);
var target = new DataDefTestDummy();
SetValue(target, fieldName, altValue());
Assert.That(() => Serialization.CopyTo(source, ref target), Throws.InstanceOf<NullNotAllowedException>());
Assert.That(() => Serialization.CopyTo(source, ref target, notNullableOverride: true), Throws.InstanceOf<NullNotAllowedException>());
}
[TestCaseSource(nameof(RegularFieldsData))]

14
Robust.UnitTesting/Shared/Serialization/SerializationTests/ManagerTests.cs
View File

@@ -445,8 +445,8 @@ public sealed partial class ManagerTests : SerializationTest
public void CopyTo_RT_NS_NT_Class<T>(DataNode _, Func<T> __, Func<T> ___, bool useContext, object[] ____)
where T : class
{
T? target = null;
Assert.That(() => { Serialization.CopyTo<T>(null!, ref target, context: Context(useContext), notNullableOverride: true); },
T target = null!;
Assert.That(() => { Serialization.CopyTo(null!, ref target, context: Context(useContext), notNullableOverride: true); },
Throws.TypeOf<NullNotAllowedException>());
}
@@ -464,8 +464,8 @@ public sealed partial class ManagerTests : SerializationTest
public void CopyTo_RT_RS_NT_Class<T>(DataNode _, Func<T> value, Func<T> ___, bool useContext,
object[] valueExtractors) where T : class
{
T? target = null;
Serialization.CopyTo<T>(value(), ref target, context: Context(useContext));
T target = null!;
Serialization.CopyTo(value(), ref target, context: Context(useContext));
Assert.NotNull(target);
AssertEqual(target!, value(), valueExtractors);
}
@@ -533,9 +533,9 @@ public sealed partial class ManagerTests : SerializationTest
[Test]
public void CopyTo_CopyByRef_Class()
{
CopyByRefTestClass? target = null;
CopyByRefTestClass target = null!;
var source = new CopyByRefTestClass();
Serialization.CopyTo(source, ref target);
Serialization.CopyTo(source, ref target, notNullableOverride: true);
Assert.NotNull(target);
Assert.That(target!, Is.SameAs(source));
}
@@ -552,7 +552,7 @@ public sealed partial class ManagerTests : SerializationTest
public void CreateCopy_CopyByRef_Class()
{
var source = new CopyByRefTestClass();
var copy = Serialization.CreateCopy(source);
var copy = Serialization.CreateCopy(source, notNullableOverride: true);
Assert.That(copy, Is.SameAs(source));
}

12
Robust.UnitTesting/Shared/Serialization/SerializationTests/ReadValueProviderTests.cs
View File

@@ -47,7 +47,7 @@ public sealed class ReadValueProviderTests : SerializationTest
{
var data = "someData";
var instance = new SelfSerializeValueProviderTestDummy();
var result = Serialization.Read(new ValueDataNode(data), instanceProvider: () => instance);
var result = Serialization.Read(new ValueDataNode(data), instanceProvider: () => instance, notNullableOverride: true);
Assert.That(result, Is.SameAs(instance));
Assert.That(result.Data, Is.EqualTo(instance.Data));
}
@@ -57,7 +57,7 @@ public sealed class ReadValueProviderTests : SerializationTest
{
var data = "someData";
var instance = new SelfSerializeValueProviderTestDummy();
var result = Serialization.Read<IBaseInterface>(new ValueDataNode(data){Tag = $"!type:{nameof(SelfSerializeValueProviderTestDummy)}"}, instanceProvider: () => instance);
var result = Serialization.Read<IBaseInterface>(new ValueDataNode(data){Tag = $"!type:{nameof(SelfSerializeValueProviderTestDummy)}"}, instanceProvider: () => instance, notNullableOverride: true);
Assert.That(result, Is.SameAs(instance));
Assert.That(((SelfSerializeValueProviderTestDummy)result).Data, Is.EqualTo(instance.Data));
}
@@ -68,7 +68,7 @@ public sealed class ReadValueProviderTests : SerializationTest
var data = "someData";
var mapping = new MappingDataNode { { "data", data } };
var instance = new DataDefinitionValueProviderTestDummy();
var result = Serialization.Read(mapping, instanceProvider: () => instance);
var result = Serialization.Read(mapping, instanceProvider: () => instance, notNullableOverride: true);
Assert.That(result, Is.SameAs(instance));
Assert.That(result.Data, Is.EqualTo(instance.Data));
}
@@ -82,7 +82,7 @@ public sealed class ReadValueProviderTests : SerializationTest
Tag = $"!type:{nameof(DataDefinitionValueProviderTestDummy)}"
};
var instance = new DataDefinitionValueProviderTestDummy();
var result = Serialization.Read<IBaseInterface>(mapping, instanceProvider: () => instance);
var result = Serialization.Read<IBaseInterface>(mapping, instanceProvider: () => instance, notNullableOverride: true);
Assert.That(result, Is.SameAs(instance));
Assert.That(((DataDefinitionValueProviderTestDummy)result).Data, Is.EqualTo(instance.Data));
}
@@ -91,7 +91,7 @@ public sealed class ReadValueProviderTests : SerializationTest
public void DataDefinitionValueBaseTest()
{
var instance = new DataDefinitionValueProviderTestDummy();
var result = Serialization.Read<IBaseInterface>(new ValueDataNode{Tag = $"!type:{nameof(DataDefinitionValueProviderTestDummy)}"}, instanceProvider: () => instance);
var result = Serialization.Read<IBaseInterface>(new ValueDataNode{Tag = $"!type:{nameof(DataDefinitionValueProviderTestDummy)}"}, instanceProvider: () => instance, notNullableOverride: true);
Assert.That(result, Is.SameAs(instance));
}
@@ -99,6 +99,6 @@ public sealed class ReadValueProviderTests : SerializationTest
public void DataDefinitionValueBaseInvalidTest()
{
var instance = new OtherDataDefinitionValueProviderTestDummy();
Assert.That(() => Serialization.Read<IBaseInterface>(new ValueDataNode{Tag = $"!type:{nameof(DataDefinitionValueProviderTestDummy)}"}, instanceProvider: () => instance),Throws.InstanceOf<InvalidInstanceReturnedException>());
Assert.That(() => Serialization.Read<IBaseInterface>(new ValueDataNode{Tag = $"!type:{nameof(DataDefinitionValueProviderTestDummy)}"}, instanceProvider: () => instance, notNullableOverride: true),Throws.InstanceOf<InvalidInstanceReturnedException>());
}
}

2
Robust.UnitTesting/Shared/Serialization/TypeSerializers/ArraySerializerTest.cs
View File

@@ -27,7 +27,7 @@ namespace Robust.UnitTesting.Shared.Serialization.TypeSerializers
{
var list = new[] {"A", "E"};
var node = new SequenceDataNode("A", "E");
var deserializedList = Serialization.Read<string[]>(node);
var deserializedList = Serialization.Read<string[]>(node, notNullableOverride: true);
Assert.That(deserializedList, Is.EqualTo(list));
}

2
Robust.UnitTesting/Shared/Serialization/TypeSerializers/ComponentRegistrySerializerTest.cs
View File

@@ -48,7 +48,7 @@ namespace Robust.UnitTesting.Shared.Serialization.TypeSerializers
var mapping = yamlStream.Documents[0].RootNode.ToDataNodeCast<SequenceDataNode>();
var deserializedRegistry = Serialization.Read<ComponentRegistry>(mapping);
var deserializedRegistry = Serialization.Read<ComponentRegistry>(mapping, notNullableOverride: true);
Assert.That(deserializedRegistry.Count, Is.EqualTo(1));
Assert.That(deserializedRegistry.ContainsKey("Test"));

6
Robust.UnitTesting/Shared/Serialization/TypeSerializers/Custom/FlagSerializerTest.cs
View File

@@ -28,7 +28,7 @@ namespace Robust.UnitTesting.Shared.Serialization.TypeSerializers.Custom
Assert.That(sequence.Sequence.Count, Is.EqualTo(1));
Assert.That(sequence.Cast<ValueDataNode>(0).Value, Is.EqualTo("One"));
var value = Serialization.Read<TestDefinition>(node);
var value = Serialization.Read<TestDefinition>(node, notNullableOverride: true);
Assert.That(value.Flag, Is.EqualTo(1));
}
@@ -45,7 +45,7 @@ namespace Robust.UnitTesting.Shared.Serialization.TypeSerializers.Custom
Assert.That(sequence.Sequence, Does.Contain(new ValueDataNode("One")));
Assert.That(sequence.Sequence, Does.Contain(new ValueDataNode("Two")));
var value = Serialization.Read<TestDefinition>(node);
var value = Serialization.Read<TestDefinition>(node, notNullableOverride: true);
Assert.That(value.Flag, Is.EqualTo(3));
}
@@ -61,7 +61,7 @@ namespace Robust.UnitTesting.Shared.Serialization.TypeSerializers.Custom
Assert.That(sequence.Sequence.Count, Is.EqualTo(1));
Assert.That(sequence.Cast<ValueDataNode>(0).Value, Is.EqualTo("NegativeFlag"));
var value = Serialization.Read<TestDefinition>(node);
var value = Serialization.Read<TestDefinition>(node, notNullableOverride: true);
Assert.That(value.Flag, Is.EqualTo(TestFlags.Negative));
}

2
Robust.UnitTesting/Shared/Serialization/TypeSerializers/Custom/Prototype/PrototypeIdListSerializerTest.cs
View File

@@ -88,7 +88,7 @@ entitiesImmutableList:
stream.Load(new StringReader(DataString));
var node = stream.Documents[0].RootNode.ToDataNode();
var definition = Serialization.Read<PrototypeIdListSerializerTestDataDefinition>(node);
var definition = Serialization.Read<PrototypeIdListSerializerTestDataDefinition>(node, notNullableOverride: true);
Assert.NotNull(definition);

2
Robust.UnitTesting/Shared/Serialization/TypeSerializers/DictionarySerializerTest.cs
View File

@@ -44,7 +44,7 @@ namespace Robust.UnitTesting.Shared.Serialization.TypeSerializers
node.Add("2", new ValueDataNode("B"));
node.Add("3", new ValueDataNode("C"));
var deserializedDictionary = Serialization.Read<Dictionary<int, string>>(node);
var deserializedDictionary = Serialization.Read<Dictionary<int, string>>(node, notNullableOverride: true);
Assert.That(deserializedDictionary, Is.EqualTo(dictionary));
}

2
Robust.UnitTesting/Shared/Serialization/TypeSerializers/FormattedMessageSerializerTest.cs
View File

@@ -28,7 +28,7 @@ public sealed class FormattedMessageSerializerTest : SerializationTest
public void DeserializationTest(string text)
{
var node = new ValueDataNode(text);
var deserializedMessage = Serialization.Read<FormattedMessage>(node);
var deserializedMessage = Serialization.Read<FormattedMessage>(node, notNullableOverride: true);
Assert.That(deserializedMessage.ToMarkup(), Is.EqualTo(text));
}
}

2
Robust.UnitTesting/Shared/Serialization/TypeSerializers/HashSetSerializerTest.cs
View File

@@ -28,7 +28,7 @@ namespace Robust.UnitTesting.Shared.Serialization.TypeSerializers
{
var list = new HashSet<string> {"A", "E"};
var node = new SequenceDataNode("A", "E");
var deserializedList = Serialization.Read<HashSet<string>>(node);
var deserializedList = Serialization.Read<HashSet<string>>(node, notNullableOverride: true);
Assert.That(deserializedList, Is.EqualTo(list));
}

8
Robust.UnitTesting/Shared/Serialization/TypeSerializers/ListSerializerTest.cs
View File

@@ -28,7 +28,7 @@ namespace Robust.UnitTesting.Shared.Serialization.TypeSerializers
{
var list = new List<string> {"A", "E"};
var node = new SequenceDataNode("A", "E");
var deserializedList = Serialization.Read<List<string>>(node);
var deserializedList = Serialization.Read<List<string>>(node, notNullableOverride: true);
Assert.That(deserializedList, Is.EqualTo(list));
}
@@ -38,7 +38,7 @@ namespace Robust.UnitTesting.Shared.Serialization.TypeSerializers
{
var node = new SequenceDataNode("A", "E");
var result = Serialization.Read<List<string>, SequenceDataNode, ListSerializers<string>>(node);
var result = Serialization.Read<List<string>, SequenceDataNode, ListSerializers<string>>(node, notNullableOverride: true);
var list = (List<string>?) result;
Assert.NotNull(list);
@@ -53,7 +53,7 @@ namespace Robust.UnitTesting.Shared.Serialization.TypeSerializers
{
var list = new List<string> {"A", "E"};
var node = (SequenceDataNode) Serialization.WriteValue<List<string>, ListSerializers<string>>(list);
var node = (SequenceDataNode) Serialization.WriteValue<List<string>, ListSerializers<string>>(list, notNullableOverride: true);
Assert.That(node.Sequence.Count, Is.EqualTo(2));
Assert.That(node.Cast<ValueDataNode>(0).Value, Is.EqualTo("A"));
@@ -69,7 +69,7 @@ namespace Robust.UnitTesting.Shared.Serialization.TypeSerializers
Assert.IsNotEmpty(source);
Assert.IsEmpty(target);
Serialization.CopyTo<List<string>, ListSerializers<string>>(source, ref target);
Serialization.CopyTo<List<string>, ListSerializers<string>>(source, ref target, notNullableOverride: true);
Assert.NotNull(source);

2
Robust.UnitTesting/Shared/Serialization/TypeSerializers/RegexSerializerTest.cs
View File

@@ -27,7 +27,7 @@ namespace Robust.UnitTesting.Shared.Serialization.TypeSerializers
{
var str = "[AEIOU]";
var node = new ValueDataNode(str);
var deserializedRegex = Serialization.Read<Regex>(node);
var deserializedRegex = Serialization.Read<Regex>(node, notNullableOverride: true);
var regex = new Regex(str, RegexOptions.Compiled);
Assert.That(deserializedRegex.ToString(), Is.EqualTo(regex.ToString()));

4
Robust.UnitTesting/Shared/Serialization/YamlObjectSerializerTests/ImmutableListSerializationTest.cs
View File

@@ -28,7 +28,7 @@ namespace Robust.UnitTesting.Shared.Serialization.YamlObjectSerializerTests
// Arrange
var data = _serializableList;
var serMan = IoCManager.Resolve<ISerializationManager>();
var sequence = (SequenceDataNode) serMan.WriteValue(data);
var sequence = (SequenceDataNode) serMan.WriteValue(data, notNullableOverride: true);
var mapping = new MappingDataNode();
mapping.Add("datalist", sequence);
@@ -45,7 +45,7 @@ namespace Robust.UnitTesting.Shared.Serialization.YamlObjectSerializerTests
var rootNode = YamlTextToNode(_serializedListYaml);
// Act
var data = serMan.Read<ImmutableList<int>>(new SequenceDataNode((YamlSequenceNode)rootNode.Children[0].Value));
var data = serMan.Read<ImmutableList<int>>(new SequenceDataNode((YamlSequenceNode)rootNode.Children[0].Value), notNullableOverride: true);
// Assert
Assert.That(data, Is.Not.Null);

4
Robust.UnitTesting/Shared/Serialization/YamlObjectSerializerTests/TypePropertySerialization_Test.cs
View File

@@ -32,7 +32,7 @@ namespace Robust.UnitTesting.Shared.Serialization.YamlObjectSerializerTests
TestPropertyTwo = 10
};
var serMan = IoCManager.Resolve<ISerializationManager>();
var mapping = (MappingDataNode) serMan.WriteValue(type);
var mapping = (MappingDataNode) serMan.WriteValue(type, notNullableOverride: true);
Assert.IsNotEmpty(mapping.Children);
@@ -69,7 +69,7 @@ namespace Robust.UnitTesting.Shared.Serialization.YamlObjectSerializerTests
var mapping = (YamlMappingNode) yamlStream.Documents[0].RootNode[0];
var serMan = IoCManager.Resolve<ISerializationManager>();
var type = serMan.Read<ITestType>(mapping["test"].ToDataNode());
var type = serMan.Read<ITestType>(mapping["test"].ToDataNode(), notNullableOverride: true);
Assert.NotNull(type);
Assert.IsInstanceOf<TestTypeTwo>(type);

4
Robust.UnitTesting/Shared/Serialization/YamlObjectSerializerTests/TypeSerialization_Test.cs
View File

@@ -25,7 +25,7 @@ namespace Robust.UnitTesting.Shared.Serialization.YamlObjectSerializerTests
{
ITestType type = new TestTypeOne();
var serMan = IoCManager.Resolve<ISerializationManager>();
var mapping = serMan.WriteValue(type);
var mapping = serMan.WriteValue(type, notNullableOverride: true);
Assert.IsInstanceOf<MappingDataNode>(mapping);
@@ -56,7 +56,7 @@ test:
var mapping = (YamlMappingNode) yamlStream.Documents[0].RootNode;
var serMan = IoCManager.Resolve<ISerializationManager>();
var type = serMan.Read<ITestType>(new MappingDataNode(mapping)["test"]);
var type = serMan.Read<ITestType>(new MappingDataNode(mapping)["test"], notNullableOverride: true);
Assert.NotNull(type);
Assert.IsInstanceOf<TestTypeOne>(type);