mirror of
https://github.com/space-wizards/RobustToolbox.git
synced 2026-02-14 19:29:36 +01:00
Serialization v3 aka constant suffering (#1606)
* oops
* fixes serialization il
* copytest
* typo & misc fixes
* 139 moment
* boxing
* mesa dum
* stuff
* goodbye bad friend
* last commit before the big (4) rewrite
* adds datanodes
* kills yamlobjserializer in favor of the new system
* adds more serializers, actually implements them & removes most of the last of the old system
* changed yamlfieldattribute namespace
* adds back iselfserialize
* refactors consts&flags
* renames everything to data(field/definition)
* adds afterserialization
* help
* dataclassgen
* fuggen help me mannen
* Fix most errors on content
* Fix engine errors except map loader
* maploader & misc fix
* misc fixes
* thing
* help
* refactors datanodes
* help me mannen
* Separate ITypeSerializer into reader and writer
* Convert all type serializers
* priority
* adds alot
* il fixes
* adds robustgen
* argh
* adds array & enum serialization
* fixes dataclasses
* adds vec2i / misc fixes
* fixes inheritance
* a very notcursed todo
* fixes some custom dataclasses
* push dis
* Remove data classes
* boutta box
* yes
* Add angle and regex serializer tests
* Make TypeSerializerTest abstract
* sets up ioc etc
* remove pushinheritance
* fixes
* Merge fixes, fix yaml hot reloading
* General fixes2
* Make enum serialization ignore case
* Fix the tag not being copied in data nodes
* Fix not properly serializing flag enums
* Fix component serialization on startup
* Implement ValueDataNode ToString
* Serialization IL fixes, fix return and string equality
* Remove async from prototype manager
* Make serializing unsupported node as enum exception more descriptive
* Fix serv3 tryread casting to serializer instead of reader
* Add constructor for invalid node type exception
* Temporary fix for SERV3: Turn populate delegate into regular code
* Fix not copying the data of non primitive types
* Fix not using the data definition found in copying
* Make ISerializationHooks require explicit implementations
* Add test for serialization inheritance
* Improve IsOverridenIn method
* Fix error message when a data definition is null
* Add method to cast a read value in Serv3Manager
* Rename IServ3Manager to ISerializationManager
* Rename usages of serv3manager, add generic copy method
* Fix IL copy method lookup
* Rename old usages of serv3manager
* Add ITypeCopier
* resistance is futile
* we will conquer this codebase
* Add copy method to all serializers
* Make primitive mismatch error message more descriptive
* bing bong im going to freacking heck
* oopsie moment
* hello are you interested in my wares
* does generic serializers under new architecture
* Convert every non generic serializer to the new format, general fixes
* Update usgaes of generic serializers, cleanup
* does some pushinheritance logic
* finishes pushinheritance FRAMEWORK
* shed
* Add box2, color and component registry serializer tests
* Create more deserialized types and store prototypes with their deserialized results
* Fixes and serializer updates
* Add serialization manager extensions
* adds pushinheritance
* Update all prototypes to have a parent and have consistent id/parent properties
* Fix grammar component serialization
* Add generic serializer tests
* thonk
* Add array serializer test
* Replace logger warning calls with exceptions
* fixes
* Move redundant methods to serialization manager extensions, cleanup
* Add array serialization
* fixes context
* more fixes
* argh
* inheritance
* this should do it
* fixes
* adds copiers & fixes some stuff
* copiers use context v1
* finishing copy context
* more context fixes
* Test fixes
* funky maps
* Fix server user interface component serialization
* Fix value tuple serialization
* Add copying for value types and arrays. Fix copy internal for primitives, enums and strings
* fixes
* fixes more stuff
* yes
* Make abstract/interface skips debugs instead of warnings
* Fix typo
* Make some dictionaries readonly
* Add checks for the serialization manager initializing and already being initialized
* Add base type required and usage for MeansDataDefinition and ImplicitDataDefinitionForInheritorsAttribute
* copy by ref
* Fix exception wording
* Update data field required summary with the new forbidden docs
* Use extension in map loader
* wanna erp
* Change serializing to not use il temporarily
* Make writing work with nullable types
* pushing
* check
* cuddling slaps HARD
* Add serialization priority test
* important fix
* a serialization thing
* serializer moment
* Add validation for some type serializers
* adds context
* moar context
* fixes
* Do the thing for appearance
* yoo lmao
* push haha pp
* Temporarily make copy delegate regular c# code
* Create deserialized component registry to handle not inheriting conflicting references
* YAML LINTER BABY
* ayes
* Fix sprite component norot not being default true like in latest master
* Remove redundant todos
* Add summary doc to every ISerializationManager method
* icon fixes
* Add skip hook argument to readers and copiers
* Merge fixes
* Fix ordering of arguments in read and copy reflection call
* Fix user interface components deserialization
* pew pew
* i am going to HECK
* Add MustUseReturnValue to copy-over methods
* Make serialization log calls use the same sawmill
* gamin
* Fix doc errors in ISerializationManager.cs
* goodbye brave soldier
* fixes
* WIP merge fixes and entity serialization
* aaaaaaaaaaaaaaa
* aaaaaaaaaaaaaaa
* adds inheritancebehaviour
* test/datafield fixes
* forgot that one
* adds more verbose validation
* This fixes the YAML hot reloading
* Replace yield break with Enumerable.Empty
* adds copiers
* aaaaaaaaaaaaa
* array fix
priority fix
misc fixes
* fix(?)
* fix.
* funny map serialization (wip)
* funny map serialization (wip)
* Add TODO
* adds proper info the validation
* Make yaml linter 5 times faster (~80% less execution time)
* Improves the error message for missing fields in the linter
* Include component name in unknown component type error node
* adds alwaysrelevant usa
* fixes mapsaving
* moved surpressor to analyzers proj
* warning cleanup & moves surpressor
* removes old msbuild targets
* Revert "Make yaml linter 5 times faster (~80% less execution time)"
This reverts commit 2ee4cc2c26.
* Add serialization to RobustServerSimulation and mock reflection methods
Fixes container tests
* Fix nullability warnings
* Improve yaml linter message feedback
* oops moment
* Add IEquatable, IComparable, ToString and operators to DataPosition
Rename it to NodeMark
Make it a readonly struct
* Remove try catch from enum parsing
* Make dependency management in serialization less bad
* Make dependencies an argument instead of a property on the serialization manager
* Clean up type serializers
* Improve validation messages and resourc epath checking
* Fix sprite error message
* reached perfection
Co-authored-by: Paul <ritter.paul1+git@googlemail.com>
Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com>
Co-authored-by: Vera Aguilera Puerto <zddm@outlook.es>
This commit is contained in:
Paul Ritter
63
Robust.Generators.UnitTesting/AnalyzerTest.cs
Normal file
63
Robust.Generators.UnitTesting/AnalyzerTest.cs
Normal file
@@ -0,0 +1,63 @@
|
||||
using System;
|
||||
using System.Collections.Generic;
|
||||
using System.Collections.Immutable;
|
||||
using System.IO;
|
||||
using System.Linq;
|
||||
using System.Reflection;
|
||||
using Microsoft.CodeAnalysis;
|
||||
using Microsoft.CodeAnalysis.CSharp;
|
||||
using NUnit.Framework;
|
||||
using Robust.Shared.Prototypes;
|
||||
using Robust.Shared.Serialization.Manager.Attributes;
|
||||
|
||||
namespace Robust.Generators.UnitTesting
|
||||
{
|
||||
[Parallelizable]
|
||||
public abstract class AnalyzerTest
|
||||
{
|
||||
protected static Assembly GetAssemblyFromCompilation(Compilation newComp)
|
||||
{
|
||||
using var stream = new MemoryStream();
|
||||
newComp.Emit(stream);
|
||||
var assembly = Assembly.Load(stream.ToArray());
|
||||
return assembly;
|
||||
}
|
||||
|
||||
protected static Compilation CreateCompilation(string source)
|
||||
{
|
||||
var dd = typeof(Enumerable).GetTypeInfo().Assembly.Location;
|
||||
var coreDir = Directory.GetParent(dd) ?? throw new Exception("Couldn't find location of coredir");
|
||||
|
||||
var references = new[]
|
||||
{
|
||||
MetadataReference.CreateFromFile(typeof(object).GetTypeInfo().Assembly.Location),
|
||||
MetadataReference.CreateFromFile(typeof(Enumerable).GetTypeInfo().Assembly.Location),
|
||||
MetadataReference.CreateFromFile(typeof(Dictionary<,>).GetTypeInfo().Assembly.Location),
|
||||
MetadataReference.CreateFromFile(typeof(DataFieldAttribute).GetTypeInfo().Assembly.Location),
|
||||
MetadataReference.CreateFromFile(coreDir.FullName + Path.DirectorySeparatorChar + "mscorlib.dll"),
|
||||
MetadataReference.CreateFromFile(coreDir.FullName + Path.DirectorySeparatorChar +
|
||||
"System.Runtime.dll"),
|
||||
MetadataReference.CreateFromFile(coreDir.FullName + Path.DirectorySeparatorChar +
|
||||
"System.Collections.dll"),
|
||||
};
|
||||
|
||||
var syntaxTree = CSharpSyntaxTree.ParseText(source, new CSharpParseOptions(LanguageVersion.Preview));
|
||||
return CSharpCompilation.Create(
|
||||
"comp",
|
||||
new[] {syntaxTree},
|
||||
references,
|
||||
new CSharpCompilationOptions(OutputKind.DynamicallyLinkedLibrary));
|
||||
}
|
||||
|
||||
protected static (Compilation, ImmutableArray<Diagnostic> diagnostics) RunGenerators(Compilation c,
|
||||
params ISourceGenerator[] gens)
|
||||
{
|
||||
var driver = CSharpGeneratorDriver.Create(
|
||||
ImmutableArray.Create(gens),
|
||||
ImmutableArray<AdditionalText>.Empty,
|
||||
(CSharpParseOptions) c.SyntaxTrees.First().Options);
|
||||
driver.RunGeneratorsAndUpdateCompilation(c, out var d, out var diagnostics);
|
||||
return (d, diagnostics);
|
||||
}
|
||||
}
|
||||
}
|
||||
82
Robust.Generators.UnitTesting/DataClassTests.cs
Normal file
82
Robust.Generators.UnitTesting/DataClassTests.cs
Normal file
@@ -0,0 +1,82 @@
|
||||
using System.Linq;
|
||||
using NUnit.Framework;
|
||||
using Robust.Shared.Prototypes;
|
||||
using Robust.Shared.Serialization.Manager.Attributes;
|
||||
|
||||
namespace Robust.Generators.UnitTesting
|
||||
{
|
||||
public class DataClassTests : AnalyzerTest
|
||||
{
|
||||
[Test]
|
||||
public void DCTest()
|
||||
{
|
||||
const string source = @"
|
||||
using System.Collections.Generic;
|
||||
using Robust.Shared.Prototypes;
|
||||
//using Robust.Shared.Serialization;
|
||||
using DrawDepthTag = Robust.Shared.GameObjects.DrawDepth;
|
||||
using Robust.Shared.Serialization.Manager.Attributes;
|
||||
|
||||
namespace Test{
|
||||
[DataClass]
|
||||
public class TestClass{
|
||||
[DataFieldWithConstant(""drawdepth"", typeof(DrawDepthTag))]
|
||||
private int _drawDepth = DrawDepthTag.Default;
|
||||
[DataField(""myList"")]
|
||||
public List<TestClass> testList;
|
||||
[DataField(""myList"")]
|
||||
public string abc = ""testing"";
|
||||
[DataField(""drawdepth"", constType: typeof(TestClass))]
|
||||
public int test;
|
||||
}
|
||||
}
|
||||
";
|
||||
var comp = CreateCompilation(source);
|
||||
|
||||
//Assert.IsEmpty(comp.GetDiagnostics());
|
||||
|
||||
var (newcomp, generatorDiags) = RunGenerators(comp, new DataClassGenerator());
|
||||
|
||||
Assert.IsEmpty(generatorDiags);
|
||||
|
||||
var type = newcomp.GetTypeByMetadataName("Test.TestClass_AUTODATA");
|
||||
Assert.NotNull(type);
|
||||
|
||||
var memberNames = type.MemberNames.ToArray();
|
||||
|
||||
// 3 properties
|
||||
Assert.That(memberNames, Has.Length.EqualTo(3));
|
||||
Assert.That(memberNames, Contains.Item("testList"));
|
||||
Assert.That(memberNames, Contains.Item("abc"));
|
||||
Assert.That(memberNames, Contains.Item("test"));
|
||||
|
||||
var members = type.GetMembers();
|
||||
|
||||
// 3 properties + constructor
|
||||
Assert.That(members, Has.Length.EqualTo(4));
|
||||
|
||||
var memberDictionary = members.ToDictionary(m => m.Name, m => m);
|
||||
var yamlFieldNamespace = typeof(DataFieldAttribute).FullName;
|
||||
|
||||
Assert.NotNull(yamlFieldNamespace);
|
||||
|
||||
var yamlFieldAttribute = comp.GetTypeByMetadataName(yamlFieldNamespace);
|
||||
|
||||
var testListYamlAttribute = memberDictionary["testList"].GetAttribute(yamlFieldAttribute);
|
||||
Assert.NotNull(testListYamlAttribute);
|
||||
Assert.That(testListYamlAttribute.ConstructorArguments[0].Value, Is.EqualTo("myList"));
|
||||
|
||||
var abcYamlAttribute = memberDictionary["abc"].GetAttribute(yamlFieldAttribute);
|
||||
Assert.NotNull(abcYamlAttribute);
|
||||
Assert.That(abcYamlAttribute.ConstructorArguments[0].Value, Is.EqualTo("myList"));
|
||||
|
||||
var testYamlAttribute = memberDictionary["test"].GetAttribute(yamlFieldAttribute);
|
||||
Assert.NotNull(testYamlAttribute);
|
||||
Assert.That(testYamlAttribute.ConstructorArguments[0].Value, Is.EqualTo("drawdepth"));
|
||||
Assert.NotNull(testYamlAttribute.ConstructorArguments[3].Value);
|
||||
Assert.That(testYamlAttribute.ConstructorArguments[3].Value.ToString(), Is.EqualTo("Test.TestClass"));
|
||||
|
||||
//TODO Check for dataclass & if its correct
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,21 @@
|
||||
<Project Sdk="Microsoft.NET.Sdk">
|
||||
|
||||
<PropertyGroup>
|
||||
<TargetFramework>net5.0</TargetFramework>
|
||||
</PropertyGroup>
|
||||
|
||||
<ItemGroup>
|
||||
<ProjectReference Include="..\Robust.Generators\Robust.Generators.csproj" />
|
||||
<ProjectReference Include="..\Robust.Shared\Robust.Shared.csproj" />
|
||||
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.3" />
|
||||
<PackageReference Include="NUnit" Version="3.12.0" />
|
||||
<PackageReference Include="NUnit.ConsoleRunner" Version="3.11.1" />
|
||||
<PackageReference Include="NUnit3TestAdapter" Version="3.17.0" />
|
||||
<PackageReference Include="NUnit.Analyzers" Version="0.6.0" />
|
||||
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="3.8.0" PrivateAssets="all" />
|
||||
<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.2" PrivateAssets="all" />
|
||||
</ItemGroup>
|
||||
|
||||
<Import Project="..\MSBuild\Robust.Engine.targets" />
|
||||
|
||||
</Project>
|
||||
Reference in New Issue
Block a user