Code Server code-server
0 Followers · 0 Following
  • Joined on 2026-02-14
Repositories Projects Packages Public Activity Starred Repositories
code-server merged pull request wylab/nanobot#17 2026-03-04 16:32:56 +01:00
Fix consolidation checkpoint-based trim to preserve history
code-server commented on pull request wylab/nanobot#17 2026-03-04 16:16:06 +01:00
Fix consolidation checkpoint-based trim to preserve history

✅ Fixed in commit e782318

Added deferred trim logic to _process_system_message() (lines 806-815):

# Deferred trim: same logic as _process_message
# System messages (including…
code-server pushed to fix/consolidation-checkpoint-trim at wylab/nanobot 2026-03-04 16:15:55 +01:00
e782318338 fix: add deferred trim to system message handler
code-server commented on pull request wylab/nanobot#17 2026-03-04 16:14:07 +01:00
Fix consolidation checkpoint-based trim to preserve history

Code Review: Checkpoint-Based Trim Fix

Summary

CONDITIONAL APPROVAL - Fix is sound but incomplete. One critical issue must be addressed before merge.

✅ What Works Well

1.…

code-server created pull request wylab/nanobot#17 2026-03-04 16:05:24 +01:00
Fix consolidation checkpoint-based trim to preserve history
code-server pushed to fix/consolidation-checkpoint-trim at wylab/nanobot 2026-03-04 16:05:08 +01:00
dc94aa76cc fix(consolidation): use checkpoint-based trim instead of relative count
code-server created branch fix/consolidation-checkpoint-trim in wylab/nanobot 2026-03-04 16:05:08 +01:00
code-server pushed to main at wylab/nanobot 2026-03-04 14:16:47 +01:00
5cf019c21e Merge pull request 'feat: extract facts with main agent LLM, bypass mem0 GPT-nano' (#15) from feat/mem0-extract-llm into main
790bdd6b8a fix: remove dead code, fix JSON parsing, add facts validation
b25c09f5ed feat: extract facts with main agent LLM, bypass mem0 GPT-nano
9e8c910ab1 feat: extract facts with main agent LLM, bypass mem0 GPT-nano
Compare 4 commits »
code-server merged pull request wylab/nanobot#15 2026-03-04 14:16:46 +01:00
feat: extract facts with main agent LLM, bypass mem0 GPT-nano
code-server commented on pull request wylab/nanobot#15 2026-03-04 14:08:38 +01:00
feat: extract facts with main agent LLM, bypass mem0 GPT-nano

✅ Approved

All critical issues have been fixed in commit 790bdd6:

✅ Dead code removed (custom_fact_extraction_prompt in MemoryConfig)
✅ JSON parsing bug fixed (added .strip())
✅…

code-server commented on pull request wylab/nanobot#15 2026-03-04 14:05:17 +01:00
feat: extract facts with main agent LLM, bypass mem0 GPT-nano

Code Review

Implementation Overview

The PR successfully implements the described feature:

  • ✅ extract_facts(): Uses agent's LLM to extract facts from conversation
  • ✅ store_facts():…
code-server commented on pull request wylab/nanobot#15 2026-03-04 13:41:57 +01:00
feat: extract facts with main agent LLM, bypass mem0 GPT-nano

Code Review: Critical Issues Found ❌

Summary

This PR is BROKEN and cannot be merged. The code references undefined methods and will cause runtime failures.

Critical…

code-server pushed to main at wylab/nanobot 2026-03-04 13:15:59 +01:00
cc10e20a47 Fix prompt caching: save mem0 to session and add 4-breakpoint strategy
code-server commented on pull request wylab/nanobot#14 2026-03-04 04:50:47 +01:00
feat: extract facts with main agent LLM, bypass mem0 GPT-nano

Review of commit 55b0875 (v5)

Simplified extraction prompt was tested against the detailed version (16 tests) and performed better. Approved.

  • Orphaned docstring line removed ✓
  • Prompt…
code-server commented on pull request wylab/nanobot#14 2026-03-04 03:55:25 +01:00
feat: extract facts with main agent LLM, bypass mem0 GPT-nano

Review of commit 887abd1 (v4)

Scope: mem0 extraction via main agent LLM + bash heredoc fix + tests

mem0 changes (memory_mem0.py)

All previous blockers fixed. Code is correct:

-…

code-server commented on pull request wylab/nanobot#14 2026-03-04 03:55:14 +01:00
feat: extract facts with main agent LLM, bypass mem0 GPT-nano

Review of commit 887abd1 (v4)

Scope: mem0 extraction via main agent LLM + bash heredoc fix + tests

mem0 changes (memory_mem0.py)

All previous blockers fixed. Code is correct:

-…

code-server commented on pull request wylab/nanobot#14 2026-03-04 03:44:25 +01:00
feat: extract facts with main agent LLM, bypass mem0 GPT-nano

Re-review after force-push (0b0c4e9)

Both blockers from the previous review are fixed. Code looks correct now.

Fixed

  • provider.chat() instead of provider.create_message() (line 277)…
code-server commented on pull request wylab/nanobot#14 2026-03-04 02:01:49 +01:00
feat: extract facts with main agent LLM, bypass mem0 GPT-nano

Re-review after force-push (99bd54a)

The approach is fundamentally better now. Using the main agent's existing LLM for extraction + infer=False storage is clean — no provider hacking, no…

code-server commented on pull request wylab/nanobot#14 2026-03-03 11:23:00 +01:00
feat: extract facts with main agent LLM, bypass mem0 GPT-nano

Code Review — PR #14: Use Haiku via Claude Max OAuth for mem0 extraction LLM

Good idea to eliminate the per-call OpenAI cost by reusing the Claude Max subscription. However, there are several…

code-server pushed to main at wylab/nanobot 2026-03-02 11:14:17 +01:00
34ed4345fc fix(bash): use newline separator for sentinel to fix heredoc hangs