mirror of https://github.com/claude-did-this/claude-hub.git synced 2026-02-14 19:30:02 +01:00

Files

Cheffromspace 31efbbc2bb feat: Add @botaccount review command for manual PR reviews (#131 ) (#152 )

* feat: Add @botaccount review command for manual PR reviews (#131)

- Add detection for 'review' command in PR and issue comments
- Implement handleManualPRReview function with authorization checks
- Reuse existing PR review logic with manual-pr-review operation type
- Configure PR review tools with broad research access and controlled write access
- Support manual triggering of comprehensive PR reviews on demand

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* style: Apply pre-commit formatting changes

* test: Update test expectation for new operationType parameter

* fix: Improve PR detection for manual review command

- Add pull_request property to GitHubIssue interface for PR comments
- Handle both direct PR objects and issues with pull_request metadata
- Fix TypeScript compilation errors and linting issues

* fix: Improve pre-commit hook to fail on issues instead of auto-fixing

- Use format:check instead of format to detect issues without auto-fixing
- Use proper error handling with clear error messages
- Provide helpful instructions on how to fix issues
- Make commit behavior more predictable and transparent

* style: Fix whitespace formatting

---------

Co-authored-by: Claude <noreply@anthropic.com>

2025-05-31 22:15:53 -05:00

2.3 KiB

Raw Blame History

Test Migration Notice

Shell Scripts Migrated to Jest E2E Tests

The following shell test scripts have been migrated to the Jest E2E test suite and have been removed:

Migrated Shell Scripts (✅ Completed)

AWS Tests (Directory: test/aws/ - removed)

test-aws-mount.sh → test/e2e/scenarios/aws-authentication.test.js
test-aws-profile.sh → test/e2e/scenarios/aws-authentication.test.js

Claude Tests (Directory: test/claude/ - removed)

test-claude-direct.sh → test/e2e/scenarios/claude-integration.test.js
test-claude-installation.sh → test/e2e/scenarios/claude-integration.test.js
test-claude-no-firewall.sh → test/e2e/scenarios/claude-integration.test.js
test-claude-response.sh → test/e2e/scenarios/claude-integration.test.js

Container Tests (Directory: test/container/ - removed)

test-basic-container.sh → test/e2e/scenarios/container-execution.test.js
test-container-cleanup.sh → test/e2e/scenarios/container-execution.test.js
test-container-privileged.sh → test/e2e/scenarios/container-execution.test.js

Security Tests (Directory: test/security/ - removed)

test-firewall.sh → test/e2e/scenarios/security-firewall.test.js
test-github-token.sh → test/e2e/scenarios/github-integration.test.js
test-with-auth.sh → test/e2e/scenarios/security-firewall.test.js

Integration Tests (Directory: test/integration/ - removed)

test-full-flow.sh → test/e2e/scenarios/full-workflow.test.js
test-claudecode-docker.sh → test/e2e/scenarios/docker-execution.test.js and full-workflow.test.js

Retained Shell Scripts

The following scripts contain unique functionality not yet migrated:

test/claude/test-claude.sh - Contains specific Claude CLI testing logic
test/container/test-container.sh - Contains container validation logic

Running the New E2E Tests

To run the migrated E2E tests:

# Run all E2E tests
npm run test:e2e

# Run specific scenario
npx jest test/e2e/scenarios/aws-authentication.test.js

CI/CD Considerations

The E2E tests require:

Docker daemon access
claude-code-runner:latest Docker image
Optional: Real GitHub token for full GitHub API tests
Optional: AWS credentials for full AWS tests

Most tests will run with mock credentials, but some functionality will be skipped.

2.3 KiB Raw Blame History